From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A166645A76; Tue, 1 Oct 2024 09:42:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DBF04027A; Tue, 1 Oct 2024 09:42:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 6E24B40261 for ; Tue, 1 Oct 2024 09:42:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727768555; x=1759304555; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+5DhDBoBPYfN/naZ6br7+oZFqft3HgnfuzF79pj6i7E=; b=hSw6Ndts/9d60uqiPVEiAamyfxhZCCuOk1BOEPwmzNJS6sEnCWVfzGN8 RTWg83sVuS83+fpTgXiYSlUBPpp2sH7aobwena4RgNPYt9Go3VPVKTpFe HKNJxf9n5K/DPs+2R4oSgjYishvxY7X3/9Z1UBnmbDlvaVmi5oJPQrVjW QT+i3YPttKDW3Ycj+Gm05TXToEWyofybTphr7BNvhqe4fUgOlSLoV/w10 00Ls88+SEZxWVuWcuJvzxhd8Fs2mA4dZxZUmKYOUkhpDo0hl61O+Rkia9 OTbrerXl3OPybubTpcSByl3aKiW28s78fOBfuXfUmd7BFQM74yscfJ/18 g==; X-CSE-ConnectionGUID: TlU/mxOITJaItj4ocRi8EA== X-CSE-MsgGUID: LboSLzA2TzyhrfiWBQlg4Q== X-IronPort-AV: E=McAfee;i="6700,10204,11211"; a="37560499" X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="37560499" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 00:42:33 -0700 X-CSE-ConnectionGUID: IMQkNaFvTgyIyeXmG9zECg== X-CSE-MsgGUID: SdXEJxM7TKeBcOIbOKNzGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="74354691" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Oct 2024 00:42:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 00:42:32 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 00:42:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 1 Oct 2024 00:42:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gK7Rm6E98f3Cms6RE6SRRCVHSmMiBhT1biTvobwukRmzuYuhRDHMENSkpTJ20en7a3gQ4NseKQMqcUdWFda4QHBNXDvrNvet/7p0iGJoyo1KUvNdVL2/tULgzzl6YHVQVAxPzN1i5+XeIA39CEqZOwggjdoiIJc40hFCoDhUFIdGdJcZW9zzsbOWTNp9C3eySsSdUDjq589lFG1DI4K7O2FG5O9QfRdYH1l8G3u95j6hsrEqO5O0knkbMoCcYa50wF2yaMPX7SXYegJAbOQw1TnIEx5u2MGUjccFAGLfW9vTK2Z5g4d5kHDOTuQjdCI4X7qxR6Lv+piNADUc/G0lpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ugA/40X1JCR4SwPFs7eiqgy8AJnsuzuRUpzES/oJT0=; b=pxWwtbHL9Sk02iUybPynnbRexQ+PzlzpvV2gCeiSUwiDPEY0dlvoKfVaiJy0V0xc18wsKxVWTGnVyZIouiSa9lPk9egwNTcMH2wtSBGjzGkM2+x6NRnK9oToeBzsJa/iNNMwgdYzsg4MzBiWHTY5JbG71ywfKJgWfzNzhPttGdzT9v81jJJIJHsVqi0zAYowoXuaKorU4vA3QMiQQaZWKWIEbEpXgLvmsNdSu/8MjzhJRDoj0GTt59MmrEyjrPc/2riBCyvFEd2MXjn2wWr5a4RRjU/PHyzSrBnmF5jfn4M7eGIPx+ifDiF+DPsrL+ROO/WCBN8ZkkVEnOdMJCNPcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB6617.namprd11.prod.outlook.com (2603:10b6:303:20d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct 2024 07:42:30 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 07:42:30 +0000 Date: Tue, 1 Oct 2024 08:42:25 +0100 From: Bruce Richardson To: David Marchand CC: Ian Stokes , , Robin Jarry Subject: Re: [PATCH 0/4] fix issues with using AVX-512 drivers on 32-bit Message-ID: References: <20240906141127.628873-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0281.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: 48f79997-81b2-4c2e-149e-08dce1ec9aa9 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q0treUZWTG9iT3dnbXh1bEI0b25CaytyUXVMK2RGYUdndm1oc21NcWVpV2c3?= =?utf-8?B?dGVNNDduTmpEd1M4TjU0M0t2QXpmbFhON01yb0NBUVBwcks3blBqc0ZMSElx?= =?utf-8?B?TEJ2bGJIa2hZTmNCZ2d2eUQ2ZGVhYlpRS25XNEYyVzk2R1NONEFkM3VyMHlI?= =?utf-8?B?T3BTbWo0b1c2MUo4V2Z0UEx0MWtqOCsrYkN1c2FJdmtyZm9rR2pvSnNhNG9z?= =?utf-8?B?TnJwSjhxYWl2RVBIbUI0am9Bd2xUaWpyNWFxTzdGVGY2QnU0UHRNUzVuMFBh?= =?utf-8?B?K2hpMk1EYU5GdU1JbGp2UC9ndHFiRjQrM2ZsUjFVTVNnVC92STVYb3hpdFQ0?= =?utf-8?B?UzloUmFMSkhMSU1sU3QvOHdKSnBYZzdPcXJubyt6Q0FKMTZZczlGdVBQUHYz?= =?utf-8?B?d2tPTVRENW90ZERPS0NnRjUxSVFHSXBXbXBOZWtqN1pFYWFGQktrSkxXd0dr?= =?utf-8?B?djAwOWlwS3poRndlTkFBSUcwcm1TaHZQbjNQbEFCRnIzQzZZKzJsV1RqRWNz?= =?utf-8?B?b0RwWDNpWUZWQ05aVS84ZXM4UGZVUUc1NVVMditQS0hGWm91bXZrU0dYQkpT?= =?utf-8?B?OWFTMks2b1UvcVZCdjMrakx3c3RNUGloYmRLaHFxa25yQ0tjUlVuSW54UEd6?= =?utf-8?B?ZDhicmtlUzc5WGJLOVF5Vkp4VkJoQjh2Ti9GMVVJdWRteHpSZnRPU3VJak9D?= =?utf-8?B?dG9zMjAwNXNVeFljUklodkdWTUJpcFU5eGM0OUQ4RG9TbVNERytiTTBEUXNl?= =?utf-8?B?eE9MMU16Uzl0dXBiYVRNeCtRTStCN0N6ZmNCYTBYMDR5L0FzRUc0TEdpbmdN?= =?utf-8?B?RzFFczFlaEJHSG1CRUJKbnZQdlJBMFc1NWRpK2xObFM4NHpqSXJ3bjkxbHc2?= =?utf-8?B?Q3JGb0dLcVJ1aGJDZHhET0hlZEZXcmRGdzFaYnVYaEpBQVRIVE9aNTN2Wmxw?= =?utf-8?B?WGlmTW9vOFRYZ1pFNVl4Q1dOWUFiWERoMDJPNzQ1NlRyM0N6SGszR2hPakZs?= =?utf-8?B?TDMvQU0yRytFMHkzcDIydFVoNXFNVVlPMnFmRE8rVi9qVUQ1VVkySUlPYVAr?= =?utf-8?B?cThRM3dOK1d4MEZMSHlSV0UzS0FONUROc1BOKzZsVnBEZkFpSHdMRFJOdEhM?= =?utf-8?B?YkIxOEpTdkxrT3Rpa1lnbVJxYkNwejVlQ3RWY1U4ZzdyL0pVVWkyTDUyN3Fr?= =?utf-8?B?emlHUkY0VGFydnlKbk9IbVhTT2g5d2hjeWw0T0FVQ1NnaGRwMUdqSHlTeEc3?= =?utf-8?B?NXlhZkxxekRVS0ZyS3JkNGNyTlNOUStXUEpocUJocmxMNEZ3TGp1SXcyMGZT?= =?utf-8?B?MkY0TnRhNklTU1RmbXFKYStvc1ZrTVRUL3dySTZJek8vTHV3dit3WmQvZVpG?= =?utf-8?B?V0JEdWtBRGZZbXBsUHU4ZHIwQllHd2Q1MFVZbVYxK0ExYjdoOVpsdU9CMGZD?= =?utf-8?B?RkhpUytDVTlqZ2xoeHE5Z0xGUEpNb3FTZWJGRURjSEVFUWJRWUNWWVlLOG0z?= =?utf-8?B?aDJrSWNlcWdPVm9uaHFoRmMyVy9saHJhZjUvZXRkUXpHM1NmYlR6cXdIVGFa?= =?utf-8?B?eTI5ZlZnOE9rK1J5RnNlbXAycG05OFJzTU5ZV1NiVWpzWVh1TWk1Y0lxK3BL?= =?utf-8?Q?XR7GUTyF7S93UdyFjlHqfQFuXYzI0jnjxj59zbmxYIVc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjByWWFDVWd0SXVLMDZFc2FxZ01MSFJTYmthUDM0Wkw4SEFUOUczSkN2Ly9Y?= =?utf-8?B?U1BGbHdkNXZoTTgzdTN4cXVLODlyUEdKeURtZHkrYStnNjc1LzFUek90UElm?= =?utf-8?B?NVNCVTdZNXE3QjRzb29seU1wWi9zY3NBYi93WTB4Ri9wMysvNlJKZFhGSmFV?= =?utf-8?B?OERRRmVheENvY3A2V0hRUEppNUIvRld0eWZKZmVzYmY5NDVhcWQ2Y21ReVow?= =?utf-8?B?NkE3ZkcxZTQ4aXFYYklMdi9kM1FoVlZDaEQwUjN2NjBzYlJVSG5ESWIwVHFv?= =?utf-8?B?ZzlPZjlPM2lhT1I4a1VQd242YkJ4YU1GRXNtVWptSFA1M1NFNloreWlsbndM?= =?utf-8?B?dGpJT1QzVEsrKzdLcmZ1M05MSFZndnFzT0NMdnMyb01HcnJPdmpUcTRjMTlK?= =?utf-8?B?WUZRVnRKdzhyZEhuYmFpN2tGcVZkaU82dGVXSys4U0x4U0pyVXRLN0wzR0hQ?= =?utf-8?B?NjBLRW9LOFY1RW9UenRuSFlFaGJKWEs5dklxSlpvQUc2TVBrRnl6azVud3Nj?= =?utf-8?B?a3ZxbUwyQ3I0WjQ2QXNaUFhuOXlLaFg4cERzTVpSaVRHbm56MmxOUmtjZWVi?= =?utf-8?B?REgyT1VIV0l4U1NOY3lTWWZCY05tMGVDcjRCakJYZWV2Ujc4cXhkeGFEMVpx?= =?utf-8?B?ZXVtUmUwczZwYTc0clF1SEcveW5hQS8zL3QyWEpCTVcvd2N1RTBYSHVNZkRE?= =?utf-8?B?enVLMncrUEQ3YUlaQ3lPOHlYTDFNQU5LMjhTZTVXYWdnQ2pYVk85Y0ppRjJu?= =?utf-8?B?U3R4Y1VVNFdEK1BIdlpjaWVVTFVTcDBZRzEyeHZKM3FoOTU2aHpHdlpnbWVY?= =?utf-8?B?c3Fhb2dpbkEvWDVRSWpKTTJSWWhjNGYxZ3RXRVF1Ui84dFpsajE4L0pDUVIz?= =?utf-8?B?empTZ2pIeG1kRDFkalI2akhCU25IRWdqTFU2K1lFL1FpVFFnUlVicnpHb3Na?= =?utf-8?B?NkNWYXpZYmJyYVIxeHRIYzdvQkx3c1ZkTm9VNU1uM3RPYWNodGhGUkhGN3pI?= =?utf-8?B?bDZ5VzlXRmRCNXRTSXAzUndjaGQ3Yzd5SDB0TnluaVhmUzVLbzF2VWxNOStB?= =?utf-8?B?OXRBYS9NVVE3OVl6b3NkTEc2eUV3L3p2a2NEMGI0L2tzdTdUVlQxYmNhTjZv?= =?utf-8?B?V05reS9tMXhWWlBnNFROZVZPSnJIUWUvU1VCSUxxYVVwdjZSL1pEZEJiZHlu?= =?utf-8?B?NWlaZkRKQ3djK1U0K09RZXlUWkR2NkpRSzh1RnQrbGRNeUQvRXUrbXdQSklS?= =?utf-8?B?OUw1YTVSRkdXVzhUb2JmVGVpODdiQkdCNGpMOEFhWVplUjI0VEJYWUg4eDZN?= =?utf-8?B?WEwzOUJuVEJBOWxNVzI5SUF1VktFa2tnSEFFeFhqdTF0Z0RLRGtxbUF2akpk?= =?utf-8?B?UVNwcU1TSkRnazg1dmFTbGw5OVBCbWNlSE10eVZlbE51M2g4dzY4STJqeFYy?= =?utf-8?B?S3MyZWc5bjZ5OUZNckZtTVhEYkJnOW54enZrVDlWQlQvb1kramZBYmJBUjFH?= =?utf-8?B?YUI5cGNPOTZURFpJQVp2NVlBK0xBV29VbVI3STBTQUIzU2NYck1ndGVRaFBq?= =?utf-8?B?eEJ0MTVaME4wdmZGcGs3S2VPZXgyOWxvd3N1ZDh2SU13eENBNG5pV29SS0RM?= =?utf-8?B?V2pNU1VlMklXcHRzM0hFcTdrakVIQWV1SDJSMGNRa1JRRlhiYk9VY0dXSjNO?= =?utf-8?B?N3dDNVYva2FqZVYwWThJMm9mcjdFSTRvWVFhenY5OEYrQ2lmSC9zeDVid0lO?= =?utf-8?B?VzhwS3dwc3F5ankxdExSa3ZaRlVsL2MyRGNxajh5UXhrK1ZKbjhXcFRwdi9Q?= =?utf-8?B?blk1VWNFT2thaXBnTXdxTHJ4K3NzUUo0eTA5UWRlTTl0T0tielJrb0tPclVJ?= =?utf-8?B?RDdEcjJTVlU5WU4yY01ORUd0NDZZNFp2WEp5UjlreTFzSG1ZZzd6VnRyUzFI?= =?utf-8?B?QXNJazVUcVlTSjRSZ3A4MXJzMm9Ma1Jod1EyZWxzTTBZOUJ5OWJZNUxKakNF?= =?utf-8?B?aHBJcnlSMy9RSlM5NVgwNGVIU3pxU0Z6d0doaDNaT3gvcWJueHJkdEFkUERR?= =?utf-8?B?SmF6cnJLTkZ6UVQwWjFvV1FaOFBzRmNiQjEzVW5wNEtSWFVRb0c5RWFxOWkv?= =?utf-8?B?N1p1K3IrOHJKRmNSNnpJbkxxeTh0dWVON29PQlZReE9uR0ppVUE1Q1VSSnFR?= =?utf-8?B?elE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 48f79997-81b2-4c2e-149e-08dce1ec9aa9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 07:42:30.5160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aFMtWV7AoT0Xd/qH60p0ctSZV55ew33a45p3P3BdRkBId/m01MBSIO0FwKRqYQBh5xZYzoeLPbE0VaDuZ2+BeU3kR7CSU0krTsw7qBnLRUA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6617 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 01, 2024 at 09:14:53AM +0200, David Marchand wrote: > On Mon, Sep 30, 2024 at 5:57 PM Bruce Richardson > wrote: > > > > On Mon, Sep 30, 2024 at 05:38:44PM +0200, David Marchand wrote: > > > On Fri, Sep 6, 2024 at 4:11 PM Bruce Richardson > > > wrote: > > > > > > > > The AVX-512 copy code in multiple drivers was incorrect for 32-bit as it > > > > assumed that each pointer was always 8B in size. > > > > > > > > Bruce Richardson (4): > > > > net/i40e: fix AVX-512 pointer copy on 32-bit > > > > net/ice: fix AVX-512 pointer copy on 32-bit > > > > net/iavf: fix AVX-512 pointer copy on 32-bit > > > > common/idpf: fix AVX-512 pointer copy on 32-bit > > > > > > > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 7 +++++++ > > > > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++ > > > > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 7 +++++++ > > > > drivers/net/ice/ice_rxtx_vec_avx512.c | 7 +++++++ > > > > 4 files changed, 28 insertions(+) > > > > > > Sorry, not directly related to this series, but as I was checking some > > > AVX512 patch, I suspect some drivers are missing runtime checks for > > > availability of some AVX512 instructions: > > > > > > $ for meson in $(git grep -l __AVX512[^_]*__ > > > 'drivers/**/meson.build'); do dir=$(dirname $meson); for flag in $(git > > > grep -ho __AVX512[^_]*__ $dir | sort -u); do flag=${flag%%__}; > > > flag=${flag##__}; git grep -ql > > > rte_cpu_get_flag_enabled.RTE_CPUFLAG_$flag $dir || echo > > > RTE_CPUFLAG_$flag check missing in $dir; done; done > > > > > > RTE_CPUFLAG_AVX512BW check missing in drivers/common/idpf > > > RTE_CPUFLAG_AVX512DQ check missing in drivers/common/idpf > > > RTE_CPUFLAG_AVX512F check missing in drivers/common/idpf > > > RTE_CPUFLAG_AVX512VL check missing in drivers/net/i40e > > > RTE_CPUFLAG_AVX512VL check missing in drivers/net/ice > > > > > > Maybe some flags are implictly available... worth a confirmation from > > > Intel in any case from my pov. > > > > > > > I think it would be good practice to explicitly check for all the AVX-512 > > extensions actually used. Ideally, as a cleanup, we should probably check > > for those listed (f, bw, dq and vl) once early in the config and reuse that > > value throughout the build, rather than having each and every PMD > > continually check them. > > This simplification on the build side looks good. > > On the other hand, vectorized handlers in libraries and drivers are > selected based on some AVX512 instructions availability at runtime. > Don't we need to validate *runtime* availability of each of those > instructions in each library/driver? > Yes, each lib and driver should be also checking these at runtime. Simplification of such checks may be possible, and may be something I look at in future, time permitting. For now, an example of the checks done can be seen in [1]. /Bruce [1] https://git.dpdk.org/dpdk/tree/drivers/net/ice/ice_rxtx.c#n3486