From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FE9245A7A; Tue, 1 Oct 2024 15:14:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2673A40647; Tue, 1 Oct 2024 15:14:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 7DA454027C; Tue, 1 Oct 2024 15:14:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727788487; x=1759324487; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eX5lHT/zY4pfM0C4TndcM33PgWb72/mVDVlTGO0jdw4=; b=S72d9zYmtNTH6UUfHbUgkWhVLKKulo9+7sSKnHA1/3eKZ7318m02qQeg IO2rHRPgKxiDW4upYdFc00tbYRJcq3pFvHMGNyKlBvJfNMH4qL3LmG07l a4N5wXDio7kk1aJWVJkT4IH7p/6DlQ6AHFWE84O4gQ7FD84JE07J63oPw C5HWrecCjBeCWm7FonHrP79M+2/6B0vtMshQ25zPgQEWA5HK3dLtYimCl asgAp5Vx1cAXYtjwV44Bl4qTr1/zB2KstTYWE2B1cLeW7El1wTVb/D/Dj BLH0c9Sy2v7voaQuR8dDTIU3ZatjYoRe09U/uz3/DWN4+QlDnBFnE2/se A==; X-CSE-ConnectionGUID: TyZrKwhPTjGWaJAGfSAhOA== X-CSE-MsgGUID: nDwQs2reS1O2JIl8kOh3Mg== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="29804317" X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="29804317" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 06:14:45 -0700 X-CSE-ConnectionGUID: adggYgRIS8um/4d/Al5Ksg== X-CSE-MsgGUID: Lr4KKKSqRS697BiZGtlPfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="73324421" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Oct 2024 06:14:46 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 06:14:44 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 06:14:44 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 1 Oct 2024 06:14:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jPBX6OWSsypC4OBjYETOR1SC/WfWanZ827htsyLy9zc8qzYs1k9CTGCpCGZERdc6bXUBal5JjUDbUOizWs4Xjn6X86WvkRQAvZRnA2S5749So3eiUdAb6XN2RhkBhfGqwgUd897bi7O31sgaUl3wX+6YGJKrmXscS5XId7LWXoJgriN5d2xGNf3TQ2XGlR2Tsq/jtgq56Z1V0s9mgLuYrm5hqImI47cq1NjcdaI0jxFPNBX+Us20AKgNa1oPn6LMdALzaqlD84CFhkW6k4szyYlqPq0JvQOkkicqBhRBkS+kaQyuekmEE4/LXkX2JV1hByEHeJwJ6W+01K/vqJSlCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CoK8oYRF5adm5+MXpTAt4Z91ZLvX4J44HjFc3H2SYcA=; b=c+p/U4BXqS4K7qr6pgVw2Itu1KSUWWJF+xAABMTLHiBoQ9nopet0NXuYRctO5drJpX/dr7S1ovk80wUqPv1lN9Udd2B7PBUonpuZEexFzkJariit7+Hssg2MKG0+usRvdScrcHjq017zO8skS/8w3gLxNph27uvYvPMg2NhrWQI9zzeWlupB2/DcpmJTRHeXSzWtdy1gbl/K2TWihp7+HxKSKdU1FfbG3Nrx8ng0KAFJQLnmzlPLfLaHlE5qnjT/hhStwEFoMnFnQmDpVXkdzf1nY6lkBj6wFRdqSym5oMU6GIkRZlGlaB/JHsvCuV8q+zBXIGqO+1uOn1TwVVdfSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB8327.namprd11.prod.outlook.com (2603:10b6:806:378::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.15; Tue, 1 Oct 2024 13:14:41 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 13:14:41 +0000 Date: Tue, 1 Oct 2024 14:14:36 +0100 From: Bruce Richardson To: David Marchand CC: , , Jingjing Wu Subject: Re: [PATCH v2] net/iavf: preserve MAC address with i40e PF Linux driver Message-ID: References: <20240919120039.4097053-1-david.marchand@redhat.com> <20241001091254.98540-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241001091254.98540-1-david.marchand@redhat.com> X-ClientProxiedBy: DB8PR06CA0039.eurprd06.prod.outlook.com (2603:10a6:10:120::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB8327:EE_ X-MS-Office365-Filtering-Correlation-Id: 879e2a3f-5d4e-4370-6216-08dce21b0247 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IOcjis5T022S9pW4010l6nh7UcAYUl+Gx2z3JgJm/PePYozDlgnsyFbg9Cry?= =?us-ascii?Q?qkPWhyrjhvlb8+G3xWljzh3qMSK9cjjmjbePMhFtds79gWJeDdolOb+zXzwj?= =?us-ascii?Q?1Lkda7aYpnnjmupA5HOnpJU534u31qr/7NS6VFQJPttniHD/ZW4c1peP8SSN?= =?us-ascii?Q?EbQ+v5Q7pRIjLbvV3sgxm6FrDCOlBQnd2PtH5nSV7Czr847VwhJqbPeAeCG9?= =?us-ascii?Q?s9UXgcoMctka7WZZm2WkMbXGg3DZXAnKoob5je9eLmQ/UCdflvMIuWFXnrYs?= =?us-ascii?Q?mIJtkN3INZL2Eim8+cOPrAn3Lane/ynpCvK8Nr4G7Q8Gf2wPKlhTthBRSx6h?= =?us-ascii?Q?SdjV8HYWf/JUyFDdGPoLPwUgqBfMzo5Lv/Sw/QhV+iR9t0GSkAFW1eDnETVz?= =?us-ascii?Q?5AaiC8Xf3qa8qCmCKy/I66dvL82ZSwedlBZ3L3M8iSwF8suv4F4izgmVvV9/?= =?us-ascii?Q?89IqOHsBqowtbALVQnC3Q7hBoBqLzk4XUEb0I/HuuKmxbpPX6z3gFz5vylKW?= =?us-ascii?Q?zcoLgVM7WOXZM77orAKF1mivQqWrSRYBnDXGIkWHCKurrLOi/dfIhccXeXZB?= =?us-ascii?Q?LcdVNDusodyNtGX7Az3tFp/3bpxD2oxOuP1URu5Qp23ELRdcNP4euWID7kwO?= =?us-ascii?Q?/wPpocPR5UWlJSzU1KcYLNKzIi7DJmlIXxu0/ewUYQEIcs8dRfph5R1OK8wi?= =?us-ascii?Q?gLXuo0/wBdjPEx5lorP+Ygb7yxsd8UVIo7PPJd4NEooFKK8jAfEi84zxsLCU?= =?us-ascii?Q?s+yTfN/P56zYxGAuYtk3Um1CRB+BshnzDKQz8gR8eoV1RUOIYe/DozMFBnYI?= =?us-ascii?Q?3+2kenU7zSkARRlKWx+VWIa2Yf9ZhvJQ3HVKNhmwJZ2//CWrHQrI4jH9Qyj+?= =?us-ascii?Q?egmPvpNJLzvXlJuIfn95W7pvVaGUWeWo2t+eV4evvh2/yoVCK5f6cH+4RP0O?= =?us-ascii?Q?BqGQyPGplnuAMTpslO8HPIDQ9fzjmWJs4QgXvXPi8/y820qCR5NdtsXdNdHC?= =?us-ascii?Q?xvSQNqQWpfi91uNK+xYfhIY9dx89W3Nrjk9PaOm3iVNu7SDpRHnXbseqfMUY?= =?us-ascii?Q?xILZkaEo/UxAMUIqMCY037KWbgxPKn/ofU4PqTPWwURrLNSLowNfrr8npIhV?= =?us-ascii?Q?BZUGhBGPmylri33ABOkfV1R3V0F5U245M6ULbj7y21hFQMASTR40qiads6Cx?= =?us-ascii?Q?CSZUIL9Y3rkfcD5+ARyNf1S3FEKRoDYvt0WwpB9nL7k/iDpze7zHnVwAySdu?= =?us-ascii?Q?6PVm6iDcycRmHfBZlKaoKLUxeM34tgnzIRgGZBbdOIsTRa5Tg8lFuXSFELeN?= =?us-ascii?Q?HYE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kcjY1qhP8E3ZRgIeTXEumfoTgK5O7HhvMNi/DdTmqCPU7j73moQPnjfyH4ty?= =?us-ascii?Q?UvgLiLFoHiGNl1t+WF/XLRT1bIuCCjNOiNfKdZyDOO/L9UxpmVwVAW7gKUJf?= =?us-ascii?Q?Gnq7C+gr1iop+lJ7vKXyVwtaxAKAhfQZSLj2KXOf/61vN2vPhDyyjAL9mPGs?= =?us-ascii?Q?BHPwRcuR85KCTvQcxQ3LYJl6RMA5Zpo6qKpC3AL7wHgYBotGwx42oF9yuUdE?= =?us-ascii?Q?LdI8//XozC0A4phGH2t60eIWRjehx/ye79yqIqZt+bAKK/0Z7zFj4a9hJ0/4?= =?us-ascii?Q?CQsRrs0dqLMVyXdviaAuqhsEI8SZ6QebTScWNqHf2pqV+4aqrNefN46Kg4PW?= =?us-ascii?Q?ved79sabKN/PYgWNqpyzrYMIqCfsiS9qV4T8ZtmYqQ03t7MbJ8FaLZnnaqPn?= =?us-ascii?Q?WvdPgvVCf+r9TPaxwVDT0fGQzRLgDCt+ioCaQ6GUwOMDRG4V5SESAGPimv5k?= =?us-ascii?Q?vUX4H6JtlQRzCVJZsZhO4dLe+jIPUdCCyJdVP/llOy4JMRrI2kFOdH7tsNIW?= =?us-ascii?Q?wzVEM5vCPlDaBHZtfYNnVKmRPtQpmyBvMn+X7C6W4lAJEIeXRDOHJXF2sIE9?= =?us-ascii?Q?Ke+yldZ1XD4Uny1lVQvxipdEENprfK6sCtUcrxI6DL5Vr8G6Rk90p8VnpSM1?= =?us-ascii?Q?0MtWmZpHDM1qmAz2xk1bGb2t2jyigWBIaKCdvu9sK4Hdu1dTYB6NtbCeGid3?= =?us-ascii?Q?AsOZh9AXXSj5WcwgkyBFNn3XEU4HSnxoVe/IUkNySvWipPCZqu23QN6fMwdg?= =?us-ascii?Q?Z40nzk/LwX8AGs792ShcwnWgnHMARYS8YXBQTRmlmACuWJEdYDil8OwRx5wG?= =?us-ascii?Q?uZiMdvNAEK42Re8lEifSbhCxNch566MeQJs4hBRJ4GLJskuNUJ2lr5mL5BKn?= =?us-ascii?Q?XPKhM8wtdVljNioGSKQTkBoAg7DstoHSNSu73ALPaXPbgPi0q53K8L4F2g5b?= =?us-ascii?Q?zKrSjB2gUd3gVElXBp+7gXLGA1zJlogYUzgIVu6Y+eJjvvkoIeHRPOdC5KCG?= =?us-ascii?Q?1I/h84vhC161uht4o/WYR76J7jSHVxBtJiFtKcmG1Bgp8ZYaXXmdpasgZoGZ?= =?us-ascii?Q?7/wYZ/iVLfe5M5XADLJxxtN946nDxWtUGtbgFFmNckqQvP4HVq9vaQk8+v6I?= =?us-ascii?Q?F2e2p79vVguIkIl7CvWLpIsIIRN4G+co+BI3fo5X94eR/mh4SsoUqqUq/J7X?= =?us-ascii?Q?eLasKb0BqRIsip5ethONIo93Ng/+7wWGV32znJyq71CMPgQeODxKIS+1d8c5?= =?us-ascii?Q?pJDhKkWtNBnc75f9ceQjYITGjhb9+M/5iq8aLdtFh+077mfznsod5hRgppDS?= =?us-ascii?Q?N/hQXsKC9ewKG3NKf1JEq6DmBHxeHwQmAnT8KjT1dok2Ibmw9Garh4lzCr1a?= =?us-ascii?Q?8DpwB3WeOcgaB1ijwaTD3ssrFNUhQXd8z3GFzGXqjEKXCca8GMOg5gX8zc/w?= =?us-ascii?Q?yf3no+KX9nvzAQNmWHfYQXI6q9eOeK8XKGFMUzhCxKMrc7FgQ0HJsZdOWZOn?= =?us-ascii?Q?/Rs5+3S45L/E2WWg17cl+ZDGnPmjJQ6eAWNRXg3SJC54g0rloKNW+DDTTxHS?= =?us-ascii?Q?BLwjU+lxLxn1SNzuYrQWHh2qoyGfBzddFzvKBbwY2Evwj8IETXouWd5w2nx+?= =?us-ascii?Q?kA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 879e2a3f-5d4e-4370-6216-08dce21b0247 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 13:14:41.2266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: COa4nBCZpqCH/twTtdyGTK4TTPpxOy2TTIKp3wu4EdRdCJeu0pum75+9bbt/9wOwTFSK7LoeArPoS6tdLz6bcy44EQTdwsDE6shiZcmrdG8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8327 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 01, 2024 at 11:12:54AM +0200, David Marchand wrote: > Following two upstream Linux kernel changes (see links), the mac address > of a iavf port, serviced by a i40e PF driver, is lost when the DPDK iavf > driver probes the port again (which may be triggered at any point of a > DPDK application life, like when a reset event is triggered by the PF). > > A first change results in the mac address of the VF port being reset to 0 > during the VIRTCHNL_OP_GET_VF_RESOURCES query. > The i40e PF driver change is pretty obscure but the iavf Linux driver does > set VIRTCHNL_VF_OFFLOAD_USO. > Announcing such a capability in the DPDK driver does not seem to be an > issue, so do the same in DPDK to keep the legacy behavior of a fixed mac. > > Then a second change in the kernel results in the VF mac address being > cleared when the VF driver remove its default mac address. > Removing (unicast or multicast) mac addresses is not done by the kernel VF > driver in general. > The reason why the DPDK driver behaves like this is undocumented > (and lost because the authors are not active anymore). > Aligning DPDK behavior to the upstream kernel driver is safer in any > case. > > Cc: stable@dpdk.org > > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fed0d9f13266 > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ceb29474bbbc > Signed-off-by: David Marchand > --- Seems reasonable to me. Acked-by: Bruce Richardson