From: Bruce Richardson <bruce.richardson@intel.com>
To: Zhichao Zeng <zhichaox.zeng@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v6] net/ice: support customized search path for DDP package
Date: Tue, 1 Oct 2024 14:54:49 +0100 [thread overview]
Message-ID: <Zvv_KaL7YTSEpOUj@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240920100559.1464272-1-zhichaox.zeng@intel.com>
On Fri, Sep 20, 2024 at 06:05:59PM +0800, Zhichao Zeng wrote:
> This patch adds support for customizing firmware search path for
> DDP package like the kernel behavior, it will read the search path
> from "/sys/module/firmware_class/parameters/path", and try to load
> DDP package.
>
> Also, updates documentation for loading the DDP package in ice.rst.
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> ---
> v6: use open() instead of fopen()
> v5: update documentation, fix code logic
> v4: fix CI error
> v3: update doc, fix code error
> v2: separate the patch and rewrite the log
> ---
> doc/guides/nics/ice.rst | 60 +++++++++++++++++++-----------------
> drivers/net/ice/ice_ethdev.c | 47 ++++++++++++++++++++++++++--
> drivers/net/ice/ice_ethdev.h | 1 +
> 3 files changed, 76 insertions(+), 32 deletions(-)
>
> diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
> index ae975d19ad..a6104db4d4 100644
> --- a/doc/guides/nics/ice.rst
> +++ b/doc/guides/nics/ice.rst
> @@ -80,6 +80,37 @@ are listed in the Tested Platforms section of the Release Notes for each release
> | 24.03 | 1.13.7 | 1.3.35 | 1.3.45 | 1.3.13 | 4.4 |
> +-----------+---------------+-----------------+-----------+--------------+-----------+
>
> +Dynamic Device Personalization (DDP) package loading
> +----------------------------------------------------
> +
> +The Intel E810 requires a programmable pipeline package be downloaded
> +by the driver to support normal operations. The E810 has limited
> +functionality built in to allow PXE boot and other use cases, but for DPDK use
> +the driver must download a package file during the driver initialization
> +stage.
> +
Minor nit - when writing documentation, rather than wrapping the lines at a
fixed column width, it is better to wrap on punctuation and to always start
a sentence on a new line. This reduces the diffs when editing documentation
in future.
In this case, I'll just adjust the line-wrapping on apply, so no need for a
new revision of the patch.
/Bruce
next prev parent reply other threads:[~2024-10-01 13:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:53 [PATCH] net/ice: support for more flexible loading of " Zhichao Zeng
2024-08-28 7:55 ` Bruce Richardson
2024-08-28 8:53 ` Zeng, ZhichaoX
2024-08-29 3:35 ` [PATCH v2] net/ice: support customized search path for " Zhichao Zeng
2024-08-29 3:41 ` Zhichao Zeng
2024-09-09 12:13 ` Bruce Richardson
2024-09-12 7:47 ` [PATCH v3] " Zhichao Zeng
2024-09-12 8:01 ` Zhichao Zeng
2024-09-13 6:15 ` [PATCH v4] " Zhichao Zeng
2024-09-13 10:57 ` Bruce Richardson
2024-09-19 3:29 ` [PATCH v5] " Zhichao Zeng
2024-09-19 7:49 ` Bruce Richardson
2024-09-20 8:34 ` Zeng, ZhichaoX
2024-09-20 9:04 ` Bruce Richardson
2024-09-20 10:05 ` [PATCH v6] " Zhichao Zeng
2024-10-01 13:54 ` Bruce Richardson [this message]
2024-10-01 14:03 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvv_KaL7YTSEpOUj@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).