From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7026645A7A; Tue, 1 Oct 2024 15:55:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6073B40289; Tue, 1 Oct 2024 15:55:01 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id A419C40268 for ; Tue, 1 Oct 2024 15:54:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727790901; x=1759326901; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=PHWu5nEbQj5x8TGFb+d+OCDcb3m+4MgYYNd6aASxX4o=; b=Dit0u9La5Zuzqnz3BJ+49VKeEo+L9u9lEhBZV2mCy/xmvU/wTkzPzuAH E3LJUfo0Gc81gi0i1ye0drCRDLa1OUfg+j6jC4o5Lsat+zLBVG/gzU7Vy Z/Jq4gwoNFQXYpOl3EjUwuewYtt8JUe6DBzC8FrogKTh4aYWG9Xl63n3D mz/6AmCsePm7IKkp7A07wtF4/KAT9TUlnpPr7GWZ/kYs6EY+MqSDkEnG6 Lr74ZWsr1osOv5yW+eUbyuIGg7UoK4E2BAm0G6wVoheL5bF1ebHYCCTEO mGECSYLUcAK7OdjMF7l669LTPkLMMxmTJ/wQ2bqu6uGAWPo0m6p/S9ZWH A==; X-CSE-ConnectionGUID: trVRP2KzT6SvN61n6SzXmA== X-CSE-MsgGUID: kwP0iNEVRwKT4iVh9NMcsA== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="30632373" X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="30632373" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 06:54:59 -0700 X-CSE-ConnectionGUID: PQJJBNcZQHG3WgcNd3C/mQ== X-CSE-MsgGUID: qmRSwqZlTMS90L01xvDylg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="77719751" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Oct 2024 06:54:59 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 06:54:58 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 06:54:57 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 06:54:57 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 06:54:57 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 1 Oct 2024 06:54:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tNpL+Xrd000CG4X4gUl4JIT0YTu2804dDeanRJioShCknBpYfuV/or26EuN/yCbZhXXNgi9e7vJrLM2/cYbLDrz2fA7H6ZnLNwbPekuUNkwDsgqqSw3+g+RJJ/XEg2lZSnF1Xe5uqwJSdamFfrntXRRDYrxkX9a/bgnRoyqroVHcm/btv2higUyMTwfppXBEyXTMmRYmDX7Iw35uR6u/ZEhhkvF0qeCyb3djmbyzOfNJzXICOzHDDfzBfAJnOFPtzwCIU9uNX4dV7P0bqS1H7PDHM18nGSZfwp0LveW2QjFazjj0EKUWrYxV5Alj4lIQbEFyat+a5A+H9Bzve+HBXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tNIutwZk/hgUOfp4E2RhZ2Jv41pbUUjzevx0IGWTYeM=; b=bngtodnMMIc8QaEyquZaySKGjrI9be1y0jZz1qo3xqeQiQu3l6ZArAgZ/oIAQbpXeOH3sba3p6XN7KnESMjcocsgEgao1R2DWkj22zVHG5iwmQep+TX4KLk6nzQYNErXenMexkO5l1E2BUSioaOcBeT6Fc3ZW7RXLLU52iw1AWlbV9mqlEGUO6+lUYhtLquKiz2GRQhkm++tWD0AME9tX5eQLhmshTACpGE1scich646aw+JDmqqUXFR7hAkDLs6BQTS6oD10tpSTmjfThCRb0E3YXdxgATqdCyQiEULNW6jvou08DLiOiqU6204CwPzqO2nGUw087neEjuVdI+EsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5020.namprd11.prod.outlook.com (2603:10b6:806:11f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct 2024 13:54:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 13:54:54 +0000 Date: Tue, 1 Oct 2024 14:54:49 +0100 From: Bruce Richardson To: Zhichao Zeng CC: Subject: Re: [PATCH v6] net/ice: support customized search path for DDP package Message-ID: References: <20240919032934.800979-1-zhichaox.zeng@intel.com> <20240920100559.1464272-1-zhichaox.zeng@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240920100559.1464272-1-zhichaox.zeng@intel.com> X-ClientProxiedBy: DB8PR03CA0029.eurprd03.prod.outlook.com (2603:10a6:10:be::42) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5020:EE_ X-MS-Office365-Filtering-Correlation-Id: 988daeba-9eee-4ffb-a3f0-08dce220a095 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rwXDVvq1xvaRgypGR7KR6MlSjUeW/UX5OfIx+B+0kJUugJj8rLYODqLrgEGi?= =?us-ascii?Q?1k/JGaeVWjUcqJoKZYRVMNkrxKH+vNCtiTaVzSOrBuDe/Hu3qLiR0DlD7LRM?= =?us-ascii?Q?sFGlrQsxOjGkwXjJQdZvVInejb1u9Y6YL2dfwjRkff70NvreOFU5vE5q1r//?= =?us-ascii?Q?ENoVZXnoG0r9LLZmp/p/1Zools2KQNQMh0cgcsjY2/A33bFQr6VMMa45y/DJ?= =?us-ascii?Q?+BYezSZtpVTOkl9yNFUYHYvFDKMgLEFSTJlmC2v8owZyKyWuuqPSSJldF4RP?= =?us-ascii?Q?+IG2u49QSJebXASHx0nTiHCbfRCeHopPwWny8LF3J+B/rngwK51SwSVcKjZG?= =?us-ascii?Q?Om3ibqEUFbTGRLuRNzM9rwTnszCWl6OU7t2494zUQiZTub0vVZ3XIyIApAlq?= =?us-ascii?Q?ZbYGMAQOXPsagbasIECu6emeiDg7gVZDUc2emtfpz/jah7NM2GkKqU/2dbIJ?= =?us-ascii?Q?KPOoFMZAJfsIHHfN2rJTyYBULOGwNqs7bTq3mgNYsCr3CM0tfG+lWxOzVSYA?= =?us-ascii?Q?fCGw3aF6/LiPWI0nTYkMfLFwMTGyKDRrJLCYx2nAe8OGKl6Jutxp0nJix6U1?= =?us-ascii?Q?gs5aHJRSkGh+D2m/K++vCNj+eOIDd3YzhDokr1cJfNFVc1Ph5nM8dB9nOqvc?= =?us-ascii?Q?wkXWG7mA4QJqpT1xu3xxfJfbZPzi74wLjFMr28x5luNkwF4DpukxxyLVx7os?= =?us-ascii?Q?Ov6TKHYEQHk62C5Ql3lWW8R+M9WOpPg9r6vjP6iLlhYsl0i1TJVxF2j0UqpV?= =?us-ascii?Q?2LsjdEjH7asSG55RPEDu8HAvJ/QHRmwFb8T+Hk/L6cw+9IwoKSA5G2s5q75p?= =?us-ascii?Q?N6HkqNEi+TkNTZv+zFPnxlJYK02ejsXBc+sz4GA7mO+muoWFXSnkSIy4W4fp?= =?us-ascii?Q?aGa7QZO+ZsZyBEg+VrA85rRPd728wMoOg7bMZwSbyLI12jSdGLErFL0N93x+?= =?us-ascii?Q?qa6/Ohn1q+hoSb2/dlKo9/013psRqo5weyvrzuWJftU9t7IPiYnt5qxOzeKj?= =?us-ascii?Q?Jf3av7xEMyubD18Whb8cVSflm8Qh883Z06tvBpc0J3qOAr+WRSKSa1TvK4PX?= =?us-ascii?Q?q2vljCkGM6y/WpSsvrCxWWGFOK2R2Q8TLXFGX6XlaLfwLlD3XOa5sKBF2Eon?= =?us-ascii?Q?jfz+QQO1By7GgxL+vSyLSQb59EKLBngOaGm3DvzkdazhyAbEPouMqm3p6zbr?= =?us-ascii?Q?Swv8YeyRlQ9k/VXc0HS0FLZp8RFy0vGZhYS3WSJZIQVzTLoP7cpD8cuDYwrX?= =?us-ascii?Q?4o5tGbFgrXkO69wZDNzVO2OdKJ6tduOROLdtfz8IK9ha/2ibgFFQpViIDNfZ?= =?us-ascii?Q?8pjirnOxNul8R4/EDlGOMnrgsQg+MReUKAim4d1kBLfmyQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0bwx4xwEvloGsFbT8muG4E3dE1osB13iQBQlmCY5cnQvwp/L4Ghf+S9QtHHO?= =?us-ascii?Q?PrvdF/CRyIJYTUlrH5eu3hV32IoHeTuqgTB4qoYvPYUyadrXhD2sMhv/dEO2?= =?us-ascii?Q?90A6FQnBrpN93a8muOQMM6Qqw4VrI0PRzNnbeE41gaVmTcZ/K/c3llNzhdL+?= =?us-ascii?Q?AR8+qtRCVoTFK/xrqSPVDEenPjRUBoFv4+uyBLKhobyAnBkeA/7M2XORFAqF?= =?us-ascii?Q?4SfjJmD9tKR5+IL6axJzAFTRpzJ8HlwksrjSQC5YXsXrRoa1lEw/mhyveKgy?= =?us-ascii?Q?uwIl3R7zp/LbRS1sZf/AVFtzNTiQ5nTWRuKlm6letpH2f/sGSXD3rAB+nkTi?= =?us-ascii?Q?blQzdB9jHE+mxgArCcB38n7iWcZ9JpuxGGeTi+TGIrC14tiHNWLv8lSjOyan?= =?us-ascii?Q?kPp7SQdDFEnEZ7NMqisuVI+7gurDbQbrZFzVRLfu1M7H46He6UDoiJl5Pk/j?= =?us-ascii?Q?3y66a6xY7mjIpIeob53DCS0sQmsFcXqV7OvUspWun43HfxqiRplcZ+h3Tsxp?= =?us-ascii?Q?QA5G/gJ4L4qcqV3k7HQfF3DmBY8B19J2Tg60LR3BYwKE7lrXaRtvW3V0OtVo?= =?us-ascii?Q?5jZSRt2gRqqy6JKbeV1YIr1x5w/yTU8scCgXP8oGAcXTggW3ULdSWg6gdq0d?= =?us-ascii?Q?WK+6WVUASVoHt2nXxSUgoix/KgaQ34V8lj0aSl1WG7liS/Ie6OIh7yll9uxN?= =?us-ascii?Q?o8gLN849LMaDWeJeMwGNCw+UMHmRDXAkH3E4cHHMqscu4zdq0YiM4NZdAq37?= =?us-ascii?Q?v3o3mJTTO7VbPWWk56VyL5v3iWUjuGi5Pzdbr+VBKEE9PZN25yHFvGhdCItq?= =?us-ascii?Q?4wiD6Vcogf6SLZcnjrANMA26ExTiDwt2WDrKPai/Ejt/E/vY53kvikVPUKiD?= =?us-ascii?Q?fxlYC2IsXrBjDGglAcCdpIxPD16gT8N8vc0U2kVQnUfAlDArsBbartMuUizX?= =?us-ascii?Q?p9SI4jC1+NDdX03Am0KtAPa3SZ8QNXxoeNfIu0dX+wC+UEn59bb3E82C01H4?= =?us-ascii?Q?uMKewwRzyICyE7XUt+IYnVhWxA5wxVHuKci+2AMSo0pVxvdgECkRC+UsOorL?= =?us-ascii?Q?NFvLQFjWMQdkq7M4QQjoG60Rsgp5OhzRs65CASP9InsZOPDh/5KGD5jj0Fqb?= =?us-ascii?Q?wWGk6yNGG2yHoaYTbRCPMA3p6smGzrvVX6gbr0Du7I3iDoZFKMiMt4DhTNU0?= =?us-ascii?Q?yvsm2hUQsxRhH842cUPf5qupcnY0pFCxz9baeJCihHlbrdRAaS8AmuWOSksC?= =?us-ascii?Q?9xTsEGQvLULgclNcQFmvFSQxdbw126CHpvy62s3hjR5O+R/RNGOLS/dY9/5D?= =?us-ascii?Q?dIitHW01faLp7dVw05IgpEobFIbwJRdGXGvOfzEhjQKyKddAO+ien6lcT8Fv?= =?us-ascii?Q?k2hRx33X8kle1pYmMB5ZQ7Ni4pYV+UfuUqIG/vazz4oV4AmBlxLz6I5MqE5Y?= =?us-ascii?Q?v3aRgZsQSfSW2Nn1J22arzBgsQd5L48sztPeRVY78NkK9a+2EVn2n6HtU+yt?= =?us-ascii?Q?K2CeQdt6OcS6PRNQ4/8ie0s+QdbSGGVenqlQdBbouVx1Vund8U0lBfbFQ5fv?= =?us-ascii?Q?YTODL8zdWBhS4Azr4eBCP9dpZja++PqTBulVICv+DEh5rpge6Gl0zNRuXPab?= =?us-ascii?Q?vQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 988daeba-9eee-4ffb-a3f0-08dce220a095 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 13:54:54.2876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pv+uCnrfPeYH9rP73SAWsbC9cMzka6VsbaJZaShyqK4py/14IdFSg8O2/uPPGgnDu9qyGzA4f53LNjcYyB7Yfl8ZA7OvrVKeKVxrZIwTqv4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5020 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 20, 2024 at 06:05:59PM +0800, Zhichao Zeng wrote: > This patch adds support for customizing firmware search path for > DDP package like the kernel behavior, it will read the search path > from "/sys/module/firmware_class/parameters/path", and try to load > DDP package. > > Also, updates documentation for loading the DDP package in ice.rst. > > Signed-off-by: Zhichao Zeng > > --- > v6: use open() instead of fopen() > v5: update documentation, fix code logic > v4: fix CI error > v3: update doc, fix code error > v2: separate the patch and rewrite the log > --- > doc/guides/nics/ice.rst | 60 +++++++++++++++++++----------------- > drivers/net/ice/ice_ethdev.c | 47 ++++++++++++++++++++++++++-- > drivers/net/ice/ice_ethdev.h | 1 + > 3 files changed, 76 insertions(+), 32 deletions(-) > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > index ae975d19ad..a6104db4d4 100644 > --- a/doc/guides/nics/ice.rst > +++ b/doc/guides/nics/ice.rst > @@ -80,6 +80,37 @@ are listed in the Tested Platforms section of the Release Notes for each release > | 24.03 | 1.13.7 | 1.3.35 | 1.3.45 | 1.3.13 | 4.4 | > +-----------+---------------+-----------------+-----------+--------------+-----------+ > > +Dynamic Device Personalization (DDP) package loading > +---------------------------------------------------- > + > +The Intel E810 requires a programmable pipeline package be downloaded > +by the driver to support normal operations. The E810 has limited > +functionality built in to allow PXE boot and other use cases, but for DPDK use > +the driver must download a package file during the driver initialization > +stage. > + Minor nit - when writing documentation, rather than wrapping the lines at a fixed column width, it is better to wrap on punctuation and to always start a sentence on a new line. This reduces the diffs when editing documentation in future. In this case, I'll just adjust the line-wrapping on apply, so no need for a new revision of the patch. /Bruce