From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DEA445A7B; Tue, 1 Oct 2024 16:03:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05EC24064A; Tue, 1 Oct 2024 16:03:32 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 3404E40268 for ; Tue, 1 Oct 2024 16:03:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727791411; x=1759327411; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=4SSCIp0JzfJj1nOFUBCL/NkE9Gq+1MFwjc5UHSkR8X0=; b=MN1lXM5xYW4UgOqPbWmmNXe/buT3fNJrA+7f/iTVZJPYR9RpeZGB1fGE J3kK/7oTpMpX6rb8ngPQbZoXfRVczK6QDHqaxu+s5aSnZYW8merGYh51d +4UnDTLa+/5KaiQH2UR2JuVXzRD9xMH9CTeEgGTkb/MiHoQ8mQwEsUR12 LnImuLcvIPnDwtCcSi1VvIeZZrX7SpTqVGLVM9xTuPy6/jjXzhVLmM+QB vfPe86GSPkI1yGc+LfcwVdiaZzHnnlFUsPR0Ace0ivIECb3i5433WVtL3 kIQSeZkch808FYAXqqgmrOSq6Yoo3ySp/y6vWimz6pIJ7+GY6QUzkRogW A==; X-CSE-ConnectionGUID: uQUu3BsRReOsu7rFv6JqTA== X-CSE-MsgGUID: +uDPewTfSAaywjgwLCM7XQ== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="27059311" X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="27059311" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 07:03:30 -0700 X-CSE-ConnectionGUID: AJc8iGL1SjmpBVwARIReBQ== X-CSE-MsgGUID: Ngk8VHUZQFuFYKYsNsnquQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="73647761" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Oct 2024 07:03:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 07:03:28 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 07:03:28 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 1 Oct 2024 07:03:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YSIp3CVwDbDbKU1A6sLr8RuEgbBfJ+n3BVRd7haDCLjzEK48X+3Nd2EeGf9v/GpZ7tb1EWye82M9W8fDv0rs+GkstF7Evt99ekMz+mMn9ww/x6EQHNSEZ44e03+ykUsw12JN7OoJw5UOLHwNTIWxj/70a/mxQFrKrj8Pfc2OoCKn2unyaBKwBqdG3P8n8w9EzOeLNwF6nzxdF7d2+uW3IfFF9gcW0Ed8wXFaQbIzx9j1Ctn82YGV9ZmCojSZGB9f81cHTnDEO0Mua81wVuKrOqyQkCNhmyBrNjNEldRjpYaAZ8qWCYcFDKQhEizsRFXq9UYpGmxGyWhe+xMGOKk8eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tn3kDVWjg2gCg5lMsfw+pMDN1GcrBy7jn1k7mFdHj6k=; b=Lxldldtoy1hCkhpefy/8SNe4aMSLIKdvbxlHm/NyRXBiVOwSzragPlLpIfzyDN0Gf1vFFHiqLS2ImzmThimDV+9g96f/GYlajFtINzwjZPsqpghdnHsEVR1fRLWBjkL9eL+8Dikj4aBgSe9EjJxlQCuO0ozabcXsj6MUvuM3/Wag1D9Fqqp2JU2vuvEwvWOWFhT2GKpOpUAwGE2neHJRw7OtZOwwAQxDgpRX8R19/wOgjTr07hjNzsSHBhd3T/s8HeRIOG51N0Tirc5LMfgLWhjDWpMYR0o5VSt82ltWpHI9dxQmjUO+oZalfTL2HVPFfv/qmToarvHRTBXu2mYH2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8705.namprd11.prod.outlook.com (2603:10b6:610:1cc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct 2024 14:03:21 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 14:03:21 +0000 Date: Tue, 1 Oct 2024 15:03:16 +0100 From: Bruce Richardson To: Zhichao Zeng CC: Subject: Re: [PATCH v6] net/ice: support customized search path for DDP package Message-ID: References: <20240919032934.800979-1-zhichaox.zeng@intel.com> <20240920100559.1464272-1-zhichaox.zeng@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB3PR08CA0003.eurprd08.prod.outlook.com (2603:10a6:8::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8705:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d3c6b65-6c4e-4875-a376-08dce221cec2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?J/f003bz+8b5KW0Qbmk58hH6TGDV41MU6i4P9uU8FgOKvLo9RtyXIsXWhas6?= =?us-ascii?Q?fZUE2lUDUn571a92ZjF6SWzB5oWMiafqtDRhvFQH/GQGS7/Y5hf8eVyGM0cd?= =?us-ascii?Q?EZB85/wPaFCW+C60/f8vD2wZ6TRJPR2s/nkHpHPn5h94tlm6vbjdVAa75yvA?= =?us-ascii?Q?giMoiBHmIdTbp2npbbLcRQX9F9b69Z1HJ9zYqdHIWulnGeUYTGzcG4ISKB4t?= =?us-ascii?Q?C6qazGWm3ynAMaSnI8sQNPnidL1xDBd7sNwkxR9jFtMzOrmvBxhWk5iUKUSO?= =?us-ascii?Q?XgiKrkTFolH+1kBxe9tl0ZGygEmXPK7WH1wtEFUBtqMMf8n+BhSKigdEf7XQ?= =?us-ascii?Q?z5yUefZl7kivZeq+0V2Y0C+Qo40r4ipNQDBGsPfX8DbGX07lMwEqQTe3vCuW?= =?us-ascii?Q?dRYwN1T0IFFNkVg108l+C9G87vlSnMY9DoIZi7yfegQtUO2I4qRGZ9FhWIp7?= =?us-ascii?Q?jtkktejl6/5zckrU8kbicyR/+dHhIfnZ1iRE9AR1idVjPN7tX2r0BV+y82hM?= =?us-ascii?Q?EY1mzo5wZqgfbJwTsv54gQWl4k5VNLHucPOr16+NEd+J61abmHtmBA3MgJqw?= =?us-ascii?Q?Lbgi/gwxE19Wl4k9yZqapS9VbgqMHvP4mFQHrDEM1E5vrY6v3BvnfAV4YUzy?= =?us-ascii?Q?a6b1qrH3WODX3Z1WseaN4qdcib0xzwJ2LBASLle46QNVIuSxXBEfsefiTACj?= =?us-ascii?Q?pUvKpKEOtEJmrIVdLvrTx+IU98vMk4P7mv3zi4Tx/xR8tbIctaUkKQASi2+i?= =?us-ascii?Q?6Y6osoU9OezAXGqWBSnU0MlOzBbe/lyX4tGgTJJC1k+jPe2r2QfdYU5Qd47y?= =?us-ascii?Q?3BAJKWka9BadUqM2WdMtYMI+zrGUHN+yGbpXWEUrnUSEmnKcjpQyu3bu0hvk?= =?us-ascii?Q?9f+Lme4PdWVvYRVoJm9eaT5n3pcFBXMPR+GB1JNrxUfYlH7JKGuWgmxDwTsX?= =?us-ascii?Q?/2r6ii+J+nPp7B9QR98nY41dE688/PpGz8zN+yHOtDfn6o4LGBRqJcJTJ2OY?= =?us-ascii?Q?kZiGfeUYIMulmw8x4XKu2V/dJsf7dXcO/z0GF21OvEBYdqLhQkakvV0iYF0b?= =?us-ascii?Q?VlG6mtQQplhRTj5w8bQWQAbGDDD1AJ2bs5A0uz/3yEFr0+J6Ytuh/YbOZjBP?= =?us-ascii?Q?zuPbsMhGiF4fcE8vu0I86X/N6DNsRjfZyRcZ46agYABBJPl0Xa84CjAeHM7w?= =?us-ascii?Q?J8SmnaaTfhtaS3tp66d2Uo4Th036ykCsj1gvjId7h9qLsMQ9DTfi5wiO90Ri?= =?us-ascii?Q?QJghLFCX7LHNh0XwTlGLzymHNAhfJlJWWlP9stIMjA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jWI3sUcTG/ge7n8sHd2uHJFBfS16F6az/oeOlX4N2bIqV8oQxUvn1BjaTumd?= =?us-ascii?Q?HCV3JlM7gVbvRB2oO3s/zbwQBdgzYWfZSIIqwhGN1I0kjW76nOuDHUXMNjF7?= =?us-ascii?Q?4DudBw1t4k5kKBkVG8pU3QMeo4CKATxJD7I/wn/dG5VjSkaDo7/OWh1aeYWr?= =?us-ascii?Q?SoniCikTzTYqFcRuTiMmpdNwfEtb2qkSmXv/Q23pxxcDXXEL9KUlc8wNGy2r?= =?us-ascii?Q?Sm9yBhoLf2ykpd4ukYme3S32P8suh1u3M/OEhFgA0JEXvXFZ3X9rmnYp0XHh?= =?us-ascii?Q?CCHprX5m0O6rOKWoOCN6YNjdiVbIfVXJkzNw/6oxWtmVZ0+YeCNw44at45Uh?= =?us-ascii?Q?5VmowSeUdchCKHSlSW1WpIJJQ62fU64Z0ZfKDb2a2P3L7vD7VZDsESLs4BoG?= =?us-ascii?Q?KvSILUZxCw17N0p4B9VlY5L/D0ex840gN4pQUk6Ko79VkJW+SzH3mxv/zgT2?= =?us-ascii?Q?w13EpSlYxPhA+QDn5FFwpyIZgag3KOxlyt0uR5KPJbafsChe2ZZu2W4L9nrQ?= =?us-ascii?Q?o1bXUyMp+TyH/5MauaLeIuRo3wxqJjkaiyZUVx2DwrqqFP2xMqB8zX2WXRhN?= =?us-ascii?Q?YGDKYIm4EFoz9Xe5dP2liBZzhEI+yG9HZID6acj2nsEFOLj9EuCpyy8Szk2u?= =?us-ascii?Q?OvCci7L2yXFgctBgZoxUlUaskduyfyv5ItHiuvLvQfc+eVnLwZg0IgTXd3VC?= =?us-ascii?Q?FBl8QoPWOQDWEUwwLw0mIhWKH/97sTIrOSu7pKlG3zdjvtjolNI85dreih1F?= =?us-ascii?Q?6jkS8N90RNPadW0XyllYDWU2gp65MOaLcbnXNo0zREUnZ+Ydavi+61udMsmT?= =?us-ascii?Q?Dm3VxtBeVaXpBOkIXovuFUGO9b5ax4W/r763jSWmD/iUrXcecsp3C596R7WH?= =?us-ascii?Q?R56GjW4Pljbi6fP96Qj4ISVeQWoprewwypC4kZwOo50FmIe5z1p0ritmeea5?= =?us-ascii?Q?VVXhD3IIPM6VON50K/4Me9aPrQuYo5C3dqEJQUyVw2SiOEGE+knnRvGx1Sbu?= =?us-ascii?Q?yHBRvgFs+YdmAvib6hyciowgdVDmN/KHY8bNo/jLK8RkyvYh8mYixlGUJc8i?= =?us-ascii?Q?BR02QUxyBQXQN4QV/Z3vY/O/lh9OOcWtyxl0EomU/eFTnr+4b3V511NNJ+v1?= =?us-ascii?Q?4i3Z/wuDlxSv9q5+GMfCMjdjrRH33fCKta1c3qYgnBOJOAuetKPYR6sqJkD8?= =?us-ascii?Q?2J/KHspUUykaMWD3tczkg487y5y/2x3stZED+yP+xSaLfITQRGe9M8mhllSd?= =?us-ascii?Q?VFNYaKXYnwVHh2VckMp4C4DDxxs9wL3dZCmFtTDoShFQ/KIqvA+0FxkRFKDX?= =?us-ascii?Q?dzeUqkEPFpcZOVi6p0GeHWQSq722ophC2dFY5jHw5JYJkdZ4sX5lKmwg77AJ?= =?us-ascii?Q?ks8hZ4x/lsEwQrV1gP5cf5AXFEMAgzFEl0l4DVU0MYFqXHBFJ5Fa2Px7cdpw?= =?us-ascii?Q?+CuFT7LXIZSihPWzyGBb0H3gIPC90a8IcnyBXcUDC15XwXohx4FxhWbd38Zh?= =?us-ascii?Q?W8tBB1ju7IGYQmgXhmhb20Bt7O97aa+HoyYKSLyDfu1J3E7kKIVUP0rVitV9?= =?us-ascii?Q?fcOjP2qO4Te/yY1oi1P7VVwlzxgfnJXkSyJBybGuPmOIpj+ypR+nkszu5a0J?= =?us-ascii?Q?gg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4d3c6b65-6c4e-4875-a376-08dce221cec2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 14:03:21.6373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B3yNZzQbxx6h4y6hYPFZR1g0SyTBWrfUSwjT2f7+3XiNjGhHuowZ8K267tvNlYLPcUNMXYDvQ3a+ViwVk2cmz7CmZ3MLOF0fP4jyojsajmQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8705 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 01, 2024 at 02:54:49PM +0100, Bruce Richardson wrote: > On Fri, Sep 20, 2024 at 06:05:59PM +0800, Zhichao Zeng wrote: > > This patch adds support for customizing firmware search path for > > DDP package like the kernel behavior, it will read the search path > > from "/sys/module/firmware_class/parameters/path", and try to load > > DDP package. > > > > Also, updates documentation for loading the DDP package in ice.rst. > > > > Signed-off-by: Zhichao Zeng > > > > --- > > v6: use open() instead of fopen() > > v5: update documentation, fix code logic > > v4: fix CI error > > v3: update doc, fix code error > > v2: separate the patch and rewrite the log > > --- > > doc/guides/nics/ice.rst | 60 +++++++++++++++++++----------------- > > drivers/net/ice/ice_ethdev.c | 47 ++++++++++++++++++++++++++-- > > drivers/net/ice/ice_ethdev.h | 1 + > > 3 files changed, 76 insertions(+), 32 deletions(-) > > > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > > index ae975d19ad..a6104db4d4 100644 > > --- a/doc/guides/nics/ice.rst > > +++ b/doc/guides/nics/ice.rst > > @@ -80,6 +80,37 @@ are listed in the Tested Platforms section of the Release Notes for each release > > | 24.03 | 1.13.7 | 1.3.35 | 1.3.45 | 1.3.13 | 4.4 | > > +-----------+---------------+-----------------+-----------+--------------+-----------+ > > > > +Dynamic Device Personalization (DDP) package loading > > +---------------------------------------------------- > > + > > +The Intel E810 requires a programmable pipeline package be downloaded > > +by the driver to support normal operations. The E810 has limited > > +functionality built in to allow PXE boot and other use cases, but for DPDK use > > +the driver must download a package file during the driver initialization > > +stage. > > + > Minor nit - when writing documentation, rather than wrapping the lines at a > fixed column width, it is better to wrap on punctuation and to always start > a sentence on a new line. This reduces the diffs when editing documentation > in future. > > In this case, I'll just adjust the line-wrapping on apply, so no need for a > new revision of the patch. > Acked-by: Bruce Richardson Patch applied to dpdk-next-net-intel. Thanks, /Bruce