From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F36BB45A7E; Tue, 1 Oct 2024 19:04:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E5864027E; Tue, 1 Oct 2024 19:04:38 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 7935F40273; Tue, 1 Oct 2024 19:04:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727802277; x=1759338277; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=XmZTyDN9k31Q3Qw/AN9TB+zL5HdiCVfk2XZdeOCn8zU=; b=Pw+HhKaPszF41QUKKb1Sg6/1acgDHyJHuCWoS2OrEqQjmleXmDKTI/K9 r/RtUGwaS+zdjOYW+46wnqQNYpH65auq7dNPiEZ1Ub64bpXlYhsnfM8Yi fnSFfminn+mif1NPH2HKHw97wHDQnEmj6Y2SiMzz7/h+QarZ6MguNQSEA 52tFHNifYHmJO8R9RpO12nUDVHjbq73jEmpwITExwlnL1fweDH8yhZAlF P4W3BQiJp6vbadtOeOfcZ603m44aFmQRa5qYIlpXyA89I8fWfJEITEjxJ OiKzcNKU6UKi8tnkweZuV/MPNL/zzHh8KEv1Fl4Sz9T/M/8/m4L/q8fQa g==; X-CSE-ConnectionGUID: sIwUzmI6SfisJGIYqpmIQQ== X-CSE-MsgGUID: m5/GUHGQSoG1Ec/v8wATzA== X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="27088287" X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="27088287" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2024 10:04:36 -0700 X-CSE-ConnectionGUID: d7sO9DIDRVGLFe+vwCRk4w== X-CSE-MsgGUID: odUmGoLKSL2eOVsMQWDJsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,169,1725346800"; d="scan'208";a="73615952" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Oct 2024 10:04:35 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 10:04:35 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 1 Oct 2024 10:04:18 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 10:04:18 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 1 Oct 2024 10:04:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P+ZBoZmBFetd1v2Kx7qhoXwgAJctPEaaXiamdDePX+Jrv8hWXRYgqiJQugCosssHMQRttQqAT50LpJKFaHFGogkHnEJrvjwfoGU3cUbR6cmraAR64Fn7VbfVxpLuNZnq+UwAwWNK9reAdDqOAG1/puIrLzI30h3yLcY0GSFFpuX5y/owb6gDw/Ye/3/IVC3yoluc1ITb6TXyS2hnqlnVQsjJRTy/kID8FRtZIqMRms/mXIN3gGVfXPjhBK9HwpdhI+j1Z1xTJ948YIIHL2hQXJNxkU5KjSkJqhWBcCrKfKSMPo5LygpMsbxBq80nhYJFjPhaJYCZ+EafF8Hs/B5fcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=krqmXNs07a/avNe1YkDT0e5xDs8taA/zHfm68BXLvfw=; b=uqYQ5svax1/Un2AmHbKmvCsJ5GrW+1Vcatr2a/ElhH7pNlahypIRrn+WLFg3VaWnnG6ASF5X9AdQrJlw9P+HBkY1j9iHPBjgJbuUiN8MKXaweF6M3nstEkMcEH76OvG1EaZN/3H405xPOUCXknDy7w0QtbAUUSDhUTphhmhx79s3o6OfyEynOX8jZ74Z4TU+yA55y+KLtN01D/SRP7PPPov4cbMxuKlbOndQTzV6X7a+b1TU+kYTAL8m0gYMLPoyhypdjUnWAXQB3yWng/sTD2gfJrOIa5uSe5UP6gTI6+rmazymsnQWsy9rFHnp76E6LQnw7j+6xVUynNf3WihovA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB7344.namprd11.prod.outlook.com (2603:10b6:208:423::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct 2024 17:04:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024 17:04:06 +0000 Date: Tue, 1 Oct 2024 18:04:01 +0100 From: Bruce Richardson To: Stephen Hemminger CC: , , , Conor Walsh Subject: Re: [PATCH v5 03/17] dma/ixd: fix incorrect free function in cleanup Message-ID: References: <20240927204742.546164-1-stephen@networkplumber.org> <20241001163708.355128-1-stephen@networkplumber.org> <20241001163708.355128-4-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241001163708.355128-4-stephen@networkplumber.org> X-ClientProxiedBy: DU2PR04CA0252.eurprd04.prod.outlook.com (2603:10a6:10:28e::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB7344:EE_ X-MS-Office365-Filtering-Correlation-Id: c13e1624-e58a-4abe-3488-08dce23b0ebd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?niWUqer527Y1hOOMJRJHCRA5jFHkEjvLyk4oL/tcwiTc3IOOIWSv7V1J+p7S?= =?us-ascii?Q?Kx6pCM6+5RPjSP+LVSvx4EXJIxgJqptAzuXBqI5aFSLAcEKCsmJKxklkKwXK?= =?us-ascii?Q?LF5moI4u6L1FX09l6ZMQ1Lto4uqMpBGfdCVMpniMKLfglpAuHh65cPZ7phyo?= =?us-ascii?Q?Oov66nZiwRmTvTqPPqCpuDLSCgU1b80yKnXn8gqUTWkHc4tKpTlM6yEGOIVU?= =?us-ascii?Q?EMQyH75Q9pDSyWiXOTfeiU0D1kIzr2lxs84tWCjau0nu6LLEdc8K9R9j86Mh?= =?us-ascii?Q?NaiSy7My0WhQgNb+kEVuklEWxSVWxakang/zCZsNHxjcspxHlECZOZ5WFCyF?= =?us-ascii?Q?xQZpKeMwX1JBioV9Bdo4bTOQdsr+ExcQ3TFIgV8tLTe9VKLEP2RwK/pO47w7?= =?us-ascii?Q?4lIqg7U7S0S6Rt3P/uUsA7TIeM9HRqRT2mxk4ifBBkVAA0orRyZ5M2kN78G8?= =?us-ascii?Q?56BIr4XkI7Pm3IO1gQOYARa7qO1tJapwqCXRAmYpDFhyHin/0mOhYl+qtSl0?= =?us-ascii?Q?fCWPWgUOiqIVIp71qAKCyclyAyq39S4MDxB+WbSnPwrGFml58JXxBcPZ6eOY?= =?us-ascii?Q?bQH4JeCvUxkpdCOBHJyZ69tLqaCJL+0dSvO9ZzpVJm+WobiayjEZEqUyJObP?= =?us-ascii?Q?bGp+bjMUcq7cRLpG7kxG0M092c3QC11whNaOqtDFF+JXz2MvSuOaY35SSAES?= =?us-ascii?Q?aohRbL3Wk5BKSAld+dDmtIzbYvgi8xiezyRX5MDGdUf8mmFZTMhsqqtfdBT4?= =?us-ascii?Q?s6Mn+RmLnqS4HjDNky/dINqCXcCS428dgK53X5fqJQLZ6fSgPJnsTYB2Hp8W?= =?us-ascii?Q?DM87C1v/2xET8hpoL7+ekIOq03v17K4wjP5iVaqLKxUgWLscs2trY8n0HK6W?= =?us-ascii?Q?HwuERD3trjJl2htjle3thX4ymX1lUugQDGPKkdT6wX2O7zDFkhsR0ZZH01Ac?= =?us-ascii?Q?vNujpwRU2fgFMDHdOB26A8macU9KK9aLosE/cHIDNmgKQ41Q5CtUQMP6wLvb?= =?us-ascii?Q?WNAiU3XvEl0ajefUi96GDWKxt6dj2NLB5Tn5uaZkK279WxDnCtAUi4GJJ8Az?= =?us-ascii?Q?BFAzC7rYey+IG1qchrsJWqsh62ij3kcVJya87xUm3WKNUlvvSyK5EA/ZG1ri?= =?us-ascii?Q?Ry9bcWOnEjhLjTkdojIhTs4xyvQ+VnQCAZNMw1DaHXKup3NmVzizkHBFjLfX?= =?us-ascii?Q?HmeU5qTdVkTNQN0bf3RNMjHnNbquUwKK1l0TZYhbT8KTsg58tIHSE4B3gPdA?= =?us-ascii?Q?akDzxyVidwau5Dqb1zZK0x0LbDgr1h6t5N5IzfsZvw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1qW0SRV1aGf/I3ltgH7ovnPMnKbf6RjTrrA5KZaB2bNDeLmHeJuZz951toZc?= =?us-ascii?Q?8tO86l3KuM74CWp5ERAqX5AMrq4dSDTuLRxkchlT3poVFMjL7UM6cgNtIYPZ?= =?us-ascii?Q?tlz/PqIK1C6/BEeWj+V1uxEKwHfUsGDl5g8sr5XSdixlpxr9V3HHTepIoeSY?= =?us-ascii?Q?hNwFHAvhLe/Gx/daulY9OqFJ08XZxhZH/dWwVz6P+r3zQrJAhIAQ5OXPsjHq?= =?us-ascii?Q?76um7f8rAyxpFSPheG5lrW1i3hqakVlBKt1kanP7pGdj8i6fz0+Cvbb2Lnvr?= =?us-ascii?Q?hxRkM8aybpG/nXowdNVAwsm9Xt7OvfedFE4yCFWRn2ASD8Af3A4PCLIrC5ci?= =?us-ascii?Q?4prAariJRZ/nevIQMh5yNZRtjjzlG8jgSvBgTwVseDLXoUOdeW8D40tlZMRH?= =?us-ascii?Q?NBe3rnvEj6JDAbq1VAOgqL5eVwbX55JkStu9vnSiHaGzVl6/CgIDW+VzyVxf?= =?us-ascii?Q?cQVJSiWCO4Rc0SbW45zYFxKUHMGEhhVNTeQnhejgE1fG0lhWWACFbXQdJEyg?= =?us-ascii?Q?SF++bt4W/tHEKqEd9nmpel5/B4RjfHpgcXOiqEXwhaWh/USj9SpzUmbdPdg2?= =?us-ascii?Q?AI2Dhnna0kHqeDM/u3IvPk/eGq2O8LC5a0TXdYHWS9t7P9CNLElmZxJn7Fdv?= =?us-ascii?Q?GKrLFSK3enMIW7GnSAoGDOlhBHqf9nKtrYC+I97oJgmL1EAmN2cv88wfjCwT?= =?us-ascii?Q?y5RB7vffgHGsfYKBQTpqafTH1D5EXeMM1iIvoHfiH6Ua4VD2bp7ZZ+WMJY3k?= =?us-ascii?Q?EvLkdXmMc//jopZsR8MUSQAUJKI2OYkmPv47j55vp+8OCo1QABGP1GpbQhVf?= =?us-ascii?Q?cz8JMl6/1CmATeNCyLhkT8+L9eb2b228BjWc9M9zRESCwflTJUJFBIELIF2I?= =?us-ascii?Q?q7UsUUsD9yqXw/830GeGyUjTT+87GabRD8FF/FObjf4G6ljOXdFR6UXw8iUI?= =?us-ascii?Q?W3lQIeCk+7OyfX4W3uHINBU8CRivQc1fGuCxFwTZpXVl34qBYYWCZXo6xZOw?= =?us-ascii?Q?n/P5bNTL9vKsKd5BPTXOA/w5U5T45Gw2JchaOeX3WuiN67W8zZZbnIWe5gdv?= =?us-ascii?Q?6eFKurSJfSB2umZ2uIQnn6TJnxK+ecktcbDe9R2l22HKgodtt+/b8eNNM7+X?= =?us-ascii?Q?C+lCF8VSk9RlEkly+sOm0AWb46rqOB+Mlcz2YlwnCLaJEoSsl+xxP9oiQKMd?= =?us-ascii?Q?AQBHS3j47UIs2CuB7Eglr9Y6u9QqHkAbITJQtE/qUJDk2gpPis4g0vghDYRW?= =?us-ascii?Q?FDFozg9jlUyfK96CP2DR/Ws8ebplQTefamziN573lFDhGqhCL2etpVBqAGCg?= =?us-ascii?Q?DB2TUtYYbUoJTfHPMkwqdh8HLOIsHm0jzxIH+mm0iDDrZNiGW1k4FqW1HEhr?= =?us-ascii?Q?chwI6nXTq3WjkYoOwZd1RUfGXuq7uJWiHWlD+h78kuJv5lx0ZSw6DApKPIdx?= =?us-ascii?Q?emtE8RwlEIlxUrZl6Sc+vuPP6R+6cPl+lCosAm2+iK++k/g/SX9NkaYyTAvX?= =?us-ascii?Q?3b6QUFz0oxQojsWpbxA38fn6GUO8K2b2uJOLN8wwFAeReT20N5AZfgwrDnun?= =?us-ascii?Q?er0vFgWRHu1ZhGIHO8ilphFcNUAZ/VjCD6YogioC29JYd3aTPr0CmHGWg5Lq?= =?us-ascii?Q?yg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c13e1624-e58a-4abe-3488-08dce23b0ebd X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 17:04:05.9208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E2SaZsttE4O55DUNtk1mKog1qIV9Fm3vf3wN/sVYcnK1aGDAtp1p7QAeC+x9+2YphI02fqmqTHRhKEDizJ/GtE1S0SHVHG8PUf6Qs+XyYe4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7344 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 01, 2024 at 09:35:26AM -0700, Stephen Hemminger wrote: > The data structure is allocated with rte_malloc and incorrectly > freed in cleanup logic using free. > > Bugzilla ID: 1549 > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > Cc: kevin.laatz@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger >From previous revision: Reviewed-by: Bruce Richardson