From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH 2/5] net/ice: improve Tx scheduler graph output
Date: Tue, 15 Oct 2024 15:32:38 +0100 [thread overview]
Message-ID: <Zw59BrUBBf6v9THT@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20241009104543.026ddd29@hermes.local>
On Wed, Oct 09, 2024 at 10:45:43AM -0700, Stephen Hemminger wrote:
> On Wed, 9 Oct 2024 18:08:19 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > The function to dump the TX scheduler topology only adds to the chart
> > nodes connected to TX queues or for the flow director VSI. Change the
> > function to work recursively from the root node and thereby include all
> > scheduler nodes, whether in use or not, in the dump.
> >
> > Also, improve the output of the Tx scheduler graphing function:
> >
> > * Add VSI details to each node in graph
> > * When number of children is >16, skip middle nodes to reduce size of
> > the graph, otherwise dot output is unviewable for large hierarchies
> > * For VSIs other than zero, use dot's clustering method to put those
> > VSIs into subgraphs with borders
> > * For leaf nodes, display queue numbers for the any nodes assigned to
> > ethdev NIC Tx queues
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
>
> Fixes: ab4eaf9a8a31 ("net/ice: dump Tx scheduling tree")
This is not really so much a fix as expanding the scope of what is
displayed. Therefore not including the fixes line and Cc of stable in v2.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
>
Thanks.
next prev parent reply other threads:[~2024-10-15 14:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 17:08 [PATCH 0/5] updates for net/ice driver Bruce Richardson
2024-10-09 17:08 ` [PATCH 1/5] net/ice: detect stopping a flow-director queue twice Bruce Richardson
2024-10-09 17:44 ` Stephen Hemminger
2024-10-09 17:08 ` [PATCH 2/5] net/ice: improve Tx scheduler graph output Bruce Richardson
2024-10-09 17:45 ` Stephen Hemminger
2024-10-15 14:32 ` Bruce Richardson [this message]
2024-10-09 17:08 ` [PATCH 3/5] net/ice: add option to choose DDP package file Bruce Richardson
2024-10-09 17:47 ` Stephen Hemminger
2024-10-09 17:08 ` [PATCH 4/5] net/ice: add option to download scheduler topology Bruce Richardson
2024-10-09 17:49 ` Stephen Hemminger
2024-10-10 8:10 ` Bruce Richardson
2024-10-09 17:08 ` [PATCH 5/5] net/ice: limit the number of queues to sched capabilities Bruce Richardson
2024-10-09 17:49 ` Stephen Hemminger
2024-10-15 15:19 ` [PATCH v2 0/5] updates for net/ice driver Bruce Richardson
2024-10-15 15:19 ` [PATCH v2 1/5] net/ice: detect stopping a flow-director queue twice Bruce Richardson
2024-10-15 15:19 ` [PATCH v2 2/5] net/ice: improve Tx scheduler graph output Bruce Richardson
2024-10-15 15:19 ` [PATCH v2 3/5] net/ice: add option to choose DDP package file Bruce Richardson
2024-10-15 15:19 ` [PATCH v2 4/5] net/ice: add option to download scheduler topology Bruce Richardson
2024-10-15 15:19 ` [PATCH v2 5/5] net/ice: limit the number of queues to sched capabilities Bruce Richardson
2024-10-18 14:38 ` [PATCH v3 0/4] updates for net/ice driver Bruce Richardson
2024-10-18 14:38 ` [PATCH v3 1/4] net/ice: detect stopping a flow-director queue twice Bruce Richardson
2024-10-18 14:38 ` [PATCH v3 2/4] net/ice: improve Tx scheduler graph output Bruce Richardson
2024-10-18 14:38 ` [PATCH v3 3/4] net/ice: add option to choose DDP package file Bruce Richardson
2024-10-18 14:38 ` [PATCH v3 4/4] net/ice: limit the number of queues to sched capabilities Bruce Richardson
2024-10-21 15:57 ` [PATCH v3 0/4] updates for net/ice driver Bruce Richardson
2024-10-22 16:39 ` [PATCH v4 " Bruce Richardson
2024-10-22 16:39 ` [PATCH v4 1/4] net/ice: detect stopping a flow-director queue twice Bruce Richardson
2024-10-22 16:39 ` [PATCH v4 2/4] net/ice: improve Tx scheduler graph output Bruce Richardson
2024-10-22 16:39 ` [PATCH v4 3/4] net/ice: add option to choose DDP package file Bruce Richardson
2024-10-22 16:39 ` [PATCH v4 4/4] net/ice: limit the number of queues to sched capabilities Bruce Richardson
2024-10-23 10:29 ` [PATCH v4 0/4] updates for net/ice driver Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw59BrUBBf6v9THT@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).