From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0AC645ADE; Tue, 8 Oct 2024 13:35:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83B3A402A9; Tue, 8 Oct 2024 13:35:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 823F94026F for ; Tue, 8 Oct 2024 13:35:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728387337; x=1759923337; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=FfkJT/evJdULevFo2Om1sgUhGjUo9PqcSQJQkwKxqQI=; b=RazA/CLnW4J7rFc7L6tFHZV7C4S3eO00/YmMQjlZ82CjV0vnDi5FKzRZ wE89DuPPWiCH02M2PrgcjPHR73C08R/E+0U+nZ5K3cCSJS/YoxuAI5BGC kF5FcHFQS5vGi6GdQh64APBktobhj46gGfgCB6fYbkP/Bh6DWbvbwf19A Oab6LyZUF4f49iybFvCegVM7IoHhj0DmYuR22ETgdst+4gfCwjEBUlkzo GfBfqa8H1W1m7ZXI+cFQVI9WK8ZHaGQapSVT7rFUHft+kdccrpRe0umfS aCAU7KHrL/ORKvvnxxBEuJRF6byKED+X/Qoab3cvVCpSwYyZv6YyIcxgM w==; X-CSE-ConnectionGUID: DNl0a/uiTnaaN3pADO5BZw== X-CSE-MsgGUID: NTiv3ZqVSre1I62j9tjKsw== X-IronPort-AV: E=McAfee;i="6700,10204,11218"; a="38707935" X-IronPort-AV: E=Sophos;i="6.11,186,1725346800"; d="scan'208";a="38707935" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 04:35:36 -0700 X-CSE-ConnectionGUID: eb7nwscrSjWtIh4241A7UA== X-CSE-MsgGUID: RKIbG3StSLqVC6LC8oa+3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,186,1725346800"; d="scan'208";a="99144330" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Oct 2024 04:35:35 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 04:35:35 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 04:35:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 8 Oct 2024 04:35:34 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 8 Oct 2024 04:35:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oGJmb8b0EIqb+CvznjRNbVf5KHXq/SMdXZDYD0TKIMlKf+3rzyVvkHhwwWACUcaQ5SydCMEn3Cb0O1DxyXcllgqW7SiH6GHCU2nuXqD6n0ynjv4mu0MsHYEZ6NheK9ujG3LRRRjdweOi9GUar6ds6R86BA6mcEm+QzuG++rZROU6H595W281U/KM0Fvib6yOc04RSKRUB6qffAc5Px0pFhNswjEDfOMOAIoQE1rDlyKk/92KXxNcIyMnQq8UW7hA9Bw+xYjB+2R+28+uquUBaLTxpBQ+qCULQ1qbiLCIgQ5sTayFUzYQyJFtkjoEkwx0mCfuf1knebMYDF0Q5zR8lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F53IEwmS0Jp5T/SZe7yVBLg86gcIKN9pSUQPegb7MQM=; b=K8ydAuTeCkE0AfWLnfwi9szBDEjAqteo2Vq8PKQVxe2XSDlvwdbsW9akuNqyiNeXQkBWmo7WPXwDkFtsyoNw7TuRgWg4GrtMk9Bomxdxs05ZQnYBEp3OasWOPMnSw+y3Af4kEbbNZb7p2hen/tzV2PlUaRJ70fz/Pe2Z//jmT5Y4lNMQ+YR08R67jXJbdI+AY/Y3fiREVVWCRZhge6Xgkp6f1GZAK4LaI/ZxRy6Mvgftn+RrjIUooNTbYp5hmo22IgI8KIwZhbqijP0ovj/B88FVexy5m0n6uI8tMdR8ll7Xn6tIJbc1IPboJnxDohggl5bqXOca/XwL45qD+wQoDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB6333.namprd11.prod.outlook.com (2603:10b6:8:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Tue, 8 Oct 2024 11:35:30 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.013; Tue, 8 Oct 2024 11:35:29 +0000 Date: Tue, 8 Oct 2024 12:35:23 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH v2 0/8] centralize AVX-512 feature detection Message-ID: References: <20240930175033.2283861-1-bruce.richardson@intel.com> <20241001111802.2728765-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB7PR03CA0107.eurprd03.prod.outlook.com (2603:10a6:10:72::48) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB6333:EE_ X-MS-Office365-Filtering-Correlation-Id: 56461287-a277-4f7b-600d-08dce78d4f5a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dy9sZldZanBaaEZhNXhhSFcwMmNEa0l6M0RzK1BNNy82cVV6eGJ6aGVNai9k?= =?utf-8?B?N1VEWjBXMzN0eCthU2NzNTE3WTBBWHkveVozbHVac2g4UzhCUmFKd25tbG5H?= =?utf-8?B?T3piaTVHNTFXYjdCTlFmcVRGSVJYU3JtNE9zTVBmcm9GVzJ1aHRBay9BSmFB?= =?utf-8?B?U0M2RHh4dEt6eUVvczF1OTFRTVNWdUVyL3R6OEREVzJZdWpTcG55bWV4K2Zu?= =?utf-8?B?K2tjQXF0N2N2cWtPSFUwOHZBT2RFZHVhY3l2RUpkWlJXamZCYS9EMFJvaUEw?= =?utf-8?B?L3o2VWk0OGVPOFM2NUxNN1FWS2oyaGdGTFRPT3NoZnlhdUZ3SFFUUmxiVGsr?= =?utf-8?B?NWZscEJMa1FNSE8rZFo2cmpxYkljVjFPWnBJSkpBRC92aWo0TG9HcWF4WFZW?= =?utf-8?B?aW9ISS9xcExUNGhkN2pFUlEzY1hBdlkrMmhkaEUyUTd4cEE0NXFtZ0VTMmw1?= =?utf-8?B?WlJ6eDdEcHh2ZHc1MU9rZmp0WHdnNU1Zbk80YVdDUFZXU2VPZ1hCcDRvd0pQ?= =?utf-8?B?MHU5NUVDWS9MQlVNMlpWZ0poRi9Pb2JSUEpGOWNTZFA3QTlYK2tSLzZTcUFT?= =?utf-8?B?SWN5ZytVMHNOeXR2VGVlajhBVzlGaDZzalEwL2tLRThFZVVoYWNZcm9QajBK?= =?utf-8?B?aVJUeDQzZEJtQ21VR0NYcHhMSTdDcW4rWnJKeEhBSXpORk80T0MwUFROTlAw?= =?utf-8?B?bTc5c2hVczBKb1NTVXFmTTJFakZkMFhZNS82MGdhTVM1b3pBNTluam9mT2Zo?= =?utf-8?B?aUdsNHFYeWc5b3ZZd0FrTG1GSlFmZmd3V0VXWUNxNXkyeGFNdmdRbjBsM1hn?= =?utf-8?B?c2dUSWhNRVNRemdtM1FDMUNST2g0cUZWNGhvTit2Sm9oMGJMNWdpRCs0ZTFp?= =?utf-8?B?ck1Sa2RwVXZYbmN1Y1FNWUZvb3RPZ29oVUxGQml2S3Z6NFFsTndSa3U1SmZv?= =?utf-8?B?ditkcmxvb094WmE5ZnhNR2QyUXE2UjlkV0JKNHp4aFdydHRIckZ5K0xSS210?= =?utf-8?B?VG9kTDZhWG5OTHFKWHBvcUZ4a3hXWGt0bElMQzhzTFY5T0NrYllZeWF4YWVU?= =?utf-8?B?NDBwNEZuUCtrZHMyNU1YQ1ErWjNyNHhzSHgwc3o5S2UvUjZRdmxTZlNZaDZX?= =?utf-8?B?RU1VcVdqc0dTOUdneU5xSHZFREd6K0pRcTRNRjQ5Qk84eVpRRExlUGdGU1R2?= =?utf-8?B?azlIL2wybytVWWVYSFVocjBPSHA3bk13N0xpVURKS01NTk5tQ1NvNG95SVFn?= =?utf-8?B?dkJhNEJFSk5zN3A4cUFhRTJtNGVzc2NieFA3K0Njak95c1FIRWpGNWQxc0N3?= =?utf-8?B?MmRndjJZOTRPT296d1RVWi9Wc1RSeUo4dnpRUktReTBxaU5tRS90UzJEd0Jw?= =?utf-8?B?OTBhUzhVUC9BMXN5Z01FbUo5dWFYcUhITVpUSTFDU1hucSs0NnhDQ1N0b1Jh?= =?utf-8?B?RXNtaWVPVmlhci9idktENDd6NnVpbkg4TVVxT2lhMVphQmIxRGRFZ2dFSnhX?= =?utf-8?B?L2RpUXNmaFBQZmJzM0FNSjc5WDQ1Y2Q4MkZkZE9vQ3RUNlJPWFlCa1RGcERZ?= =?utf-8?B?a0d2RFdxTVNNL1RWNTlZdUp5czlLNnk2TEJ0UjBlS0hNQUxzZVl4Sjcybjdx?= =?utf-8?B?WGtQb1FQYStab0VjQVl3R0dmUHZIV2xGeG95UXoySXhMMUtxN2tKZ21YRGgx?= =?utf-8?B?djdweStjRS91VmNoMnZyTTJxdDd3RTl6VGh6S3VuSWpDR3hHVVRvYTRWU2xB?= =?utf-8?Q?clRvm6ZkHarG5RNP5k=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0x0RkxXaW1wVzlHM3Q0UnE5bFpKaCt5Sm5EeEg3MUVNTUMyZjNVWElNTk92?= =?utf-8?B?UUZ5T01UU1BYTXZza0ZTbnUvaDBndVgxMnNxWCtIdFliVUlZT2N4ZmVGUUNw?= =?utf-8?B?M3R0VXNnZU1DNUVjeE5lSjF3TmV4RzRaekpEWHRwWUFRM0xPUmM2aWZVOG1U?= =?utf-8?B?RU9VR2JyYWVqa1ZWWUFkSHdsTFNRbmJrOEdhd3lhRUw0WVVjd2tiTlpqazVl?= =?utf-8?B?TzdoYlUrVG9UclhoRnBQY2hjYWlmTGcwbnJhMGNHaFFQNUZiMCtOZHE0aWtp?= =?utf-8?B?SE9Xejl0K2V4T3VaRDEwcWVkeTBUaUpSTWlxelpSVFhnVis1TVE2aU93Vzhy?= =?utf-8?B?c3BMWllNVmdMTSs2MWUyWmxaTGpCRjdkbzlDQmlKeGVOcHp3VjlaZi80RTVP?= =?utf-8?B?MENYVXk0V3duUDdtQisvMGFXNHozdUdzMUs3b2NHcGp5dmJXbGo0SU9XdFdi?= =?utf-8?B?S3RvU2hKV25zKzgyNm1HSTl1NDJEY1AyZGpVbjRTV2ZsMStDc1V0MUx6QWpT?= =?utf-8?B?SlkxcDVqY0dzVjNHUTRmaXJOMmczdzVOU01yUVpBTDQzVDUxQ1l6bHMranFq?= =?utf-8?B?TVlYTWxrOVB1bUNQYzUxTGNjcjlLVTZYVGdXZDB1UXF6WUV1cWtuclNoUkI5?= =?utf-8?B?M0hHYndqQjFSMFltdFBmN1NVZkpkRG42dmd4eEFEZlFMTTU3NTJqK21UWE1J?= =?utf-8?B?K0x6clZMbWtQYXFPcFl5OWl6dHlzZ2Rweit6SXNhU2s0VGVjSVRrSW5XTWhF?= =?utf-8?B?UEYrY1Vjd0dUa1FMVDF6UlFqRzNFN21DUEx1eE1jYlV4ZTcwT0dtSE9laDlX?= =?utf-8?B?VFJJU01vQjJuU1hDZ0ZLYkNxdFpUcTdWS0NpSklYQThGTkVFT29GLzF2cFI3?= =?utf-8?B?aGF2ZUpwWjJuVjVpTEdCSm1JZ25QUENhczZNVkVML1RzMUtPVWVBRGY0OVRJ?= =?utf-8?B?MHdmKzRqdUFIU1BHcmJsV3RPam44bHhnVEtTY0lnOUVwTEgxbHlMZE9hNURi?= =?utf-8?B?Z2sxWFNiYVMvZzR0OVNxRjJXcW5sbW82QnRsU1IrU0wxa2pNYTgrNHRmZXZa?= =?utf-8?B?OEZyR3ByYkRDakl6S2l5dGpNV2JLTlBEdkdFazdKZHBueFFIWGxJNkhORjd3?= =?utf-8?B?NE42TlJPVFBSRmZVOWhFbFQ3Z0tHYS9ZYjFUR0hNUW8zU0g5emx3Rkt6cFhL?= =?utf-8?B?TDh1Z0ptQkNJeWJYN1h0MWtUN1gxa2s2djBqdjdTeWdNL0ZPQnVLNzZ6SXBF?= =?utf-8?B?NEJTVU54NFRvZi9jWEhodGlvZDlwTE02RUN4K3dwaGVZMUtYVWQ5dVB6RGpP?= =?utf-8?B?M2RVOUgyRjBUK3dOaDJWNVVvT1VSNkxVVkZtR2hjalVMcWxRbzZxOTZZaEkr?= =?utf-8?B?TTV2em11TkY1WmtRNHlubW50Mlk2TEU0c1VFWFRmZ0ZVNjVFNnVrMFZPODlC?= =?utf-8?B?VzF4R3ptMWg2TzdJVjlHWHc5ekE1c3h0MFZTOVNCbmZZbTErRUxJVWx4YnRr?= =?utf-8?B?MUJYTVdnenNxSSs0MGFrS1hUQ0lBcGdEemM2TUU3b1ZJWDRQMG1sbld5S0xZ?= =?utf-8?B?RWxyWE10c2k5Ylc5akszMWFIdjRiNkk3bXU3QjlWeFQ1WjA3Y3BRQXFtY3kx?= =?utf-8?B?ZG9XRytZeWNYUVhyR1JGZ1p0eEJ6SG1jMHdDMThFVVAwWTllaUJ2OVRZS3Y0?= =?utf-8?B?S0Y2WTZ6bXJsWDVyY1A1ZnZUTGVTQ2JGTTg3ZUZkT0JBNTh2UmdPMHluVE56?= =?utf-8?B?K0RoQnNkejAvUFFCZkZjeTNPeXorMVlsUm5hUVBZNHFvSlpQQmp0a0liZ0x1?= =?utf-8?B?Yi9xbzRXbGNLTDJWNzROejJGSUJEOU9RVTRJYlBJN2ZHcU9UYlQ2ZmVrZ1RK?= =?utf-8?B?MUY1YjRjeUhDQUwrWEFUQm9xNkFpK3hiREQ1Y2ZhTVViY0cvZXJsUDRhaFNS?= =?utf-8?B?ZU5peHozN1BnQ0FWWGtBMkRiaDZnZ0I0WGtoNHpVTlBSN0RZWDE2VHNrWlIy?= =?utf-8?B?L1MyUTNPZ1JVY3BkSE1Mc2lnTDM4S000aFdhVGRnV1BiUFdPaVZ6Q3VSZEJD?= =?utf-8?B?c2ZoNWcxUnMzLzViRisyNVV0cWMxdld0VEQrWm8vbmZHVU5nT3hDQ1crcVV1?= =?utf-8?B?Y1ViK0FsYXN1ZzlnSGYwVVZVZEZFZ0FEUklMQ21PSEdVcWVpYWhzdnB5NTRk?= =?utf-8?B?T3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 56461287-a277-4f7b-600d-08dce78d4f5a X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 11:35:29.3584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MVW4g5/bLbSxFMiB0mqa5Zh5WK2fc67sAsGpvkAvGrwzDCSsCOmwPGzwmme0jqdCd8jvvjfWfbXclkCc2vTfooKvk/mcSnOj8IM+ycNtrSI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6333 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 08, 2024 at 01:33:16PM +0200, David Marchand wrote: > On Tue, Oct 8, 2024 at 12:03 PM Bruce Richardson > wrote: > > > > On Tue, Oct 08, 2024 at 10:49:39AM +0200, David Marchand wrote: > > > On Tue, Oct 1, 2024 at 1:19 PM Bruce Richardson > > > wrote: > > > > > > > > The meson code to detect CPU and compiler support for AVX512 was duplicated > > > > across multiple drivers. Do all detection in just a single place to simplify > > > > the code. > > > > > > > > v2: ensure that target_has_avx512 is always defined on x86 to fix build errors > > > > > > > > Bruce Richardson (8): > > > > config/x86: add global defines for checking AVX-512 > > > > event/dlb2: use global AVX-512 variables > > > > common/idpf: use global AVX-512 variables > > > > net/cpfl: use global AVX-512 variables > > > > net/i40e: use global AVX-512 variables > > > > net/iavf: use global AVX-512 variables > > > > net/ice: use global AVX-512 variables > > > > net/idpf: use global AVX-512 variables > > > > > > > > config/x86/meson.build | 19 +++++++++++---- > > > > drivers/common/idpf/meson.build | 17 ++----------- > > > > drivers/event/dlb2/meson.build | 42 +++++++-------------------------- > > > > drivers/net/cpfl/meson.build | 19 ++------------- > > > > drivers/net/i40e/meson.build | 13 ++-------- > > > > drivers/net/iavf/meson.build | 13 ++-------- > > > > drivers/net/ice/meson.build | 15 ++---------- > > > > drivers/net/idpf/meson.build | 19 ++------------- > > > > 8 files changed, 36 insertions(+), 121 deletions(-) > > > > > > Thanks for this cleanup, I have two comments. > > > > > > - Some drivers were going into great lenghts to check that individiual > > > avx512 features were available. > > > With this series, we end up requiring support for all features to > > > announce avx512 availability. > > > Are we perhaps disabling AVX512 support with some toolchains, out > > > there, supporting only part of the set? > > > > > > > The various AVX-512 feature sets checked for (F, BW, VL, DQ) were all > > introduced in the same hardware generation - all are available in gcc when > > using -march=skylake-avx512 or later, or -march=znver4. On the toolchain > > side, gcc introduced all these flags simultaneously in gcc-6 [1]. For > > clang/llvm, testing with godbolt for compiler errors/warnings indicates > > that all these 4 avx512 flags are available from clang 3.6 - the minimum we > > support in DPDK [2] > > > > [1] https://gcc.gnu.org/gcc-6/changes.html > > [2] https://doc.dpdk.org/guides/linux_gsg/sys_reqs.html#compilation-of-the-dpdk > > Perfect, thanks for the details. > > > > > > - Some drivers were checking for presence of -mno-avx512f in > > > machine_args as a way to disable building any AVX512 stuff. > > > This gets discarded with this series. > > > > > > > Yes, because it should no longer be necessary. The places in the build > > system where we set the no-avx512f flag are reworked so that we don't have > > cc_has_avx512 set. > > Ok, it is clearer now. > > Last comment on style: > $ git grep cc_avx512_flags drivers/ > drivers/common/idpf/meson.build: avx512_args = [cflags] + cc_avx512_flags > drivers/event/dlb2/meson.build: c_args: > cflags + cc_avx512_flags) > drivers/net/i40e/meson.build: avx512_args = cflags + cc_avx512_flags > drivers/net/iavf/meson.build: avx512_args = cflags + cc_avx512_flags > drivers/net/ice/meson.build: avx512_args = cflags + cc_avx512_flags > > I think it is safe to remove the [] around cflags in common/idpf, right? > Yep. > > Do you have some cycles to send a v2 and convert lib/net and net/virtio ? > Otherwise, can you do a followup patch for rc2? > I'll see what I can do today. /Bruce