From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF2E145B03; Thu, 10 Oct 2024 12:34:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 617A440279; Thu, 10 Oct 2024 12:34:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 115144025E for ; Thu, 10 Oct 2024 12:34:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728556473; x=1760092473; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=c9EfBmwf2rwoAWAyBRvaxssCf4qMhEAvZsSfPpBY4IM=; b=GW1fsYmg98iG2kq6pteDzZs8/PYLzWb8q+YBjVJg49G23hzFJhbsvQCv oJrMEbgfCv5vpOjfhZG5UzGlPvpq64Kke1nlHNGoTka0mmRvNtocvZM2K VqldGaF2+pa8ne5aP625t2vU7ycB9Y0lNAxgD4mEwgGAZi/7+8F1xgHBU v81jEJTvb6p+8EcvZoUMFW6sSDOMetB3mLaC1QM+P7lss7lbMfyQl7sng 7B7gk19MO5g66d14F1XhqrLNR6usZk8Bj4yvC54WoomqG7r1H/ECSfvA2 97/n3lrlVY7kYowWbOmyU/WTKvF/5jMHxdb7s96B/TfeXdM4OCdGEVDwY A==; X-CSE-ConnectionGUID: v6gTkZQ+TzKxOAppr9XnRA== X-CSE-MsgGUID: +r5n2cQlSNGVctb78o7l3w== X-IronPort-AV: E=McAfee;i="6700,10204,11220"; a="27351702" X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="27351702" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2024 03:34:32 -0700 X-CSE-ConnectionGUID: awKJFYR4S4irWjOcvl+4Qg== X-CSE-MsgGUID: NdQFE2dvTDmzrKt0o5Lcww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="80559731" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Oct 2024 03:34:31 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 03:34:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 03:34:30 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 10 Oct 2024 03:34:30 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 10 Oct 2024 03:34:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uu2crgIyDyleDxVqY0O7frjeLp5xRjejuWf62D3sAYcxJzVbVxq9WKoqmpEtER3TmpM7ufLmt3LH+xJr4CSlW4hHmGXmKa+hg9fhaJgi8oT0HcKKP6Hf6zu+36HLrjTal8xsFef7qGUV8NbjQlm9RlFsPv3VWV/4TCxylMBXua2ByQVlVPDgc9GAcM/VVBgt66M7q/fnE6fgugHBBrbBdQBAbVBHVRm4NUW2BcRhWb83N5obzmcYSWEJu6+4ELNb3SdQwnYrTt58AprH/T9KMMhskOQ1aFX32uzMfR/oHb84Q6fTR0qdviedWvfsi63PN73DYTNpr3ojKMB+vGYD8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kA1QANFloW2rMzHa0CmagUNLQU12mQ7AM0e9SzZofF8=; b=c/uL2hWSFt46Dbi+Y8XsNEaR7pBG9Qe1ACQz46djjLTx7Bc4ZGZhEuZNAM6ZwpQHhd86DojegRqauzjGDOlp1wKcGGaIbzWVKHnEotcDf5TudFE9Jo3nhbie6GtTcbbp0vS9Z3xm4KpSqwqtbHl3BAdCSvm7QCEB8JvMuTAe7eVggouUK/iSumEy+T6IdB2wb4ezojjmOYvEP+4ekQpHF2Ex6wubyjNy/Qe5pWegIoVtnZWU/drLp4UK6k0b/lD/+dc9nP53Z0KZo60yEkdMYFtJQwjsIJd7DcLooiLkN9GDN3H6zIlhV4c6nx44qnzEo3VkfINHM+CdDfNYO3uJNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7851.namprd11.prod.outlook.com (2603:10b6:8:fb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Thu, 10 Oct 2024 10:34:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.013; Thu, 10 Oct 2024 10:34:26 +0000 Date: Thu, 10 Oct 2024 11:34:21 +0100 From: Bruce Richardson To: Mingjin Ye CC: , Simei Su Subject: Re: [PATCH v4 2/3] net/ice: add frequency adjustment support for PTP Message-ID: References: <20240930084216.1174034-1-mingjinx.ye@intel.com> <20241010093221.1359778-1-mingjinx.ye@intel.com> <20241010093221.1359778-3-mingjinx.ye@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241010093221.1359778-3-mingjinx.ye@intel.com> X-ClientProxiedBy: DUZPR01CA0058.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7851:EE_ X-MS-Office365-Filtering-Correlation-Id: 2beab75e-da2b-4655-619a-08dce9171d28 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xYIqpTdoOHzUya/vVS9avLomXne/gPbFGrKOKxESFeq7c91Pks+UvFl+QWcr?= =?us-ascii?Q?7GqwkKbPu/RkuX3aT42tuy0zGLj7JXyajDISyTVFFeUg5tnEuCGHn3dhzhoh?= =?us-ascii?Q?wDH7x8SNUlIkX8ixBgCs8vOI8GEnXtSQ0mDt0lO+Odmzaq3mgnfh0krcLYW5?= =?us-ascii?Q?TmlIFWwDwPhTN2g7bZPkJjtxaaidWDolALzxOko77CG29K+oVT7N2x/tZTJl?= =?us-ascii?Q?bUZriuytGrywMJYzgPvXMLy4YsSHLTHKXyNCNErYUt644yj9Qn9XKRFLOZSy?= =?us-ascii?Q?7k+En1Jk5GORzbpTcMjqG+zLTB5xlrN0yeiTI2wgt+WEL/CE7ISA8sTDpofk?= =?us-ascii?Q?LWdco2wiaPFTpKDeq3mSr++H91Olvy5s2RkTZPbMIlULBu/te6LzRopZJHBf?= =?us-ascii?Q?NNIt9oUe1/CVceHJOmA615jVbnUVouAinS3Blfe+0WJ6sr+XBWkeNQmkBVp8?= =?us-ascii?Q?IDvMRAbfci81h76jYqV3/2RB/ao2z7LNlKc+DRjhafAAYieawKTODJAnLZr5?= =?us-ascii?Q?6Psnp4jPOlAlrGfaPwHG+m/nzfAEor1hbglyAwPfQbG4VMZ22F6+Dn1cN3P1?= =?us-ascii?Q?XN9Jnepq1dSS+WjTEZH9Rqf4w0OfihirELHy4IpyMElMKQkvlIa1IN0FGym+?= =?us-ascii?Q?8QZoS4pM/YRUTMh0Y72h21RJsgg560hfaJzRbGShdgGRREiN+6oVvOaYemEr?= =?us-ascii?Q?V4/afRErG1cNStHUOpM3u263FXSByeYcM9SYxsts9WjK35vFW1GeRoMOzl7h?= =?us-ascii?Q?R/ucjYlA/HtvRK8XYJfKvNpE43kbL65lcucqLv3Gu6rWw7U7VIoHqUUeWpkA?= =?us-ascii?Q?au5X+WLRHjk4C43yv/s6DqEevx+7g65ILlHkP7kWljlI8Apr7VWci7o3V91i?= =?us-ascii?Q?yJDMIKqAn6+SIhQggq7KQ8Ik0nyo9+J6EfD/9DcXs7FcEQi/3yK+8u+gj1md?= =?us-ascii?Q?TcZbVqVsKIedLtPM9lrEFvtPYye+qYsiAhhMyzgHGAYrKodmO5s/hFmpJl3M?= =?us-ascii?Q?lmiLPj0DUjl58Xq5Zx4YsLAZpoHBWuQiAR1nUL2y67sA/1oFfx6iJ6LRpsEr?= =?us-ascii?Q?JWRw8eS/esZs1nPmisFN5r6BRldnIS1R39G4psEbGtWhf9LUYDj1KT1c040j?= =?us-ascii?Q?Z7V9fDL0z22RxFlQPxUWWfsNSgKJ5LfCHCP5IqvUz3Q2YnO/PLcnF25tRm87?= =?us-ascii?Q?TEzf1S6HqK70kDZ2ioYnp8XkpHlxYrwmjlOusZUbWYdH73VwnJPRcIl8B8wS?= =?us-ascii?Q?TGJ5xb5uylJCZQtLn0hm4dSYUJFGGGWLoS3tR2IY6w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XSj36jMXV98DdJttE3pH4t5e7rIPKUWZo2IdX0KCgvHXWTrjfl0wMyQLTEz9?= =?us-ascii?Q?3u84fEMVY6kGjnUsct0kwCvyEtieQ3KAUjXLuuDC8zm6O9nPIJe2mI9rUKnx?= =?us-ascii?Q?sXEgXolr9rkRRlaBHrF+vhYGokwQwpC5F6McWTUuUO3PXcdF1N1B8cCptyd2?= =?us-ascii?Q?IKt7EJ1Jqo7Odm7W8le7zOVxNpa6ssIe6FwUh//qDfR5VbEygBzQEi2j50qe?= =?us-ascii?Q?XM/QijZVSaLgtpNJDBl+isBL3b8T8bRQfUdexKjMcFPQMM4wWabvb+l45XJU?= =?us-ascii?Q?fy2txrh7n01TnaWXWZoyODq+RvVsAXgKlrJpPzzdSJyd0djvVhnmpTJZm8Ro?= =?us-ascii?Q?Bv33mzkRmvUpLQM4GhTUMj7Ep4EREEfFszHVGo+1ZNpCjbRfe6P4iY0giAOn?= =?us-ascii?Q?AnEtnQNp19ctZgOHCjBZ2UnU16MK14krGaGcLloPohPBbpPKvDGV273VkzRn?= =?us-ascii?Q?fACoKp/QBOCwwBlvQxtu9j+hTj8X7P24gIsnJLlMPCe/ZRXSrhO3RfDBUzih?= =?us-ascii?Q?xwY2N5QxXXRB8k8cGt3QgJCGOmadJXtwCfIvopxrlF/KD/rBVR6e0m3vpRm6?= =?us-ascii?Q?p4scvgWCvrDZP8lKeEP+4K02r2zjSOxSHVF2O+AyGbr5A4mU8mDxCL3ecAhA?= =?us-ascii?Q?1Zq2fLOOymOvrRdGiXPmMky9IlScWTXF2pjhrv4XduMmE3+AGj3WX2bGPrn6?= =?us-ascii?Q?opQrldlGAg0Olx6yM5BmDFYKR4Xf4s7BMTNBICbhfWJkqy3EfgeY5c3ewN8b?= =?us-ascii?Q?ydUb5QZ5lwK1hR2beJn0O9kFoyiTkU1cHbV0XRWSnFMah4251mAHg2sX806k?= =?us-ascii?Q?Kg++7b3XTMl1J5u8LuIr4uXX1qJp9g3MrLhaALl+hORc6FGzVIDHf0PXrEc5?= =?us-ascii?Q?8m6/iCVDCPZkP/+HBjXQsnIsNxOhHdQ/0WPnZDLsfELchGuB0JXdkNRmQhyd?= =?us-ascii?Q?NPesSYQBZLmhV5bQFW+TCxqLDIEugVYNFlTMKZI6fodSCzS7YRhKj6PBZB3/?= =?us-ascii?Q?NwyjzafKg50TuKyFIrYcaTG9wqG6TUuxqpRJAfUW/ohnfRPardFk+l303NTc?= =?us-ascii?Q?PtwUrO8jhDvQbOal57V3CHRWPbF6/4b8RPQDgCZd1Q//QWmwkXyLPTMZx3h4?= =?us-ascii?Q?TWOyj7FFfaMhAgP0LVXMOzoHoyNK2ES0ZlCbqRk+A+YTsE+tv7g5WpgCDStg?= =?us-ascii?Q?TZeNTMbFfudwH/0EOmRrKbteddQqO4hPJwwAR4FmNycDUKKOK2Y73gBzZcYM?= =?us-ascii?Q?T5+IAtEDLnMJNRk0su9oeowsDc//WlBilzPzNNIFdMcZqPeP5F6p7boYZTcY?= =?us-ascii?Q?TvBweJ99YxkPO/xXlxyUyxwAExnCH4HRAhVYtym4UH3iQLQiZn/h9y/E5FFx?= =?us-ascii?Q?B7HJ+jqhVQbbzpEYlHA5kpnIEtIDML1kKvAqiUNEya1zPlCPWHb3uyD/4MiM?= =?us-ascii?Q?OAfpVdVGHcS4ku79V5ooiP2tkRYGHR2rsKztxD8UoE7l7p9ndfJg/s5ZSwuR?= =?us-ascii?Q?gdxfWSz68gWeyZY8gGlAXorQgKU8TwZPGsOxzZfL+O0jECZpyOnMGEaFBpX/?= =?us-ascii?Q?8rUTMp1W5miEvg5mpzBHtui3+MqrOlaUeHA715PxYBHJYyhPnq3ETZU7KeAL?= =?us-ascii?Q?6g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2beab75e-da2b-4655-619a-08dce9171d28 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 10:34:26.4477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WfiWTLYm4fenk7Oea0koQPo3WghM1QnDrJeVPfPO2tLKFKAsYUzEpJiLEcEnvFSsCJw3SCXezKXG92OVm16vSvb4Vh0gH/KBaEH+51gaOIk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7851 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 10, 2024 at 09:32:20AM +0000, Mingjin Ye wrote: > Add ice support for new ethdev API to adjust frequency for IEEE1588 > PTP. Also, this patch reworks code for converting software update > to hardware update. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye > --- Hi Simei, Mingjin, some review comments inline below. thanks, /Bruce > doc/guides/nics/ice.rst | 15 +++ > drivers/net/ice/ice_ethdev.c | 177 ++++++++++++++++++++++++++--------- > drivers/net/ice/ice_ethdev.h | 2 + > drivers/net/ice/ice_rxtx.c | 4 +- > 4 files changed, 153 insertions(+), 45 deletions(-) > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > index ae975d19ad..51fab743ef 100644 > --- a/doc/guides/nics/ice.rst > +++ b/doc/guides/nics/ice.rst > @@ -328,6 +328,21 @@ Forward Error Correction (FEC) > > Supports get/set FEC mode and get FEC capability. > > +Time Synchronisation > +~~~~~~~~~~~~~~~~~~~~ > + > +The system operator can run a PTP (Precision Time Protocol) client application > +to synchronise the time on the network card (and optionally the time on the > +system) to the PTP master. > + > +ICE PMD supports PTP client applications that use the DPDK IEEE1588 API to > +communicate with the PTP master clock. Note that the PTP client application > +needs to run on the PF and vector mode needs to be disabled. > + > +.. code-block:: console > + > + examples/dpdk-ptpclient -c f -n 3 -a 0000:ec:00.1 -- -T 1 -p 0x1 -c 1 > + Couple of questions about this documentation: * After running the example given, does the time on the network card remain synchronised when the user runs their own app? If so, this text is ok, but, if not, I think we better clarify that the PTP client functionality can be integrated into their own app. * I think we need more detail on "vector mode needs to be disabled". Does this happen automatically when we go to use PTP, or does the app or user need to deal with it? For example, does the dpdk-ptpclient app disable vector mode itself? If not, we should include in the command the "force-max-simd-bitwidth=64" parameter to disable vector mode. > Generic Flow Support > ~~~~~~~~~~~~~~~~~~~~ > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 7b1bd163a2..99d39849c4 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -176,6 +177,7 @@ static int ice_timesync_read_rx_timestamp(struct rte_eth_dev *dev, > static int ice_timesync_read_tx_timestamp(struct rte_eth_dev *dev, > struct timespec *timestamp); > static int ice_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta); > +static int ice_timesync_adjust_freq(struct rte_eth_dev *dev, int64_t ppm); > static int ice_timesync_read_time(struct rte_eth_dev *dev, > struct timespec *timestamp); > static int ice_timesync_write_time(struct rte_eth_dev *dev, > @@ -307,6 +309,7 @@ static const struct eth_dev_ops ice_eth_dev_ops = { > .timesync_read_rx_timestamp = ice_timesync_read_rx_timestamp, > .timesync_read_tx_timestamp = ice_timesync_read_tx_timestamp, > .timesync_adjust_time = ice_timesync_adjust_time, > + .timesync_adjust_freq = ice_timesync_adjust_freq, > .timesync_read_time = ice_timesync_read_time, > .timesync_write_time = ice_timesync_write_time, > .timesync_disable = ice_timesync_disable, > @@ -2332,6 +2335,34 @@ ice_get_supported_rxdid(struct ice_hw *hw) > return supported_rxdid; > } > > +static void ice_ptp_init_info(struct rte_eth_dev *dev) > +{ > + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct ice_adapter *ad = > + ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > + > + switch (hw->phy_model) { > + case ICE_PHY_ETH56G: > + ad->ptp_tx_block = hw->pf_id; > + ad->ptp_tx_index = 0; > + break; > + case ICE_PHY_E810: > + /* fallthrough */ I don't believe this fallthrough is necessary. It should only be needed when we have fallthrough after some code. Just having multiple case labels is fine without annotation. > + case ICE_PHY_E830: > + ad->ptp_tx_block = hw->port_info->lport; > + ad->ptp_tx_index = 0; > + break; > + case ICE_PHY_E822: > + ad->ptp_tx_block = hw->pf_id / ICE_PORTS_PER_QUAD; > + ad->ptp_tx_index = (hw->pf_id % ICE_PORTS_PER_QUAD) * > + ICE_PORTS_PER_PHY_E822 * ICE_QUADS_PER_PHY_E822; > + break; > + default: > + PMD_DRV_LOG(WARNING, "Unsupported PHY model"); > + break; > + } > +} > + > static int > ice_dev_init(struct rte_eth_dev *dev) > { > @@ -2499,6 +2530,9 @@ ice_dev_init(struct rte_eth_dev *dev) > /* Initialize PHY model */ > ice_ptp_init_phy_model(hw); > > + /* Initialize PTP info */ > + ice_ptp_init_info(dev); > + > if (hw->phy_model == ICE_PHY_E822) { > ret = ice_start_phy_timer_e822(hw, hw->pf_id); > if (ret) > @@ -6466,23 +6500,6 @@ ice_timesync_enable(struct rte_eth_dev *dev) > } > } > > - /* Initialize cycle counters for system time/RX/TX timestamp */ > - memset(&ad->systime_tc, 0, sizeof(struct rte_timecounter)); > - memset(&ad->rx_tstamp_tc, 0, sizeof(struct rte_timecounter)); > - memset(&ad->tx_tstamp_tc, 0, sizeof(struct rte_timecounter)); > - > - ad->systime_tc.cc_mask = ICE_CYCLECOUNTER_MASK; > - ad->systime_tc.cc_shift = 0; > - ad->systime_tc.nsec_mask = 0; > - I see lots of removals of ad->systime_tc from the code in the diff Are there any references to that left in the code? If not, please remove the variable from the adapter structure. Same with the other values below. > - ad->rx_tstamp_tc.cc_mask = ICE_CYCLECOUNTER_MASK; > - ad->rx_tstamp_tc.cc_shift = 0; > - ad->rx_tstamp_tc.nsec_mask = 0; > - > - ad->tx_tstamp_tc.cc_mask = ICE_CYCLECOUNTER_MASK; > - ad->tx_tstamp_tc.cc_shift = 0; > - ad->tx_tstamp_tc.nsec_mask = 0; > - > ad->ptp_ena = 1; > > return 0; > @@ -6497,14 +6514,13 @@ ice_timesync_read_rx_timestamp(struct rte_eth_dev *dev, > ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > struct ice_rx_queue *rxq; > uint32_t ts_high; > - uint64_t ts_ns, ns; > + uint64_t ts_ns; >