From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3F1445B36; Mon, 14 Oct 2024 10:04:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 571FD40273; Mon, 14 Oct 2024 10:04:47 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 276C240151 for <dev@dpdk.org>; Mon, 14 Oct 2024 10:04:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728893086; x=1760429086; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=95dutR/nsh2wjvlxKkeniyzaCmztrcR33rs7jKzwTus=; b=aCrxTLZK/l2u+S/J7njoh0Q7s7Ryj56cA+GfyamvcDAsgKkcQCG6EpQo b22Ta4hbyATIDLqlHCgKFNfg7cjtud9qsQuDZDx0Gc0+8oMumXi1+F3hw 3j0/30v9Z+YauZ6RdoV0ZWLzOdTyicx9Ne4/JAAmYlILeTYI0MeQ9VXps +Ow2zDQ+9RyLF94Fa7ZoYBCgou10EW/YFWnd6TgstfZn16cwbG1/aH50I LzvFA6DBDRb4f7aW8RZhtJT9AMP5M7+2g2vc0sZ7b5W0TEST6H4H9JnBj BGcw01PVTzcNTvhmRgtp3xXYGbwx3i9dBVdZ5riFG0eStTwPGGafmmsjA w==; X-CSE-ConnectionGUID: R+z6ZJb3SI6JsZLXmzdM7g== X-CSE-MsgGUID: Yn974QikT3WgRuNCFhwuxQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="31925016" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="31925016" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 01:04:45 -0700 X-CSE-ConnectionGUID: 4w2obbmaQEKY5155njD9eA== X-CSE-MsgGUID: YgjrlJ6rSSSK8rZr3dmp6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,202,1725346800"; d="scan'208";a="82273058" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Oct 2024 01:04:45 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 14 Oct 2024 01:04:44 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 14 Oct 2024 01:04:44 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 01:04:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gyKG9v783B0jh+pB4fn8LVzuUGTzXL8PrWvK5sZz397vdupoysZfX64r7kAgA6b7vDfF4KSXwMKpY8dAZ6LH+EM/9MtaiAJ9gV+Lr5nIodmGiW1uTeOhTqygXZEXcyB4kjXs8ZIOU/vQDQyI7DUvYsREq5jFdFGiMIiVEnRgKHz1rvni3RxxFBRD2Lsq7sbQ02SkSlo9Zag/joKOk0BlXg1Uy2v91nzpTe41Uxn1NyK3Z4LVQ1PUlUk0BO7CRjUPd5WfIiWqBJe7k1fC4i3UReec8GOs8/z5aRcFEGgR9S47bkn7DlWn05ElnO6KoF+IJ9+IVUhyw37Ctcm79hU2NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tgYyN6dzoavA5PsxyQ/AMBbs9Qs35kjrCYnwlsF2+VA=; b=C8WZnArJoO2/4JReUgAUVMeMVQgWQGbFlJ1FRfihaEmESv8o19W/PQ4qmFMgBGSYOQqi1TQ+9bMyv32jmhZuB7xMJ9M8LmiBbQhF+HHZTBSFLi8wiJ5NjGWHGY5qPp7Gu9LdrogJCpwbYxKKXvuS9oacLxyEFyB+tVKstAAyDC8DC3B1HkDt3vBfMHyCFAYSNLsTqmZoLuRWOleaJeoaRxnOohw1GZUCnR1kV+bfTIxdyxxrglvAvHHJsymtF8wfK8e/hkH06zqb+Z3xEjgbly3xrlkcIpA/HrEGu1BN0vh6w6uMEgWwWOA723xtjdzLB2I3sKgYaPVi8iXgzb2JjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN9PR11MB5244.namprd11.prod.outlook.com (2603:10b6:408:135::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.26; Mon, 14 Oct 2024 08:04:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8048.020; Mon, 14 Oct 2024 08:04:41 +0000 Date: Mon, 14 Oct 2024 09:04:38 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com> CC: <dev@dpdk.org> Subject: Re: [PATCH] net: improve vlan header type alignment Message-ID: <ZwzQlqalWAgH-n5y@bricha3-mobl1.ger.corp.intel.com> References: <20241013083554.97489-1-mb@smartsharesystems.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241013083554.97489-1-mb@smartsharesystems.com> X-ClientProxiedBy: DUZPR01CA0178.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN9PR11MB5244:EE_ X-MS-Office365-Filtering-Correlation-Id: a4b8832b-d014-4a9e-b14c-08dcec26dbaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?SX5ObiFgbm1aio91vp2K7waXMx1Cm/Ltw4WbRiZA+Xf5UslZa8lJ7yodeX?= =?iso-8859-1?Q?TmYVZfmD8YrKoaaL6euDMnS1CKhwe42V747uIKaQQtK9s9zcVeR/BZiYqG?= =?iso-8859-1?Q?2zwYahZup9TP2VZGUNCiv9/lI2LSgeg82Pu+RA4lpe3Jvlo78/k9QeZVNC?= =?iso-8859-1?Q?gJT1yqMqry/kcogGMAM+Kl4VNKIapqantdtbzdsEflCFeB2ke0c4MfJmzR?= =?iso-8859-1?Q?5fypYBEatTt4bipyNGNBW2W4dAXYgWZ5oXiblPirTzfsvrQ7apDD8TNOaO?= =?iso-8859-1?Q?A2fOtdDA1XJTsAX3VchsWaQJ4V+3uH0WDyJw5ACOzZuuw1OVJopyHL2nfB?= =?iso-8859-1?Q?95CVbtycS/5PstSGZZ+m7IHt9iQYoe5kUzknrYcSbhrHr5z8+tndSvi3Gg?= =?iso-8859-1?Q?GymPUPCG82bee7qeCcdOl5N4iZPoc3PVpcqnVDx0iG3BNF/aF/IkauCEp5?= =?iso-8859-1?Q?RJ1BwbPdEcnsSqLGKGvBpqnA99ozO7TSJel2NnMrUHCOjP1Im1NeCLTXCG?= =?iso-8859-1?Q?5VQf/sbfEP2tri7Gz2YqPHzB6Fosy1RkRTh22FLLLIKmPd4Tj/Q69UTqLt?= =?iso-8859-1?Q?K1TfdwnyvxZmGCf9BnPgGCh4p7Q6HfMymzS4XVohHqNOJhcPt7WR/SNKh3?= =?iso-8859-1?Q?bOI6eOBZbRvuxuu/0j0D4AWEL3qbcu3yY9aTsWx3URkzDAZ56qvGxjueS2?= =?iso-8859-1?Q?n1MV2lxcDIRtst6RK/hJs1krSICJ7F1xFmx6rW2/PpLP8aYvVzDum/uJ3b?= =?iso-8859-1?Q?9rwpvu+b2pny2QcLxmVmOoJvm6LaGSkFEcf/wOJiVjYpGHfZtlUcj5Te2E?= =?iso-8859-1?Q?etcpBezH/7t8ziGIT6wHVNWamxT9+bHnHwfydgx14UwYgkYSR2I0W64Spr?= =?iso-8859-1?Q?Bie/io3hQKeFknH8CtyiAHo83yO9/3b5zcYM2OlfLzaXM7Gcu5wpOMuQ74?= =?iso-8859-1?Q?b2pHHPEMsafyKtXSRdyi45Oql60df69/95BuHYqHGY4PzDxdyMn18rp313?= =?iso-8859-1?Q?x12IFQffrqHO/7rHYTpa3XB0k7+69EYfDSpthwReIVWB3nbB2x6szY5qXW?= =?iso-8859-1?Q?wDQPLJeFFGJRp7vpMEDUCR0SBP+yqhxYNdX/pu5j9wG5D1V46tDlubcYux?= =?iso-8859-1?Q?COyH6H7/UtQAqF+EnxLpansjbPkKXu3JkukirQe3fu4VA82330h9H58I5/?= =?iso-8859-1?Q?X8c0EMI8OfNHJ7qjaWEtb41Wlib8Up4tFtNRud8YzEwZcfbBlB+vpjUe7Q?= =?iso-8859-1?Q?vI2abQNbsgannTLhl+0QAIyPucTotw3XBK88PoGjZr++M1ONlm5+/+/o8z?= =?iso-8859-1?Q?Clf9UEBG1nPWYudrDUm0m2uMMw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?diROUPpqgR/zFgpcGEtmjhS5GuR5fIPCbxArc0se7hD97BEg5a5q0h6xcy?= =?iso-8859-1?Q?X5CPuENObq/oBmqQA8W8JAnaVZctMePlQq91GEETp/RxhcezRNrUtHYrDf?= =?iso-8859-1?Q?eE9KmVsN7hV091IgWpiNHss1IXTnjaAEnmEAGBRS2i/yMAeI8SFjGCOfYR?= =?iso-8859-1?Q?gEI/c/IIHIvmVlNy786HSKn52mpTA9LMhGZ7ne88Zz6pUVWUo3imY1KOs3?= =?iso-8859-1?Q?bXG4gwDnF+9aimhajYknVckzXpgq5Mqd+wEjJwNQrmc1fvqDgvmgC0/4u9?= =?iso-8859-1?Q?Be+wcfwIB34xTeAACWpWO9gvqZbElqBrRYImnQPHuxXh1sVbEiJ1G/g4l5?= =?iso-8859-1?Q?kFYh3g7y+165lkneku6ECsmwCkBF0kv9Ky1O/qpBqpmjBuzX5Jk1EEj6Ct?= =?iso-8859-1?Q?zGUreiRz3xRjlqm/GZtEk9+C4+cUlyeO7nBYDCsw8+WopedsNY6WyvEbWf?= =?iso-8859-1?Q?AbpnCyOWdw6PnhdEGGvEbHJ3BX6exjDcTLcUL5weRy1xtHKliRpZcw9JGA?= =?iso-8859-1?Q?24dsaUf2sRiS6gezPPRy6WrNQnrrTk+LItSzloukXkDmKLR6hxfswe/9Rz?= =?iso-8859-1?Q?XPKKiXwONHonybB8dMY+kbLd8myp6DwKwybctQrHjuXFHOYc6tYKMXVwWP?= =?iso-8859-1?Q?bKJQuzwgOxerVdZzutj2vnpEtn2xCC2ZCYWmaivXb8mjyntETLOhK7yeck?= =?iso-8859-1?Q?FlaacxKyKV+e2W6squGFrRUOr0THnRcZzhOD6PEbCDgXYC/0D6I2GiuqNQ?= =?iso-8859-1?Q?0qRchin2v5/JxajXbZ+AZ4FZqDLXHbQ2MP5t/QG8GJZxb+zSivlUJgrrZK?= =?iso-8859-1?Q?cBq+fdRGgACoA1P6rNojVWBfR30dLCq2V9pX6LvQNYyjvn7SPUOwTI+PN7?= =?iso-8859-1?Q?YbP0RXWwXc6G7QyPz85VlvjmFv+XnoI7a4aPfxtNQ/nABKFAsmQzfF/JkJ?= =?iso-8859-1?Q?DmuQviXJF9fxeaXqPmxbYQ1lzJNFxp3rveJvPot2ZL55zChpVyhD6NHLEK?= =?iso-8859-1?Q?hA9V37ZuUnj/pE4vAJ42cxmkjFsSWQ+TIMFOd2iRSx3qZD6gkZRhn7UkDb?= =?iso-8859-1?Q?WHSsGIdzpYTGCCSDID2dgOb3L0dHs6xEYKWYcbrGQjg2ueaxhz5JEyKChs?= =?iso-8859-1?Q?OLp544zOONaWdxgpKkBeXb60iZR6R5JwnOMpj6GFfbQdyfEjgNFjRh0LwB?= =?iso-8859-1?Q?XrnshSptzEtbARVTk8nt/IEv2/FVRaNVnYB/8H11x7gEAzexCVxvSP1+Ss?= =?iso-8859-1?Q?6LUUOmNk/kpv5LOpELUTKUyL+11jGD5JvDqfdU/VlVwI6TxgwQcrowaoWJ?= =?iso-8859-1?Q?2K2luXj5WerZnj7MRMbeihv3lYsgNtikVboA8E7ghgJ/n7tUfnkTsBJR3M?= =?iso-8859-1?Q?A+ZCWpjbCSw71jZHuBqhTIOk+gsn1/w5NZg1etLPhTCtMrEZaGZjSCnTrd?= =?iso-8859-1?Q?/zwzU3PdnI4mJetn/llDgopt3bqRpOmXCmziYhCtw77iHvHxrEButSksLK?= =?iso-8859-1?Q?H+vUf6LSp9M/jUQgkWfxdbBlq6jZdakIsBTAOgGII1dkYsKPphSXiDSTfJ?= =?iso-8859-1?Q?LvQNJ4cWAMYy/w0TOlJBfTwdC74aVd1Bu+pb5BqPuBwfyaZFx7Gf1XVV34?= =?iso-8859-1?Q?ByLTafqiIlilmfolvdMI1GMlOuNPQWQjj4sPCllhTtyWGBYa04BxzJbA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a4b8832b-d014-4a9e-b14c-08dcec26dbaa X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2024 08:04:41.8977 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lhRR3V7c/GSJNRvMRli8e9wqq6TWXp2/GOzIoeSwkHh7HgUMc/cl4otn5aIsxhaZ9wDjA5ZYAuYbMBkdE8p9t4DXrl+xyUePxOtVYYkJ4Ao= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5244 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Sun, Oct 13, 2024 at 08:35:54AM +0000, Morten Brørup wrote: > Ethernet packets can be VLAN tagged, i.e. an Ethernet header can have a > VLAN tag (a.k.a. VLAN header) embedded. > Since the Ethernet header is 2 byte aligned, and the VLAN tag is directly > related to the Ethernet header, the VLAN tag is also 2 byte aligned, so > packing the VLAN tag structure is not necessary. > > Furthermore, the Ethernet header type is implictly 2 byte aligned, so > removed the superfluous explicit 2 byte alignment. > > Added static_asserts to verify the size and alignment of the various > Ethernet types. > > Signed-off-by: Morten Brørup <mb@smartsharesystems.com> > --- > lib/net/rte_ether.h | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > Acked-by: Bruce Richardson <bruce.richardson@intel.com>