From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <dmitry.kozliuk@gmail.com>,
<roretzla@linux.microsoft.com>
Subject: Re: [PATCH 0/5] Increase minimum meson version
Date: Thu, 17 Oct 2024 11:04:48 +0100 [thread overview]
Message-ID: <ZxDhQHQ64Zqfqw5i@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zPLHB4mjFgSHTCN5Ba=q1g57z+Jidg_pD2vGr2SU=R5A@mail.gmail.com>
On Thu, Oct 17, 2024 at 09:53:18AM +0200, David Marchand wrote:
> On Fri, Sep 20, 2024 at 2:57 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > This patchset proposed increasing the minimum meson version to 0.57
> > and makes changes to update our build files appropriately for that
> > change: replacing deprecated functions, removing unnecessary version
> > checks and taking advantage of some new capabilities.
> >
> > Why 0.57? No one particular reason; it's mainly a conservative version
> > bump that doesn't have many impacts, but still gives us the minimum
> > updates we need to replace the deprecated get_cross_properties fn
> > and have a few extra features guaranteed available.
> >
> > Bruce Richardson (5):
> > build: increase minimum meson version to 0.57
> > build: remove version check on compiler links function
> > build: remove unnecessary version checks
> > build: use version file support from meson
> > build: replace deprecated meson function
> >
> > .ci/linux-setup.sh | 2 +-
> > config/arm/meson.build | 4 ++--
> > config/meson.build | 8 ++++----
> > config/riscv/meson.build | 4 ++--
> > doc/api/meson.build | 2 +-
> > doc/guides/linux_gsg/sys_reqs.rst | 2 +-
> > doc/guides/prog_guide/build-sdk-meson.rst | 2 +-
> > drivers/common/qat/meson.build | 2 +-
> > drivers/crypto/ipsec_mb/meson.build | 2 +-
> > drivers/event/cnxk/meson.build | 2 +-
> > drivers/meson.build | 7 ++-----
> > drivers/net/cnxk/meson.build | 2 +-
> > lib/meson.build | 6 ------
> > meson.build | 7 ++-----
> > 14 files changed, 20 insertions(+), 32 deletions(-)
>
> The series looks good, and CI guys gave me the green light.
> Series applied, thanks Bruce.
>
>
> There is one remaining TODO in config/meson.build:
>
> # MS linker requires special treatment.
> # TODO: use cc.get_linker_id() with Meson >= 0.54
> is_ms_compiler = is_windows and (cc.get_id() == 'msvc')
> is_ms_linker = is_windows and (cc.get_id() == 'clang' or
> is_ms_compiler)
>
Yep.
I'm hoping perhaps one of the windows maintainers/devs could look at this
because I see a number of possible linker values for windows listed in the
table at [1] and I'm not 100% sure which ones are to be accepted here.
/Bruce
[1] https://mesonbuild.com/Reference-tables.html#linker-ids
prev parent reply other threads:[~2024-10-17 10:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 12:57 Bruce Richardson
2024-09-20 12:57 ` [PATCH 1/5] build: increase minimum meson version to 0.57 Bruce Richardson
2024-10-15 8:16 ` Robin Jarry
2024-09-20 12:57 ` [PATCH 2/5] build: remove version check on compiler links function Bruce Richardson
2024-10-15 8:16 ` Robin Jarry
2024-09-20 12:57 ` [PATCH 3/5] build: remove unnecessary version checks Bruce Richardson
2024-10-08 8:33 ` David Marchand
2024-10-15 8:17 ` Robin Jarry
2024-09-20 12:57 ` [PATCH 4/5] build: use version file support from meson Bruce Richardson
2024-10-15 8:17 ` Robin Jarry
2024-09-20 12:57 ` [PATCH 5/5] build: replace deprecated meson function Bruce Richardson
2024-10-15 8:17 ` Robin Jarry
2024-09-21 23:21 ` [PATCH 0/5] Increase minimum meson version Ferruh Yigit
2024-09-23 1:59 ` fengchengwen
2024-09-23 2:19 ` fengchengwen
2024-09-30 20:55 ` Tyler Retzlaff
2024-10-08 8:28 ` David Marchand
2024-10-08 19:49 ` [OS-Team] [dpdklab] " Patrick Robb
2024-10-08 20:04 ` Bruce Richardson
2024-10-09 14:27 ` Patrick Robb
2024-10-09 1:04 ` zhoumin
2024-10-09 14:31 ` Patrick Robb
2024-10-14 1:24 ` zhoumin
2024-10-16 13:08 ` Patrick Robb
2024-10-17 5:26 ` Patrick Robb
2024-10-17 7:53 ` David Marchand
2024-10-17 10:04 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxDhQHQ64Zqfqw5i@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).