From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A55B45BA0; Tue, 22 Oct 2024 15:03:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64FC04029A; Tue, 22 Oct 2024 15:03:29 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mails.dpdk.org (Postfix) with ESMTP id A8D9040273 for ; Tue, 22 Oct 2024 15:03:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729602208; x=1761138208; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=7aAyv4sjyVecqBP6dqzi90a5eM5tNyxtu/4ubQiqeDU=; b=FtOgx3+8iB56+iPurXfyZR/nI93f1zLBxEtt+A6/HATYA4lA5mRCHHXC tUfUM3k7KCa6GeMkfGosJVId136Nds0oKAnp1kZN3oQpe9NgTe19BIvAU Jv+jgii+awI9tZsONrOmSWKw9vOWguvPTWs3qcbYTeHZYCYEF97wiTVlV x2e6NoIFD1sr66mEQU+k2BJ4XO3WVZmSJGfuaYJArvoKzX4aMzR2gCaOd ezEYyWDh0SCnT5n7yeMMEf+PKQWxapuJ1GiAmJNSeqJkYucmZ63Nf3oLT gEM+osDmj7F06ZXid4AWG+FVDoSoLnEdI45Ksefl2ijITk71rTlnBErAR g==; X-CSE-ConnectionGUID: LXa51KcdR9uNbtmiJRl38A== X-CSE-MsgGUID: qKTLt8IBQOK2hGDJ9PsjCQ== X-IronPort-AV: E=McAfee;i="6700,10204,11233"; a="29340298" X-IronPort-AV: E=Sophos;i="6.11,223,1725346800"; d="scan'208";a="29340298" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2024 06:03:27 -0700 X-CSE-ConnectionGUID: A8+5CvK3TUWbgV2dz36XoA== X-CSE-MsgGUID: BREgNej8TNOUm6/oVVSA3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,223,1725346800"; d="scan'208";a="110686326" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Oct 2024 06:03:27 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 22 Oct 2024 06:03:26 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 22 Oct 2024 06:03:25 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 22 Oct 2024 06:03:25 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 22 Oct 2024 06:03:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KGtea8+fRMi7W2OjgCqp+dFJRY9JAWf3qHSz79KCLdUHkfI86aSNabv2PViP9JLKlonp38C0s6BGzvQuEhszk1lqSap6DYlfMi6UaF2Fw4DPbT0C4XkG9MucQdDMsawkK3LwztQf6Lzc3XKLDR6J4ZalFqJwsI1JT059deRW8Zae6Vm4wthmlXwMK5O6bq2smMy2zyrRQlm7tqoduNTj/fQ06S4bNQZnRa55ycQTgeBOmkCBBb8zAU5Ctbof34WMBO6zRTu/tnp2WlpICWQrOys49iRCltsv7QZsd1kTRnLphDniNmnG3yczwU34KsyJh42aa+OWTcaEpbHqNb5MXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P7W8duikmgNH7KXf4bYog2JgtMvOt5tNJb2uer6nZtY=; b=VatawQ0w4Brw5MtkrXupV0e3cdrKfSVMaQi2DX35KMZvgFGIJ4EpS2sIwVFmpxJG7fWOeSR3z89xG6ts9eA5u43xVDXE86M4QgDNpP4FNQJXME/45tVjl6NCcAvsk6zOAKbuiZYmL3LNKA8ks9rQOOakZ1TYjJGrz9VMe/fBtY+DbTRIXxvrIUVm+qBKeguqXECM+51h1wN72/4YI80T8TLHSopEmT71LFaWsbAcTsOQ3Hs2MpiDNcvQNMZFlX/XiP58pnirmGYkkicIJ/H4c/O+mUQSQDv7TBn+ccnWJA9RVJmjt+OIK8a0YxOTUCHTMXFBCjou0Pw3EkelFx/Zwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB7271.namprd11.prod.outlook.com (2603:10b6:208:429::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.27; Tue, 22 Oct 2024 13:03:22 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8069.027; Tue, 22 Oct 2024 13:03:21 +0000 Date: Tue, 22 Oct 2024 14:03:17 +0100 From: Bruce Richardson To: Lewis Donzis CC: dev Subject: Re: FreeBSD problem with ixgbe Message-ID: References: <20240927180829.525350-1-sriharsha.basavapatna@broadcom.com> <20240927180829.525350-18-sriharsha.basavapatna@broadcom.com> <136318200.3114519.1727475831877.JavaMail.zimbra@donzis.com> <1498261798.8960233.1729600321210.JavaMail.zimbra@donzis.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1498261798.8960233.1729600321210.JavaMail.zimbra@donzis.com> X-ClientProxiedBy: DB8PR09CA0008.eurprd09.prod.outlook.com (2603:10a6:10:a0::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB7271:EE_ X-MS-Office365-Filtering-Correlation-Id: 98f3fd3f-01a0-4386-4d4f-08dcf299e7ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vfpF8wi62ARFEiJs5p4xODQod0Ia/gp/IBSGUrj5oeNP32fMBd4gO+FnuNAC?= =?us-ascii?Q?6jVnRVr2EFQdx5l56leFfps8NE2WPY+M+iRYlBDgsSS1bqBUbABqQLXv+K+K?= =?us-ascii?Q?ASb60YWSGkpT5GFGKa586cAATYVBexSWnK6joI/Vzs7UEDSpglQO/g8k5Z4P?= =?us-ascii?Q?+1dDIDRTLi6crT6rY8wZNRm5QpWexkxFTG85wqkynkIbHSwR4RIomtsqDIbM?= =?us-ascii?Q?T3xcP3MDsliogCQfQ1pycBvbT46LdbUIYqsXKTztzT+CIEKYdUmz7JlSeT10?= =?us-ascii?Q?2H8CYKhHhrZll1FNcuQnFRPUabvTVnj+0Uib3DpTIei04JtXaQaq69TwvRNR?= =?us-ascii?Q?vYx0+IjbLmHmZclBDyE2KelWFHLuyyQzjcDPHtsbFa2kY1EHuxZIFaRHhpuN?= =?us-ascii?Q?icfIHPQSNQhNvJzFlKghX2V8vqCb4E6uKetNEBqVuhoOKdRVmofrP1IWUcDt?= =?us-ascii?Q?be9XeZeM8SecLrL+0wPNpwwBHousbZ4zNGcbEatn/RHdTch98niD4sRwpVFl?= =?us-ascii?Q?qxiWMCJvSDVzTtvJBi1H4V7M8al/vyRDQRjFeRzBKfc+a3YzndJFhEOVKarb?= =?us-ascii?Q?lBV5wTd1kzt8FfafPZZxniPS4cGWpfibtzhxq4gTOa4Szidz1UlrCsiPuOWQ?= =?us-ascii?Q?5Uc0NRYg3Zglu2WRPTaEIBorb3HF1PNPfEhPLRl1K/Cku9A9oeanJrCqRMFk?= =?us-ascii?Q?zXbGkHi/MMnkrmLPx5kGoBhpioznwSp/KS9Uhms657oTeTUfdiFbelwUnYwq?= =?us-ascii?Q?dISoZ2gLTeoJBznxNE3VPjZ5kI1MGRzWnUNYpklrHVuYZ/oIledrehNHcbU+?= =?us-ascii?Q?NNqKHG0neFvI9wTts6wi+QmDtfU24T7fTMfLVx2H2LFibnGlFEBbHQfUklxN?= =?us-ascii?Q?/5kGxxfIsw/7it/NsrlrP0zjqXV0cKidK20SpZvWtzaEB8+nkOJn5f3lQVNU?= =?us-ascii?Q?4kzIoJtkK66qOVmCji+gigB2E3ptc9R/mvLNh9DTZt6Kz69XBEY75FYKFqsa?= =?us-ascii?Q?/LxvAMgIYEYvTm/GzCi4TaBo4P6YeeB2b9mDCPzxZtxWCuWcciysJ+0Lo8lU?= =?us-ascii?Q?E2c7BtnnQhFVOm6FeblGJlxl04lv2EaA33EjQX8pLEzIqjX1kTDwO1xatqjE?= =?us-ascii?Q?SdfWCzBJ4ytthPcrquf/KTFXz8UomDGxs595YL8gAbRfu+fGrwZEcaXkJkfA?= =?us-ascii?Q?OfsedWjq+o1fUoeIbFmP454gdAvpb1kCE8x2Kh0tY6mxc9q0g4371V3IaVMf?= =?us-ascii?Q?hNp2FKVYq1weWPWrmNuh?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?drUwcLIAA0vU2qgpT7T5qbk4YQ7eaQGZ7PETudJmI+ehQ22ugGrZl7q3huQA?= =?us-ascii?Q?TLLymmjAoWe537qJWgb98VMNaw1LB2HNBl3qlXfSM4fFL3qUm81MZaJnRebM?= =?us-ascii?Q?L6HCtII7lby6f6KWHFLosWHrYoxeeCuZIh9QTTAIBQu2YrdVipTZ6TpiT0og?= =?us-ascii?Q?aYLPyNwgTVPgubpJYbyjIwMv7yHaikiMFqtHqrOEywVn6RRxtrZuc50dVAEM?= =?us-ascii?Q?Ulb7AzVnRkXOKIJwlLJdk1gKROVyeTL50QK7Tr8yD3jcX2PT+M1N1VRtoQVc?= =?us-ascii?Q?8x0/nJPWtM8vPyst2+H2ikqAuO1vuVBnejHhQwlndy0EMn5E8PE6Y1T0LRfj?= =?us-ascii?Q?Ay/EkwmtiQh/3/oDWZD8YG3WYX40zjz5nibc+ml9FwkpppWxJqc8sOYcoN1+?= =?us-ascii?Q?43YYD+pAXAGzwWN/238wzF6PQu1ApQ0XUEOdUOtDRUuiaKiU3PvBk1l8Rpkp?= =?us-ascii?Q?masO1H3rjMXHSO59TcwiUqWWI8/zsQ+Hf7qYdKlnVKKsitnegJ6o+kj9i7VP?= =?us-ascii?Q?5ZRd/nAYCWPSSMX8HC2706FsQt6PSwfMRTROn+s/OX25efpKWLcqdfymB9L/?= =?us-ascii?Q?hb4eTQaG6fkJhCDihVNp75C3xklCIumskTDfPkMrNmWB1/S22vxWtG+yob8P?= =?us-ascii?Q?2oQ5kOgpcONMsFwRL89ONvc7HIbdgkJXMiMFlQ/5BEFyySZ5GfO7USpLq0jI?= =?us-ascii?Q?wg64LR8j4fCjO96lnn1Ke4Jw0J8I5AaUgxZ1jWb7X87YO5Hjlwx4pBM715Hx?= =?us-ascii?Q?wwfeQSNzP6EgPku8kdan1KKfUxvxyR2QxbyKI+k0YSv2//7s02iRHNLJcLAM?= =?us-ascii?Q?372w1UsdZGI/jRYH1LX/jLDES9W0vHwy+XGSPyLcA5dZyWQW5zdIH5KaJKES?= =?us-ascii?Q?wiQwxLWttNrbobem28mfULJFR0ADWmr614ds4ejon8OBeN1hE1fR8pwNg6fD?= =?us-ascii?Q?zKcZ1VMuqLNmCBpuPHoy4ouD/ErHL0FOnz8j8mNYg7SYCmRCT5l8849m5qKQ?= =?us-ascii?Q?oqwX6X5P9tFd3lW1+/tqLBhk0rO1O3T7Ac3URdqP+YmaCZmyBZHBMFybgMJa?= =?us-ascii?Q?ste8dSQ4C2H2MSJZ6M6aCuHzo6ud+ORlEjhRvW92epFN4wP9TT+vlFVeEJSD?= =?us-ascii?Q?CXAyV2XYK2eQKNBNtU7K6iG1Szp53U+UeAKG5LObDRlYsqDLVpe1lPG+TqEI?= =?us-ascii?Q?lx81wKO/0lxdkEdW72iqBBmQrsMduUPDvL0JPc1Zbcifwq1giU7Hgx/c9rMo?= =?us-ascii?Q?e5QnP5jKEVMSMeOxOSwLtGNqJVHf1t6+uPn/+hjSfx0qb5YScckz5rgdNFeR?= =?us-ascii?Q?1+iQUYRHIT+SV78E4VE62mUpaewJ6mKEbeywgNCekg+ezeXlVrbV5isoaLeL?= =?us-ascii?Q?B79ggJRdqmUxVnfoI2Ich6ntYBxtCKhG6uiB0KDGBNdeY8wdRXgfjdH4YHsw?= =?us-ascii?Q?/78pc0tnvyxtM5pMZmUN/z4UrF+UN7/Krb3HK6zY7lzw58miZL/KELDlftEL?= =?us-ascii?Q?7HKlX9BwHKk7wkUhKCwA60JWdi7j3/Ohpdx966bpm4iuyUHXbO1j4nR3XdC1?= =?us-ascii?Q?lQhO3MdvZ4ZeEat0aTlsAttd93qHQ2k3CMzzqnDhsJB2950EzH63G7r24A6Z?= =?us-ascii?Q?iw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 98f3fd3f-01a0-4386-4d4f-08dcf299e7ea X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2024 13:03:21.7991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +yw1pj1ysOPGvk5CiXoJMNe2i0xpKd3OXKZ09sugjjB1RVBoELauenjmOat+A00K+JF3AEsvYtM2P3HokFQgVrOPxXFeSlxwNQWXJ9ABJzU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7271 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 22, 2024 at 07:32:01AM -0500, Lewis Donzis wrote: > I've reported this several times over the last two years, but there's been no reply and no change to the ixgbe driver. > > Specifically, calling rte_eth_link_get_nowait() on FreeBSD does, in fact, wait for link-up which causes unexpected and long delays. > > I suggest removing the line from ixgbe_dev_link_update_share() that forces "wait" to be set on FreeBSD. Would someone be willing to commit this, please? > > Thanks, > lew > Hi Lewis, could you please submit this change as a patch (using git send-email) including your signoff on it? We can't take code into DPDK without the appropriate signoff. Thanks, /Bruce PS: For reference see: https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body > Here's the "git diff" from a modified version: > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index ab37c37469..008760e315 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, > if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) > wait = 0; > > -/* BSD has no interrupt mechanism, so force NIC status synchronization. */ > -#ifdef RTE_EXEC_ENV_FREEBSD > - wait = 1; > -#endif > -