From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5917445CB1; Fri, 8 Nov 2024 09:51:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47C3842EE9; Fri, 8 Nov 2024 09:51:10 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 65CD642EDB; Fri, 8 Nov 2024 09:51:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731055869; x=1762591869; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=8nPySKC/SNyQ43hIFv6wkT+sr+MPUpFqs7YJLYbDIpk=; b=ag8ZOxv/G8iXqi2lngqMUCG2YYSXhfFFyu2p2uFKDPkVGcV+e9hkReLg bTENH8KDCMnz3Caj1JktcD3lFKJ4gDF0lo2hQUHr1X0aOjKZ4JiAV2gHP z15wADY2y2e3hERkcUj9fpGL91VujAbTJ+fbdJ7znaZ6weRfRvHzpdlBz +2aiiqCtD3M97VBtkZ6u3hCDKqwgw1eJFqzWpJlGSshgZDkuTY772s0Pt 3Pw62I9n4hnjMfds0TmIOaysLQzGg9kJEgYlTi2DzKI0ny9JJKbSeMp97 ujtNTH3ZTpgRB7Netz6aVRAqcX7ViAvZyNCBykbvaFKIBMz440AUiJhpb w==; X-CSE-ConnectionGUID: 36C+kk6LTCm9GMPXPswHwg== X-CSE-MsgGUID: Po3wrtRtRKOuvCYS2t4bGg== X-IronPort-AV: E=McAfee;i="6700,10204,11249"; a="33789961" X-IronPort-AV: E=Sophos;i="6.12,137,1728975600"; d="scan'208";a="33789961" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2024 00:51:07 -0800 X-CSE-ConnectionGUID: h4f36jefQUWrc4NziXYyug== X-CSE-MsgGUID: Ey/63xHURTqx369P//kpLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,137,1728975600"; d="scan'208";a="85363565" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2024 00:51:07 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 8 Nov 2024 00:51:06 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 8 Nov 2024 00:51:06 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 8 Nov 2024 00:51:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XSg8U9ongCMFjapHL4KQ3yPtcgpN5EuKSstugjHYYZUaqyz9bTZCydkpVpvZOMidOdhYKUsUdCwpikFmP4tkfmVAbk3EvqHFuPiJRcPgHXGyUKkmmDPS3xyPXNwLJYp+7RNhXipdH1wJTf0Fj6UAlF3wcRSHJgiXQds02OnxIrFy56X3GXm38HmcHE5P/w2jbRmI5IhUZuOsQBzZpkMCsS6Lj8/xLjQ9g8+SZs+R2ByKKwCMuebE7LR2BugyZvJBW5k07JFptqvSokHVwiCryfGwCdVLZxaFjQxrwnIR6yY+bIJc7EYnzNIpeNs2GiYSMQvxKlDI97SKvsAmc6/J3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cM72vphZAn5OVOlLqPldygMhNxRQD0x6QjXw3pCdFZw=; b=r5mf11uQbw/zvv3LAER3GV/iCXsrF5Op4IGS5tWMRABy0SKbHaQ41itmN/3tTyBG0JVf7X3X63ek7N70swouSsHTv3RfNbOEFEOQRYuz9p84oh2paeJJKKoO67sZLdc/jX3JLPdKyMnrYr1LUsF4tfLLt4U5UDOGgjzLtTWlSmCuyPu70d6cpGUQg/RvVW3fZkh29goDxFcu4Vbdt/nTpxO1i7/maXewdfuaz2GDs0b4ngUwyVN4bkckoW7a8k73Zvq5Ki6IFgtq8bqFqr9QfG5/pipRKVDzLeadsuCd3I6Ao48G91cQ8Kk7XbtyiX0KL/KvtPU3nM8Vtm6x/ZkykQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB6568.namprd11.prod.outlook.com (2603:10b6:806:253::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.19; Fri, 8 Nov 2024 08:51:04 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Fri, 8 Nov 2024 08:51:04 +0000 Date: Fri, 8 Nov 2024 08:51:00 +0000 From: Bruce Richardson To: Andre Muezerie CC: , Konstantin Ananyev , Subject: Re: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1731026691-1529-1-git-send-email-andremue@linux.microsoft.com> <1731026691-1529-9-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1731026691-1529-9-git-send-email-andremue@linux.microsoft.com> X-ClientProxiedBy: DU7P189CA0016.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:552::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB6568:EE_ X-MS-Office365-Filtering-Correlation-Id: bdae404b-007d-4834-9eca-08dcffd27a8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0CZaKOR880PkXg5/mdaxcfNBDVZIo0qDuhVnsXOeeOHQ8ELrUczHdVbSqPiZ?= =?us-ascii?Q?8hNmUTREIwBcJBehZsvprPloyiuzN2jqGw4MbFaIoRc5F6myrTPkuQIh7z4w?= =?us-ascii?Q?UWW5l06EvK+aw/375K07YmzeHXnHUqekloX8jkOiXz6OmLls8vIKqjg91kOy?= =?us-ascii?Q?zZxkf0tATf3OPcnD+NtB2a5QJEKWOrnK6bQna1ERc7PbrrmX2IXHCpW8I538?= =?us-ascii?Q?TBmjSWyfIM/iGweYQeD0UknLLi39xgAd4/s4couCEnISB+VrQFx7dAVWYwKi?= =?us-ascii?Q?GuMKUkSOTnRhyyQB9EqAtAu5aFEEStx9/kHSTjZWuO2avswowGBxN3tjohrk?= =?us-ascii?Q?RFsqpWNLDMETiNmoCDFsYTZiHV+pgqUqbkAhatE4DSoItIvfIkbUmUKRgh+e?= =?us-ascii?Q?bh0VKrEYe9ME0vRmVEhFuZyzE82OcAGOE/1jrGddb1k1mckRfgw6Nbgf+5mx?= =?us-ascii?Q?FKTYlv7S0DBhvWK9XzjaDgFbavSxjE7W9PDblN+w5asV9H6+j08rtWUNr9Ug?= =?us-ascii?Q?IzSaERCWHhe8Bh2ys6lAJRWZqER4uOccC3dNgzh616DxrkqwWSlLfS6aeG4N?= =?us-ascii?Q?RSqVo+FpB8nqYCS1KupYV+hlC/xlwLGhO5h8REjJY8C12w8rbEmEmtyCKkMu?= =?us-ascii?Q?Am1YBeQua2GhVDrNWxwz7zr7hPx9spYnJe5W/BfZhjG13ft7HpCh2+b+jXiV?= =?us-ascii?Q?eSoZgKL1s3vvCmSmBLJwyA9sQqW77c8DFEfWfaR3pSRe/03BdYvF1OpaMDEa?= =?us-ascii?Q?bfNkJ/GKxssSIYaDXE/ujYNuuKhJPYq16mpzDdxBr7pXx90JCD8AmVZRsPNB?= =?us-ascii?Q?xBQu89UnD5Wn4ZKDoGv2mGJ1t/ogtvInMsYkmL2ZdggN1R1ZfZwgv6rpqM7C?= =?us-ascii?Q?5LdtftFYVII04bv+P/x+g8fbKUJyz4b/LuHiH83gcYv0CYf46hWTEwAKJ4fV?= =?us-ascii?Q?RpiZ5/EEBdpVboHufavAl5KQQsICuGEUbRzGjbFG04GMayVOoeeXIpfGAOWb?= =?us-ascii?Q?LbkddRpQRnym6DNSlTUmsQxU33T6b6vqzEEvySICQALbp2+RzrgAHu8xoIN9?= =?us-ascii?Q?g4rRUOW/OCQDad7dmfspLc8AWxNCBpG7vac1djKrIciK7tCwKV2/6EKOG4tq?= =?us-ascii?Q?P4LaL0Rz72vZ1NAFCnpM1Ht1KX8ohRZoQFQuS2uPYjnNxdCr5op8UOkdE2HP?= =?us-ascii?Q?sodRTCXADFHk8oj6NALhdKfpvICFjIXJ1pVvcSt8/GPkrqo+Z10zXBK/XkGw?= =?us-ascii?Q?4L1u3hDm6V2obMRumcgHXf51Zy1pavgWV+Bj3x/bNpg3WDmw692txJbjRfcW?= =?us-ascii?Q?tOQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tu+MYvYzAEOlFYE+hI7AIClvyLW8M3k4iharfNyYDcOoUzuWyZSIO7O8xeLb?= =?us-ascii?Q?17fKRkgf0N0n43vwVPcYtfgXXkQkbCBUgq5JXD1Ib0zN7XlHUFBr9fX9ugLP?= =?us-ascii?Q?IsrwYw0AgOANxhyMM5fDHh/fKyWhPvjO6Knb1T2zSY/xKGeLyx1dz6Vjy2oi?= =?us-ascii?Q?b4eFx6tLUsIwhhiPRSPjh60p0Q+5ktEcgc/ssRd9DtrE5AjJsFi4WAD1y0YX?= =?us-ascii?Q?q4sbXUD+mGJF0ECLkCty4WEwSPbrJdgVaW6FFe2HlvKW7/Mmg+wYUCj/89Hf?= =?us-ascii?Q?Hx8k9D4JlGJ1nv5m/ms3o3t0hQ75FHJF6bA+SPKZtMxM/IPulXnvWd9PRxhT?= =?us-ascii?Q?R38PSI9ueSUZKLYSie6tQC3Bwkr65Hr47FVvcrExWwxTZnLYhebFeR9cZZLG?= =?us-ascii?Q?gWDj6FAGti8r+Nmq12fGTiY2HamRgVM1eWkju8zzgFKGYNPNofN+Z+x02GWd?= =?us-ascii?Q?Q4IPHFvr6R0ZWqRflOlIU/Cz+8WGTIlZyKvj0aXZiyhKJo3Zj6ZT9BrC8Q6i?= =?us-ascii?Q?d+6fcHT2tUNIUka5T/N/La++KP/KPdrMIWR3s42E2OLvYj9dOT8wwRv/VU6U?= =?us-ascii?Q?loqEYGs+WOaErBTcFBP9xXVAd+LORHi0/AycUGmZclOUEUDzPAbssBufZ/Dw?= =?us-ascii?Q?fAfKN0tXutzApQ9THJyQ2pXo9jD/rw3khhKZLF1HLNeLnv3+29eHihfk48Lj?= =?us-ascii?Q?3HtUj4tP/fVMWfZi6wwVlo9jyO6HnPOvPQAqsfNfUEOt+aVVkJlUHfvqRFFY?= =?us-ascii?Q?d4SXK7rDeSJieoE8JqiiAKuFn+AM6QAztIAooeg+1kPyoyiXDuox2gb9omt+?= =?us-ascii?Q?FWeSyFZe069iVe00+CFb49kcAwHAVlKviw0mHtNgFrMPcrpNyi22hH4CU2Bo?= =?us-ascii?Q?Hb+QMxEkjq9YjhyfQqwo2EooOt3woJ9sCZRLP4AeDUjephwliUpbS2wXQOSj?= =?us-ascii?Q?5nEbwQWng5oFfacKG4pY+cYH8jYWODxgTAdCqOsObYwViDqkI3vEwXLKDn+2?= =?us-ascii?Q?c43oS/Qfql0uAK0AYlJKM4GWJ5hGf59PH0b6e5WRunmNc3UH2kiV/AbbZDHl?= =?us-ascii?Q?2mJH9D0F4b+wwR1jPsvR/R1biWFu/UbunnG58Zj2xGL8XMczrW1KEXsMkPaa?= =?us-ascii?Q?teMuqtA0cX/Jfk7LeSnsQ7Huwo4QNaGXlNFFaYH/Wc8oW7eiq+epd7HDjCZy?= =?us-ascii?Q?CmQ0YbVJGmqV4Yy3oe+kOfBlY2ycWB9cqwsXPVL4fcKYq6EwvraR7AFpcLI9?= =?us-ascii?Q?lIxYWGLTItxPGj06sgrXsmDP8ximrQ1eR8rkBYwGnwApOKhFNwOAj8aTaavk?= =?us-ascii?Q?GiACxxVIizWzzpERVah8aWjuK5bVdksFyjVJxLJAnDhHiucgtPJfZpRhRDTY?= =?us-ascii?Q?VSSduTdlEvnVQSkGPr+rwcGQUTG/nYvVCr080ZDLTVyMczHOgKcd/9E2NbBJ?= =?us-ascii?Q?Z0m0sdVr7uE7U1401GUnKWsU9qLo5Y6K+HXa2Dgn/mNuta13NaOd474phJMu?= =?us-ascii?Q?VKvJ7my7MLxEoX3FAO8VWbXcy8VYxxBM7Inq0az8UQN5qdTA0FrM8Wk0P5ZM?= =?us-ascii?Q?TY+DOJWOWUMP+zH2XOA0KEYJEmd3bybDa+CK7ph/TmRr4E1Oz/z7FgISnPlD?= =?us-ascii?Q?OQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bdae404b-007d-4834-9eca-08dcffd27a8e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2024 08:51:04.6373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nxuF2PgUSCY3Ut2544aID20yR+HK9qfXVV9vrQKpsfetcdDb4B31MxTsBJr0lMPcLXxVRqSg1XnVJHEi6HIcpU/ynP+DEkkQXbID6R1v+Ms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6568 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Title for this patch is incorrect. Does it belong merged with the next patch in series? On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote: > From: Konstantin Ananyev > > gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account > that first entries in pkts[] can be already occupied by > un-processed packets. > > Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") > Cc: stable@dpdk.org > > Signed-off-by: Konstantin Ananyev > Acked-by: Ferruh Yigit > --- > lib/gro/rte_gro.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c > index d824eebd93..db86117609 100644 > --- a/lib/gro/rte_gro.c > +++ b/lib/gro/rte_gro.c > @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, > /* Flush all packets from the tables */ > if (do_vxlan_tcp_gro) { > i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl, > - 0, pkts, nb_pkts); > + 0, &pkts[i], nb_pkts - i); > } > > if (do_vxlan_udp_gro) { > -- > 2.34.1 >