From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C92A45BC0; Tue, 29 Oct 2024 16:49:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D8F542E48; Tue, 29 Oct 2024 16:49:00 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 87FA640261 for ; Tue, 29 Oct 2024 16:48:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730216938; x=1761752938; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=QRLMmX2EtjKafJzme/hvpY7D4SPaLgqOWn0xuOa1YC0=; b=GnYCnmWi3vO2kUUKfXT7zKdR2QlzECrvJAflNfALDzZUDSi/850b4cUN SDVCTF+5Ij3qwZnlCsMYsN+hli2J8gUxyPUtFomYaSmejCZrP6p6YLb+8 pL9VZmIkInVQd5OcLTbnzGIUkT6ACXdBNwQ2ycH1y4w6qHdNXooBPJg// 5/5VKUZmZEFAqacC7UDMMltuUiHvtbkAVpD8hS0IuZe32xM3FxY/XpyaF 8qOGFC9PetAZjuxVh4Sr5BdzclZ1SjrfUV5A4LeSZ9G91aYGZrX96og4C OIHWGstI0VTo1LuujaVmZfvOymhXnNDkZUwdZq0KXAjp0DfWOtBkuuDAF A==; X-CSE-ConnectionGUID: us6LRnNJTYe9m6tIC41Xaw== X-CSE-MsgGUID: +Fi8vn8SRqCk9v4bSFqYKA== X-IronPort-AV: E=McAfee;i="6700,10204,11240"; a="47350428" X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="47350428" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2024 08:48:57 -0700 X-CSE-ConnectionGUID: 2vajjmKFRoCCVU5EH3/mfQ== X-CSE-MsgGUID: xSUxBeVJTxCc1SnVZ8eXvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="86771886" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Oct 2024 08:48:57 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 29 Oct 2024 08:48:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 29 Oct 2024 08:48:56 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 29 Oct 2024 08:48:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k2rYcCdWP99MMZt5W1jAPGfgx4fo/a0aYqDcaxFdyOlLNigTRro4+Q3zuis47/6J+vEUA9ioLYJJp+bdRMnmhiRctP1aiGXptC0IFBEYsOQe6QI1SKlL/+fe1HhWWiN1On21GNotkLG1mOh+9d25+KWST+B9EfOvGkrr3/NBMiW78VpbK2dQvie3FcuAFYlAekKey29hNrPfymGMPUT3ZHiwkHu7uT9sHxAXPhBouvNFsUeyocofnqwKg4rPztBDH+6zQewIX4+bLOeDX4T9hYHcyy1jbJrtYpPZHScwX+mBUUNPuB3wC5/owMR0+RfuVdnueNDKx/loj2NfAuHpSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f5PaAEuVO6pOWD9AIk1pSu2MdUyT84KNIukKGCY/soI=; b=ULf/TAV42DNTz7IfknWRaa9i0pcs37rlX0kiEpnPkG7Aj87xwBoiQknrPfYrJ0Pui4VCXZ0raMolrIgYOCgW/1gHVhDfJUnywJ5kAxyh+gzDNOHxeoOLY/t+CGVHZ2A28LMSHPiOvmseqLG5OWzVL4voJe3Wuu6fIbtxYCqvuam8uAfdk9YI8draU4DrnJaJQmOn3J03kUcKlmEQqWN/t2a/IVGDzgTB2N9EbCgDs8lhd2hNbqIpZuq/ORW+bsbrBfsvQsiBnD+We+MiX/4eiHgcqr0rXaNy1h5xp6eJlIQq+Gf2gMVS4jUmxJiygAeZ+Gx2zDAReaq+qrwPCJwQiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV8PR11MB8534.namprd11.prod.outlook.com (2603:10b6:408:1f7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.23; Tue, 29 Oct 2024 15:48:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Tue, 29 Oct 2024 15:48:54 +0000 Date: Tue, 29 Oct 2024 15:48:49 +0000 From: Bruce Richardson To: "Medvedkin, Vladimir" CC: Subject: Re: [PATCH v5 1/5] net/ice: add option to download scheduler topology Message-ID: References: <20240807093407.452784-1-bruce.richardson@intel.com> <20241023165540.893269-1-bruce.richardson@intel.com> <20241023165540.893269-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0040.eurprd01.prod.exchangelabs.com (2603:10a6:10:468::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV8PR11MB8534:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ea8a527-b4f3-45d0-161f-08dcf8313107 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QkCkmGUbnYScyOJpRNXYl4sx5ycS+67DE/g91sF6GnuMW8EQNi3wkcVgKrc/?= =?us-ascii?Q?1YEYHosiDdYEevkUQnJnl4NLkHbbOzLw4PqZxAbGpm8LpPHUiYoL6ms0FJwt?= =?us-ascii?Q?3ZAw5xERmaNU7yXcfJIqd2p48HhcVrEU3ZEH3ntBT/B9OvRd5dynpNx84iYu?= =?us-ascii?Q?BstcbWSSUVjuc7d4NGfGJNbn7r8tr7z8ytpaq3zBN5ivAVKw7lGkrtJ5Tx6e?= =?us-ascii?Q?XkwzHdANoFfvDCMrQJP7Ss4MNYrCBLBDRnCWbz+1tRVwpv75Eb1q4x3TkTpk?= =?us-ascii?Q?35XqO9e+3MhFHxSTA54/1FiJrLICrpxpC89cHVByXiIqDjphW7N1wwmpDmNc?= =?us-ascii?Q?Dohx8cCqLIgGplkmvlGWX583Ua/bGUnxWiXco3K4iKbGEA0xTaJWbHoOpSO0?= =?us-ascii?Q?EiT9Cdte3xMJKY//kxz/B1ZGV4jBm3duTGzhedPo+OMxrPU660LlF8j0k/qw?= =?us-ascii?Q?5i14zE9x0VQaU0zFl3Yg2sNdQXdWgOediozTSlQSpVQZzIVqCF3CliyCP+R7?= =?us-ascii?Q?Xj357c0GEboUUcstW+WVePOs6Wobl4G4BUzET6C3iWqYIvM9TuzK5irQYCsd?= =?us-ascii?Q?AeEKOOyLpk343PkISgXHNoHE2BZYu8ByW7Ngo68yfp+ZahI87F7bsv0KaM3C?= =?us-ascii?Q?71QjCkNLlwiOmWXj1yjD2RGx07yhkpDE4GEDuf+/V3Pc3/esbYBRZsR6SjtC?= =?us-ascii?Q?J9clPJjpc+SorDnM74nBGO2R4eavIO7bpIzNJFW59MWs2LSXesI02ZSwXX2K?= =?us-ascii?Q?hajKwD3/KDPjxebguraD6SuHHLca9est2XFFCySNCeDvTsWnkKomEkzfvhKe?= =?us-ascii?Q?W7FzC/INipRPapc7ta8b4HSEoLMdpHZkEJUMu/4DGqSlHcqsrb9uuoGlbek6?= =?us-ascii?Q?F3TMndPynwEIKefTOn2tW/1OWjVk6eF4O8UVuy071ygTh8UsoMtuPuwxdxzz?= =?us-ascii?Q?rRYXm5IxNshSUI1s2uEjOIk/HmqDPcs4h+s7DlWh8fjSw6qqI/1ZMioTIqyu?= =?us-ascii?Q?rcglEuiL6h+1uOwsnlMWRlltR2wDI70c5XdPsepupAOJ53ZOH+QZquSYiOMs?= =?us-ascii?Q?oYRlxLm2wE+dyzojAqT3Au2EHVR6KaOGxqGLkFJdARkHGcbttF9dtEVHSi6S?= =?us-ascii?Q?tV0FgOC0t1abxHfqXDHTR4F5gTR+wgjdEp73UumdXfyo6LhgQ16SmJL7TzLZ?= =?us-ascii?Q?hLWLYdkuNhqlvaXboDau17SOYtpsWi8bPiEOuoX0tsUdonhkCOQOtz89M1lM?= =?us-ascii?Q?fGLGc61CyKZUG97ZeYEFrm7JgXpEQqqB48CLIejjd35tdDM+y6JK2UrdEH2I?= =?us-ascii?Q?XwFr1g/7dfizEDkcJwIA7tXj?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lwsbbq3EO81UFPfBILai4rxP4KHPTinDc3E6u0PVm9/I4e9N5Foa/Aucl3X+?= =?us-ascii?Q?LsCejbMJkGLCLEke4AW4QebBhzoItfipcDFCkfajW3TALMMG2ZIdzWGb+INo?= =?us-ascii?Q?+JvM3FMN7wd/QEI6nwZ4HN5I0d7ILevTdx2RCyWbDrXy9MkjYjSWlV6dQc9B?= =?us-ascii?Q?/cyzK2JGAk3nEfPFgUgwZWlMYd6VI7OZvsgOn3FqZKnsEzXXuR4L8JVw75kV?= =?us-ascii?Q?P1bTEqViKNYt9ucByfShdh/AihdX9oLw63ZjFn1WQ6n4bFFUKWbJ5dyksp8V?= =?us-ascii?Q?NB5AcKdvqMJiz+/EiniMNnX5w3iCK2mFcw8NPjvHwdK11Bs3xL4sffmINXOb?= =?us-ascii?Q?AQb3CXE+GEDH6+hX2b6aNmCi9b02Ysyr/WbVGdY4D1GSjsqr/hsju6Am2ITD?= =?us-ascii?Q?ru8ooOr9zujtcTlGmamL3LU8MRh1l0LOMlgqO8sfix/1vmXanmcUCnhPZfqO?= =?us-ascii?Q?haw9n+JiG5sjrq6FH7o89zXV71SKLT+xk7K9XbY91d40qaL8EY3qhLEawFXU?= =?us-ascii?Q?qNPngQb2RbSkvfdq1HOq1CQHAsyrlITpLuwA0Kj0Xs7S7wFuEE23Nnx1DpLO?= =?us-ascii?Q?TII+GE4qksR92RKYrbR2ylMowmr6e/Xrk9p0v1356kpYTjtEdOgsLXh5olZh?= =?us-ascii?Q?Uj4FXndjur/ld9cJp3gkDFhQoZaGVNS628cgpn0TsnPyTQ9H+w/ESX7FNlG+?= =?us-ascii?Q?GFJj0fjvFrVzGSoJMjtGLhdD+h3I/NXX/QrnAw5v5/TGDc7tWGFe8VKiMRso?= =?us-ascii?Q?1OUckvIkFKwVIMA6ypccH/OTeOJV97WEdIIM8GTNOEXT75SYYXJY+ifA/g8N?= =?us-ascii?Q?6CJwucxsTMW+xS1BTI81rMAQHhUn1yJvZM2Gp4VrHB5CHwlYV2M/zNL7H72A?= =?us-ascii?Q?jwWeD2/WkWcylV6pxFdsJR4H9RdNdKC6W6mRPOfFHGMyaqlpfCjCbYc5ud/G?= =?us-ascii?Q?M4gEZsCVD+EUMpyLQI+6iMMF2n5O/PrT0FWzg3BHASucH2RJC7QggwW5nYaB?= =?us-ascii?Q?9VFhYik3FGajXrteKRX7/DZkB0Vpmp3nPsdUMXLOUmRoFm6DLMEU6L7rqnQv?= =?us-ascii?Q?F5Z9K8DIQOjU4GorAq2bW4IsGWIRzWkRAhq8+hTfhCjkM5ot3EF1KkCnqYkh?= =?us-ascii?Q?mJ7UF68oxPw0UCI2OekgFeXLeBcORTJzbhIKc51UikxZqciRZvbCoP5hjOsv?= =?us-ascii?Q?gdcA79l9QaZvEapocNqvw3rZV9DLMmD6n3Wy21S3U3TbeJwEmONga7gj1DVA?= =?us-ascii?Q?ZK0rNGZny/FKI89mqusY5/sS28N4EjGDLRziVFhbamc/SApNkZfSX/QlZ772?= =?us-ascii?Q?ey1kayQewLev397TaJziWYiyVdSJB+mNQcjbw9A8k+G7KEqDz4B2FD/H5ez0?= =?us-ascii?Q?YzrI5zeNNIpag+4/35lxjHa34yZyrnmoxC1lchZ7JU/4H96+6bIXugZRMIhV?= =?us-ascii?Q?rrFaR1A4PeEb8S8VjvEPVNzI2chtzcIxOwJiD1V9Owu5P1D0UNox4WfZglqW?= =?us-ascii?Q?L/HHhtj9eU9/hx5C9/NTmDWX/Khncvodd5vBKoooIXPKeJ8oT6nkWBUiA58u?= =?us-ascii?Q?M2mrD/vj2apmbVOibUkx1JatkAOMUKMVN7Li1paaXrsQiuTBWRnh5cnCOQf3?= =?us-ascii?Q?2A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea8a527-b4f3-45d0-161f-08dcf8313107 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2024 15:48:54.2696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SI7UC6SIHSIGFLiE0ClNPNI4V1BOigoiafrG7Qv6DGFKIqyV0W96A6hjLl14Swh52sr4ItuLDNAJdDX0Qk/5DjTm2yDHAqBOqqYCPmVArkE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8534 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 06:01:06PM +0100, Medvedkin, Vladimir wrote: > Hi Bruce, > > On 23/10/2024 17:55, Bruce Richardson wrote: > > The DDP package file being loaded at init time may contain an > alternative Tx Scheduler topology in it. Add driver option to load this > topology at init time. > > Signed-off-by: Bruce Richardson [1] > --- > doc/guides/nics/ice.rst | 15 +++++++++++++++ > drivers/net/ice/base/ice_ddp.c | 20 +++++++++++++++++--- > drivers/net/ice/base/ice_ddp.h | 4 ++-- > drivers/net/ice/ice_ethdev.c | 24 +++++++++++++++--------- > drivers/net/ice/ice_ethdev.h | 1 + > 5 files changed, 50 insertions(+), 14 deletions(-) > > > > > @@ -2030,19 +2032,18 @@ static int > parse_bool(const char *key, const char *value, void *args) > { > int *i = (int *)args; > - char *end; > - int num; > > - num = strtoul(value, &end, 10); > - > - if (num != 0 && num != 1) { > - PMD_DRV_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", " > - "value must be 0 or 1", > + if (value == NULL || value[0] == '\0') { > + PMD_DRV_LOG(WARNING, "key:\"%s\", requires a value, which must b > e 0 or 1", key); > + return -1; > + } > + if (value[1] != '\0' || (value[0] != '0' && value[0] != '1')) { > + PMD_DRV_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", value > must be 0 or 1", > value, key); > return -1; > } > > - *i = num; > + *i = value[0] - '0'; > > I think that instead of using char arithmetic, it would be better to: > > *i = !(value[0] == '0') > Not sure it's that big a difference, however I will change it. Any objection to removing the "!" there and doing: *i = (value[0] == '1') /Bruce