From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 2E9C64D3A for ; Tue, 9 Apr 2019 12:35:28 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id w15so793071wmc.3 for ; Tue, 09 Apr 2019 03:35:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xAvuhGuwHNJVb7OkuqDm0vlc2JMTWjH/14hpxOezR2g=; b=o7BjtFCE03hNXGXrstUQEVl4otD/oDEoFMOz4IrRURux0i3PeWpIll6ruifMzoB/Ik EcIEZInCOpu29uECzY54njuNonKgYMHuD+L6z9Sa48OP41QbODpAemI7BmajXnrK5Hit 9iKHtk2L/nmwdxeiWZyYYCnZpQr7iOg57BfVnWpK3h9wN2s/KrJKw6l/uZZJAQW1ppkH 686YQgv7fn7vHte+X6AZKfxxbzcrXjbZMeVFcIT0BpRze1crZB/PY3eohN9TvWVFPfSj Sv6mf5LSrd31CeVquIjuLqVktDoqDZbc4nkVMeS+DosSOMe6FgaA6gLp5rinotpTj2WZ acHg== X-Gm-Message-State: APjAAAVBuWdZ3eM92E4qAe7YFO0e9W8XFEGJhQwdXJXoPMVnxEUBG9ir NvuewIc02oA5JnmfRLJgyuA= X-Google-Smtp-Source: APXvYqypvdDEfOq7SKflwboaQd1t+w1ADDnbKqOHo91c2rJ1yl6JyAo78PaqoWhwExOjOU+g68wuFg== X-Received: by 2002:a1c:7dd7:: with SMTP id y206mr20942414wmc.81.1554806127825; Tue, 09 Apr 2019 03:35:27 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id t15sm31639956wrx.22.2019.04.09.03.35.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:35:27 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Tue, 09 Apr 2019 11:35:26 +0100 In-Reply-To: <20190409092933.55356-3-bruce.richardson@intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/5] build: increase readability via shortcut variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 10:35:28 -0000 On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > Define variables for "is_linux", "is_freebsd" and "is_windows" > to make the code shorter for comparisons and more readable. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > app/meson.build | 2 +- > buildtools/meson.build | 2 +- > config/meson.build | 14 ++++++++++---- > config/x86/meson.build | 2 +- > doc/guides/contributing/coding_style.rst | 2 +- > drivers/bus/dpaa/meson.build | 2 +- > drivers/bus/fslmc/meson.build | 2 +- > drivers/bus/pci/meson.build | 2 +- > drivers/bus/vmbus/meson.build | 2 +- > drivers/common/dpaax/meson.build | 2 +- > drivers/crypto/caam_jr/meson.build | 2 +- > drivers/crypto/ccp/meson.build | 2 +- > drivers/crypto/dpaa2_sec/meson.build | 2 +- > drivers/crypto/dpaa_sec/meson.build | 2 +- > drivers/crypto/octeontx/meson.build | 2 +- > drivers/event/dpaa/meson.build | 2 +- > drivers/event/dpaa2/meson.build | 2 +- > drivers/mempool/dpaa/meson.build | 2 +- > drivers/mempool/dpaa2/meson.build | 2 +- > drivers/meson.build | 2 +- > drivers/net/af_packet/meson.build | 2 +- > drivers/net/avp/meson.build | 2 +- > drivers/net/axgbe/meson.build | 2 +- > drivers/net/dpaa/meson.build | 2 +- > drivers/net/dpaa2/meson.build | 2 +- > drivers/net/enetc/meson.build | 2 +- > drivers/net/failsafe/meson.build | 2 +- > drivers/net/nfp/meson.build | 2 +- > drivers/net/softnic/meson.build | 2 +- > drivers/net/tap/meson.build | 2 +- > drivers/net/vdev_netvsc/meson.build | 2 +- > drivers/net/virtio/meson.build | 2 +- > examples/l3fwd-power/meson.build | 2 +- > examples/meson.build | 2 +- > examples/tep_termination/meson.build | 2 +- > examples/vdpa/meson.build | 4 ++-- > examples/vhost/meson.build | 2 +- > examples/vhost_scsi/meson.build | 2 +- > kernel/meson.build | 2 +- > lib/librte_eventdev/meson.build | 2 +- > lib/librte_kni/meson.build | 2 +- > lib/librte_power/meson.build | 2 +- > lib/librte_vhost/meson.build | 2 +- > lib/meson.build | 4 ++-- > 44 files changed, 55 insertions(+), 49 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 26C95A0096 for ; Tue, 9 Apr 2019 12:35:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 021224F91; Tue, 9 Apr 2019 12:35:30 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 2E9C64D3A for ; Tue, 9 Apr 2019 12:35:28 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id w15so793071wmc.3 for ; Tue, 09 Apr 2019 03:35:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xAvuhGuwHNJVb7OkuqDm0vlc2JMTWjH/14hpxOezR2g=; b=o7BjtFCE03hNXGXrstUQEVl4otD/oDEoFMOz4IrRURux0i3PeWpIll6ruifMzoB/Ik EcIEZInCOpu29uECzY54njuNonKgYMHuD+L6z9Sa48OP41QbODpAemI7BmajXnrK5Hit 9iKHtk2L/nmwdxeiWZyYYCnZpQr7iOg57BfVnWpK3h9wN2s/KrJKw6l/uZZJAQW1ppkH 686YQgv7fn7vHte+X6AZKfxxbzcrXjbZMeVFcIT0BpRze1crZB/PY3eohN9TvWVFPfSj Sv6mf5LSrd31CeVquIjuLqVktDoqDZbc4nkVMeS+DosSOMe6FgaA6gLp5rinotpTj2WZ acHg== X-Gm-Message-State: APjAAAVBuWdZ3eM92E4qAe7YFO0e9W8XFEGJhQwdXJXoPMVnxEUBG9ir NvuewIc02oA5JnmfRLJgyuA= X-Google-Smtp-Source: APXvYqypvdDEfOq7SKflwboaQd1t+w1ADDnbKqOHo91c2rJ1yl6JyAo78PaqoWhwExOjOU+g68wuFg== X-Received: by 2002:a1c:7dd7:: with SMTP id y206mr20942414wmc.81.1554806127825; Tue, 09 Apr 2019 03:35:27 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id t15sm31639956wrx.22.2019.04.09.03.35.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:35:27 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Tue, 09 Apr 2019 11:35:26 +0100 In-Reply-To: <20190409092933.55356-3-bruce.richardson@intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/5] build: increase readability via shortcut variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409103526.vF1s59_KjqqRbzDx4CDWi15cpPIknFsD9E_8lyQaW-4@z> On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > Define variables for "is_linux", "is_freebsd" and "is_windows" > to make the code shorter for comparisons and more readable. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > app/meson.build | 2 +- > buildtools/meson.build | 2 +- > config/meson.build | 14 ++++++++++---- > config/x86/meson.build | 2 +- > doc/guides/contributing/coding_style.rst | 2 +- > drivers/bus/dpaa/meson.build | 2 +- > drivers/bus/fslmc/meson.build | 2 +- > drivers/bus/pci/meson.build | 2 +- > drivers/bus/vmbus/meson.build | 2 +- > drivers/common/dpaax/meson.build | 2 +- > drivers/crypto/caam_jr/meson.build | 2 +- > drivers/crypto/ccp/meson.build | 2 +- > drivers/crypto/dpaa2_sec/meson.build | 2 +- > drivers/crypto/dpaa_sec/meson.build | 2 +- > drivers/crypto/octeontx/meson.build | 2 +- > drivers/event/dpaa/meson.build | 2 +- > drivers/event/dpaa2/meson.build | 2 +- > drivers/mempool/dpaa/meson.build | 2 +- > drivers/mempool/dpaa2/meson.build | 2 +- > drivers/meson.build | 2 +- > drivers/net/af_packet/meson.build | 2 +- > drivers/net/avp/meson.build | 2 +- > drivers/net/axgbe/meson.build | 2 +- > drivers/net/dpaa/meson.build | 2 +- > drivers/net/dpaa2/meson.build | 2 +- > drivers/net/enetc/meson.build | 2 +- > drivers/net/failsafe/meson.build | 2 +- > drivers/net/nfp/meson.build | 2 +- > drivers/net/softnic/meson.build | 2 +- > drivers/net/tap/meson.build | 2 +- > drivers/net/vdev_netvsc/meson.build | 2 +- > drivers/net/virtio/meson.build | 2 +- > examples/l3fwd-power/meson.build | 2 +- > examples/meson.build | 2 +- > examples/tep_termination/meson.build | 2 +- > examples/vdpa/meson.build | 4 ++-- > examples/vhost/meson.build | 2 +- > examples/vhost_scsi/meson.build | 2 +- > kernel/meson.build | 2 +- > lib/librte_eventdev/meson.build | 2 +- > lib/librte_kni/meson.build | 2 +- > lib/librte_power/meson.build | 2 +- > lib/librte_vhost/meson.build | 2 +- > lib/meson.build | 4 ++-- > 44 files changed, 55 insertions(+), 49 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi