From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF3CDA0350; Mon, 11 May 2020 10:56:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 192921C235; Mon, 11 May 2020 10:56:17 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id BB6251C1E9 for ; Mon, 11 May 2020 10:56:14 +0200 (CEST) IronPort-SDR: kb9iaGqdZOwsOkh49Vt/N3C1kChQGZfANwL+z+ZoLgJRYGPpTh2ELuoWU3R2axGZ8lHyAoofBc 3jj3jP9IxCuA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 01:56:13 -0700 IronPort-SDR: 1etyo+NX24hX0n6CK46GTs8ZA8M83I4PSDBsw2FGih6KXC22vdoikCX3i2RQXvFdVE6Ps+6+MA FXwoyR7ojxJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,379,1583222400"; d="scan'208";a="286204879" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.212.65.193]) ([10.212.65.193]) by fmsmga004.fm.intel.com with ESMTP; 11 May 2020 01:56:11 -0700 To: Stephen Hemminger , dev@dpdk.org Cc: pbhagavatula@caviumnetworks.com References: <20200508232505.2275-1-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: Date: Mon, 11 May 2020 09:56:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200508232505.2275-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] eal: remove register from function parameter in headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09-May-20 12:25 AM, Stephen Hemminger wrote: > Compiling a C++ application that includes directly or indirectly > rte_common.h will cause a warning: > > include/rte_common.h:350:37: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister] > rte_combine32ms1b(register uint32_t x) > > C++ pickier than standard C and flags this antique usage. > > This is a bugfix please apply to 20.05. > The register keyword is an old K&R legacy and should be removed > everywhere in DPDK. For now, fix it where it hurts. > Checkpatch should also be able to flag use of register keyword. > > Fixes: 08f683174e94 ("eal: add functions for previous power of 2 alignment") > Cc: pbhagavatula@caviumnetworks.com > Signed-off-by: Stephen Hemminger > --- I remember similar patches already being submitted, and the community has decided that 'register' keyword was worth keeping (although i don't recall the reasoning). Has something changed since then? -- Thanks, Anatoly