From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97F36A00C3; Thu, 16 Dec 2021 11:05:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D3CC40696; Thu, 16 Dec 2021 11:05:24 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 1738840143; Thu, 16 Dec 2021 11:05:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639649122; x=1671185122; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=HVdkvdb4Ddf3v7y1IoZsisTqQUUSxWjg1gUX1FkHZyo=; b=UTJTmlqfvEyvwKBjONbIPOAMXvX3gFtAsTVasUVR37Nf1av3FBqd8Z1R 40WpcymA/gjN/w7d9QgBnViZwcWyug6LpZ4CAfNpBdFbXJP+wyHBVuo6J TIGOnkmxVQoA8xtYOihA8yo71tICuOgMnUk4lhX+4IaYpLiFCrvXugISK e2rZpJYsEZVvAsXyCbyb2xFTGcpWWpk1ROrWugOFjIyC/LCe1tfpkAyZh 5SH7p7MElKuWBoWcl10WI0c5JwOEf4YQe2ft4FZ1LZ2IIWgcsSZUX8otu Ko64R4FZjLF0kr+jS+NZqmMo4dTkvh4JjZmioNLs7uiRgwjzN2dvIJZgT Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10199"; a="325734432" X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208,217";a="325734432" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 02:05:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208,217";a="662394132" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 16 Dec 2021 02:05:21 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 02:05:20 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 16 Dec 2021 02:05:19 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 16 Dec 2021 02:05:19 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 16 Dec 2021 02:05:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdKBVKtWyEiIqWtnXL+bPf9CoJDf9tqK/OiukePRG8H05sdICE3nmzUP35LebuYIewCO4K57blCM0GBifKTfzPvl9QzUyC4+ohpFbI06LDtfV4x6RaffUWG3EJvIjuMjJawpRB9knC/bpKI7ISG2GZZ8jS6wT6U/oj356hsPWoC03ykz3RsTfVBZR5V+Y3BbyNkwLOC7+GyLqntn4LJcj1Vry8ulZsWwqACBJ04esSr/Kqjtggmf0HwjGCWcX4ky+ihTMCYvZwUqD5S+8lHtXPvKDFOfslaQSgzH4j/mUnSEWZ3/aMPcEjF6MvSXffkGCLHBMoWitkhSik6FPJGiWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J75S/hkX/aJ8KFxpH1mrnzvfJuo6qQC40X5PXMJLdHA=; b=kpIKTSukqPsAMeARXoL9Z4+bAFdPu4dUbqe90TcMioTs/tLtGoWxJOIq2Td+leK97Wds9Pmgc/7hHJWXkeRIh+XwlgfLugdcJxK8vIKcpt1VgpyWVUE8tLeFYDeBnj7pvzJFM9KJxJTAk7UHafx0rOunNKZdbPmFURFgcObcUgbnJRz8G/Tnp95VFv+7UQFfnKG6I4V6ZsFNnbJy2IwnFAUfvNIQTtSeWxMLBaqiR6zUYRosTV4o0Snci4tj30smGlVrPG4W6fP4VJkDRpngwgD/Be2rIaaUD+098joaXkyPthEOJDQ3xnXGiDfO4Qoe6UtyFqOQyNDWBiJWFat0nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by CO1PR11MB5042.namprd11.prod.outlook.com (2603:10b6:303:99::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Thu, 16 Dec 2021 10:05:19 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::3d1b:65a0:5acf:2e5a]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::3d1b:65a0:5acf:2e5a%9]) with mapi id 15.20.4801.014; Thu, 16 Dec 2021 10:05:19 +0000 Content-Type: multipart/alternative; boundary="------------0IbeOf36JANjhzdRPnug0cqx" Message-ID: Date: Thu, 16 Dec 2021 10:05:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.0 Subject: Re: [PATCH v1] net/iavf: remove the extra symbol '+' Content-Language: en-GB To: Haiyue Wang , CC: , Jingjing Wu , Beilei Xing , Abhijit Sinha , "Declan Doherty" References: <20211216044342.25551-1-haiyue.wang@intel.com> From: "Nicolau, Radu" In-Reply-To: <20211216044342.25551-1-haiyue.wang@intel.com> X-ClientProxiedBy: LO4P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::15) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: edaf547b-01c2-41cf-e6e1-08d9c07b9079 X-MS-TrafficTypeDiagnostic: CO1PR11MB5042:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UwY9AdnLrmt1+ltC5dZCHRMXKzpwV9yfc0gYvcfzuTWRlWJBBOZBFriWCzqa1wfjcx7fdX9s3S4Tx6c24Zb4+NWJXx8SPHvOrEJUySZ9q+0Vbi6CV7jeAwlxCBkDK7c5p7aNd8lrKvyFFDzXmRAkjC3az9ItHdZAx9sXkAGwAS4Lq9zKwAxhPuXLASiW3kP0RUZ01twttgtkW5hmY0+udqC+X5kHgQqlyLXIj+8867WXi00yxsIG5tDf/e6ZwAbo3bo4lH8sPhHm+2lPMk2Z+pcf4+WnkkmhctBvZTwPDieXyMD8/E6iG8X3QMkwQ+taiZM+Y/eZ/oSzE0yDW3d51BXNkTXy5u+gx/TJM8yNR12zGp4nniV7szb851MqXzog/NpFqw7iIfFVhgNrAhgrgs2/pmj8LblNyde70/B0MtAJrqCnMDRhi8sk6e9/9ilmjFAzQ3Prw2LO3RoSpvRelPdBcg6rVYxx6kKjqv8vPUGKbZ7Pa7iH3dErLbN24NKgi4WpwgTAjg+aDX2hybdqm0H0Okdpc2K4LbfctrkCMhcIU+k5PYE521tMYOTBhWfMRrRMkFVTpUbH5s0RYddpqo32zH8KNK7+5H1f8N5yFGTguJWvNqaRcZLl8IXsp/AozGZeYkyN7XOmRGYr6zI3wMO+Y3A1VhKSIB1CK5lljb/RBvHy0EY20avLRP6P1NWno/w6PfOzmn4SJCqQ2KVMj0lpx7KrTgnu4zlrGH2cYE0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(53546011)(8676002)(36756003)(6506007)(450100002)(8936002)(6512007)(107886003)(31686004)(316002)(4326008)(26005)(82960400001)(83380400001)(86362001)(54906003)(6666004)(31696002)(186003)(508600001)(55236004)(33964004)(6486002)(38100700002)(2616005)(66476007)(66946007)(66556008)(2906002)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTVyUTJ5eGRSaVcySCs1SHNKRG92S3BFR2swUGw3YUUxd1JuUjAyalhYRnc4?= =?utf-8?B?VUF6OVlZMGlEUGVTdk9jOGJCcnhXZWZPNk01dFNLODQ4NCtMQ3dDSlpZN2Mw?= =?utf-8?B?TWJXRE1mYTFwUWZhMmdmOGc1dEZJcmRCVXU0dFFtSFdhZCtwZDlwbEk3cXc2?= =?utf-8?B?OFlCcm5zRGgwTml4SDhXQ3Q5eWxaWDhLQnVlNEsrWUo5VjdqRmxITVpyREJs?= =?utf-8?B?NDgrUGZrdklJZCtiYk80OEtTRWYxTFE0aU9CaytKTlhLSkxNTFpqdGtkUm81?= =?utf-8?B?djhtd2srdE1GRCttRks2cG9KTFFFUFBFODRpQmthUXBTVHpnZ0dGN0Z3SUxV?= =?utf-8?B?d05TNWRsNitMWWlvVlRyQlY2SVhqZUF0WkRjSmx0enBSTFJzSDlaK1R5S2sr?= =?utf-8?B?Wi9nR0pPMTdwb0JoTDQ4QnFmUjBHdnFhbTB3YjBjVEpuVGR1c1ZucEN5L2NU?= =?utf-8?B?M0Q4SllFWHNuMVBkK3JZOFNlWWFYajRmKyt4SVRKRXdwTDkweUxIbEhqTXNC?= =?utf-8?B?eFNkOUt2U0ZrWjh6dXIycW93NlpITVpERisyazNxWWZ3NDVOeDRGdHlaTS9O?= =?utf-8?B?b1BVRXFQMktxajdhdFhUd1Vta3A2cGJxaEJwdUs3cXJ1ZTlzT1lwZUJkQ3VN?= =?utf-8?B?QTlUOTlIZmRFem1zWndNZU9XQ0sxYVBQeGY0bW5IUzFPaS9wZ3VuU2RWN1RF?= =?utf-8?B?SHlUL1o0c1hKQXlRRkxOOG5SR3JSeC9seEpSVU9WenZ2QlBsaVZxUXFBWFVr?= =?utf-8?B?c0pSeXpNTUkxMUFhc1lpRG0xbitZeDBETUpTME1PNVhuMmRTTnVKcW9Wd1du?= =?utf-8?B?YURpSG1yMGRjb1lBUzZIOVRHcWNianZ2bkQxUXhDZ2h1R1N5L1krekNkbDVL?= =?utf-8?B?NWN2cUVHTGRNeHhlL3Y4WjA0MjJ6ZWNkc0tIb0MwWmxIYkNIckJ6OGw1WWpU?= =?utf-8?B?WWI1NzZSeEZjZVBhdmxlb1RydVZIWGsySzArczRTYTlhM2NEZ0doQlh2eWpO?= =?utf-8?B?bG1rR1VjbW50Zk1JTHJtN3hwZUVETWF1dytBSHRRekJsK0dQR1JwR2o1OVdS?= =?utf-8?B?WXIwWnZjN1daaUo5VjVUY0NNZkpGeXB5am1tK2NRK0E4M0wzNE8wa2szZDVR?= =?utf-8?B?UXVjZlNRc05aUTBoWVRIZ0pPc3lWTE84cWZab1pQRmd1MXA4bHluZXdHRHlz?= =?utf-8?B?YlR0MzdZYndmaWhKcUxvOVRuVEFBS2ExRCs4VnRLZm0zMzRKLzZGNkJKZy9i?= =?utf-8?B?Wk90SDNWM1JibXJIREttUnpHcFlhWUltNDQ5WitFRFU4aVgzMUJhSEdDbEtX?= =?utf-8?B?VEFCN2I1bjVnZS9TLzJ1QW1RTVFIVEJFMGxVcE5RVmF5MFZjalpYcjgzSFhu?= =?utf-8?B?UzgyL3VwTU9CK2E5U1NYR0xmTjRtajZ4NGVGQ2NmSEJoTklIbnpaSFZxM0tL?= =?utf-8?B?Y3ZjeHM0RWw5Mk9Kd1l3c2Rjc3AxVFRzRGZBQzY2VTNzRWtZS0Naa1Q4dUJT?= =?utf-8?B?Q0luQk1saDhlNmpsckZodzBzdzE2NGUrSjczTkdVRFlZaWlyeDhlODNyN0dG?= =?utf-8?B?TzVib0dWLzk2MGZZWmw0Ym13RURqaHlEWFl0MnpWd0dsZkZiZ2RNNEYrNlZR?= =?utf-8?B?UXUzc21CQWFZN25iRzFKNWJLeUZPMlozUzVZYTdmRFNpbUpiUlFVNjhqSldn?= =?utf-8?B?T3NOT0c1REJ3bzAxR2FpVVFic0lYanhsZFoxY01DRFNGM29vQlVJVUNFek9D?= =?utf-8?B?M0VEbWIzZU1sdjlSOG1SckNTSjBtS2gvZUN4Z0lYMCtHL09SQnRJRTlYUnBu?= =?utf-8?B?eDYxQWVDVWJQdzdyZ3VQNUVnUHN2ZXF5eFJIYmtsN3JnelF0Mm94Y1N1OTlX?= =?utf-8?B?Yy9zbWJoSTdhLy9KMSt6dG1seVRGLzhxVjNpQUpnREp2RGhnUC9TWkUxQU4z?= =?utf-8?B?ZHlWR25HdU5UUTJjVFdRNk1hR3hqMFF5VWtIOTVLSmNXOG1CQkFqZ0I3bkc5?= =?utf-8?B?V2cwN3F3U0ZXQStpR2lYMDdYL0NoRklnWHhVdnFSMC9LeFF6TDBrODZySCt3?= =?utf-8?B?S2E1d0t6MXlYQ2ZEemlNK3RyQzdrRFVVVGxNaE1YblZiRWJrMTVNY1paWnhU?= =?utf-8?B?Q2MzY0t1RjQyWjdkWVJmNHZyRDBtbmNPVHJIRXJGb2tZaE5pc3dsNWdrQy9C?= =?utf-8?Q?zzkwvBw9+hg86EtcAj4QAP8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: edaf547b-01c2-41cf-e6e1-08d9c07b9079 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 10:05:18.9184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eckJMDic2cWrmbPV0nBbPwuIIRSsl5KgI0W/wnBxo82rnc4NP4FxGQf6eSahDSR+7XkaCm/atz3PYvaQZ1l72g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5042 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------0IbeOf36JANjhzdRPnug0cqx Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 12/16/2021 4:43 AM, Haiyue Wang wrote: > This extra symbol '+' should be added when patch was reapplied, and the > compiler treats it as unsigned type, so the code still runs well. > > Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") > Cc:stable@dpdk.org > > Signed-off-by: Haiyue Wang > --- > drivers/net/iavf/iavf_vchnl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c > index 145b059837..8fdd6f6d91 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter) > VIRTCHNL_VF_OFFLOAD_VLAN_V2 | > VIRTCHNL_VF_LARGE_NUM_QPAIRS | > VIRTCHNL_VF_OFFLOAD_QOS | > -+ VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO; > + VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO; > > args.in_args = (uint8_t *)∩︀ > args.in_args_size = sizeof(caps); Acked-by: Radu Nicolau --------------0IbeOf36JANjhzdRPnug0cqx Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 12/16/2021 4:43 AM, Haiyue Wang wrote:
This extra symbol '+' should be added when patch was reapplied, and the
compiler treats it as unsigned type, so the code still runs well.

Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/iavf/iavf_vchnl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 145b059837..8fdd6f6d91 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
 		VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
 		VIRTCHNL_VF_LARGE_NUM_QPAIRS |
 		VIRTCHNL_VF_OFFLOAD_QOS |
-+		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
+		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
 
 	args.in_args = (uint8_t *)&caps;
 	args.in_args_size = sizeof(caps);

Acked-by: Radu Nicolau <radu.nicolau@intel.com>


--------------0IbeOf36JANjhzdRPnug0cqx--