From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F63643263; Wed, 1 Nov 2023 18:57:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AE8F40282; Wed, 1 Nov 2023 18:57:13 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85]) by mails.dpdk.org (Postfix) with ESMTP id 25D5A400EF for ; Wed, 1 Nov 2023 18:57:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJIB8MA6GXbhmr5ZRESk4MSsrTfHEb+IsHrIHg8fjgOsVzr/6TCk17MkyshAhyECqNIeYFOGrjgPH5GUr6VEdtCxkfS4vAnkvTrPA0hIhTzLWeH+/WXvpTv5N31rJsHg95xn7u1aA7/oPPntei37hZwqPasGWB3MATolhOf25szvNNFDKbT6fktPpgukfBG7w9dJXXYlxE9g5DrWCQfTat5u8QOcWGPE4MfUHc/Q/toRwyndlYYIcLgNhB3DjwBce5+6RF0kPFdW6WfbfYsk6ADZ4h2P1VJnmdugH3crjuPmMr/vhAznrr8DL5G1Jw8i2cqubQ6sLrdKa+xF9YfRvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oVEOy6uzpeuz8Iiunpcf6DcDSe+4mfBctj+qaGTtnn0=; b=F57L5wB8mJeEvYR7CFA+4io8fmXhb5Pch1KbalZiWfXqFG3va0eC4hDPWu2WVTbpu5XdMWu7oxBR/St2F6z8kCmb52hKss80FzLIuLW8AFl3c34kcQ51dBU6X5teNCRU+biwyLsiJCWT2AGJSjiNwCTMTJkCH3sP0p+GZwtjjN9Xi8vNxnH6NqWhyAs96gcSwXTZvDBjPex+76uXXTuxj8WIjF4WifE7B/Qsib1yOLfwSFkAPFqGM7KvH9lSyf/jFXZqHJvWztjzMm0YmjLF1tnmyjYdy7zjk/n2IVtYSx3/2SR736Pln9IPOdJH6I5PESbuh0JG51dCPOLBCP4AnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oVEOy6uzpeuz8Iiunpcf6DcDSe+4mfBctj+qaGTtnn0=; b=aHM2UbpuEKI3CkrNssL44ftkSpdTT0e8w9vWV3VsSpp9TzdXEMG2p4Cnr7NER4Ro5UkjOYfETJLscroYQZ1Fgn6UqSkLlLTMeCUJ7HfVVcZCg+XxvyPoC0c8Dplax+gtgRFq8mO60w9gAg432svNYIUO0IAJ9qJMYTR+EahHvDI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB7577.namprd12.prod.outlook.com (2603:10b6:208:43e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29; Wed, 1 Nov 2023 17:57:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Wed, 1 Nov 2023 17:57:08 +0000 Message-ID: Date: Wed, 1 Nov 2023 17:57:01 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/11] net/nfp: remove the unneeded data abstraction Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Peng Zhang References: <20231028061558.1842855-1-chaoyong.he@corigine.com> <20231028065315.1937188-1-chaoyong.he@corigine.com> <20231028065315.1937188-5-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231028065315.1937188-5-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB7577:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cb36703-ef81-40b6-0522-08dbdb03f6d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0PUrWcPP5bAbBYJtgbFvXI3c7ELGZ5zgBBlORc3hmewYn6uXDGJg7BdxO6iVZVzpVkVUYrxqK1zWv+jorADQ2/alksYFESi/ez4O8bsYKRcpbdjKKO0pZXKdZQScNn9EBMlmlOPomYnPPz47V+2u/d8Y3dN8/wSSBZxcLcu33NTlVg3LBSIDhcZcLZTr8RlNm6WdNS0yMmFdIUgSdKGuRVhZE4f2kKblkgUDl7LYTrdj3SAkt5Y3SIUqasAWuLAJmpa8ksSlxj++CcauxJIQnf2fQTJv7ymr5EsUBNMaoT3SAMuS9jJ1wQfSMp1qHis4JWpVyfC16bvi2E+DjnA3jyv6AV/gg3oF7Dp3lNdzawJqd0sMLXxfjLz1jsDxN0toA/k0ftLLLVoGVmt8VYfoXU9z7w5SMQb2ohWHYRspt5g6/eQ4eRjQfECF7ibLdCjoMxq49ZSGjA8B21lUrJWriDSjdrd95UVn88qTtYI6o7b5bHq7FyjQK50ZAxVGkn8ZpEL8f5s7/JQLgZjg+zzoRSysBaWpy2K8XOgVsxgW77nNjAxj1gHfVLw6/ZtF/WOjb/HTq1eoggtqy0Qsu/n5uUFSKWtkg6IjpDVN3vQvFZvmr60MtTe4wkYsGXeDqrM6eTy463W7LOJEWpcFV+kKm8wxPkC2WGD4DTh98Ot3pJO/DnAVWmITZjE0k36aXZjn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(366004)(346002)(39860400002)(136003)(230922051799003)(64100799003)(1800799009)(451199024)(186009)(31686004)(6512007)(26005)(38100700002)(36756003)(31696002)(86362001)(6486002)(4744005)(53546011)(478600001)(6506007)(8676002)(316002)(6666004)(8936002)(2906002)(2616005)(66476007)(4326008)(66946007)(44832011)(41300700001)(66556008)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVFMelBicGt1TVlhNWRXOGRHUlY1anJra1d0SHdsNVZ6aUU4UHBuY1R6UnMw?= =?utf-8?B?eitDdW5BREdtU1VIelJRSjdkVGhMeldSbGduNFNDUExuRjBacUdnbnQwaExG?= =?utf-8?B?dmRvZ1NiTkpxSVZJcUo5Kzh3VWZad01rSVM1dzBDZ1l5eEIzc3JEb1R1QjJx?= =?utf-8?B?QlZzOThrQUFQcHNISDBQTjI0emhGcWJQR1JYcnhEaEFSL1ZpcXExdzN0TkFI?= =?utf-8?B?V1llbWJ0YURWRzZvWUpER3hNVURyckNuazc4NG5uTzAzSFhxVGhQN2E0N2hV?= =?utf-8?B?OVIzTlBsVlZCQ0ZKWU1vcUF1NmIzK0J5eUNFT3lKa0N2NVcrQkZoK1M3WHRH?= =?utf-8?B?dXpYYmxUbFBoMEJYMlh1N1prNFZRaDJuKytCK1FyczJXWkZhczUyR2RWbVpo?= =?utf-8?B?WG5RS2hTdUVrUzFsQS85a3NSeERuUnhMK0ZnU1RlaUEwN09CMEp2Qm84cnpt?= =?utf-8?B?UmpiK05vVFhuaHBNVWVvYm5SZlludWJEbTRWdjBVODFWQTYvWm5MOWFaVlpO?= =?utf-8?B?OXk2ekR1aHN5RGlOOWJUZFhPUzdjV2Q4N1FRSWYxbTFFNnc2UlRDWGV6ejhu?= =?utf-8?B?K1QvME1sY0hISVhXYVdzYlM3eFBFSWNpWGt3ZXFscENZUUJjU0ZsbXQ4V0k1?= =?utf-8?B?eXZNdEhZRmN0SXQrTEhKWUJBVWhBYlpFeUppZ01SWVpSUmJaSTZEU3pOY09F?= =?utf-8?B?NjJIcUNkTW5kUG14ZVlPZ1UvRkJxcTh2SW1FNVplZWhEeFVYdmZRQUJ1ODV6?= =?utf-8?B?UFdpdHc5WjVFenZ3Mi9EMzVwSURFMWVpM2pYaE50Y1IwcU1VS3hLKzFxdVVL?= =?utf-8?B?YXFzM3FBUkRmcWNGelNNUHptQlY3STdVbEVDNENxK2JzaXFmb2c1Q2c4RWdU?= =?utf-8?B?blRvV0dSL3NwMW5QMy9HQzYwcnNwSUtIK0c1bElrdXVzUWQzdStmejUxKzlM?= =?utf-8?B?TWZqQXRuVWkzU1krMjJveTJKMHFkYWJjY1FscUpEelNXd2JWK2ZodjRzMXdq?= =?utf-8?B?M1FXRGJIRUdXTVFQV0VVVHIwMWp4OHVzK29zb2FPcmtNR21ITVBtckZZRVNE?= =?utf-8?B?UVhCYVpzNWJnRXU2Q21mbUhaWXZDcS9qcnJrUFJsVmwrRm5yb1kwYUJFWERR?= =?utf-8?B?Zk11WUNKTmZKaktQU1hoNXFEbEl5OG1DSUZ3OWZ1UzlmM3BWcUVXVGxrNHhp?= =?utf-8?B?eTRVNW9UNzh4MHZwNVBTSlBDK2dmKzUrOVdja0ZwdTh5YmpuaTFXZGNJejI2?= =?utf-8?B?NFFtQzVMVEkxMUZDWEExcjlYd1NvRXloSXg2RWlhU2NOLzZ2YTQveFc0c3p1?= =?utf-8?B?ajFLQWp4VFRXWHBvNXVSS1gvbzlyZW8wcW1iaG5nZnM3d1VwOTVUTTlucUdU?= =?utf-8?B?ZmM0b0lwcU5QU05mZDRLMWNROUVQNGorZWdqcWlVV3hMTk0wcmdWYkhUZkxi?= =?utf-8?B?VHBZU2lUczNRWUdYOU9UTmczWXNROUxSem9FWk9MNXE4WDdPT0QvMVZJWTNU?= =?utf-8?B?SGxQK2lBcDA3NkF0L2F1YUwvQzhTZjB4WnRwbGlLYTVzU1FUd3l3T1pPVTFp?= =?utf-8?B?Y3VxRUt1N1RwTGE2QmJIUFYzbE9rendjRytWdUZBaDBJMUdiQnEzS0ZDNWdG?= =?utf-8?B?Q1U5ZVFtbDJ5Y3c4S2FqMmYvVGFBbzFZMGs4OFBCZkdSaGw0YnVoRmFhdVJ3?= =?utf-8?B?b2d3OXJ0dEMxditETWJmcFo1VW1sUVF5ZzBUVkV0Zm5YU2Q1RXVjMUs3QlZM?= =?utf-8?B?QnVNVGRzYkFJUkpraE9YMHM0WE1DamZZWFk3MnRZODJuUkYwRXRTRjFLQWI4?= =?utf-8?B?SThUbTBCWkJ0b09rdTVLcHJ1Qk1maitqUWgzYjIrdnRGS2dXN0JLNXh3eWhs?= =?utf-8?B?TGtIeUJBdG9rMmphOTh6TW1jRmVmTGZRYVV6RktFSnlDYzRLQ2NZQmZtSHR1?= =?utf-8?B?aFVSaHFoR0E0S0s4Ly9OTFN2UVA5dkJ1ZHhKbmVqSmdhYlkrQmJ5QXpqNHoz?= =?utf-8?B?NVFuM2lpZFZsTnRyc0V3REJLQ1FmbWVNbEJ0TDRuOWFtaEZ2ZGNhMWtJRit0?= =?utf-8?B?clpPdDErUEx0ZGFnY2kxMnZIdmRyejhhMzRLKzdGY3lNVWZONTJ5SHY2RzBU?= =?utf-8?Q?z+t+dbP7L2t2nUIqMrIh/mQWm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb36703-ef81-40b6-0522-08dbdb03f6d6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 17:57:07.9145 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6hPxcZAS2PYt9T6atXybz+dDNDrSmhrB49z6YetkY2IHmP6ZAtKy4PRbyHDj8GhK X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7577 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/28/2023 7:53 AM, Chaoyong He wrote: > The data structure 'struct nfp_net_adapter' has only one data field and > we won't extend it in the future, which makes this abstraction unneeded, > so remove this data structure and the related macro > 'NFP_NET_DEV_PRIVATE_TO_HW'. > Mentioned abstract struct, 'struct nfp_net_adapter', is not removed in this patch, although mentioned macro removed. Since there is not user of the struct after this patch, I guess intention was to remove the struct, so if there is no other issue I can remove the struct while merging. > Signed-off-by: Chaoyong He > Reviewed-by: Peng Zhang