Re: [dpdk-dev] [PATCH] compress/isal: fix getting information about CPU

[Akhil Goyal <akhil.goyal@nxp.com>]

On 3/29/2019 8:58 PM, Daly, Lee wrote:
> Hi Tomasz,
> 	After some testing I can now see the approach in your patch in the best method for getting the CPU info.
> Rgds,
> Lee.
>> -----Original Message-----
>> From: Daly, Lee
>> Sent: Wednesday, March 27, 2019 3:01 PM
>> To: Akhil Goyal <akhil.goyal@nxp.com>; Cel, TomaszX
>> <tomaszx.cel@intel.com>; dev@dpdk.org
>> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
>> Subject: RE: [dpdk-dev] [PATCH] compress/isal: fix getting information about
>> CPU
>>
>> Hi Tomasz,
>>
>> 	This patch makes sense to check does the CPU have the capability of
>> certain instructions before Adding it to the dev_info flags. I think one more
>> addition should be made in isal_compress_pmd.c When checking what
>> compression level should be used , decided by the AVX instructions available,
>> it previously used the
>> Rte_cpu_get_flag_enabled() function, however, I don’t believe that is needed
>> any more since it will now be checked beforehand, it would be doing twice
>> the work.
>> When the driver now needs to decide the compression level it should now
>> just check the feature_flags set below. Perhaps a V2 could be sent with this
>> addition.
>> Regards,
>> Lee.
>>
>>>> This patch adds query about CPU features
>>>>
>>>> Fixes: 53a9baa98c36 ("compress/isal: add basic PMD ops")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
>>>> ---
> Acked-by: Lee Daly <lee.daly@intel.com>
Applied to dpdk-next-crypto

Thanks.