From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com,
nicknickolaev@gmail.com, i.maximets@samsung.com,
bruce.richardson@intel.com, alejandro.lucero@netronome.com,
dgilbert@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 06/19] vhost: define postcopy protocol flag
Date: Tue, 9 Oct 2018 13:47:58 +0200 [thread overview]
Message-ID: <a0ddb462-c194-2524-169c-8b35467b4910@redhat.com> (raw)
In-Reply-To: <20181009114129.GB32180@debian>
On 10/09/2018 01:41 PM, Tiwei Bie wrote:
> On Mon, Oct 08, 2018 at 05:25:44PM +0200, Maxime Coquelin wrote:
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Acked-by: Ilya Maximets <i.maximets@samsung.com>
>> ---
>> lib/librte_vhost/rte_vhost.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
>
>>
>> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h
>> index b02673d4a..b3cc6990d 100644
>> --- a/lib/librte_vhost/rte_vhost.h
>> +++ b/lib/librte_vhost/rte_vhost.h
>> @@ -66,6 +66,10 @@ extern "C" {
>> #define VHOST_USER_PROTOCOL_F_HOST_NOTIFIER 11
>> #endif
>>
>> +#ifndef VHOST_USER_PROTOCOL_F_PAGEFAULT
>> +#define VHOST_USER_PROTOCOL_F_PAGEFAULT 8
>> +#endif
>
> Do we want to keep these defines sorted? I.e. define it after
> VHOST_USER_PROTOCOL_F_CRYPTO_SESSION (which is defined as 7).
Yes, makes sense.
>> +
>> /** Indicate whether protocol features negotiation is supported. */
>> #ifndef VHOST_USER_F_PROTOCOL_FEATURES
>> #define VHOST_USER_F_PROTOCOL_FEATURES 30
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2018-10-09 11:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 15:25 [dpdk-dev] [PATCH v4 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 01/19] vhost: fix messages error checks Maxime Coquelin
2018-10-09 8:03 ` Tiwei Bie
2018-10-09 12:20 ` Maxime Coquelin
2018-10-09 12:54 ` Tiwei Bie
2018-10-09 17:53 ` Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-09 8:05 ` Tiwei Bie
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-09 8:12 ` Tiwei Bie
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-09 10:21 ` Tiwei Bie
2018-10-09 10:30 ` Maxime Coquelin
2018-10-09 10:34 ` Maxime Coquelin
2018-10-09 11:02 ` Tiwei Bie
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-09 11:35 ` Tiwei Bie
2018-10-09 11:47 ` Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-09 11:41 ` Tiwei Bie
2018-10-09 11:47 ` Maxime Coquelin [this message]
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 10/19] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-08 16:22 ` Ilya Maximets
2018-10-09 7:59 ` Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 16/19] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 17/19] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 18/19] vhost: add flag to enable postcopy live-migration Maxime Coquelin
2018-10-08 15:25 ` [dpdk-dev] [PATCH v4 19/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0ddb462-c194-2524-169c-8b35467b4910@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dgilbert@redhat.com \
--cc=i.maximets@samsung.com \
--cc=jfreimann@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).