From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C3BAB1B4F5; Tue, 9 Oct 2018 13:48:13 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED8B43091745; Tue, 9 Oct 2018 11:48:12 +0000 (UTC) Received: from [10.36.112.57] (ovpn-112-57.ams2.redhat.com [10.36.112.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DCE3D5B2E7; Tue, 9 Oct 2018 11:48:00 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org References: <20181008152557.14275-1-maxime.coquelin@redhat.com> <20181008152557.14275-7-maxime.coquelin@redhat.com> <20181009114129.GB32180@debian> From: Maxime Coquelin Message-ID: Date: Tue, 9 Oct 2018 13:47:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181009114129.GB32180@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 09 Oct 2018 11:48:13 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 06/19] vhost: define postcopy protocol flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 11:48:14 -0000 On 10/09/2018 01:41 PM, Tiwei Bie wrote: > On Mon, Oct 08, 2018 at 05:25:44PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Dr. David Alan Gilbert >> Signed-off-by: Maxime Coquelin >> Acked-by: Ilya Maximets >> --- >> lib/librte_vhost/rte_vhost.h | 4 ++++ >> 1 file changed, 4 insertions(+) > > Reviewed-by: Tiwei Bie > >> >> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h >> index b02673d4a..b3cc6990d 100644 >> --- a/lib/librte_vhost/rte_vhost.h >> +++ b/lib/librte_vhost/rte_vhost.h >> @@ -66,6 +66,10 @@ extern "C" { >> #define VHOST_USER_PROTOCOL_F_HOST_NOTIFIER 11 >> #endif >> >> +#ifndef VHOST_USER_PROTOCOL_F_PAGEFAULT >> +#define VHOST_USER_PROTOCOL_F_PAGEFAULT 8 >> +#endif > > Do we want to keep these defines sorted? I.e. define it after > VHOST_USER_PROTOCOL_F_CRYPTO_SESSION (which is defined as 7). Yes, makes sense. >> + >> /** Indicate whether protocol features negotiation is supported. */ >> #ifndef VHOST_USER_F_PROTOCOL_FEATURES >> #define VHOST_USER_F_PROTOCOL_FEATURES 30 >> -- >> 2.17.1 >>