From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id BA0051B212; Tue, 10 Oct 2017 13:05:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=866; q=dns/txt; s=iport; t=1507633546; x=1508843146; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=qCk3U7o7stc2II4oOggDgv7Pkn7bu+qAYKHys547uqE=; b=HkMKkNzhLzXVwF7w/yKWRrV5/P6F4BmXNqF28MQsJOd9BOuhGnMambyS /xGV0jQZQ7Xe+8VokTtjj0uOTT0VdagByKR6+Wts6+XhAuX6dGI2ZEOmT EnVk2m6g4awTgzNnnmGqbNlSCnTkrvA/RdpzbK+04iRZAzpqdQtdONc7b Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CcAQB9qNxZ/5FdJa1bGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1tkbieDepoTgXaWL4ISCiOFGAKESUAXAQIBAQEBAQEBayiFHgE?= =?us-ascii?q?FIw8BBUEQCxgCAiYCAlcGAQwGAgEBiiAQp3uCJ4sjAQEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBIIEOgh+CAoFRgWorgn6IF4JhBaE8AodcjQuCFFyFF4Nahy6VYYE5IQE1gQ5?= =?us-ascii?q?4FYgCJDYBij8BAQE?= X-IronPort-AV: E=Sophos;i="5.42,504,1500940800"; d="scan'208";a="14959959" Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2017 11:05:44 +0000 Received: from [10.150.214.100] ([10.150.214.100]) by rcdn-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id v9AB5iDJ010216; Tue, 10 Oct 2017 11:05:44 GMT To: Bruce Richardson , Qi Zhang Cc: konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, stable@dpdk.org References: <20171010132205.72173-1-qi.z.zhang@intel.com> <20171010084807.GA34984@bricha3-MOBL3.ger.corp.intel.com> From: "Roger B. Melton" Message-ID: Date: Tue, 10 Oct 2017 07:05:33 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171010084807.GA34984@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 11:05:46 -0000 Hi Bruce, I can.  It will take a day or 2 to get the results. Regards, Roger On 10/10/17 4:48 AM, Bruce Richardson wrote: > +Roger Melton > > On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote: >> vPMD tx does not set sw_ring's mbuf to NULL after free it. >> So to prevent same mbuf be free again, we need more carefully >> check in i40e_tx_queue_release_mbufs. >> >> Fixes: b4669bb95038 ("i40e: add vector Tx") >> Cc: stable@dpdk.org >> >> Signed-off-by: Qi Zhang >> --- >> v2: >> - fix at i40e_tx_queue_release_mbufs so no performance impact. >> > This patch also supercedes this one, http://dpdk.org/dev/patchwork/patch/29814/ > right? > Roger, can you please confirm that this alternative fix works in your > testing and that your patch is no longer necessary too. > > Thanks, > /Bruce > > . >