From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55862A0C4D; Wed, 13 Oct 2021 01:26:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20D3640150; Wed, 13 Oct 2021 01:26:18 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 5FC9540142 for ; Wed, 13 Oct 2021 01:26:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="226070408" X-IronPort-AV: E=Sophos;i="5.85,369,1624345200"; d="scan'208";a="226070408" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 16:26:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,369,1624345200"; d="scan'208";a="442057028" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 12 Oct 2021 16:26:04 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 16:26:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 16:26:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 12 Oct 2021 16:26:03 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 12 Oct 2021 16:26:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=miOCzv3wMv/dp3ngypuq6aT2/jRhGMFgDTSLaxP36kpql8ecKw4ZX0IosXoNqQc7zABzXlWIDodeMv8wCrTk9Zf8HYEZXv+2SQEkOwHcHxHQdd20dJnYbyOY8PP8vzopqB0+JaJbCMbJnDSG2TEFZbyWnbkKKF8LOHPR7N3Xt4FxfRCUQbi3NpNPUcVeIdsMxlylPMMhAbTKAXPsRAICVbMlwRPd36oZ4MKQhPxWuhnP4QkTXzZSVfbCCx5gdqrRE1A1Z7NM5AKCIK5RZs8rXQuo/OULdSsEBw++gFHEbUx7W4ZKz0DJzMoAAUI/8VYDtHe+0hFZ22YHEBKXooL6iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WcwssK86+C38/0zWuG0TQ0YcR+9jUysSd1dJ7Ddf1fw=; b=CsObvi0h2CLuk7B6sYTA0lgDAZGJX8ndyLnUz5vnz2sPIfce1lKhH+eEs/pKrY5bA6bdst9Q048szPNUIbihRTYxtQ3TncMmpdtH5aJCS1YoPj2ZCqK7fVVbHmzKQ3S/1ZPL4nPf9HxiRcSAR1kb1llXiVC/gbnsZptqzKkJva2Tt12qmLuGYy4tgFXcSg3fGtY29NHeTI1P7Q8Ph2wPVPi1iiFBzp5P6CQsqjAfCcztHvFhHMjalsLdJ7uvlPcSpnPN3g9ZxeaD1iAUe822wWfOM2kVW7YU5lIdkhVqFxgSCR1ZHsx2GHuuzq3c1vD9ncpUe69+LN32T+aH5rlfpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WcwssK86+C38/0zWuG0TQ0YcR+9jUysSd1dJ7Ddf1fw=; b=fVhNSQrbj7XMZRAUihgSu4YdgVJ3JYSIrlByB5VAsdoW5EAdi/wmWiKObi7fIRqsjyyP3Ua/ZBRl/IK0RX/xTKLonwuaR/8c4xsUtMA3NsJUDD9p5oMAH2m1UtMBU6dYRVKXoZYO4Ab+QlNV+X2YHA48r9LBaW2JZqj5Bn4V+Ak= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4982.namprd11.prod.outlook.com (2603:10b6:510:37::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct 2021 23:26:02 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 23:26:02 +0000 Message-ID: Date: Wed, 13 Oct 2021 00:25:56 +0100 Content-Language: en-US To: Ivan Malov , References: <20210923112012.14595-1-ivan.malov@oktetlabs.ru> <20211012194620.26366-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211012194620.26366-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0109.eurprd07.prod.outlook.com (2603:10a6:6:2c::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0109.eurprd07.prod.outlook.com (2603:10a6:6:2c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend Transport; Tue, 12 Oct 2021 23:26:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb152e11-665e-4cb9-898a-08d98dd7a7b3 X-MS-TrafficTypeDiagnostic: PH0PR11MB4982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l6Mo5o2AvNVkOKuE8Zlf+KbFGWqKssGj8RwstF/5sBTIONCBlzAewzuTF0BvBaDTBsq3d99X4bYR2J7UUfcjuIV0Vuvrh0koMkm8kSMYRtTttIR3j27A+oPQOFfhbLo3fV0vdOMoDvxqImDddUAHV0l5exO7ijDYlUPiM709PkoK3qk5mMxNshuGuoeXt/0Iay9OTfK4qXFEBhxN4M8iPQXUu5y9blQ0U2d5rluxdK5YgAZE3i4j4gAU+/Ca3dDiIeWvjpxl+Jxn7+/y5bku92WnD5LpJUN8JWLCB5WidWMORuN2oRCHaqajV4bcFKdxHJJJw0RKNQCccnf6RPyzentN2GlHg0BPyrkC2F4qUu6Y0BlxnfM6mYKwZVJmbbEKSCWBn/czHbdTwa65uSFnx3MFKQIb2f9dhLE0Mso1yjPHoEPaI3K/oRUc0ZscShqOKjICc+cRVvre5DQ/MInBf7k9gS4f/iO5f9nolSru64RxtQ0EddQ6Zs6iZhGZYC65mEdrBqd11G5eI95HaHiak7Q/7BHUqMjUD0mtQA/OO+ycu6RXXEb+meZI3BDP8R1f9TIMG57hlg5yimd559Z7SzBy4nCZ8f5Z75pYqI0o1OLHBPdVQ/kwO6iaitYe2ir3Sz5+hIjoKgc/TwYJxzvUru3e8ZP+D7tr4qTTsSMKjZXzYzY1xHsgxM29jrLvrfjRSKvUcQvwJKkDBsr2YMr1ew== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(83380400001)(86362001)(44832011)(5660300002)(316002)(82960400001)(8936002)(16576012)(31696002)(31686004)(186003)(8676002)(2906002)(36756003)(66946007)(6666004)(66556008)(66476007)(6486002)(508600001)(38100700002)(26005)(2616005)(956004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0tmSm1YRFBZbE9zQXU2VmFtZmR6dTdOcFcrM2lkelBYK0pmQjlUR2M2Y0FF?= =?utf-8?B?d1lydkVsY0xBWUhSdzc3OWM3UXViNTFNaVdtZ2xRSHlpdWFiWk1HK0x2ODlY?= =?utf-8?B?SDAwcEF2NjJnRXY3eHlKbUFQSVR2Z1Yra0ZmWHNGeGZucXQ2YSsxeUVjajEv?= =?utf-8?B?cjBhdkQ5NjJhR0MzV3NtQW9Za0pVWjgyMWFNODhlWXJPeFZHNyswSC9rZnlt?= =?utf-8?B?N2JSVjdvRk5Ha09CY2ZmNDNpY0FHSVM2YmNKRXBWSnFnRkFLZ1ZITUxFZGRv?= =?utf-8?B?TXdQTTFhdkFtd0R1MG9CUWlPOTczRU9ZYldQd0lmc2RrdkgweURtNzVCWkQ1?= =?utf-8?B?RzNudDUvYTlTWjZpV0NVM3NjSmVEcmVoanN3enRSRW5Obno2b3MrQVNDTVlD?= =?utf-8?B?cWMvZnBzWE9yY09wQmsvQlc0NFF6U2I2SkJodnZEd3FuL0hObVhoN3RIcXpy?= =?utf-8?B?ZVB4Q21GS3JURzQ3TmlQcFo5aTB5alp6VzUwUWJDZms1Y2Z5d0d3SlNOa3M3?= =?utf-8?B?clRTNkM4R2FmUklnUHNoMytmRFkycGxMSkpXSnZRazNzM3NUU1NDZmxMalMv?= =?utf-8?B?ZnBVaGVnaGxwQjZzcWZ2TFdCaVAxa1oxdC8xT1NKODdjS1UzYm9XMnBkUzlB?= =?utf-8?B?TWtRUWVDRXI4dXBrMjh6MEtjSHczR0FReTlndERqN3ZuMk56ZkttWkFPb0tl?= =?utf-8?B?WVV5UG9CRmJXUDV4dlFCVlNGbGpSUGVkd25CVHc1UThvVGFBRlB3aWpFYWVF?= =?utf-8?B?Z0dyNEczR2cxTW9kRkI2cVBsTi8yVmRRdm10a0NwM0M3anY3OHh2NE9ROGd6?= =?utf-8?B?c21LOFVxR2lVN2RaaTVFODVoejNoWWFBdE1QZWkyeTdmdUF4RUI3eUFYQkdB?= =?utf-8?B?NU5tV0FkdWg0bU5DNzNCYk9aMzRDOXVEd2V2UUtIbVdVTlNhNUhTczBkS0tX?= =?utf-8?B?cTh4d2NyWXRjQVhPaU5Jbm1RMHFsUlFMTFlreks1WnNUbEtsWk16aFVJOUM2?= =?utf-8?B?UkZTVWZ0TVRWNTFMTHZMZjRnM0ozL2J6Tm5nVzA2RUlrbUl1ejlCcERhMCsv?= =?utf-8?B?ZnFkdGQvOENrNUlvN25MWWNsTjNpcjJXaVpuNHYvbTVuck0yQjhBVmtSYVBv?= =?utf-8?B?SmJRYURSQ2ZmZUM5ZjBock1WcXNwcnFoTUM2akJRYjFOTFltQVJzMVdYcSta?= =?utf-8?B?TWZJMFZYYnRaSU9NazJCaXVmYmZoaC9OQWpMYkx2TXlLSkpuMVhnblNPWTY3?= =?utf-8?B?TEROdkpPWnlMZVVHV3dQMnNXOFlsM0pUZVZlK0M4bFFZUG1ZMEJySGExWGxt?= =?utf-8?B?YU1pdlNRNTZ2Vi95YktmdUEwOTNJTlAzT0RWY1pnQjJ4ekkyQ0F4R3RWZUU3?= =?utf-8?B?eG9BeCtmd2x5ZTF1YzR2UUVoOE9aajdpSW9JZ24rWHYwUXZGWDNoT0s3WjZ2?= =?utf-8?B?cktINERoTlVlcmQ2YVR1Q2R4Z1pEeW02YlhZakV3SWtIT0JRZUQzbHFEME8r?= =?utf-8?B?SzNCOXRtbkpFWTVXb3FFdG0rbzliY29Xdm9MaUkxWTJQTk9PZjRYeTFMYk8w?= =?utf-8?B?ZGNjR1k3WXJ2dTF6ZTNwSi9IZHhhbGs1ZEloeDBoOS9BOW9LNXpiWFRvTHNW?= =?utf-8?B?bW5rYWMvK3A4ZUh2Vk9aT3k3b25NMmRvNDdRM1p2T2hRSUFKNTMxZEdOVHdM?= =?utf-8?B?U20vVG1nY3ZuQlE3SFFPTnFKQ2xWQnpaSG01YVpZd0xtTEErc2U1NzRZZXIz?= =?utf-8?Q?uYTTAYqfXUKDJtQck/42YK/MmRUm3/DP1QXD1Vl?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb152e11-665e-4cb9-898a-08d98dd7a7b3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 23:26:02.7153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OY4+MaASWzCixoE3ovpxuNhPoDdTU/Y+N3OFiRlzlR2nwxZxlkTwcfI6W8PM714dCiatzeQiaRYxvqmJwjKfpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4982 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/12/2021 8:46 PM, Ivan Malov wrote: > In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace > intending to add new flags, RSS_HASH and FLOW_MARK. Since then, > only the former has been added. The issue has not been solved. > Applications still assume that metadata features always work > and do not need to be configured in advance. > > The team behind net/sfc driver has given this problem more thought. > Conclusions that have been reached are as follows. > > 1. Not all kinds of metadata can be represented by device offload flags. > For instance, having flag RSS_HASH is legitimate because the NIC is > supposed to actually compute something when this feature is active. > However, if similar flag existed for Rx mark, requesting it would > not make the NIC actually compute anything. The HW needs external > stimuli (flow rules) in order to set the mark in the first place. > > 2. As a consequence of (1), it is apparent that the user's ability to > use Rx metadata features is complex and consists of multiple parts: > a) the NIC's ability to conduct the flow actions (set metadata); > b) the NIC's ability to deliver metadata (if set) to the PMD; > c) the PMD's ability to provide metadata received from the > NIC to the user by virtue of filling out mbuf fields. > > 3. Aspects (2-a) and (2-c) are already addressed by flow validate API > and the procedure of dynamic mbuf field registration respectively, > hence, the only problem which really needs a solution is (2-b). > > Patch [1/5] of this series adds a generic API to let the application > negotiate the NIC's ability to deliver specific kinds of metadata to > the PMD. This API is supposed to be invoked during initialisation > period in order to let the PMD configure HW resources which might > be hard to (re-)configure in the adapter's started state without > causing traffic disruption and other unwanted consequences. > > [1] c5b2e78d1172 ("doc: announce ethdev API changes in offload flags") > > Changes in v2: > * [1/5] has review notes from Jerin Jacob applied and the ack from Ray Kinsella added > * [2/5] has minor adjustments incorporated to follow changes in [1/5] > > Changes in v3: > * [1/5] through [5/5] have review notes from Andy Moreton applied (mostly rewording) > * [1/5] has the ack from Jerin Jacob added > > Changes in v4: > * [1/5] has the API contract clarified to address concerns raised by Ori Kam > * [1/5] has the API name fixed to use term "metadata" instead of "meta" > * [1/5] has testpmd loglevel changed as per the note by Ajit Khaparde > * [1/5] has testpmd code revisited to take multi-process into account > * [2/5] through [5/5] have the corresponding adjustments incorporated > > Changes in v5: > * [1/5] has the API comment improved as per the note by Ori Kam > > Changes in v6: > * Rebase as per request by Ferruh Yigit > > Changes in v7: > * [5/5] has rebase defect fixed > > Ivan Malov (5): > ethdev: negotiate delivery of packet metadata from HW to PMD > net/sfc: support API to negotiate delivery of Rx metadata > net/sfc: support flow mark delivery on EF100 native datapath > common/sfc_efx/base: add RxQ flag to use Rx prefix user flag > net/sfc: report user flag on EF100 native datapath > Series applied to dpdk-next-net/main, thanks.