From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1E2842B3A; Thu, 18 May 2023 13:46:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7E4640E25; Thu, 18 May 2023 13:46:19 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2086.outbound.protection.outlook.com [40.107.94.86]) by mails.dpdk.org (Postfix) with ESMTP id C16404014F for ; Thu, 18 May 2023 13:46:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DHeXqaKgukhBHxjjyJwwWTZHnp4St8GKOysEaSGNdKue+fVAmSS3NMRnR2fGiRXRICo0F1oK0uNd5dUuQZZsAN+IwcC0PnNr6HAZGNPoCp2Hhu0c2XFKZAiUaccLhxRKEhvC7QlHeXX//ojIKF7p6Kdu4mInt2bXGvJ3r0kAiL93Zc28N/BXyImHNbcW3bNeWxw+/X44xTGB9greJ3s7EuAaVfroWeHM0mKKEFu9YsCZImmPEGbg5ZXHV8Jw+NRUNaxCvTd6W7rP3rlcxq7HSrvzK4aKa1xjgcIHgkEw9VCvePJUVbAGofDd+HB//H0WWhJUn5HdqPQup50KkZgRoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v7XpHRtLmCjMrMFT+G6JXcayJ30o8+YZ1SqlfZf1IHs=; b=ixhMgWZ3nJmAocLA9xRugSyFot3oEhZk27LxPxueTcTG07PBNEeNvNB4pUOb6kWSUF+XHj9v08U4x/+adUPPfTgv930ZcrZnu5i87ymovSJfYYEgNOe/G5mXJ53NwsHY5buKpEnacAOwotlHsuXfedYZNcbEdwLly8/luMvzl4HVMHVFqJK9ydKEkjvJlqALFVrCZkDWDqiouKuJNkWLlx/4nP/68XH7oz6Yp3M0Tai9Q9FnysekGROyO1SQAPoJD6+YAaTILDSdWeZe3CTnhbMrPdHz6WBGVXbo+cBose2nrV8qzmNUv/GT76CxSWEvJgYBD7AmVTCbvj4FZRIZgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v7XpHRtLmCjMrMFT+G6JXcayJ30o8+YZ1SqlfZf1IHs=; b=mYhLtVTiGPrUXtH3YFu1RAP7tG5qcz2sTlJZewwNS2eBvCdIgdvsyISaURvZlzrJclFeK2PF+lS7+RpdV4gXf10UUO4QZUuxhx3uOJU2A3ZEBbFb7rxcqiOd1o1QQQQxukZWisNX2ULnIXESIgveta8F3HuluQ5lz7TRTjfY3YE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8772.namprd12.prod.outlook.com (2603:10b6:806:341::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Thu, 18 May 2023 11:46:16 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Thu, 18 May 2023 11:46:16 +0000 Message-ID: Date: Thu, 18 May 2023 12:46:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] net/nfp: implement xstats functions Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, James Hershaw References: <20230517073351.1364030-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230517073351.1364030-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0028.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8772:EE_ X-MS-Office365-Filtering-Correlation-Id: 56527e2c-7e08-4d10-bf53-08db57957cd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pk7G3dJRcybH+OKT56QGYXP4gTYX6PlvTZtVjo7CVh0IcqhIyhSrujKLCSTlOVCKMKdrsTb0yzvCOygsKeq6CTmHBF0aaoUtPv3nip5ZmuZZaLsgfkOBIHpwZo1WqGD4q41M34hHEB7e0YPKzicuriq4/eQ8+BF8PPjlNcv333Wgl+nRQvjShWH3MXwu38lX+xmASuZVOkTrhRdxKmVDmOe7NuVSEmEVPB4sAaG4LKvgaExs9bkonfEOuVPAeafMpdhuFgzZN7U55JwRrgclymuE5nml238gwlwcrf5AT8UynQAMJ4Y4nQRMBUVluwFz0XyTpWVUsT1S0U3aC9wPrTRNhwaEuh7J29+SSZnvK26lGdpGTH/vMcfHRArAQN9nkfXNqjdzJ990lSl03fCiwFzH75lBhyWhseULZTqWHCkUToql8J/TnfhcOxyXQQd0xZRrK3u+yYgopD/aUWvr9/Lktv9+2LRGJ4G8ul084ekWw7v37NSTz+52nx8etMqeVCnHoAqhL35pdHKnYy2G+5lHverrffudOePwqATV71Ozb2JU9WTIaOHRVtLp13QQuhjiLZhphH1r9dltB7ovjZ6lIbdrv4DVLSk/rDlMqYP0cw58MLwtPVAJ80qwrE9BLWc8NNDbw0Tf7A7Xhajn5A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(366004)(451199021)(478600001)(6512007)(186003)(26005)(6506007)(6486002)(36756003)(6666004)(2616005)(38100700002)(66556008)(66476007)(2906002)(66946007)(4326008)(316002)(4744005)(8936002)(8676002)(86362001)(44832011)(31686004)(41300700001)(5660300002)(31696002)(53546011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEMzNjAwQ2g0WjBxV2ZEdjlpRDkzVk95c0V2YWE0ZU9yQldRYmdUdGw2d0J6?= =?utf-8?B?MXgrTU10U2xkUGVKVnErR3JOZlJ2T2N5NUhNVDIweVF4TkdQY2FZYzRpaEVI?= =?utf-8?B?c0tGcVhoTUdrSXlSZFJpM2JzNXgvdEYveU41ajNKSWVSYWF1WVNxN0x5UVVx?= =?utf-8?B?OUwybzhmcm8vWmN4VHNNQmRtcjIxM21oZ2RoNkZOd3ZaY0t2cDQ3L0R5bUxI?= =?utf-8?B?TDBKZGlpNkdORzVoQXM1eFRlK24vTWw3WmVDYmVabWZ4T2dRbkNxUUhMaW14?= =?utf-8?B?WFVNeWd6NXRTajJoUENkdDA4NmE3cGlCSXh4a1RHNTZ0OFRTYXJITjFJUkhn?= =?utf-8?B?ZzJpWDNvL2RKOWcvOUgyWmJoK0QwbUVwNXZXenc5dWhLRTFJd1FPME43Umpk?= =?utf-8?B?dDJWcFQ2Q29tTEdrMkJhM092WTFnMXJvdVlURmhCS3h3cTgxVGdSeStYbUU5?= =?utf-8?B?ZzY0QVZROGpNckJGQ1gyMXFHNUFqbVVOcHg3N3VwVFp3Rjlkd3dKS2JyalQ1?= =?utf-8?B?MEZ6NURNaERYejVRM2hhejErdDVJNnZSeU1YVi9mUnFlSGNFeFVBQ1BxN0hj?= =?utf-8?B?N1lPOFpTRWh0L3pLU0FtMkt1RzRMY2RzRDkycXlWTlNsR3NRN3hINXRQdWZM?= =?utf-8?B?MitSbjhsRFFDRisyZnk4WW4zMm1haTk5SEhSY1NyVW9pT0kzZTBxYldhZUty?= =?utf-8?B?UDhmd0VkMGMvWitQVDB2QzhzMWZpdjVoUi9vZDQ4NG40SUk1KzRFa3RqWFNO?= =?utf-8?B?UVNsZGM3RzdqOC9Nejdsak5NcGkvN1czYkZIYU8vZkpIQnp5YjlwSTNqQTFq?= =?utf-8?B?Qm9Lank1SDJQR3o5YWlERnd3ZUVuZUVNVG5kWUlCb1B5OXQwLy85Y01uWXds?= =?utf-8?B?a0t3SksvWmplVHJZbTU3U1NnWVl1WkM2alZ2dDd5U3pPdXFRWWlNUWIyUlhD?= =?utf-8?B?YmlCVnlZcWRKRDA0ckwwOWJDRjNqcHhUcU85M0dhWDBtM0ovUERmWDhTUXp5?= =?utf-8?B?Q2M5WktBMzk2bTY3OGlmdUJBclArb0NBWCtINTdoVUcrZzlDZy94UXEvSlpw?= =?utf-8?B?NnBiMGtBcFVlaE5CcGR2TERXdUVSTnZhS0VTMGltVXh5bUU0eWxDL2Z1RytL?= =?utf-8?B?d3d5a0wyd1Q0V0hnUnh3bmhUZmM3cTdxRk9uU0k4R09kL0dWUkZlK0NpdUZN?= =?utf-8?B?OFNidnB4ZVNRMkJudUd3MnpQd25hK0h0QW5ubjNrWEMzSFgzUy9QRXlRUVNP?= =?utf-8?B?L0FYUUJPYnNyV3FqOGFqVHdOUTdkbzNEVFB6Z2NxY2JCWWtOQjArdkxEVzNS?= =?utf-8?B?SUxXTXhGMmdtTEVzVWlaUmVTYnVGRnpwU1VXMnpTczNpRUhPb2Nyam9YRUlh?= =?utf-8?B?Nm1ZNVlabXVLVUxlTmJMaGU1WUVVNVZzOENpWFpaMDNESDhmbEp3MG5WelZK?= =?utf-8?B?SU9DK2kvV3haZWRNNzBXTDdVVjc1WHhDbnFFekZIS0lIUFVvRTBab2JmRXpS?= =?utf-8?B?UkFiSkZUWGtVb3RuelBNNkZlYnIvcldBektCM081QUFqTG9BbHpEeFEwbVJK?= =?utf-8?B?V0NuckxYQm51d1dXMmtsSWM2NGc1Y2NFMnBqSjZ1RDBBaFZoNnAwdk5BTjl4?= =?utf-8?B?ZEZpdCt4WGRGc0EyaGoxUzhLYi9ETi9KZEl6VEFKaHY1NTNoNnRLYTFHVTIw?= =?utf-8?B?QjRxWEdYSWVoZFIxNCs0bDUrVGlYclpyTm54T3Q0Z25kYkppR3Q0SGhhMFVI?= =?utf-8?B?dG5pQmFkR1dubHdEQitpZlVWa2Z2c056V05YajJlTHAyU0pYaG5wSi9HTHZq?= =?utf-8?B?ck1EdmpDdktUM3gzR0dnaUdHWnFkKzlHQWxvLzVKY0U5NUE2ZW9ZalRVTDNI?= =?utf-8?B?MGRQT2hDeXlWdWdSZjNucTVWbk5zOXBFS1VXdmhlVWVDejE2Sks4OERuenRm?= =?utf-8?B?K2p4ZzB0cjd2Ty9SMStWandUTlhJMWdwUlhMV1A4T2JXSlZOc2VIbVFSUmxz?= =?utf-8?B?eHZacUdhTzVQQ0JlNkwrakRKai9rdTVyd2pnd29HYm14ZHBzNnlmNkRVTFNs?= =?utf-8?B?b1U1VCtQZHRRZ3NEY2hueWhMZFozQ3lhWFYrbFE2VkhUMTkxc0g1YmtEQ3pn?= =?utf-8?Q?SrMlqKpP7ME1CuBEX79+BQHjO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56527e2c-7e08-4d10-bf53-08db57957cd5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 11:46:16.1815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QJgXGDsZ+gitXv9EkkY97E8pALixwRLjLFasiFmWnLAqB23RzfplHd8w3RDGrTC6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8772 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/17/2023 8:33 AM, Chaoyong He wrote: > From: James Hershaw > > To align the stats collected by nfp_net_xstats_get() to those collected > by the `ethtool -S` command. This includes a number of extended > statistics for both nfp_net and nfp_net_vf devices, as well as MAC > statistics for nfp_net devices only. This does not include extended > statistics for flower representors. > > The addresses and names of counters for these statistics are added as an > array. > > The various xstats functions for the nfp PMD are implemented in line > with the RTE API. > > Signed-off-by: James Hershaw > Reviewed-by: Niklas Söderlund > Reviewed-by: Chaoyong He > Applied to dpdk-next-net/main, thanks.