From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDCC6A04BA; Thu, 1 Oct 2020 16:35:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 274971DB58; Thu, 1 Oct 2020 16:35:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id BF41E1DB51 for ; Thu, 1 Oct 2020 16:35:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601562908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lRPbT9FGdy6rMWjxCPxmZbBow65X8sgfF6JMbOR+j4Q=; b=UtZxoE/izEPjLLOcoO3Jys/zN0KeM87vAPbcdApALW1MELzyqun8pCjkQk43j3NYJ04/qO KZ/Eg0RaUZDAeb/Hn3W78FFqez1/HlR7eZIWldxmx6J1pTwn9skWhTGSOcLBqSE5l3qXYD 2lvPQ+MSdB8WmqkOHX+90mH1/7iNvY0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-7wWv42NbMguEgBPbUyitMQ-1; Thu, 01 Oct 2020 10:35:03 -0400 X-MC-Unique: 7wWv42NbMguEgBPbUyitMQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B3161868429; Thu, 1 Oct 2020 14:35:02 +0000 (UTC) Received: from [10.36.110.36] (unknown [10.36.110.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26B615579A; Thu, 1 Oct 2020 14:34:58 +0000 (UTC) To: Nicolas Chautru , dev@dpdk.org, akhil.goyal@nxp.com Cc: bruce.richardson@intel.com, rosen.xu@intel.com, trix@redhat.com, ferruh.yigit@intel.com, tianjiao.liu@intel.com References: <1597796731-57841-12-git-send-email-nicolas.chautru@intel.com> <1601522084-151443-1-git-send-email-nicolas.chautru@intel.com> <1601522084-151443-4-git-send-email-nicolas.chautru@intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Thu, 1 Oct 2020 16:34:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1601522084-151443-4-git-send-email-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v10 03/10] baseband/acc100: add info get function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/20 5:14 AM, Nicolas Chautru wrote: > Add in the "info_get" function to the driver, to allow us to query the > device. > No processing capability are available yet. > Linking bbdev-test to support the PMD with null capability. > > Signed-off-by: Nicolas Chautru > Acked-by: Liu Tianjiao > --- > app/test-bbdev/meson.build | 3 + > drivers/baseband/acc100/rte_acc100_cfg.h | 96 +++++++++++++ > drivers/baseband/acc100/rte_acc100_pmd.c | 229 +++++++++++++++++++++++++++++++ > drivers/baseband/acc100/rte_acc100_pmd.h | 10 ++ > 4 files changed, 338 insertions(+) > create mode 100644 drivers/baseband/acc100/rte_acc100_cfg.h > > diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build > index 18ab6a8..fbd8ae3 100644 > --- a/app/test-bbdev/meson.build > +++ b/app/test-bbdev/meson.build > @@ -12,3 +12,6 @@ endif > if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC') > deps += ['pmd_bbdev_fpga_5gnr_fec'] > endif > +if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_ACC100') > + deps += ['pmd_bbdev_acc100'] > +endif > \ No newline at end of file > diff --git a/drivers/baseband/acc100/rte_acc100_cfg.h b/drivers/baseband/acc100/rte_acc100_cfg.h > new file mode 100644 > index 0000000..73bbe36 > --- /dev/null > +++ b/drivers/baseband/acc100/rte_acc100_cfg.h > @@ -0,0 +1,96 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Intel Corporation > + */ > + > +#ifndef _RTE_ACC100_CFG_H_ > +#define _RTE_ACC100_CFG_H_ > + > +/** > + * @file rte_acc100_cfg.h > + * > + * Functions for configuring ACC100 HW, exposed directly to applications. > + * Configuration related to encoding/decoding is done through the > + * librte_bbdev library. > + * > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + */ > + > +#include > +#include > + > +#ifdef __cplusplus > +extern "C" { > +#endif > +/**< Number of Virtual Functions ACC100 supports */ > +#define RTE_ACC100_NUM_VFS 16 > + > +/** > + * Definition of Queue Topology for ACC100 Configuration > + * Some level of details is abstracted out to expose a clean interface > + * given that comprehensive flexibility is not required > + */ > +struct rte_q_topology_t { The naming is too generic, it has to contain the driver name. Also, it should not pe postfixed with _t, as it is not a typedef. "struct rte_acc100_queue_topology"? > + /** Number of QGroups in incremental order of priority */ > + uint16_t num_qgroups; > + /** > + * All QGroups have the same number of AQs here. > + * Note : Could be made a 16-array if more flexibility is really > + * required > + */ > + uint16_t num_aqs_per_groups; > + /** > + * Depth of the AQs is the same of all QGroups here. Log2 Enum : 2^N > + * Note : Could be made a 16-array if more flexibility is really > + * required > + */ > + uint16_t aq_depth_log2; > + /** > + * Index of the first Queue Group Index - assuming contiguity > + * Initialized as -1 > + */ > + int8_t first_qgroup_index; > +}; > + > +/** > + * Definition of Arbitration related parameters for ACC100 Configuration > + */ > +struct rte_arbitration_t { Same remark here. > + /** Default Weight for VF Fairness Arbitration */ > + uint16_t round_robin_weight; > + uint32_t gbr_threshold1; /**< Guaranteed Bitrate Threshold 1 */ > + uint32_t gbr_threshold2; /**< Guaranteed Bitrate Threshold 2 */ > +}; > + > +/** > + * Structure to pass ACC100 configuration. > + * Note: all VF Bundles will have the same configuration. > + */ > +struct acc100_conf { "struct rte_acc100_conf"? > + bool pf_mode_en; /**< 1 if PF is used for dataplane, 0 for VFs */ > + /** 1 if input '1' bit is represented by a positive LLR value, 0 if '1' > + * bit is represented by a negative value. > + */ > + bool input_pos_llr_1_bit; > + /** 1 if output '1' bit is represented by a positive value, 0 if '1' > + * bit is represented by a negative value. > + */ > + bool output_pos_llr_1_bit; > + uint16_t num_vf_bundles; /**< Number of VF bundles to setup */ > + /** Queue topology for each operation type */ > + struct rte_q_topology_t q_ul_4g; > + struct rte_q_topology_t q_dl_4g; > + struct rte_q_topology_t q_ul_5g; > + struct rte_q_topology_t q_dl_5g; > + /** Arbitration configuration for each operation type */ > + struct rte_arbitration_t arb_ul_4g[RTE_ACC100_NUM_VFS]; > + struct rte_arbitration_t arb_dl_4g[RTE_ACC100_NUM_VFS]; > + struct rte_arbitration_t arb_ul_5g[RTE_ACC100_NUM_VFS]; > + struct rte_arbitration_t arb_dl_5g[RTE_ACC100_NUM_VFS]; > +}; > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif /* _RTE_ACC100_CFG_H_ */ Regards, Maxime