From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3B83E43DCA;
	Mon,  8 Apr 2024 10:45:58 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 18A7340289;
	Mon,  8 Apr 2024 10:45:58 +0200 (CEST)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2097.outbound.protection.outlook.com [40.107.93.97])
 by mails.dpdk.org (Postfix) with ESMTP id 9596440041
 for <dev@dpdk.org>; Mon,  8 Apr 2024 10:45:56 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JkC29je3sVHWr5Z1hkp4eoijGpD3gAqW69zZ2TinlYrldbdQaFQosuqg7iTOPbE2Erg4Ap8xon0St2/tt4lw1BCce2xfL2MFVmKKgG6Yfl0SSPvB5etWbLuKSfDgi392nGGKFWqPFwedh4lXNz+8AOD0k/p/SxU8i3fqEdSjQKQ7+G7or4bpAWgZDB33BvTukAMd4w9XvBf3HZeTQrEP8FnR8F+w4/Im0/WbbkJalUSjt7+ZRx+pPjgXb/9HhzVkaSBhx+lrTzDulpKGoZnaD0vSV5uVmhVq2L09Wedb4i17WXnlHhlSfy00JhiB5tlq62CCd9aMRafMEkL3//ri7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FpeDN0SgFzhiNTl9ZZnxQpXt277wqK6XFLoTiXD+kzk=;
 b=n5fVYnRIwRqlpCdAQBdryl17OA+MgCGC5PHdtE9D5lSASlNeyjl4g6WWNc2M3fehSaDKdjmKJbpPvOWQKzqqAJyNlza55j+feMuxWIBWx0TkYr2MT4aLr2acjYJNlacFRhpKpV6Z9PwLXaxSvBGjOzKhX0CgQ0Dw5cpE7l1urq7BBuzI+w8G4TW2tciffObYb6AehlvA71pAn9Qje5RD6oKWD14mmTX3F7qf3nmjPdREk+zMUcW88jSEEWTdpObGMTuhzA8+I2wKTc2/gjgabBbESNkuRczCrtjD/f8pAvz+nyc9ZQ4iTzKm6Wu3FTVCeyYMHFsCB5VG/Z1H9e2PoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; 
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FpeDN0SgFzhiNTl9ZZnxQpXt277wqK6XFLoTiXD+kzk=;
 b=RybAey+wteDvFnOdinx8eF5k1Uq0Tfk6b5XhLVqJQ1TkPLKTQLpZbq1th7aLsOOLpmGKaQNFppJu9pG9Awv1c7UpHukocpQQj/W1NuZBXrmmpcb22C443NVL7pwvl+AN/6ipDGQS4HuxcYnlbDoISzU6fX9JO0kH1J6HQ3kzEi4=
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
 by CH2PR12MB4309.namprd12.prod.outlook.com (2603:10b6:610:a4::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.54; Mon, 8 Apr
 2024 08:45:55 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
 ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com
 ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7409.053; Mon, 8 Apr 2024
 08:45:54 +0000
Message-ID: <a15bfb77-7ca3-4026-936a-fabcc6f030d1@amd.com>
Date: Mon, 8 Apr 2024 09:45:51 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] app/testpmd: handle IEEE1588 init fail
To: huangdengdui <huangdengdui@huawei.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, aman.deep.singh@intel.com, liuyonglong@huawei.com,
 David Marchand <david.marchand@redhat.com>,
 Thomas Monjalon <thomas@monjalon.net>
References: <20240330074409.273916-1-huangdengdui@huawei.com>
 <20240405094427.32d19496@hermes.local>
 <d8f192e2-3be8-48e1-b7d7-4db24cc41ab5@huawei.com>
Content-Language: en-US
From: Ferruh Yigit <ferruh.yigit@amd.com>
Autocrypt: addr=ferruh.yigit@amd.com; keydata=
 xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9
 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J
 eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg
 B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9
 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ
 N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ
 vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S
 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum
 CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA
 XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln
 aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID
 AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK
 Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3
 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU
 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs
 cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD
 VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg
 Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc
 GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV
 gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW
 VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD
 DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG
 CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe
 WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi
 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl
 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv
 VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA
 fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr
 ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC
 IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk
 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak
 oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq
 b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ
 Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX
 W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW
 honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA
 g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn
 GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ
 NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs
 SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe
 cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH
 dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk=
In-Reply-To: <d8f192e2-3be8-48e1-b7d7-4db24cc41ab5@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DU2PR04CA0310.eurprd04.prod.outlook.com
 (2603:10a6:10:2b5::15) To CH2PR12MB4294.namprd12.prod.outlook.com
 (2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4309:EE_
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RPpwRztCfJeXSnXdeFcTtGxG4NIKkuQFOAZWLFOmQGj8sr93XnxMb7EVbTRLHqD7TeUoOYM74L9yuAKyAMrVSyqB4850+96HusX0cyGcFxdzSd0UoR6THp31YQts9hXEpWzwjBF7MkxtM1b2DC/1T3UOOvrCVfZjserNaNztoVbkaNFSd9+s5YDej/qf6iF/PRtd8TyzPX5eqP65ejzTAZ0Y2paKQh3/uNbB/y/FIOv9mlobY4GRBMXgXaMzv8zFoo0bZ+F8uCU7ywlrzdbc8QP6kr0HeJYg/mgOiC8DnUTHauFNRyav4dmCX/iQ+5/AwiaSbe9tgGpdfz4jfGHH1cTdnJNZ3AIML54114g34DRiI80vA7Mw/GeUBlEGJ71wm6jKLrCB35qtrh/q3xc4fD05G9v+W0o89iFBBtle9NJZVLnEW0fa3OR2KdbFVrS2xPKfPVNWfVA+WhrZMIU67lYzQ5ypdMAxZJXVukYV0JpBz4LTSFhva/2mZ1L/KNpq+TAgbXKRHu8fDMPhYviuGIplktc9/HeeeyHZubm6gzWGuZfsBQIOe3Nd6LwRROqfU1HFTKJN4PyfTiMeuyrrEytd7kHQRq398Hs08QWSHoNxgL0HR92t85Ld1SiqVistOsskFObg4dL3CFU0f3TBsFO9jUbooLSsFS/kStgPgKI=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1102; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K04zclhPS3ZlcCszSWhudGtSTWlGSk1zUUtBdmJIUjNXS1VNMmlkWHM1djE3?=
 =?utf-8?B?R3VRQytNL1gxcjhYNHNqRWtmeWRvNm5uUS9LMXJnWDA2SG1odG4rTUV1U29a?=
 =?utf-8?B?SVpPaTJkWUJQNjFuaU1JVW9XNzlDMlRyekFOWUxETnloOUl1SnBwV2dqcnBQ?=
 =?utf-8?B?eTRrY0dvZXNxWnhydVE2akNDOHJMdThmT2svTjVYV1NhZllFaHAwSVQrd3Fw?=
 =?utf-8?B?dEpVUFg5cGxyZFdaeCtseEdobXN3dkRobmNJMENYQnlyRGR6UnZ5UHJ0Y3Jr?=
 =?utf-8?B?cEN4bUw5Q0lzVzQxOUJhZk1zTjBGMHlNYytxY2M1U1p1NGVST1RmVzdHbE92?=
 =?utf-8?B?a05ldmJIQ1dCRnpEclNYZnFVYVdSNFNTMnVMeG96L3dud3lPMTV1M3A4ODZl?=
 =?utf-8?B?UEIxWk9XZm44cy9KUCtuTExmMVE2TmtXQWkzWi8zeDEwR3M4TUx2TjQ4NWJa?=
 =?utf-8?B?ZDJNbUQzYXBpVEJZMDd6bitudm4xbjhqOHZ4RitCZk5ObkZ4TldGaDd0VkhG?=
 =?utf-8?B?VnNtY3dCT3RlZTJxUytqRHN6aGs5bEdJVFl5dW9ORHhVZmQxdWpBSWRtLzQz?=
 =?utf-8?B?WC84a1Zxb2E0T1psWTVIVS9vMlNLaGFTS3Q1ODVmMjY2UWZLdFlKNkhqTlhI?=
 =?utf-8?B?YlZTNzFVUmN3ZXlBdGhsbkVWVWZyNURVVFRkODlqWEUxc25ac0xjUVIyV0ZR?=
 =?utf-8?B?c0hNTUhBeHRjM21YTlM0OW1za2NPWHc1S1UyRFFPQUlrRUlKTWpIMVh5Qm5S?=
 =?utf-8?B?U1AzMU10K2ZnM1RCMUZ5ZlZaZmdBQnk2enphbmZRTUtwbVZOM2xjZkVsa0Qv?=
 =?utf-8?B?YXZUaE55RThmT2xPTlQrOGVNVDR2TjRzSlgrR2V1Z0NwSHdpa0ozZWFzaWdp?=
 =?utf-8?B?OXVWcER5ekFJSFJnMm5sdmFBSFhoZDRQbTY4WlF2em9OQTNVVDk0SDlTY3pU?=
 =?utf-8?B?R3hsRUFkS0gxK2tnL0l1aXlmU0Z4Zmo3dFc3WGE0MDViV0lJS29TRzNLdWFH?=
 =?utf-8?B?OHVtMlc5RFVCaUhuWTFuTk5XdFU3dUJnaDMxSDg2a2dNcHVLdFJLSmMwQmlJ?=
 =?utf-8?B?NjJNQm5lZ1cxc1Fpb293TG1xRkFPNmtjRUl4STArb1NQUHB0aUJ3VlZPVTVT?=
 =?utf-8?B?RklYc3lXRjYySklmaHNEVTZod3FCNThiM3hDK1RMZ0xQSnpwT1NoSjRDc0dH?=
 =?utf-8?B?WUY3azFPRDRON24rU29rZlAzSUQyTVVudXI3THpibEVlcFdKcWRXaFVXbUxJ?=
 =?utf-8?B?bVY5SmJQYUo3TTVXMXZZa2ZaSFUvTWhEVks5bFMzbU05N3VVdWFiSTIrZ0p4?=
 =?utf-8?B?bnhGSTVvS3VsVW0yTExYZHFOMnk4Z3ZabUNPNFM4VzAxMmM3MjhESjljcUM5?=
 =?utf-8?B?dm12c2ZIc0lCbXdjeEpsUld6YWRmREhQSlYrNmlzZWNRblhJRlVnRDNLUll0?=
 =?utf-8?B?WUNncU16ZUc3Y0s0MURYTTFPS1BueWl6MjFETEN1WEhUV1hPMjlnamlWNVk4?=
 =?utf-8?B?bStENWhCQWQ3MDlmN3dIMjJvdmVTSjk1MXZJZzF3YkcxM3JLN0prcUJiMEdE?=
 =?utf-8?B?aWE2RTB6MFZxQnZoUDdlUDFYemgxYUtIeXFJTlpCQllwYXFmK054eUVlZE5W?=
 =?utf-8?B?MGJldStJS3VKVWhwdVBscnZqOWV4NTdoNmNnYkpCdTdkU2pOTkZIZGM2UXor?=
 =?utf-8?B?dXFvK3Y2L28xRFJneFhjNHBWN3A3VHBFeFpjYk1xQ1J5L015RXYrYUdiV0Nu?=
 =?utf-8?B?cWJpV2RUOEV6WmxoVSs0Y1FoOTJHczVZRy8xRElYWWlERVdHeUNhREQ5VEVK?=
 =?utf-8?B?aWhpRnlVbFVWcUxHTm1lRUovRlYwSVdFNGlHT1o1SEJ6TUVkZFA0Z2Nwc2JR?=
 =?utf-8?B?OXhWbUxMVjVXVDROcDQ1T3ZCdGpZZHNGSE5pY25tQ1RwQVFxZHUxakUvUGhx?=
 =?utf-8?B?ZEs1WklWY1RNeC9rSnhtWHd3TStjL3ZOWE02cVNHeXJFMCt4ZkpyMTdxc3cy?=
 =?utf-8?B?RnJQelBrcG8zODVYS3N2TXl4UjFiNnVNM3BCQ2c0Mk1Xdk9Qelk4VkxHdUN5?=
 =?utf-8?B?QUhlek9iamdaVFBvSVZ5bGp2MGdYcEhCODRVMjFGbWNSMkNlUStqNXEzclpR?=
 =?utf-8?Q?WNlhmttfi0MUntZo+7rE41UR/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0ac8d08-2ae9-419e-5dad-08dc57a84d87
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 08:45:54.8465 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gxynP4TwvW63YYzs9z4wcxgFNnqEn1IjgLxB9xv7jKpTTG7J2CAyd780bpjuGC5u
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4309
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 4/8/2024 6:52 AM, huangdengdui wrote:
> 
> 
> On 2024/4/6 0:44, Stephen Hemminger wrote:
>> On Sat, 30 Mar 2024 15:44:09 +0800
>> Dengdui Huang <huangdengdui@huawei.com> wrote:
>>
>>> When the port's timestamping function failed to initialize
>>> (for example, the device does not support PTP), the packets
>>> received by the hardware do not contain the timestamp.
>>> In this case, IEEE1588 packet forwarding should not start.
>>> This patch fix it.
>>>
>>> Plus, adding a failure message when failed to disable PTP.
>>>
>>> Fixes: a78040c990cb ("app/testpmd: update forward engine beginning")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>>
>> Noticed that ieee1588 part is printing errors to stdout,
>> but other parts of test-pmd are using stderr or TEST_PMD_LOG.
>>
>> It would be good to decide on one good way to handle this
>> across all of testpmd.
> 
> Yeah, it's a bit of a mess. Is it better to use TEST_PMD_LOG?
> But this is a test app, and modifying it seems unnecessary.
> What should we do next?
>

'TESTPMD_LOG' exists and used in a few places, but still most of the
logging done with 'printf/fprintf'.

Agree to have an agreement what to use, document it, and stick to it.


For some cases, like 'usage()' output (testpmd supported parameters), or
cmdline prompt we always want to have output, so 'printf' suits well.

Not sure where 'TESTPMD_LOG' is needed and what is the benefit. I don't
remember many cases that I want to refine testpmd app level output.
Maybe a case can be packet verbose output, but it also has its specific
command to control it.

So should we continue to 'printf/fprintf', is there any disadvantage to
do so?