From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6AC561B216 for ; Thu, 5 Oct 2017 20:48:07 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 11:48:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,481,1500966000"; d="scan'208";a="907143627" Received: from unknown (HELO [10.241.225.33]) ([10.241.225.33]) by FMSMGA003.fm.intel.com with ESMTP; 05 Oct 2017 11:48:04 -0700 To: Ophir Munk , Adrien Mazarguil Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , Matan Azrad References: <1507195992-12513-1-git-send-email-ophirmu@mellanox.com> From: Ferruh Yigit Message-ID: Date: Thu, 5 Oct 2017 19:48:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507195992-12513-1-git-send-email-ophirmu@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 0/7] new mlx4 datapath bypassing ibverbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 18:48:07 -0000 On 10/5/2017 10:33 AM, Ophir Munk wrote: > v4 (Ophir): > - Split "net/mlx4: restore Rx scatter support" commit from "net/mlx4: > restore full Rx support bypassing Verbs" commit > > v3 (Adrien): > - Drop a few unrelated or unnecessary changes such as the removal of > MLX4_PMD_TX_MP_CACHE. > - Move device checksum support detection code to its previous location. > - Fix include guard in mlx4_prm.h. > - Reorder #includes alphabetically. > - Replace MLX4_TRANSPOSE() macro with documented inline function. > - Remove extra spaces and blank lines. > - Use uint8_t * instead of char * for buffers. > - Replace mlx4_get_cqe() macro with a documented inline function. > - Replace several unsigned int with uint32_t. > - Add consistency to field names (sge_n => sges_n). > - Make mbuf size checks in RX queue setup function similar to mlx5. > - Update various comments. > - Fix indentation. > - Replace run-time endian conversion with static ones where possible. > - Reorder fields in struct rxq and struct txq for consistency, remove > one level of unnecessary inner structures. > - Fix memory leak on Tx bounce buffer. > - Update commit logs. > - Fix remaining checkpatch warnings. > > v2 (Matan): > Rearange patches. > Semantics. > Enhancements. > Fix compilation issues. > > Moti Haimovsky (6): > net/mlx4: add simple Tx bypassing Verbs > net/mlx4: restore full Rx support bypassing Verbs > net/mlx4: restore Tx gather support > net/mlx4: restore Tx checksum offloads > net/mlx4: restore Rx offloads > net/mlx4: add loopback Tx from VF > > Ophir Munk (1): > net/mlx4: restore Rx scatter support Hi Ophir, I am a little confused, can you please help me? Currently both mlx4 and mlx5 should support both rdma-core and MLX-OFED, is this correct? When I try to compile these patches with rdma-core, it is giving warning for shared library [1]. If I try to compile with mlx-ofed, getting missing header error [2]. What is the dependency for mlx4 driver now? [1] mlx4_rxq.o: In function `mlx4_rxq_setup': .../dpdk/drivers/net/mlx4/mlx4_rxq.c:393: undefined reference to `mlx4dv_init_obj' mlx4_txq.o: In function `mlx4_txq_setup': .../dpdk/drivers/net/mlx4/mlx4_txq.c:429: undefined reference to `mlx4dv_init_obj' [2] In file included from .../drivers/net/mlx4/mlx4_flow.c:66: .../drivers/net/mlx4/mlx4_rxtx.h:43:10: fatal error: 'infiniband/mlx4dv.h' file not found #include ^~~~~~~~~~~~~~~~~~~~~