From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8D66910A3 for ; Fri, 24 Aug 2018 14:35:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2018 05:35:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,281,1531810800"; d="scan'208";a="67565688" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga007.jf.intel.com with ESMTP; 24 Aug 2018 05:32:47 -0700 To: Tomasz Duszynski , dev@dpdk.org Cc: nsamsono@marvell.com, mw@semihalf.com, Liron Himi References: <1535113006-9393-1-git-send-email-tdu@semihalf.com> <1535113006-9393-2-git-send-email-tdu@semihalf.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 24 Aug 2018 13:32:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535113006-9393-2-git-send-email-tdu@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/6] drivers/common: add mvep common code for MRVL PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2018 12:35:21 -0000 On 8/24/2018 1:16 PM, Tomasz Duszynski wrote: > From: Liron Himi > > Add MVEP (Marvell Embedded Processors) to drivers/common which > will keep code reused by current and future MRVL PMDs. > Right now we have only common DMA memory initialization routines there. > > Signed-off-by: Liron Himi > Signed-off-by: Tomasz Duszynski > Reviewed-by: Natalie Samsonov > --- > config/common_base | 5 +++ > devtools/test-build.sh | 2 ++ > drivers/common/Makefile | 4 +++ > drivers/common/meson.build | 2 +- > drivers/common/mvep/Makefile | 38 +++++++++++++++++++++ > drivers/common/mvep/meson.build | 19 +++++++++++ > drivers/common/mvep/mvep_common.c | 45 +++++++++++++++++++++++++ > drivers/common/mvep/rte_common_mvep_version.map | 6 ++++ > drivers/common/mvep/rte_mvep_common.h | 20 +++++++++++ > mk/rte.app.mk | 4 +++ > 10 files changed, 144 insertions(+), 1 deletion(-) > create mode 100644 drivers/common/mvep/Makefile > create mode 100644 drivers/common/mvep/meson.build > create mode 100644 drivers/common/mvep/mvep_common.c > create mode 100644 drivers/common/mvep/rte_common_mvep_version.map > create mode 100644 drivers/common/mvep/rte_mvep_common.h > > diff --git a/config/common_base b/config/common_base > index 4bcbaf9..978592d 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -395,6 +395,11 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n > CONFIG_RTE_LIBRTE_PMD_FAILSAFE=y > > # > +# Compile Marvell Embedded Processors Common > +# > +CONFIG_RTE_LIBRTE_MVEP_COMMON=n Do you need a new config option for common, why not enable it if one of the consumers of common code enabled?