From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B641A00D7; Thu, 31 Oct 2019 10:49:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C09401C1D2; Thu, 31 Oct 2019 10:49:17 +0100 (CET) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 4EABE1C1D2 for <dev@dpdk.org>; Thu, 31 Oct 2019 10:49:16 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 0EC5180005E; Thu, 31 Oct 2019 09:49:14 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 31 Oct 2019 09:49:05 +0000 To: Ori Kam <orika@mellanox.com>, "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "jerinj@marvell.com" <jerinj@marvell.com>, "John McNamara" <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Adrien Mazarguil" <adrien.mazarguil@6wind.com> CC: "dev@dpdk.org" <dev@dpdk.org> References: <20191025152142.12887-1-pbhagavatula@marvell.com> <AM4PR05MB3425C21E79F05FD6BEA24142DB660@AM4PR05MB3425.eurprd05.prod.outlook.com> <fbdc0419-b93d-6e61-d6cf-341ecf101b13@solarflare.com> <AM4PR05MB3425460BDDBF44ED7D78362EDB660@AM4PR05MB3425.eurprd05.prod.outlook.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <a1a892a8-c83b-7c92-2d61-49d681e37383@solarflare.com> Date: Thu, 31 Oct 2019 12:49:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <AM4PR05MB3425460BDDBF44ED7D78362EDB660@AM4PR05MB3425.eurprd05.prod.outlook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25012.003 X-TM-AS-Result: No-15.992300-8.000000-10 X-TMASE-MatchedRID: 1ZHks2aQIkgeimh1YYHcKPZvT2zYoYOwt3aeg7g/usAg9j1J7DfFzLnx hIt+8oeINEWxillimf8a8DNIHWr8fmRZzgS9bzWm40jcxy3aXNp99ekRHlOQkSMjOm6mgJcrEYZ Wr6+tcLT8fXc5fzT2CIXlbGWGCMCztSzbDslijNRZZYpuBxXlgDoSfZud5+GgD6Aoo3z94hVXoY nJE8t84lewogAZKLw6aD7BynrNGtgxbjwEFJCV6vVY7U3NX8JgIj/yNb3TyWcHWPn2mj7oRFt/t 4oKYoaVBJC0KyClyaAuk8Nv87bZJXChPHB61wQjdPuue3cRiRhVogWRsEaR/gMADm5EdqKWoAJp cl+YzP+GJYEmsGtRnskWVeHghw5wGAjMJH/qe46OjIrMSa2sR2tNZoZ5+7ekXjPwAArs5rVR6tp SM+cpi1fA8HTThVtai76m4ZjJh1/vGL9eWoYGi56N6jXWJbQ3AKbvziCwm7i6Gxh0eXo7a4y+Af TlDGN18OIj2uCTZYtYckfk2t3eiPUZjbWnwyrhMpVOsYwN78Oo2aYwunfln39nRLJB1yYQ/X9k9 AS+0jm68HgiZ8R1bPgoEPVfdFrYZzIZWNJZm39armE127uhtlGyQSSKWoGS4Vo4xoaXBy9Q0yms otmReqB3NUs570Ueev1rNZvw9fXW79LHa+gibxcgeHvTy9iufS0Ip2eEHny+qryzYw2E8LLn+0V m71LcV0i4wYIU1inueL4ZNRL7EcRB0bsfrpPIUrADBF5LpdvCIn0cKYczZepV7KYRSM3cQ2QYTg OXm8lfdrxPGekRzvqJ+69SmKhap9Xk0+B4muk= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.992300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25012.003 X-MDID: 1572515355-hYukSrsUoMyQ Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 10/28/19 5:00 PM, Ori Kam wrote: > Hi Andrew, > >> -----Original Message----- >> From: Andrew Rybchenko <arybchenko@solarflare.com> >> Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an >> offload >> >> Hi Ori, >> >> On 10/28/19 1:50 PM, Ori Kam wrote: >>> Hi Pavan, >>> >>> Sorry for jumping in late. >>> >>> I don't understand why we need this feature. If the user didn't set any flow >> with MARK >>> then the user doesn't need to check it. >> There is pretty long discussion on the topic already, please, read [1]. >> >> [1] >> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Finbox.dpdk >> .org%2Fdev%2F3251fc00-7598-1c4f-fc2a- >> 380065f0a435%40solarflare.com%2F&data=02%7C01%7Corika%40mellan >> ox.com%7Ce3f779d4b7c44b682d6508d75b9d8688%7Ca652971c7d2e4d9ba6a4 >> d149256f461b%7C0%7C0%7C637078604439019114&sdata=sYooc%2FQ3C >> kUZG3gRFPlZrm8xMfMB9gOWWex5YIkWhMc%3D&reserved=0 >> > Thanks for the link, it was an interesting reading. > >>> Also it breaks compatibility. >> Yes, there is a deprecation notice for it. >> >>> If my understanding is correct the MARK field is going to be moved to >> dynamic field, and this >>> will be way to control the use of MARK. >> Yes and I think the offload should used to request dynamic >> field register. Similar to timestamp in dynamic mbuf examples. >> Application requests Rx timestamp offload, PMD registers dynamic >> filed. >> > In general it was decided that there will be no capability for rte_flow API, due to the fact that > it is impossible to support all possible combinations. For example a PMD can allow mark on Rx > while not supporting it on e-switch (transfer) or on Tx. > The only way to validate it is validating a flow. If the flow is validated then the action is supported. > This is the exact approach we are implementing with the Meta feature. > So as I see it, the logic should be something like this: > 1. run devconfigure. > 2. allocate mempool > 3. setup queues. > 4. run rte_flow_validate with mark action. > If flow validated register mark in mbuf else don't register. > If the PMD needs some special setting for mark he can update the queue when he gets the flow to validate. > At this stage the device is not started so any change is allowed. I understand why there is capability reporting in rte_flow API when it is about rte_flow API itself. The problem appears when rte_flow API starts to interact with other functionality. Which pattern/actions should application try in order to decide if MARK is supported or not. The right answer is a pattern/action which will be really used, but what to do if there are many combinations or if these combinations are not know in advance. Minimal? But I easily imagine cases when minimal is not supported, but more complex real life patterns are supported. The main idea behind the offload is as much as you know in advance as much you can optimize without overcomplicating drivers and HW. In the case of OVS, absence MARK offload would mean that OVS should not even try to use partial offload even if it is enabled. So, no efforts are required to try to convert flow into pattern and validate the flow rule.