From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6B2742C44; Tue, 6 Jun 2023 23:42:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C5D34067B; Tue, 6 Jun 2023 23:42:12 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2053.outbound.protection.outlook.com [40.107.93.53]) by mails.dpdk.org (Postfix) with ESMTP id 6192740223 for ; Tue, 6 Jun 2023 23:42:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JAkValQNijT473dVh+ZnYcMOtP+IkW9B5gDUkXHfXYB5kCf56N3MUcI8APuNNFt1Bby6y0sD+XeP3MbW64+tO9EQ3dZe+Bd7izEfIbwAhyOB97/CoegUYBueYe9EfQ+MlEY3dYqleslUfbBNhy45IKsRJDY5p8V/OG/1rVCRG9ABPZSaYsVhcv7om/bd4JIuMDZBhX7tRSI6ai4iOStbl6dzQxWmY5ObeNuykgU047J/3tHdpbS+7DmZKHGDC//yrttY5d4j5LC6n+88irNMVpDHzV7ozA4IHRdrSdveH+WXBfFycbXqPDKaaCt+rHdk9WYz/PWvh09zc/iIDVZp9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rIF1UElJY6KUjROD34ZXgUlnN8lgKyjl3NLhFMhZa7E=; b=VrNiEEevTqe6fZjO4hxTXJcnaYR07ghiCk150iNWi4lqe6UQmQLdBK3XVSz8H7Nf4hsNy3dN14tAzPfdXNrSgnYIqbIXy9EruCEYytGgXR9AbAeshRuTiH4G78H941RmTZWl3KO7KdagwqOoBCZSPafnLe46BSdj1uhJeojxGiYN6TFzbDpRdvuKdSx/u0ytJUk9IsVoEX6zU4cXqAofThO3mEMqSwwmYPBptqr2vIKebL295uH0ClQUxruUwQC/pjVkvEPni3Fiw07zT6lrLbS+X46Np5U/HnzVwfJfzE4jnEHPru+iLYNk+7fAX7JLs4rK9bSgRVY8y917fdtKtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIF1UElJY6KUjROD34ZXgUlnN8lgKyjl3NLhFMhZa7E=; b=a9mh9RA5kF1hZ8h5IQ6P4gDlaqFEq4ks+V5cwsx2/8jEHcjpwDhPauOi7xY3RHZ2fngC/acMQjlEBx/sp1ao2kEui5lTT/00bQsfbqPpVrsxiO174pC6wNri7ObU9eWbVlS1RK2mQpbEkOtgw+p0Hg9MG+59qdXUpJRCPxIMdL8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB7353.namprd12.prod.outlook.com (2603:10b6:510:20c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Tue, 6 Jun 2023 21:42:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::cf07:30f7:a92a:c53b%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 21:42:08 +0000 Message-ID: Date: Tue, 6 Jun 2023 22:42:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support Content-Language: en-US From: Ferruh Yigit To: Mike Pattrick , Aman Singh , Yuying Zhang Cc: ktraynor@redhat.com, dev@dpdk.org References: <20230602182928.1717802-1-mkp@redhat.com> <20230606211242.2855795-1-mkp@redhat.com> <3825b2b1-c40f-6bdd-4271-7b56c60795ac@amd.com> In-Reply-To: <3825b2b1-c40f-6bdd-4271-7b56c60795ac@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0584.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB7353:EE_ X-MS-Office365-Filtering-Correlation-Id: 90359450-710f-4113-d889-08db66d6e0a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6YDg5WtmPlXa1uKh9INvv+9yaZ1k+MBCzr7tUTp/P1iGtKkgtZk9kRGa+Y3u1PCbn4DkOVVxCUTBY0EOVV+9hVF+gVuSu7btqkO4ytz63AcYeElSfK3EK1x8OML0QRgqtLmhZ6EN+VJjdsYmIl+cdquqrHhLkrgU2Hu3cy/htcAzmt8TG1+md5bwgLeEhW9SuUL7vYxn1+GnghYMR3cTUZhvQkRJZeXC1G5NOpG5vo4kh2IghEMV1NKtEgPpbJHDWVa8M2t4D5c6qpg2tVd2K1xLIE3huACe2/6SzmX646pjfzeBIl+06Q6wyb1lJ4cEEK21NopnXtbTtjjd7JLfK9mHqNHwDG1qCslADoWsGFQXF/0WsfiGROvGJHF0CsrJ1btsly7jcfA4AAgx4/W+lgHgFXhL8Cdt9rqTndohEf4Cr4unL3xdrpSqGHapawz6nFAJw5UczQMj1Ilt6Q5Wfesjr0tPqeI3OT6AZY2+nAHtwXx/fH+30JbPphTqs3H9kuFwZ2jPGWN9T5WUDGQ6HKUuTrJ9XbTtbQgeB/xiA8zGXyZJuV5VHO9eCJNxHUiu8m9Xuc16PlGZ1fHpk3q4w9NQ2hyqJCQX6uYl+fDRiwzHXBhCncLjXB1nrZtA2hSYGx+8tzR5PBYm1qYyL7HNJw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199021)(478600001)(186003)(110136005)(36756003)(6486002)(6666004)(26005)(53546011)(6506007)(6512007)(41300700001)(83380400001)(316002)(38100700002)(4744005)(2906002)(5660300002)(8936002)(8676002)(44832011)(31686004)(31696002)(86362001)(4326008)(66476007)(66556008)(66946007)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVBDVVhLTDZvdExld2lqYSt6UnlQR1UrSDkyTm5vTnVMZ1I2SWhseUt5ZGVp?= =?utf-8?B?VGRHdU1HM2ZubFlkcjd6Q01UNzBvNXBqOVBoUGd5T3I3Sy9RdHRZY0ZVbW5C?= =?utf-8?B?Rk9CaFJqQVhzS1Iwc2F2ZzEwNy90ZllZaXNpOEVNNndFbjFBdTd3cmViYzgy?= =?utf-8?B?YjN4c0F5L1U2SFVwYytjcHVoNEtzOXg5VjVCTWVISEU4Y3llMjRZV0NlMzRD?= =?utf-8?B?SzRLSXYzQmgzQTU3OEVRYW0zb3c1R05mS2dQVjhudEl2T3VsbHpoYXdYa1VG?= =?utf-8?B?Ynd4eWRYNjdOMS85UzNKT0RaaHpReXhkL0JvMHBISHBMdlhtdXYrelZWMXJQ?= =?utf-8?B?VXNwbzVhdW1XSzVIYnlXZWttMVJlSzBIdnRJT2h3ajEzZ3llZElDSGV0b1di?= =?utf-8?B?bWl2YjcrV29aMnMwQVZ2STZheTZua0w3alhWbzZXcHQ0enVjdkZCd2xXbk5o?= =?utf-8?B?QTByN2hGV3h3eStzY2pCVjhEY3ZUZ1hvYnpldEJOdnZvUFF6K1RaNDArc2ow?= =?utf-8?B?Z2kySVMxTkc4VmZKWUFoUjlYSzUzQ2FSUVdZZnZaMjU5TnRJeDkwNEgrWk5t?= =?utf-8?B?b3NzNDd6bUUwRkVtU0FVSFJja3N5T1dKem9YNC9POVFQelJRM3VrUGMvR2VL?= =?utf-8?B?V3JVcm1PN0FjYzJlZjA5K1JXTTJwcXd0L1ZtdlZWRXN1QUNkTE9qbGo4SHBB?= =?utf-8?B?c2hyMitWeDRhS1dTSzQzQUlWd1o5WHVKZG92SmhlRjlrcDBxenhEREdURDJj?= =?utf-8?B?OFhDWFU1dVpERFlNcUtqenBIT1VseUNpOXhoR0RVS2p6UCt0ZzJJZ0ExMWh6?= =?utf-8?B?TytHcUVjODIyQm91R0VEeGM1MklpeXBjWHhvZmU3S3FDOGdCN0UxN1dCWTRi?= =?utf-8?B?MTZBdEZTT0RzQTRIcnZuNTFJSjYrblpRVXprVXJiNlhOWnMvY1FyMkx2eFVw?= =?utf-8?B?Q0VHVUtRREpSOEZZaHNwWmpNN2VFeHFvNStHOERvQUJBb0NMVUdibmlVamdB?= =?utf-8?B?TDUzakRGQ2hLYWJKdktZWHNpR2x0RXkzSUN3bE9HWUt6RnZCWjc4OHp5WFlw?= =?utf-8?B?Rzk4anlxRk02UkpaMnp5eEZRWW9xaE1zeXVaNm5pVjIzVmV1akhUTGovcUti?= =?utf-8?B?Q1grbHRmeHMwSG9mNDBNbkoyWEtadXFaZWgxSTYxVkkyenZzMk9EU1JEN1Zs?= =?utf-8?B?T3dvSVZBeTBmc2dVMXVMS2FCYTJlYU9NUnBVcmhvUVR0QkVqYTk0L3pSY29E?= =?utf-8?B?ZisrYmNMT3o5NmpsRWJCdXVVZXlUTXNiWFJaZWFEazRnbkF1MmhUbWdMQzkz?= =?utf-8?B?U0JsQ2F6eW5qa0VqZXVQTjRZdUVzZ0dlYldNdjZWMHErMU1LSEtPM01INks0?= =?utf-8?B?K3JlMVZCbGdiWG01bmVoQTRROENZb3lNeHJnc1M3ZGlGRjRuaW9jNTJ1a2pi?= =?utf-8?B?NTZVcHl4NTRrcVBscE5NWEtCR2Mra0pCT01YOUxaYjl2QVlLSDhaYTBOUVB1?= =?utf-8?B?MnRTNnFVTCt3UW90bXR6S0VHMFkwM2FhWEVVeFZNQnlRSVF1K0RidkM4K3Uw?= =?utf-8?B?RENJZVBvVWZNTm5iK3EvUGdxSDdOMnVEVGFwWURWN0UwTVNOYlNPUXhnZlpU?= =?utf-8?B?U3FpSjVkL0k5akRNOW1MaFlGRUpabnFBUFpza283UXNmb1hQQStXRG43VEt6?= =?utf-8?B?RytKcGFHaEdqU2Rqbk8xZEdENHl4WERjaXhFKyt6OFVMb2V4KzI2QXR0MkpC?= =?utf-8?B?cVY0eDlwQlh6SjZrbVAxUnpxYW9yNkRYc25ZSXdQTC95bENGUUJLcFJ4bTE1?= =?utf-8?B?aGl2ZWJmRWlNWjR2djlIRHVUNzhhWm1PV2I1M3F4bGg3UmRTdmNBd2hvako1?= =?utf-8?B?UnQrSWVxQk1wYjVScmJyUFVDQ3dITDlYQS9lc281TkJGYU5Sd1dRN0lhVXpH?= =?utf-8?B?UWlRUUxHeURkYXdvbWhNY2xGQVNMcHJZL3cwRXRsU3V4eTlxdHR3N3JIbGFn?= =?utf-8?B?NU5KTS9yTXhveFQ5OG9aYkJpUXUwYldvVW0zcmY2WFVUc1NBOHpxcStVTG9Y?= =?utf-8?B?cHdUQTA4djUyejlGeTVxd1J6RGdycGlrT1hEMTJFL0txbC9PUXBMb095cXEr?= =?utf-8?Q?/itH50T/JuATbuLWi2S/C+oo4?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90359450-710f-4113-d889-08db66d6e0a5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 21:42:08.2028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k7Py7neP0mFmN011t4scRF10QRtjbqCPLBQW6VIt5ej9j+66p8eKpNsLTOHb9nbp X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7353 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/6/2023 10:37 PM, Ferruh Yigit wrote: > On 6/6/2023 10:12 PM, Mike Pattrick wrote: >> Previously the noisy neighbour vnf simulation would only operate in io >> mode, forwarding packets as is. However, this limited the usefulness of >> noisy neighbour simulation. >> >> This feature has now been expanded to supporting mac, macswap, and >> 5tswap modes. To facilitate adding this support, some new header files >> were added. >> >> Signed-off-by: Mike Pattrick >> --- >> v2: Reverted changes to random memory lookup >> v3: Refactored entire patch >> v4: Implemented recommended formatting changes >> v5: Corrected copyright statement and formatting changes >> > > Hi Mike, > > There are some comments in v4 seems missed, can you please check the > comments? > My bad, v5 looks good, I was looking to wrong places, let me review/check this version.