From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D32741D93; Mon, 27 Feb 2023 22:44:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D6E440ED6; Mon, 27 Feb 2023 22:44:15 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2046.outbound.protection.outlook.com [40.107.92.46]) by mails.dpdk.org (Postfix) with ESMTP id 9E89240A7D for <dev@dpdk.org>; Mon, 27 Feb 2023 22:44:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZT6B/bRWFXASWuxNB180syMalJsNK1FL0ccLcgMwP0n9IzzcT1y7BmnrmdLAbVPTOjaaxVwUdmdYu19QI1B5TUWD/0A52kl8Eu3mc4usbKOy0T+zW+h9RN5kv1tH/R60k57w5lPSsoVPMEdoMKECUZFS51S/YofqTJRDpwJ9YbMg9msYBFCtv6J84YKJXbelKGhWQTM/i22sw84WrwH2AWoVC6no0mTsGGOM+KLgtWMtiHqNz70htR8rfJFfgvt/Y3eSbZslYz5v7wJqQRqj6Ki217+EYChq1feJb5G085FMzXwqwO+HEQhCLkFTDOocnZ4VD1SCiM44afJsb3SSMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ltZzYXYYLMfPqPk2dQ4kvHS3SEJC/3qlCLZarVdq5K4=; b=msrw6ouw/bEq9baNgTprMcH0Kd8t3PoHUTwnsXmNQ9XjK56A+Hsrp7X7Dk54daRe551udPmgg4Bt9mWNGVYYUKgT3/VcJoXUL112wZciqNJKiEJIXStwJ6Bu9f0JYP/yS2OjdEy6slEgKBjWwfp15PuuW9/bl6GJ6Qg9AyQRfgVFQYBXZ9X+R+wWN1jq9FjOmxynkNsGKmlJwUQFwGjQ3amZLVwWl1UD+3Eb7oTm6dUD+uh6S3Q/mhnSqGBJzCiD5ClA/eR96Fp+uwP7hKICgzKN80l74jvFi8+zzu62vjLz6hzN6k4hXp3fpwEkk3wjYbaVeeaTnUrZMKBC9Dz89g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ltZzYXYYLMfPqPk2dQ4kvHS3SEJC/3qlCLZarVdq5K4=; b=UJp3mrO/4DS3//vZF0fWcSisHD1yXM29bLl/a3xbJ7NbaWFGcsDJ3GQrQpLNEbImiHIdTVdvAXbJYZB2WBSpI/phXEOwy8EeWnFnwNsdb0mwDTOCGLAaFU4sOjockGosdHEpBZ6PHBkuis30L25UepuSpm83Rg1gOkINSROPnic= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BY5PR12MB4289.namprd12.prod.outlook.com (2603:10b6:a03:204::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 21:44:11 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 21:44:11 +0000 Message-ID: <a1cf9b85-ebd7-3cab-663d-7b5dd7ff8b35@amd.com> Date: Mon, 27 Feb 2023 21:43:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Mingxia Liu <mingxia.liu@intel.com>, beilei.xing@intel.com, yuying.zhang@intel.com References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com> From: Ferruh Yigit <ferruh.yigit@amd.com> Subject: Re: [PATCH v7 00/21] add support for cpfl PMD in DPDK In-Reply-To: <20230216003010.3439881-1-mingxia.liu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0476.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BY5PR12MB4289:EE_ X-MS-Office365-Filtering-Correlation-Id: 7dd58f6b-cdfc-49cd-040c-08db190bc33e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ptL8JaMZDTT45OkVNF6kYWrFTT37XdCsERnj7Lg1PxW6sCEjo3sv6E9jr54pgpvtOEbWrZr+gferirp9ZJwXwC/Zn9RCoOnzb/sh1M0hAxHiLELcbiiRFIQhedeDuZFvygPALvmxwQHfM5mqdk+LtYYawYqeXnS+MqKoY4SQN9bH8FqLDX/Jq/t2+LQHc7k1+duVSc4GO8u+dc5bE5enxNGRpZPvoTBGOD+S5NxqIbyDOhZWKya9OHvwkjit4BddYYFIjLdKTyjOIQCV8ODzUbQy6Day2n0/da1LR5DRfyRbh63WFd08KSF2RmVB9d+EKyDmTRx8JY+Cwl06Wwwe6WKLkegeN8TBJ3QIBpDRgQadpPoptcpazqDNCFepAt88oCt0BjVxIBWwquSuTpaI8dD0u5o65BN1fHiPmM38HgE4uri6o5yKn0gm6FiQ+pjfPFmO/Sel14eXJWddJLNvT439OhQCVqCFk5EEiKICrayGMGnZxHuZH+dxUpdY8SbGDmh06iybxlyFCQDrYFFSzkInAX+UO7pPTInjeSO38xn7mU9B0I5WHVJyPi4pr537XcDWfDl1JqN7Txo0zKj1DNubDHSYdetZVIm1ruWrISrEjjcrbQ08Qvo8zgEiydHuOAZvqXVGKMXlHH7jY7JuGnwl+liN6hzfmblYi/WWMJ7eMecy/p2XSe4zy5muRUlXLXfzMgXJsiUM2IUx5xqpVNR5L6KMjfZMWj+JQIbaXmhT1SMRJaiKTMu8SsVyUZH/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(39860400002)(346002)(136003)(396003)(366004)(451199018)(36756003)(16799955002)(6666004)(31696002)(6512007)(6506007)(6486002)(966005)(53546011)(2616005)(26005)(186003)(316002)(41300700001)(66476007)(44832011)(66556008)(66946007)(4326008)(2906002)(5660300002)(8936002)(478600001)(38100700002)(83380400001)(8676002)(86362001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFl6dlNzQks0SUZTcHR1RDBCR0hsOHBZbzVBUE5wV0gyKzYyVzFtZjdQaEV2?= =?utf-8?B?Q1BRRFh2VE81enZ2R0ljVS9aMjRKQUp3TC9pV2Y3V0dwSWE1Wnptc2wzUFIr?= =?utf-8?B?TEMvZEx6Z1lJMTVOd0NMSjQycWZzU0R1ek53WTNNSjBGZ2ZSWnh5aVU4SXNZ?= =?utf-8?B?Y3dKUVJIM1l6cHI2WS9EVzZhcmZpQU0wSlpPM1JXQ3gyTHNsZFA1UUJSUWQ3?= =?utf-8?B?T0N2aWhUVnNNL01vM0JCSHU4S1NJMjM4VkpQekg1OUt2STdIL29OQ2l3Rmpr?= =?utf-8?B?SkJOZmRheDUzZkpDdXFBNHVsUXdWMzJBNFo2L2JHM0VIME5oVVU1QmpVQWxm?= =?utf-8?B?dEdKTWdHNUhzK2s0clVZQzJmcllwYnd0N1RSMmFtNTNYdGRVUkxoUCtmZHB3?= =?utf-8?B?WFdpNUlOUzdpV2V2eGFvamxxazlzQUh6UmZBZGh5aFlDUlhweVlKN1JuWENs?= =?utf-8?B?Zm9LSE91ZUpHcFppaWRFQ1FyYlhFbFRUdCt6c05zVVk2UHluTnp2WFZHOW95?= =?utf-8?B?OXl1eWJaNGdyNnQ5QWlOcGFOY0d5V3IxaVBFbllQM0tFQUorUlhMTjc3Q0RW?= =?utf-8?B?dXFCYTNvd2dsZUxSRVdOaUhkdTV6cnVYQzk5UnZBTVJmZSt3cmljU2N6VVc0?= =?utf-8?B?Y1dodTQxMEJtNGRVc1MwdDkrYjBTd3RmdmpxZWhpcnEwMjZISU9UTGRxMi9X?= =?utf-8?B?b3pjS3dpZ2lOS003ak5QZzdETTdiUnJSdVhUVld0RTlWY3JYZFhwNTZrMEhC?= =?utf-8?B?SExpOFZNR3NRdjFTSTZ5MXU5SlhURDVkdGRSU1pkdnl3eks4NUVuSzkxbm1M?= =?utf-8?B?d2lXT2RxQkVzWEZjWDZrcHJ4YnRiVVJ2TEUxRDN1ak8wTVdZc0ZQWDBUNHg0?= =?utf-8?B?U1VSNVlpTUVra2hrNkFtU0JMbVc3SkFramh5NkpIZUY1bU9UTytaSFZ2Rm9h?= =?utf-8?B?THFldkVSdFc1cy9pVk1EVGt1M0VzSmxic0dMWkxha3FYeUNoNVh3WnBRanVn?= =?utf-8?B?RjJhUE9JV2FOREs2OEdWZjBIZldqTDBZaWxnMFpENDMzbVVtVUdqcXdwN0Jh?= =?utf-8?B?RElOb2lsaGV0VXVLUklKM2M4c1c2WnFQMm5rcjIycEVMWUx2T1IzWWxSZjhn?= =?utf-8?B?d2dNVGZoQ250MDl4UTZuZ3gzY1IrUnZaSWk4YlBnbSt0WFBZUTVCQk9peVNq?= =?utf-8?B?QmlLY2xyZzIxRVpZNkl3NkV1WGpGMk1lbWVjV1U4cmFldENQdkVJWTQ0Q2Vl?= =?utf-8?B?Q0lrdUZiK0FoWFJIcVNKbmlUQ2Z1Yjh4cm4zUGJaQVN3dVBhaVZDaUx6b2Q3?= =?utf-8?B?WmJzRTJRYlBXVVgvNityYU1qRnlsMDVHWFhka1BJZFR1VkEvdUFlV0tZUS9T?= =?utf-8?B?Q1NzRU93TzNocEZydHNnRXljSkxqM2p6YWxRNDVMN2M4Vy9IT1dpTnlyZU84?= =?utf-8?B?bGk2SEhOQW5pZm0weDRhOW5uQlRDZDZjbU85SHZ4czUxMWxVNjQzWGUveVph?= =?utf-8?B?WHQ5YnFvQTZuR2FpR2NPTUN6VXJSZ0lYU3oxTUtaZEhHTjJGcVFrbmh2S3c5?= =?utf-8?B?WFN0ZEpHSXJ4cUEvd01ub3I0NldKK3lQcERWMzhiTnZxODd0NjZZbit6Z0o5?= =?utf-8?B?ZTd5SEIrR1Vpd0xuSmoreUJxY044SndqenY5UzdBLzFBZGlVdk5zRFgweXlq?= =?utf-8?B?ZzNaVDVwSXJPTy8xdzJUbmxkdmxaZUcvMlF4WmdEQk5DeUU2YUJJVDFObHMr?= =?utf-8?B?ZDNzVllvUWVVZStucGNrRndSM1VTbFhUbU1xMWJQcWJTRW1ZczFQSUpXc2JY?= =?utf-8?B?U3k5ZUNWUjhQakhmSytKQlJLOVd5eUZsRXd5dWZnMnBrbHAzV003RnNjVzlQ?= =?utf-8?B?cnBERmZBS3A1M1JmaXdrUFlmVVN1SWlScE40Sk42Wmk2d05CMVVlRS9OZ2Fj?= =?utf-8?B?WEJBczN3Y0ZXdmtsOGYxa0JHcDUzaHVub2ZTbkY4Y291VjY5aDFkNHpCWk1D?= =?utf-8?B?UHZoc1BRMjNySDBITVdwd3p6T3AxTDRBNW9RMVl5NTBJUEo3Vi9ab2Q0KzlV?= =?utf-8?B?MXhoSnYxTkRLaVRZdjhqVTFOZWxEY0VndXQxUnpXa0hWS0xXc2lrZzFza04y?= =?utf-8?Q?SM3CPx1Q/Yu06B8gokGFX/EsI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd58f6b-cdfc-49cd-040c-08db190bc33e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 21:44:11.6044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pBwdgzK1Osj19CLvAe2LRaO+GrJjt7Am+6zzuE2xwyMv8uIJvZz+stgj7xQZgssQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4289 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/16/2023 12:29 AM, Mingxia Liu wrote: > The patchset introduced the cpfl (Control Plane Function Library) PMD > for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) > > The cpfl PMD inherits all the features from idpf PMD which will follow > an ongoing standard data plan function spec > https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=idpf > Besides, it will also support more device specific hardware offloading > features from DPDK’s control path (e.g.: hairpin, rte_flow …). which is > different from idpf PMD, and that's why we need a new cpfl PMD. > Hi Mingxia, Beilei, Yuying, Do you know if is there any effort to make device specific offloads part of IDPF spec? Overall, working on a standard interface and upstreaming driver for it (idpf) but next product is diverging from the standard and requiring a dedicated driver, do you know if 'cpfl' is a temporary solution while standard gets required update or is it a long term difference between standard? > This patchset mainly focuses on idpf PMD’s equivalent features. > To avoid duplicated code, the patchset depends on below patchsets which > move the common part from net/idpf into common/idpf as a shared library. > > v2 changes: > - rebase to the new baseline. > - Fix rss lut config issue. > v3 changes: > - rebase to the new baseline. > v4 changes: > - Resend v3. No code changed. > v5 changes: > - rebase to the new baseline. > - optimize some code > - give "not supported" tips when user want to config rss hash type > - if stats reset fails at initialization time, don't rollback, just > print ERROR info > v6 changes: > - for small fixed size structure, change rte_memcpy to memcpy() > - fix compilation for AVX512DQ > - update cpfl maintainers > v7 changes: > - add dependency in cover-letter > > This patchset is based on the idpf PMD code: > http://patches.dpdk.org/project/dpdk/cover/20230206054618.40975-1-beilei.xing@intel.com/ > http://patches.dpdk.org/project/dpdk/cover/20230106090501.9106-1-beilei.xing@intel.com/ > http://patches.dpdk.org/project/dpdk/cover/20230207084549.2225214-1-wenjun1.wu@intel.com/ > http://patches.dpdk.org/project/dpdk/cover/20230208073401.2468579-1-mingxia.liu@intel.com/ > > > Mingxia Liu (21): > net/cpfl: support device initialization > net/cpfl: add Tx queue setup > net/cpfl: add Rx queue setup > net/cpfl: support device start and stop > net/cpfl: support queue start > net/cpfl: support queue stop > net/cpfl: support queue release > net/cpfl: support MTU configuration > net/cpfl: support basic Rx data path > net/cpfl: support basic Tx data path > net/cpfl: support write back based on ITR expire > net/cpfl: support RSS > net/cpfl: support Rx offloading > net/cpfl: support Tx offloading > net/cpfl: add AVX512 data path for single queue model > net/cpfl: support timestamp offload > net/cpfl: add AVX512 data path for split queue model > net/cpfl: add HW statistics > net/cpfl: add RSS set/get ops > net/cpfl: support scalar scatter Rx datapath for single queue model > net/cpfl: add xstats ops > > MAINTAINERS | 8 + > doc/guides/nics/cpfl.rst | 88 ++ > doc/guides/nics/features/cpfl.ini | 17 + > doc/guides/rel_notes/release_23_03.rst | 6 + > drivers/net/cpfl/cpfl_ethdev.c | 1453 +++++++++++++++++++++++ > drivers/net/cpfl/cpfl_ethdev.h | 95 ++ > drivers/net/cpfl/cpfl_logs.h | 32 + > drivers/net/cpfl/cpfl_rxtx.c | 952 +++++++++++++++ > drivers/net/cpfl/cpfl_rxtx.h | 44 + > drivers/net/cpfl/cpfl_rxtx_vec_common.h | 116 ++ > drivers/net/cpfl/meson.build | 40 + > drivers/net/meson.build | 1 + > 12 files changed, 2852 insertions(+) > create mode 100644 doc/guides/nics/cpfl.rst > create mode 100644 doc/guides/nics/features/cpfl.ini > create mode 100644 drivers/net/cpfl/cpfl_ethdev.c > create mode 100644 drivers/net/cpfl/cpfl_ethdev.h > create mode 100644 drivers/net/cpfl/cpfl_logs.h > create mode 100644 drivers/net/cpfl/cpfl_rxtx.c > create mode 100644 drivers/net/cpfl/cpfl_rxtx.h > create mode 100644 drivers/net/cpfl/cpfl_rxtx_vec_common.h > create mode 100644 drivers/net/cpfl/meson.build >