From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4F82A0487 for ; Wed, 3 Jul 2019 12:47:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83CC01B94E; Wed, 3 Jul 2019 12:47:25 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8F60B1E25 for ; Wed, 3 Jul 2019 12:47:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 03:47:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="157931233" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.126]) ([10.237.220.126]) by orsmga008.jf.intel.com with ESMTP; 03 Jul 2019 03:47:21 -0700 To: David Marchand Cc: dev , Thomas Monjalon , Stephen Hemminger References: From: "Burakov, Anatoly" Message-ID: Date: Wed, 3 Jul 2019 11:47:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03-Jul-19 10:38 AM, David Marchand wrote: > Hello Anatoly, > > On Thu, Jun 27, 2019 at 1:39 PM Anatoly Burakov > > wrote: > > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > A lot of the patchset is a search-and-replace job and should > be pretty easy to review. The rest are pretty trivial EAL > changes. > > This patchset depends on FreeBSD fixes patchset: > > http://patches.dpdk.org/project/dpdk/list/?series=5196 > > v3: > - Rebase on top of latest master > > v2: > - Collapsed all changes into fewer patches > - Addressed review comments > - Created a new file to store the code > - Changed namespace to "rte_mcfg_" > - Added some unification around config init > - Removed "packed" attribute from mem config > - Removed unnecessary inlining > - Added a check to explicitly forbid running multiprocess >   applications that differ in their DPDK versions > > > > For the parts I already had a look at, I still think the changes are in > too many patches. > A lot of this is just search/replace we can have it with the patch that > introduces it. > - patch 1, 2 and 3 could be squashed as a single one (plus removing the > unused macro from patch 8) > - idem with patch 4 and 5 > - idem with patch 6 and 7 (plus removing the unused macro from patch 8) > > > I will look at the rest tomorrow (hopefully). > > -- > David Marchand Sure, i can squash it down into single patches for search/replace if that's the preference. -- Thanks, Anatoly