From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A281A0521; Tue, 3 Nov 2020 13:35:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E167C9CC; Tue, 3 Nov 2020 13:35:13 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 38AE3C966 for ; Tue, 3 Nov 2020 13:35:12 +0100 (CET) IronPort-SDR: cxiJWTBKratCQCMBhnuZCmeje/91qOeTr6aEb1vacZun7r5WfQIV5O/GbWwfs8ne0vFOMU4U7X bXNaKUwESAhw== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="165540424" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="165540424" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 04:35:10 -0800 IronPort-SDR: 82SGzG5oscT/cSCTcQJP413i0tXbr2A0lB5dUzRWS2ruA5nuvz+X1uoyuagz23Z2PqH+NbxAo0 G4y/b8ZdHHMA== X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="538476990" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 04:35:09 -0800 To: Andrew Boyer , dev@dpdk.org Cc: cardigliano@ntop.org References: <20201102183527.69209-1-aboyer@pensando.io> <20201102183527.69209-2-aboyer@pensando.io> From: Ferruh Yigit Message-ID: Date: Tue, 3 Nov 2020 12:35:05 +0000 MIME-Version: 1.0 In-Reply-To: <20201102183527.69209-2-aboyer@pensando.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/8] ionic: update documentation and MAINTAINERS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 6:35 PM, Andrew Boyer wrote: > The ionic PMD is being actively maintained. > > Signed-off-by: Andrew Boyer > --- > MAINTAINERS | 5 +++-- > doc/guides/nics/ionic.rst | 13 +++++++------ > 2 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5b390d1d8..7afed5f0a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -842,8 +842,9 @@ F: doc/guides/nics/pfe.rst > F: drivers/net/pfe/ > F: doc/guides/nics/features/pfe.ini > > -Pensando ionic - UNMAINTAINED The trigger to mark PMD unmaintained was it didn't comply with new close dev_ops behavior [1], can you please make that patch before updating the status? [1] https://patches.dpdk.org/project/dpdk/list/?series=12565&state=* > -M: Alfredo Cardigliano > +Pensando ionic > +M: Andrew Boyer > +M: Pensando Drivers Hi Andrew, Welcome. I think better to not include the group as maintainer, it is very hard to follow who is behind it and who it actually responsible when a group is added. Can we just use actual people for the maintainer? > F: drivers/net/ionic/ > F: doc/guides/nics/ionic.rst > F: doc/guides/nics/features/ionic.ini > diff --git a/doc/guides/nics/ionic.rst b/doc/guides/nics/ionic.rst > index fd32926bf..2a394d15d 100644 > --- a/doc/guides/nics/ionic.rst > +++ b/doc/guides/nics/ionic.rst > @@ -1,5 +1,5 @@ > .. SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) > - Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved. > + Copyright(c) 2018-2020 Pensando Systems, Inc. All rights reserved. > > IONIC Driver > ============ > @@ -7,15 +7,16 @@ IONIC Driver > The ionic driver provides support for Pensando server adapters. > It currently supports the below models: > > -- `Naples DSC-25 `_ > -- `Naples DSC-100 `_ > +- DSC-25 dual-port 25G Distributed Services Card > +- DSC-100 dual-port 100G Distributed Services Card It was good to have product documentation, I see the old ones are not available now but can it be possible to replace with valid ones instead of removing? > > -Please visit https://pensando.io for more information. > +Please visit the Pensando web site at https://pensando.io for more information. > +The `Documents `_ page contains Product Briefs and other product information. > > Identifying the Adapter > ----------------------- > > -To find if one or more Pensando PCI Ethernet devices are installed > +To determine if one or more Pensando DSC Ethernet devices are installed > on the host, check for the PCI devices: > > .. code-block:: console > @@ -28,6 +29,6 @@ on the host, check for the PCI devices: > Building DPDK > ------------- > > -The ionic PMD driver supports UIO and VFIO, please refer to the > +The ionic PMD driver supports UIO and VFIO. Please refer to the I think "PMD driver" is wrong since 'PMD' is "poll mode driver" > :ref:`DPDK documentation that comes with the DPDK suite ` > for instructions on how to build DPDK. >