From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 377A9A04B5; Sat, 21 Nov 2020 22:50:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E8723B5; Sat, 21 Nov 2020 22:50:21 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 67ABB160 for ; Sat, 21 Nov 2020 22:50:19 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id a186so11522671wme.1 for ; Sat, 21 Nov 2020 13:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=9XCLNzcQf4MUMBBjvQp582swhTjc8DjVUw/KAijTLec=; b=gKAi+3dd8eUhaPYKOMmS5+8vMHuA+AJ+5vWm3tcqU/58NQLxUjB/gu9ii+B5Yg+Epd n32nz9/X6pZNZ7ApeIch58z/F1NujBpCVa2ZrPCCP2El//3iYd5PB8P/3Bhi3FCtiy2j E2zSiyZBwBfZ5Fe/HR72WQAcMgrArtaRtfKaOC7PlxLAdQ/HX6QZDH6bes3pPmPWnLLa mCIIcZRkI2YOH+keE4YdZtT27gPp+p9p4saqlj/VPYLyWkCOwrwAv77cME3JP9F+XC/F 69EGRKI1VveT65ggAR9CgZA0v4Pu5xMrD9PKVU4lDh4yS0lOOD14JTqLZnO0dMhmWdUG xyDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9XCLNzcQf4MUMBBjvQp582swhTjc8DjVUw/KAijTLec=; b=BYIEW9z5fQutp3iitwhsP2z25ViY4b+MOzoqr0atYNPFCFxVWNt/IGqwsrwn7TT1gN jc028B04vNVOnaoKzPw4zK+5ksAyemWOxOZ5yE1CpeEczb8usiIlmCAJ+jrRjktJt2Rs 3xiTA/bK/WV4NVQOG98YVUKOpefBWG+9TY2jyxnxsrbrd/Rt+eJGegft7hHT1e0Ge1du LbP978gbcEsKaGdb0meb1XC1u4+T03BlZ4ELrCHLlCEzm1T4v9mVu2UQ9BuO9CyG2JT9 rMB4oDkPo9KUIENgz2Sz82U+n6N0RHWTbwSJCOL7ac/N2eOniFyunyGr6V83alTJOxPA eR2A== X-Gm-Message-State: AOAM530xjNqDWN+nbbiOFxxygEaHlrsp/4+APwqjXX2KS8LjtXPrTdQi bvu8Dz21W5P56XppO5GgclsJtqRKGOsG/Xmb X-Google-Smtp-Source: ABdhPJza6qBWYFH22j+IFw8tIVAKqwgAFGRylRuTGVD0U1JENGBdPrt+pT/WSaO7B7FAfyEQ0m70SQ== X-Received: by 2002:a1c:44f:: with SMTP id 76mr16757917wme.181.1605995418509; Sat, 21 Nov 2020 13:50:18 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id z6sm8808832wmi.1.2020.11.21.13.50.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Nov 2020 13:50:17 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk Cc: Tal Shnaiderman , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tal Shnaiderman , "dev@dpdk.org" References: <20201120211255.24803-1-nick.connolly@mayadata.io> <20201121234725.6b9c823d@sovereign> Message-ID: Date: Sat, 21 Nov 2020 21:50:15 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201121234725.6b9c823d@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, On 21/11/2020 20:47, Dmitry Kozlyuk wrote: > I disagree. Just because we have rte_windows.h to properly plug Windows SDK > in, other DPDK code doesn't need to care about these details. Unused GUIDs do > take some space in static libraries, but IMO it's a fair trade for ease of > development. They shouldn't have any impact on resulting binaries. Ah!  I hadn't spotted that rte_windows.h is intended to wrap the Windows SDK. In which case, I agree with you - best to take care of it there. Regards, Nick