From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0060.outbound.protection.outlook.com [104.47.37.60]) by dpdk.org (Postfix) with ESMTP id 9CD1A2C2E for ; Tue, 16 Jan 2018 08:26:27 +0100 (CET) Received: from BN3PR03CA0109.namprd03.prod.outlook.com (10.174.66.27) by DM5PR03MB2697.namprd03.prod.outlook.com (10.168.197.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Tue, 16 Jan 2018 07:26:26 +0000 Received: from BN1BFFO11FD015.protection.gbl (2a01:111:f400:7c10::1:102) by BN3PR03CA0109.outlook.office365.com (2603:10b6:400:4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Tue, 16 Jan 2018 07:26:26 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD015.mail.protection.outlook.com (10.58.144.78) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Tue, 16 Jan 2018 07:26:25 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0G7QMCF013886; Tue, 16 Jan 2018 00:26:22 -0700 To: "Gujjar, Abhinandan S" , "Doherty, Declan" , "Jacob, Jerin" CC: "dev@dpdk.org" , "Vangati, Narender" , "Rao, Nikhil" References: <1516017078-166766-1-git-send-email-abhinandan.gujjar@intel.com> <5612CB344B05EE4F95FC5B729939F780705FED56@PGSMSX102.gar.corp.intel.com> <5612CB344B05EE4F95FC5B729939F780705FEDDD@PGSMSX102.gar.corp.intel.com> From: Akhil Goyal Message-ID: Date: Tue, 16 Jan 2018 12:56:21 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <5612CB344B05EE4F95FC5B729939F780705FEDDD@PGSMSX102.gar.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131605611859592149; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(396003)(39380400002)(376002)(346002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(13464003)(24454002)(189003)(199004)(229853002)(67846002)(8936002)(36756003)(86362001)(85426001)(498600001)(31686004)(58126008)(77096006)(26005)(81156014)(81166006)(104016004)(8676002)(68736007)(97736004)(65826007)(305945005)(83506002)(356003)(110136005)(76176011)(31696002)(53936002)(2950100002)(316002)(64126003)(105606002)(106466001)(54906003)(53546011)(47776003)(93886005)(6246003)(65956001)(23676004)(65806001)(2486003)(4326008)(5660300001)(230700001)(2906002)(59450400001)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2697; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD015; 1:i/AJ/lqNcEtdqa8KpSSjjbcc5t85v/Wv4iJTAjbv6xITCHK7DFjY3ywL0PmHtjogVgDyo2PGNCuSOCQPW4pQ3BQ13EWMMLfIdDWBrwg3/Z4KDiLAatHQVHoL2MGI+3os X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 164a21c1-a6b1-4000-c3d5-08d55cb273cd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:DM5PR03MB2697; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2697; 3:ZsX9Pe0KrYkc2LzdVG9t5Dl0edLhcr61WKa7T2poZTUf/c7c9tSI/vJ2UEtrVs7i9D1dVBUONTYdH2msN6PFnMHbXEZCjN5blDWN1zo9MrTJWn7haI/UcWuoswZEKRNWfzxWXn+CAbrMIMFyLCbhJG4OX7QxaRpfrqjHrFT+VeS4S/YcSVb4+AGAJZ2+fq5YaQ6Hg6/ZTnTZmzQdcKBZHNDdM+r8/ScEFpdtTLnqogT7I6IqYp6cyv6RXeuGL10lrJrGRrIn13t5cAs4XAlVFV3u1LnCGq2x4UpzdiHVAGogSc8F5vBofAO1zX5rlD/uFCNiI0YR4ec+IxImPn4wd+WMxI0+Gd5w2aUaPChjLsY=; 25:MN4VtHjbZVvbEK4Kt52diDfoWXuSxvItjHLjeNLHUzkRvHGzhsFR5IWvkq9mtFbFQ/sH2sr1bhINQ/DTGc3wgC/eW6TElAlaIWItbM9QogPMg6AvNrkbFLoPsqsE7LlFL6VBl6hP6gZWw+52CHaalz9m9xGieg6VWoqO/+McLl4Z6AYiAL8s/IBDg47fwSAZGzYwKbXpxC6ifl5mI2Wjz5eO72rx6DbG7Ur8gvAIc63xMVtFRRHY0t2jfSX0l5SL5W8QmIxk2th7YNWqtMKdOZpf0g/8Tt+DzqwSPG9Zr824RTSCv66RdMB5jcgNa8jAY5H1SrVKaiEyRY74yCdb2g== X-MS-TrafficTypeDiagnostic: DM5PR03MB2697: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2697; 31:Yo0aEjoS4doABvnktMQ5I0l0MkiPEe1TBXfXWeWYGN0ef2O4TeuPi0GqltK0NQOxPobi7Pfi/USJITDzdjh/ezgJjhY3mf3xsUmuA20dKmDKwmT+U3pKmdYlj+ZCoONkVwbUrNlmRF8QtbwGItPwWgjPqVTWu8cSJfmzTppOl4DUXulfaVcSRPSNeKnD1zlPa0k+8venAGU45h/1F/1RCsQDLwQky27Wwfssjt9s/uM=; 4:xojsLwin/EUy8+wir+3hkJz8GCIYaRSfOKWfUq/2EJwxHeVNwgmOpAGmmWSOWZmHp6y/75iRpefI0pZGKApEYnrYS34P5yFW9YhnS3hxkqVpdAoCftkGG+llmFExXcMqy5CD0ougbMLAQYpnYNzcR5tmoDboOoF7rl5TSPeovfP7zUegcxVsuTI1v2vAW4d+i3uKvBXlOLIoOi69m79J+4fWipmDgVxMybPjMVlnSbu+dyOlwhRyfBm4zHW5xM2ejsUXBRX3U2v3kVymAxct3DxXelao20lO4nO5AE50jtskyQ9eByfSUDuQ6Yrf9v0z4gdPjU5KNuj9fL0CtqQQGwsI5kKZtKksQxvQ4/IB8v9pAGiSNvUCcSainbwtqWkx X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231023)(944501161)(6055026)(6096035)(20161123561025)(20161123565025)(20161123556025)(20161123559100)(20161123563025)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(201708071742011); SRVR:DM5PR03MB2697; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:DM5PR03MB2697; X-Forefront-PRVS: 0554B1F54F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAzTUIyNjk3OzIzOmg1VEJpbElDNFd4anJmT29KdkFoYXE3MFUr?= =?utf-8?B?Wm1XZm5RK1lkZE1EaHNtSlo4cGcrMzJUVklTbitiV2t3Qjd4T3pMbjRqM1ho?= =?utf-8?B?dUw3c1NGYllDeG1ucWQwdXBySkxBUFdmSXBReVF6WjJlQWtoZXJYS1lGLzRr?= =?utf-8?B?V1ZFUWVmM0FzQ0ptdk15U0lGZDhiK3cwUXV0M1NUbW5QOWgrLytIdTFpUVBR?= =?utf-8?B?NXZ5WFRrcXdtM0srMDlGZnVUUStRNHRFM1JLQlVqQS92a3RXci84M3pZSmwz?= =?utf-8?B?Z29FNFcwYy8yTWRtQ2xZTHZYZkY2OHVZT0VRN2hobWpOV1poUzBDWWlPZnk4?= =?utf-8?B?bVk1b0FuQ0hBSmRpSWhVV1JTYnRxbVpzTmZJRG5sdGorZ3hHV2NxRkg2dGJt?= =?utf-8?B?d0plbmRYRWVZU29JY3BPWjRaaWd2RVRjMW56eGJYK0tkWWZFYTIyYzBQRTgy?= =?utf-8?B?VXlsRVdYZXZsMUpKRE5xUWFHdXE2VVJzTzRNV1l2TVdDa0tQR3BJRURlZDZw?= =?utf-8?B?Z0t1YmRDczNBQ0liSUtwdGFkYnhON3J4Vjk3SldHcFowYXVrMkY0bkd3cGZa?= =?utf-8?B?SGlyaXBQclVhKzZIcjc5Q2c2MW50VksvcWNna015aWcvRWhNMEpWYXovY291?= =?utf-8?B?cTg3VFViSmIva2cyZDlJVFVWL0lHK0JhWk9XS3Y3OWEzcUNrV0tVV1grd3Ry?= =?utf-8?B?TnNocTlsY3FxQ1JoR0E4bWkxM1Y4Yk90S0FyMUtvNDJkamV3TzdzUjBjRHo5?= =?utf-8?B?R2Y4Q1FzMVBFRXdmb3pEZUEzbDg3T3l1WVZXZHp5aitaU0VTSDRCZ05WRDcx?= =?utf-8?B?b1ptWnhHSjFGa1NUZjJVeTRqUXJJeXMrNW9GMUFJbWVsTUR5cFhXcExvVW1Y?= =?utf-8?B?dkFySTRPcit2bHJOcWg1WTkwb2N5OGhXNXM2eGo0Z0lXWVREYTZzcXEvOTk0?= =?utf-8?B?ZTd0a1JmbUNGY29peEVrbTNONWd4SHVLdGZDZUxOLzFvdWZEQ1JmVDJzVWds?= =?utf-8?B?TnJ5ZGNGcjlJZjBzWGViMnRIdEFHV0R0eFpRYWRqOXpRZGdZMG5aOXhjZUlH?= =?utf-8?B?eVJvY1FwNy8zaE1JL1UrRkFRbzVUSGV5Vnk5M3lXZnF4cU80QkVvd2lRajM0?= =?utf-8?B?ajF2MTNWMGVsZkxiKzIrbjZ5bnlCajNvc0EzZEpJcjlTVTU5OU5NRnFkT2ds?= =?utf-8?B?Y05Bd2VKbGRsRjNpV0NqWGdJdlg2TkpkT2c3SGFLYTJTRGlBR0REbms3RzIx?= =?utf-8?B?R2pXYVE1RDVRSEV0VUQ3a3QyMjJLTWtrRllDOWM4ZnJNWEd3UnU5cnVZME5m?= =?utf-8?B?bEtrNWUwUWxrL3hMUWVqTGlSbGpZV3FSbG1JZlJ6aXVKMS93N0FQL3laMU95?= =?utf-8?B?WVpFU3JWZXRENnlrQlU4L3lMeU5ycEZTVnZrV04rK241YS94R2lqMytFYU9v?= =?utf-8?B?RVFCQ3J1ZHl2dDNCdWNBZCtoNHdQR1ljSjJpRVFNUU1XbFBSVE52a1pJWmVL?= =?utf-8?B?VE5ZY3lVb2FIWGF0TEhtd1R2SUp4OFcveTFoMThGS21hSU1GdlZMYmtxdHQx?= =?utf-8?B?WVByQnJnV3J3WkkrVWdiZjJ2TU1XcS9QVVhWelQ5VHFBWXRYcGdPNEx5eG9l?= =?utf-8?B?dFMwRUZXSS9nT29rbS9xSVA1V2RlWmF1Wm5XWHdVaHV5UFFHb2dscU9LcTA3?= =?utf-8?B?dGxBZitISyt3MVUvT1B0MWVtcmdveU5OaFhjdG96WUVuS2ZRNjB1ci9QTjVv?= =?utf-8?B?bnhuSEgvNEFnemhZZTdCMmRFYmk5aGFjbjZ6Z0JiaVhsUDhqMThpVGpEZlVr?= =?utf-8?B?c2RJVWxXZGpNbVhrZ2xLNEo5QytNMk1FRU1JZlZHY3hySGo5S3Jaem9UeHBK?= =?utf-8?Q?D/bTZQ0hm1c=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2697; 6:6TPbNe8shGa1kN0s3cX4I0/Wn/QH3pflWZro4hvSE6H11xmONu3J+2bGXmthaA8pRLtoz/MEWdHHifRoK+1fA7yK+SRshmkn7G2XrbxsXV6c1sVTJc2tBcLqQuarYEjzLoEcvaFChBm72uT7T0wKcZWLJuGpplmMyw82WSxgqiS7tRb/vqjEVHC/5uWY+t01ObyG2STF4yPXIpYXPJMP253pWtfBDJkPIyXlL0Lpwxz8HCeF7kn9X1jcszvCO/BZP4zaLnDwQ2h6GbA0LoV+IrF4xTbU0N8hsG8cdG07z22rwmEmy2HZCd3KoBMWDVwlQL9A43ofUSFSpZmxFt2v1alMCC4dwdNoCX+mgYpuDSQ=; 5:heFGJo+L1VtSx+0Zva5vrCl45lG4zxdOLxL58GhoCNgTWYd1NyA7duhaOkMLUnBqZOsMertg+D5dppICOVgZTStk97jGwY5MpLF0CuTrgUBTFsr5Ll+kDHI6MaQT7taNNp2Sft2wZ5ii9IbNJKY3D8lQsnxOIguLSx9BZP9OVZI=; 24:oZsSNEdvziCYPVIj0xEWNs6xqN3HQeklqZOjD1vA5TgtK2RsV3cmJ/Ri/vRmmmL2nT0eBnj4RbYzO1lgAHFq8LxvaNzVC8DOkOQkRWNUGew=; 7:kcAAOC5V8Ty/XZVTwQQrrQztnlKjaDdJgixK1iNRB8M21N19NmqDBP3T9YjlCjq0o2rtvBoPy0RTCzyRJEWgyu5RYheAel3AzxeTy0NOhQH4V+iirm2Jau7EFr+xgMdqqTzVsyv06ReTAwa5kfhLmKiugAOMHUR2+6p/hXZjP8TgQJ8hB/FDlwV9543gIsZF1g4JQwniat4qhf3Bj0eWp5H32LH2UveGWDvmdQ4TERZH4fzT0GWHv/dxA3HsjjLH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 07:26:25.7564 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 164a21c1-a6b1-4000-c3d5-08d55cb273cd X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2697 Subject: Re: [dpdk-dev] [PATCH 1/2] lib/cryptodev: add support to set session private data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 07:26:28 -0000 Hi Abhinandan, On 1/16/2018 12:35 PM, Gujjar, Abhinandan S wrote: > Hi Akhil, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Tuesday, January 16, 2018 11:55 AM >> To: Gujjar, Abhinandan S ; Doherty, Declan >> >> Cc: dev@dpdk.org; Vangati, Narender ; Rao, >> Nikhil >> Subject: Re: [PATCH 1/2] lib/cryptodev: add support to set session private data >> >> Hi Abhinandan, >> On 1/16/2018 11:39 AM, Gujjar, Abhinandan S wrote: >>>>> diff --git a/lib/librte_cryptodev/rte_crypto.h >>>>> b/lib/librte_cryptodev/rte_crypto.h >>>>> index bbc510d..3a98cbf 100644 >>>>> --- a/lib/librte_cryptodev/rte_crypto.h >>>>> +++ b/lib/librte_cryptodev/rte_crypto.h >>>>> @@ -62,6 +62,18 @@ enum rte_crypto_op_sess_type { >>>>> RTE_CRYPTO_OP_SECURITY_SESSION /**< Security session crypto >>>> operation */ >>>>> }; >>>>> >>>>> +/** Private data types for cryptographic operation >>>>> + * @see rte_crypto_op::private_data_type */ enum >>>>> +rte_crypto_op_private_data_type { >>>>> + RTE_CRYPTO_OP_PRIVATE_DATA_NONE, >>>>> + /**< No private data */ >>>>> + RTE_CRYPTO_OP_PRIVATE_DATA_OP, >>>>> + /**< Private data is part of rte_crypto_op and indicated by >>>>> + * private_data_offset */ >>>>> + RTE_CRYPTO_OP_PRIVATE_DATA_SESSION >>>>> + /**< Private data is available at session */ }; >>>>> + >>>> We may get away with this enum. If private_data_offset is "0", then >>>> we can check with the session if it has priv data or not. >>> Right now, Application uses 'rte_crypto_op_private_data_type' to >>> indicate rte_cryptodev_sym_session_set_private_data() >>> was called to set the private data. Otherwise, how do you indicate there is a >> private data associated with the session? >>> Any suggestions? >> For session based flows, the first choice to store the private data should be in >> the session. So RTE_CRYPTO_OP_WITH_SESSION or >> RTE_CRYPTO_OP_SECURITY_SESSION can be used to call >> rte_cryptodev_sym_session_set_private_data or >> rte_security_session_set_private_data. > Case 1: private_data_offset is "0" and sess_type = RTE_CRYPTO_OP_WITH_SESSION -> usual case > Case 2: private_data_offset is "0" and sess_type = RTE_CRYPTO_OP_WITH_SESSION + event case (access private data) > Differentiating between case 1 & 2 will be done by checking > rte_crypto_op_private_data_type == RTE_CRYPTO_OP_PRIVATE_DATA_SESSION. Consider this: if (sess_type == RTE_CRYPTO_OP_WITH_SESSION && rte_cryptodev_sym_session_get_private_data == NULL) usual case. else if (sess_type = RTE_CRYPTO_OP_WITH_SESSION && rte_cryptodev_sym_session_get_private_data != NULL) event case. else if (sess_type == RTE_CRYPTO_OP_SESSIONLESS && private_data_offset != 0) event case for sessionless op. I hope all cases can be handled in this way. -Akhil