From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: Ray Kinsella <mdr@ashroe.eu>, "dev@dpdk.org" <dev@dpdk.org>,
"Sun, Chenmin" <chenmin.sun@intel.com>
Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information
Date: Tue, 10 Sep 2019 16:06:32 +0100 [thread overview]
Message-ID: <a24758d7-1aeb-fd1f-6f65-823cbeea06df@intel.com> (raw)
In-Reply-To: <E3B9F2FDCB65864C82CD632F23D8AB8773D67E34@shsmsx102.ccr.corp.intel.com>
On 9/10/2019 5:36 AM, Wang, Haiyue wrote:
> Thanks Ferruh, Bruce.
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Monday, September 9, 2019 21:18
>> To: Richardson, Bruce <bruce.richardson@intel.com>
>> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Ray Kinsella <mdr@ashroe.eu>; dev@dpdk.org; Sun, Chenmin
>> <chenmin.sun@intel.com>
>> Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information
>>
>> On 9/9/2019 1:50 PM, Ferruh Yigit wrote:
>>> On 9/9/2019 1:40 PM, Bruce Richardson wrote:
>>>> On Mon, Sep 09, 2019 at 12:23:36PM +0100, Ferruh Yigit wrote:
>>>>> On 9/7/2019 3:42 AM, Wang, Haiyue wrote:
>>>>>>> -----Original Message-----
>>>>>>> From: Yigit, Ferruh
>>>>>>> Sent: Friday, September 6, 2019 22:22
>>>>>>> To: Ray Kinsella <mdr@ashroe.eu>; Wang, Haiyue <haiyue.wang@intel.com>
>>>>>>> Cc: dev@dpdk.org
>>>>>>> Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information
>>>>>>>
>>>>>>> On 8/13/2019 1:51 PM, Ray Kinsella wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 13/08/2019 04:24, Stephen Hemminger wrote:
>>>>>>>>> On Tue, 13 Aug 2019 11:06:10 +0800
>>>>>>>>> Haiyue Wang <haiyue.wang@intel.com> wrote:
>>>>>>>>>
>>>>>>>>>> Enhance the PMD to support retrieving trace information like
>>>>>>>>>> Rx/Tx burst selection etc.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>>>>>>>>>> ---
>>>>>>>>>> lib/librte_ethdev/rte_ethdev.c | 18 ++++++++++++++++++
>>>>>>>>>> lib/librte_ethdev/rte_ethdev.h | 9 +++++++++
>>>>>>>>>> lib/librte_ethdev/rte_ethdev_core.h | 4 ++++
>>>>>>>>>> 3 files changed, 31 insertions(+)
>>>>>>>>>>
>>>>>>>>>> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
>>>>>>>>>> index 17d183e..6098fad 100644
>>>>>>>>>> --- a/lib/librte_ethdev/rte_ethdev.c
>>>>>>>>>> +++ b/lib/librte_ethdev/rte_ethdev.c
>>>>>>>>>> @@ -4083,6 +4083,24 @@ rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
>>>>>>>>>> }
>>>>>>>>>>
>>>>>>>>>> int
>>>>>>>>>> +rte_eth_trace_info_get(uint16_t port_id, uint16_t queue_id,
>>>>>>>>>> + enum rte_eth_trace type, char *buf, int sz)
>>>>>>>
>>>>>>> Better to use struct as argument instead of individual variables because it is
>>>>>>> easier to extend the struct later if needed.
>>>>>>>
>>>>>>>>>> +{
>>>>>>>>>> + struct rte_eth_dev *dev;
>>>>>>>>>> +
>>>>>>>>>> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>>>>>>>>>> +
>>>>>>>>>> + if (buf == NULL)
>>>>>>>>>> + return -EINVAL;
>>>>>>>>>> +
>>>>>>>>>> + dev = &rte_eth_devices[port_id];
>>>>>>>>>> +
>>>>>>>>>> + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->trace_info_get, -ENOTSUP);
>>>>>>>>>> +
>>>>>>>>>> + return dev->dev_ops->trace_info_get(dev, queue_id, type, buf, sz);
>>>>>>>>>
>>>>>>>>> What if queueid is out of bounds?
>>>>>>>>>
>>>>>>>>> The bigger problem is that this information is like a log message
>>>>>>>>> and unstructured, which makes it device specific and useless for automation.
>>>>>>>>
>>>>>>>> IMHO - this is much better implemented as a capability bitfield, that
>>>>>>>> can be queried.
>>>>>>>
>>>>>>> +1 to return the datapath capability as bitfield.
>>>>>>>
>>>>>>> Also +1 to have a new API,
>>>>>>> - I am not sure about the API name, 'rte_eth_trace_info_get()', can we find
>>>>>>> something better instead of 'trace' there.
>>>>>>> - I think we should limit this API only to get current datapath configuration,
>>>>>>> for clarity of the API don't return capability or not datapath related config.
>>>>>>>
>>>>>>> Also this information not always supported in queue level, what do you think
>>>>>>> having ability to get this information in port level,
>>>>>>> like this API can return a struct, which may have a field that says if the
>>>>>>> output is for queue or port, or this can be another bitfield, what do you think?
>>>>>>>
>>>>>>
>>>>>> #define RX_SCALAR (1ULL < 0)
>>>>>> #define RX_VECTOR_AVX2 ...
>>>>>
>>>>> What about having RX_VECTOR value, later another bit group for the details of
>>>>> the vectorization:
>>>>> SSE
>>>>> AVX2
>>>>> AVX512
>>>>> NEON
>>>>> ALTIVEC
>>>>>
>>>>> Since above options can exist together, what about using values for them instead
>>>>> of bitfields? Reserving 4 bits, 2^4 = 16, can be enough I think for long term.
>>>>>
>>>> Rather than having named vector types, we just need to worry about the ones
>>>> for the current architecture. Therefore I'd suggest just using vector
>>>> widths, one bit each for 16B, 32B and 64B vector support. For supporting
>>>> multiple values, 16 combinations is not enough for all the possibilities.
>>>>
>>>
>>> vector width can be an option too, no objection there. But this is only for
>>> current configuration, so it can be a combination, we have now 5 types and
>>> allocating space for 16.
>>>
>>
>> correction: it can *not* be a combination
>
> I think we can merge the RX_VECTOR and TX_VECTOR together, use 6 bits for vector
> mode detail. And for vector width, the SSE, NEON name should indicates it ?
>
> I renamed the definitions to try to make things clear.
>
> enum rte_eth_burst_mode_option {
> BURST_SCALAR = (1 << 0),
> BURST_VECTOR = (1 << 1),
>
> BURST_VECTOR_MODE_MASK = (0x3F << 2),
> BURST_ALTIVEC = (1 << 2),
> BURST_NEON = (2 << 2),
> BURST_SSE = (3 << 2),
> BURST_AVX2 = (4 << 2),
> BURST_AVX512 = (5 << 2),
>
> BURST_SCATTERED = (1 << 8),
> BURST_BULK_ALLOC = (1 << 9),
> BURST_NORMAL = (1 << 10),
> BURST_SIMPLE = (1 << 11),
> };
>
> /**
> * Ethernet device RX/TX queue packet burst mode information structure.
> * Used to retrieve information about packet burst mode setting.
> */
> struct rte_eth_burst_mode {
> uint32_t per_queue_support:1; /**< Support to set per queue burst */
>
> uint64_t options;
We are using first 32bits just to detect the queue level support, what do you
think converting this into a field in 'rte_eth_burst_mode_option' and use
'options' fields, so we will fit into 64 bit.
next prev parent reply other threads:[~2019-09-10 15:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 3:06 [dpdk-dev] [RFC v2 0/3] show the Rx/Tx burst description field Haiyue Wang
2019-08-13 3:06 ` [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information Haiyue Wang
2019-08-13 3:24 ` Stephen Hemminger
2019-08-13 4:37 ` Wang, Haiyue
2019-08-13 9:57 ` David Marchand
2019-08-13 11:21 ` Wang, Haiyue
2019-08-13 12:51 ` Ray Kinsella
2019-09-06 14:21 ` Ferruh Yigit
2019-09-07 2:42 ` Wang, Haiyue
2019-09-09 11:23 ` Ferruh Yigit
2019-09-09 12:40 ` Bruce Richardson
2019-09-09 12:50 ` Ferruh Yigit
2019-09-09 13:17 ` Ferruh Yigit
2019-09-10 4:36 ` Wang, Haiyue
2019-09-10 8:06 ` Ferruh Yigit
2019-09-10 8:37 ` Wang, Haiyue
2019-09-10 9:14 ` Ferruh Yigit
2019-09-10 11:41 ` Wang, Haiyue
2019-09-10 15:00 ` Ferruh Yigit
2019-09-10 15:17 ` Wang, Haiyue
2019-09-10 15:33 ` Ferruh Yigit
2019-09-10 15:35 ` Wang, Haiyue
2019-09-10 14:19 ` Wang, Haiyue
2019-09-10 15:03 ` Ferruh Yigit
2019-09-10 15:18 ` Wang, Haiyue
2019-09-10 15:36 ` Ferruh Yigit
2019-09-10 15:38 ` Wang, Haiyue
2019-09-10 15:06 ` Ferruh Yigit [this message]
2019-09-10 15:21 ` Wang, Haiyue
2019-09-10 15:35 ` Ferruh Yigit
2019-09-10 15:37 ` Wang, Haiyue
2019-10-26 16:45 ` Thomas Monjalon
2019-10-27 4:10 ` Wang, Haiyue
2019-08-15 9:07 ` Ray Kinsella
2019-08-13 3:06 ` [dpdk-dev] [RFC v2 2/3] testpmd: show the Rx/Tx burst description Haiyue Wang
2019-08-13 3:06 ` [dpdk-dev] [RFC v2 3/3] net/ice: support the Rx/Tx burst description trace Haiyue Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a24758d7-1aeb-fd1f-6f65-823cbeea06df@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenmin.sun@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).