DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	huangdengdui <huangdengdui@huawei.com>,
	"lihuisong (C)" <lihuisong@huawei.com>,
	stephen@networkplumber.org, fengchengwen@huawei.com,
	haijie1@huawei.com
Subject: Re: [RFC 0/2] Add support for link speed lanes
Date: Wed, 22 May 2024 21:59:50 +0100	[thread overview]
Message-ID: <a25ef77d-201f-4d8b-885f-47ff8e2028ef@amd.com> (raw)
In-Reply-To: <20240322222543.23548-1-damodharam.ammepalli@broadcom.com>

On 3/22/2024 10:25 PM, Damodharam Ammepalli wrote:
> BRCM576xx NIC modules support speeds with different lanes configuration.
> This is an alternate proposal to
> https://patchwork.dpdk.org/project/dpdk/list/?series=31593
> 
> Please provide your review. Broadcom driver patches will follow.
> 
> Damodharam Ammepalli (2):
>   lib/ethdev: Add link_speed lanes support into rte lib
>   testpmd: Add speed lanes to testpmd config and show command
> 

Hi Damodharam,

As discussed in other thread, having dedicated APIs for setting lane
makes API more clear, so we can continue with this design.

This RFC proposes two APIs, but agreement on other thread was around
three new APIs.

Copy/pasting Thomas's suggestion
"
 There are 3 needs:
	- set PHY lane config
	- get PHY lane config
	- get PHY lane capabilities
"

And "get PHY lane capabilities" should return capability per speed,
similar to FEC one.


Can you please update this RFC to have three APIs as mentioned above?

Thanks,
Ferruh


  parent reply	other threads:[~2024-05-22 21:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 22:25 Damodharam Ammepalli
2024-03-22 22:25 ` [RFC 1/2] lib/ethdev: Add link_speed lanes support into rte lib Damodharam Ammepalli
2024-03-22 22:25 ` [RFC 2/2] testpmd: Add speed lanes to testpmd config and show command Damodharam Ammepalli
2024-05-22 20:59 ` Ferruh Yigit [this message]
2024-05-28 21:19   ` [RFC 0/2] Add support for link speed lanes Damodharam Ammepalli
2024-06-02  2:45     ` [PATCH v2 0/4] " Damodharam Ammepalli
2024-06-02  2:45       ` [PATCH v2 1/4] lib/ethdev: Add link_speed lanes support into rte lib Damodharam Ammepalli
2024-06-11 23:39         ` Ferruh Yigit
2024-06-14 18:27           ` Damodharam Ammepalli
2024-06-17 20:34             ` [PATCH v3] ethdev: Add link_speed lanes support Damodharam Ammepalli
2024-06-02  2:45       ` [PATCH v2 2/4] testpmd: Add speed lanes to testpmd config and show command Damodharam Ammepalli
2024-06-11 23:39         ` Ferruh Yigit
2024-06-02  2:45       ` [PATCH v2 3/4] lib/ethdev: add support for displaying lanes capability Damodharam Ammepalli
2024-06-11 23:39         ` Ferruh Yigit
2024-06-02  2:45       ` [PATCH v2 4/4] testpmd: " Damodharam Ammepalli
2024-06-11 23:39         ` Ferruh Yigit
2024-06-12 17:53           ` Damodharam Ammepalli
2024-06-12 20:57             ` Ferruh Yigit
2024-06-11 23:38       ` [PATCH v2 0/4] Add support for link speed lanes Ferruh Yigit
2024-06-12 17:46         ` Damodharam Ammepalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a25ef77d-201f-4d8b-885f-47ff8e2028ef@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=damodharam.ammepalli@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=haijie1@huawei.com \
    --cc=huangdengdui@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).