From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>, Matan Azrad <matan@mellanox.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers/net: fix log type string
Date: Tue, 9 Oct 2018 17:31:48 +0100 [thread overview]
Message-ID: <a2817d90-96ff-50b8-8968-1f3391201823@intel.com> (raw)
In-Reply-To: <20181009080711.07236f72@xeon-e3>
On 10/9/2018 4:07 PM, Stephen Hemminger wrote:
> On Tue, 9 Oct 2018 12:52:38 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
>>
>> Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
>> Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
>> Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
>> drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
>> index 88e026c7d..858e65d00 100644
>> --- a/drivers/net/bnxt/bnxt_ethdev.c
>> +++ b/drivers/net/bnxt/bnxt_ethdev.c
>> @@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
>>
>> RTE_INIT(bnxt_init_log)
>> {
>> - bnxt_logtype_driver = rte_log_register("pmd.bnxt.driver");
>> + bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
>> if (bnxt_logtype_driver >= 0)
>> rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
>> }
>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
>> index a7b592eed..544e0cde4 100644
>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>> @@ -3598,7 +3598,7 @@ int bond_logtype;
>>
>> RTE_INIT(bond_init_log)
>> {
>> - bond_logtype = rte_log_register("pmd.net.bon");
>> + bond_logtype = rte_log_register("pmd.net.bond");
>> if (bond_logtype >= 0)
>> rte_log_set_level(bond_logtype, RTE_LOG_NOTICE);
>> }
>> diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
>> index 48717f2f0..16303ef5e 100644
>> --- a/drivers/net/vdev_netvsc/vdev_netvsc.c
>> +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
>> @@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,
>> /** Initialize driver log type. */
>> RTE_INIT(vdev_netvsc_init_log)
>> {
>> - vdev_netvsc_logtype = rte_log_register("pmd.vdev_netvsc");
>> + vdev_netvsc_logtype = rte_log_register("pmd.net.vdev_netvsc");
>> if (vdev_netvsc_logtype >= 0)
>> rte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);
>> }
>
> Thanks for making drivers consistent.
> Did you check the documentation?
Description seems correct:
http://doc.dpdk.org/guides/contributing/coding_style.html#dynamic-logging
But "1.9.1. Specializations" needs an update, I will send a new version.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
next prev parent reply other threads:[~2018-10-09 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 11:52 Ferruh Yigit
2018-10-09 15:07 ` Stephen Hemminger
2018-10-09 16:31 ` Ferruh Yigit [this message]
2018-10-09 17:38 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-10-11 10:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2817d90-96ff-50b8-8968-1f3391201823@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).