DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Matan Azrad <matan@mellanox.com>,
	Xiao Wang <xiao.w.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 4/4] examples/vdpa: add statistics show command
Date: Fri, 19 Jun 2020 17:04:14 +0200
Message-ID: <a29cd163-7680-5c22-e53b-2d764fe1f28e@redhat.com> (raw)
In-Reply-To: <3cc1d8fc-bf09-8f48-dfbd-fdfa5b42314a@intel.com>



On 6/19/20 5:02 PM, Ferruh Yigit wrote:
> On 6/18/2020 7:59 PM, Matan Azrad wrote:
>> A new vDPA driver feature was added to query the virtq statistics from
>> the HW.
>>
>> Use this feature to show the HW queues statistics for the virtqs.
>>
>> Command description: stats X Y.
>> X is the device ID.
>> Y is the queue ID, Y=0xffff to show all the virtio queues statistics of
>> the device X.
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> <...>
> 
>> +
>> +static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
>> +				    __attribute__((unused)) void *data)
> 
> replacing "__attribute__((unused))" with '__rte_unused' while merging.
> 
> Please check checkpatch output, it now has a warning for it:
> http://mails.dpdk.org/archives/test-report/2020-June/137330.html
> "
> Warning in /examples/vdpa/main.c:
> Using compiler attribute directly
> "
> 

Thanks Ferruh!
It would be great if the script printed the line number.

Maxime


  reply	other threads:[~2020-06-19 15:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <01591112869-78828-1-git-send-email-matan@mellanox.com>
2020-06-18 18:59 ` [dpdk-dev] [PATCH v4 0/4] vhost: support vDPA virtio queue statistics Matan Azrad
2020-06-18 18:59   ` [dpdk-dev] [PATCH v4 1/4] vhost: inroduce operation to get vDPA queue stats Matan Azrad
2020-06-18 18:59   ` [dpdk-dev] [PATCH v4 2/4] common/mlx5: support DevX virtq stats operations Matan Azrad
2020-06-19  6:07     ` Maxime Coquelin
2020-06-18 18:59   ` [dpdk-dev] [PATCH v4 3/4] vdpa/mlx5: support virtio queue statistics get Matan Azrad
2020-06-18 18:59   ` [dpdk-dev] [PATCH v4 4/4] examples/vdpa: add statistics show command Matan Azrad
2020-06-19 15:02     ` Ferruh Yigit
2020-06-19 15:04       ` Maxime Coquelin [this message]
2020-06-19  6:39   ` [dpdk-dev] [PATCH v4 0/4] vhost: support vDPA virtio queue statistics Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a29cd163-7680-5c22-e53b-2d764fe1f28e@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@mellanox.com \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git