From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DB04A0613 for ; Thu, 26 Sep 2019 11:16:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE0FA1BEBB; Thu, 26 Sep 2019 11:16:40 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 3C9631BEBA for ; Thu, 26 Sep 2019 11:16:39 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 10905140055; Thu, 26 Sep 2019 09:16:38 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 26 Sep 2019 10:16:32 +0100 To: Simei Su , , , CC: References: <1569247539-101249-1-git-send-email-simei.su@intel.com> <1569420404-163301-1-git-send-email-simei.su@intel.com> <1569420404-163301-2-git-send-email-simei.su@intel.com> From: Andrew Rybchenko Message-ID: Date: Thu, 26 Sep 2019 12:16:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1569420404-163301-2-git-send-email-simei.su@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24934.003 X-TM-AS-Result: No-5.626100-8.000000-10 X-TMASE-MatchedRID: 6otD/cJAac3mLzc6AOD8DfHkpkyUphL9APiR4btCEeb7s8CQBJM67pkj nc8qZSo35cB2EDbWw/Ys6ADgHY3HCRItOdh8xZl8Row8EUpfIBQpWss5kPUFdCMCOsSbh/rMnMY 2MsS9Myi3pAcaMyxl3MmWgSFDB1gJyVynYqyLE4miVU7u7I4INUNWaKIdBIV4CkKOpUQuXBVQbX AM/cduEhx3P/kr429T4YS6FyG8vygVlVZBrluiayI9MxSOQ6CSgkMXwPojuxesxvTCCnhvxoX95 ULhbS2Am7kHB2bm1NrtzqbwNDqs3JRVv0kpdMQOnTqdU4w65WktlZY1WAfRjTssXelfet1UuPFr kRUFXWrnzlXMYw4XMGsBqFAbBCa3EQby3lcAnYHgjrUzffFY0jPzrFCUvY7Ux7v8yFvI0cTpUa5 +nQjVnFOA6O6WXAbPOSYdTbTX8vzl4S+GDltC23jMYuWsZ4657nz43YW/6hs= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.626100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24934.003 X-MDID: 1569489398-NDZAHkmNcX7i Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: extend RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/25/19 5:06 PM, Simei Su wrote: > This patch cover two aspects: > (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve > different purposes. > (2)reserve several bits as input set selection from the high > end of the 64 bits. It is combined with exisiting ETH_RSS_* > to represent rss types. If the patch covers two aspects why it is one patch instead of two? It would be useful to motivate decouple a bit getter and provide details since "different purposes" are hardly very useful. Which purposes? > for example: > ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY: hash on src ip address only Is  (ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY) valid and an equivalent to ETH_RSS_IPV4 only? If yes, shouldn't generic API care about it or each driver should do it? Similar question is applicable to L4. > ETH_RSS_IPV4_UDP | ETH_RSS_L4_DST_ONLY: hash on src/dst IP and > dst UDP port > ETH_RSS_L2_PAYLOAD | ETH_RSS_L2_DST_ONLY: hash on dst mac address I'm a bit confused by L2_PAYLOAD | L2_DST_ONLY. Does L2_PAYLOAD mean entire L2 frame including header and payload? > Signed-off-by: Simei Su [snip]