From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D052942D1B; Thu, 22 Jun 2023 15:13:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A955540ED7; Thu, 22 Jun 2023 15:13:36 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2057.outbound.protection.outlook.com [40.107.220.57]) by mails.dpdk.org (Postfix) with ESMTP id EE3F7406B8; Thu, 22 Jun 2023 15:13:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jjxESxAwFG0nnW6u0chdfIzj19G2QyqTolkTYPskx48WbeGGoPbPuTsPGDdKH6mtnu3E75Um/JSL7kuCH7/nsKPC2j32QWQud31Yk9xCtQqfnGhXEnO9uUi6f8QH0UKVmBDPg1jxq1ypz6WpZ7ywmrAjEmt0wnEnZk1bKyBm6kVUNg8hUxkAASmRhqaLwXHP265C+thSxeQAK2nTj6MRquz1Z6qG7/86gESYr8TEXxpWd1GhV97E1hfDSVmuSbbUfbT+GLKBdLc4zo+9ujwtyrnB18tQbGuDb82+/4VpYi2q7ljM8cPIe7P1c30AVnRAA/2JHd19CLnoPQm3Fm3DMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98Wgd+gpKycJsp8fZTyf1Wk7Rh0QK3hYVDtryO7OJ7s=; b=QBbRaMjTo3LU6hhfQckS7oZVq2EFSh/qr1343Sh+AGAQeJSMwnYey9zsP/Nv3DPzh8ZdQ00ga+F/XgzbGKCjD5fKCsnhlyC0gWHvmsBRbkDcCfyQjz/aayueLBtoC7GPpr4v9cBQuertjHKmy0GHuURktWB6phksSIAPdhL3mHYBo4pUpIH9GJBphxeRJvv4tOdHx/UUcWQpF2JSm7YebAEaYVGD/fzYTfdG14KWpEYsvZX7W7UgSeywlmpIEufohTMpTkYFe/nvalxgH/pb8ZQt9XBzQu8sfECZqF1VWhJCHTaR1RKAZ4v8Vkyt1rk75da+0ZIpjXM+R2bqbr+9dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98Wgd+gpKycJsp8fZTyf1Wk7Rh0QK3hYVDtryO7OJ7s=; b=hirowjh/bFSaoUTahYvoB8PKt7SJ/+CIfgzKlTvIomnlzLcg0i/Trm0xPwZs4WnTdEWMCICfqoCIsZ4anJ7szpmflnCs9UIYkSiZdlyQSUMhhuZHUBBTrR09WTF4j2zQ+Y1OBlTGuLnsDS6Fk3a4VafXbFrgpVcJ8MQWWJvAOXQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7110.namprd12.prod.outlook.com (2603:10b6:510:22e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Thu, 22 Jun 2023 13:13:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.024; Thu, 22 Jun 2023 13:13:31 +0000 Message-ID: Date: Thu, 22 Jun 2023 14:13:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix Content-Language: en-US To: Artemii Morozov , dev@dpdk.org Cc: Andrew Rybchenko , stable@dpdk.org, Andy Moreton References: <20230531070810.93131-1-artemii.morozov@arknetworks.am> <20230622123136.264482-1-artemii.morozov@arknetworks.am> From: Ferruh Yigit In-Reply-To: <20230622123136.264482-1-artemii.morozov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0127.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7110:EE_ X-MS-Office365-Filtering-Correlation-Id: f8630e61-ec6a-47c3-e992-08db73227970 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bjqlFd5TA/rSnEpYapZbOHdD6ZSSvJNkkxLTt/nNydz5fnrjXrbMS81svO5VCP7V6naMAyVYd/5MRaZw5Le9AQ5dLFa1FvHp1dZEy7L73D9ey+bkx7S1FrCJoUgLJakebrDnOcOOBeqHzysGQ+2CzbxGPjpAAV39+UjkoXv59IaOhiFA7XPMiDzGavQgwNOoNpB/UMpCBIY5nN3NWJFWVj+lTxwzpm3tGR5+CzFWrkHBX+8nx+/Vjm0JpS5IYXrY6eyS954LxMdXVD7TwEPaIESm1wl5GXALvmESB8EOfgWrgdxWxnxL0Z73k0wPXvIjS75+o6YDarNVfsYQIvQkgJrUDzTBPDdnbefVYLGKjhd1AsbfPsu+NuN2UJPZtOTlsPARpEvb6QeWE2ruIHGle7LrwmD1+ooTZur/56SynjvVOWIS6tcGzTGsnXYuDI8B2fI3EOHgk83gTSdoUp4WrMFZMV49jmOoJNat4L0u9p1wZ8DsuDN1Hwr7erXAcKfEjCTky6XAn1qPF3FFJvGRoJKu0vQlE9dyhk7OJDjqBebprOiLTLUBuifhdcKl5C7wiF8MVBPYl1066dUhG3Lb/0uHuNrBH6D7SWlbQIqLhrQ1+HY6SLxieVpm8jB69kYIOVftJNmSk+ysG9xR35Hegg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199021)(38100700002)(5660300002)(53546011)(26005)(6506007)(83380400001)(6512007)(186003)(2616005)(44832011)(41300700001)(2906002)(8936002)(36756003)(6666004)(6486002)(4326008)(66476007)(478600001)(66556008)(66946007)(31696002)(86362001)(54906003)(316002)(31686004)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3p1UFN5b21RejlmRlVRRHVhNFZRSlRmc0JNcnRUeEZwMzlqT3pzSzluR2pn?= =?utf-8?B?WHo1SzRra2U3VHMvZkl3VEhtWDQrNGJwWWNkUGkyRDU2UW5IOFhwSS8za0Ev?= =?utf-8?B?V1BkaksxeFdielBlUnBEQlRLOUV4MmRtOE1SM0ttTW1wWjA4dVFGWFFHaG92?= =?utf-8?B?cXFhL0QxQWNmR2g3d2RXUWY3dituTGlkdmlSOHV2ZmtTZ3ptbEF5SUI3a2pK?= =?utf-8?B?NGVKeFlkdmFvTDI3ZzE0aDlUbVJFanFtS0Zrekx4YjN0SHNWaUVVZ2J1TkxJ?= =?utf-8?B?eFdRMzNBYmpEVG9teWRiSDFCVVR5YVNmdXhLRGs0VjBjSUVuemJTcm5DM0ZQ?= =?utf-8?B?VGhBZ0JreDNDUWZ6eTFMcW5wVDI2SUZWdnZQYkIxTG1jcFQzZTg1a3VrMXJ1?= =?utf-8?B?bUhPRDRrQm1rT0d0N21BTWd2SjlMd1JWcDNwV2pEVllzSFdwZ3BYd2xuTmRt?= =?utf-8?B?UHpOL05ZUk5MdW1pK0FYK3YvVEg2RDhyVWE2cVRsTmZjdDBvTSsrZWFYdUhi?= =?utf-8?B?bDU1aW80RWE0dzBtS1FKbk9ERXBkUG1xdWo2dDZ6QTJpd3ZWUVlMSEZIN3BO?= =?utf-8?B?ODBHb0Q3eHFIL3E3RnE0TmFrVE9mMXBkQzRhWVB6MmtHQjhkNnRLOVV6NU1Z?= =?utf-8?B?WDhXdnlPb1F6ZnkyT0NpQm5KczhFb3ExcjMrRWRnckh6S04rdXNFaXlzL1NJ?= =?utf-8?B?QXBYRitGenZ2NFdkdjFUekxRMFI0WnROKzlqSjhMb2NYTjR0a3k0RWVXaUM3?= =?utf-8?B?aUh3cU51RmJYanJxTGxpUEQ0ZG9RQ2RhQmVqOWQrQWM2T0svYnczczFlbGU5?= =?utf-8?B?STROdWxvZi91cUJMRG5KUW9qM1ZkVHpCRVlGYVlrZnl0dHQvc01ITVZuZEE1?= =?utf-8?B?dlpyU2V3Z1djaTQvSnlXenFIRGg0Vk9JNVFlN2NrTWVPN25hQ2QxcG5sSUc3?= =?utf-8?B?S1VZRTRJVkJSaXBNL3BtTnU2b2cwTDR5RzVHM0RyYml6VkNWd25zWWF4ekJk?= =?utf-8?B?d0xPV2JHN1ZIVjFLOS9NTnNONzZaZW1PaWcwOTF0Yis4WFQ3T0FCajFFeXZM?= =?utf-8?B?eis3ZEcxM0JCTnMraS9LSVB1U2x0azBaU3BQcDRBNnpSNk0yYlpPa2ZldDlV?= =?utf-8?B?d0UyclZYcWlUTUEwUTdlc2x2dTRYVGl2NTdRWFFaL2Y2bi9jUzRad1Z2am93?= =?utf-8?B?VVZvN0FHUEpZYk4xUXRQL0RJenZzNGRDOXU4Snk4S2ZnVnA0TzdORnNoR1VH?= =?utf-8?B?SHQyR3U1bjBraGhiVDZGdjM0V3pmaHVwRVFoQ2tHdTlqM1g0Y1dyS0V2SEhY?= =?utf-8?B?Q0VZcnQyMkpwTVl4cTl3UGhKeUc4OExxN0l0RkRoTXA5WC96K0ROMDZDYXcz?= =?utf-8?B?Z2lHbk1yK2Y3QVc0a1huK05ORmNMNGFWVVlQVVExYWVQM2o4Y0hETkVzaG8r?= =?utf-8?B?ZWJHaWFTcXZkK3VTSjk0RmIrbjFVamo0MGgzTGZRaDlSQVV3YXJ1WVJLSGU0?= =?utf-8?B?MGxyZ2lLK2tmNWJmUFBzdHFBQmEzdkVDYm9TUzg0UjhweVozN01aOE1Jb3V6?= =?utf-8?B?VnkyMUNrYVhoOEZvSFFJTFZvQW1aYjZGc3FXWnovM0RlenhsUnVzR3l1UDdo?= =?utf-8?B?K251ZGpBUFJOVW8rWGFCVWVqZVhKU0J2cVQ4VGhBYWJtSjRPOUJMdFNwK2ZB?= =?utf-8?B?REZOeG5XNzNyMFhQUGR6cEdpa3g2QWFHc1RIYkIvTkFiWHREbVl5N3NsVVRn?= =?utf-8?B?VHQ5TzhQcmpYLzkxdFFKQjdVR2RqN29iZWF6aUhnT3dXMlp3aUt5dHo5aVVK?= =?utf-8?B?bnhhR2d5bXNJSkE0TGhibkxpcHhWREpEVm5BdXJWUDJ0UWJhK1pXbVBqWGFj?= =?utf-8?B?M2NmT2U4Q3NFTXJ1L3gyK1J0THllc0QyM3F2KzBKdDByenV3dXpLVVQwZXZ5?= =?utf-8?B?UXoweHJNbnpOaitiVWtnZ09TTE1XTHR1MjNjTnU4b0hzaFd3akp0MEpza1k3?= =?utf-8?B?dUl5SW84a1NRMXh3M3ZVSDNTY2pkVE1yR1BudWV2TW9OY2FoOFZoRHhNT0FQ?= =?utf-8?B?N0U3U3ZqbG9KRS8yYnY5VFUrUjh1QmMwZmovQXlYd3o0Nnh6SWFQTEhzV2Ji?= =?utf-8?Q?XnWGycIJWbS/sM7Ha9VnUZuHF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8630e61-ec6a-47c3-e992-08db73227970 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 13:13:31.0082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IvS5toOVHsmzXS5ynJGkXDRCnw3mMGNskG5os7AcZgEN9HddiehRioRIA7wIveny X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7110 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/2023 1:31 PM, Artemii Morozov wrote: > If the prefix for the RSS hash was not chosen the ENOTSUP error should > be returned. > > Before this patch success was returned for this case causing Rx queue > creation to fail. > > Fixing return value to indicate failure. > It looks like you used sample commit log as it is, so can you please confirm this is the actual case (because this was my assumption without really knowing the actual problem), problem is not crash or undefined behavior because of 'erpp' was not set etc..? > Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") > Cc: stable@dpdk.org > > Signed-off-by: Artemii Morozov > Reviewed-by: Andy Moreton > Acked-by: Andrew Rybchenko > --- > v5: update commit message > > v4: add Cc: stable@dpdk.org and transform rss to RSS > > v3: update commit log as fix commit > > v2: don't use capital letters in email > > drivers/common/sfc_efx/base/efx_rx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c > index 68f42f5cac..61726a9f0b 100644 > --- a/drivers/common/sfc_efx/base/efx_rx.c > +++ b/drivers/common/sfc_efx/base/efx_rx.c > @@ -937,8 +937,10 @@ efx_rx_qcreate_internal( > > rss_hash_field = > &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH]; > - if (rss_hash_field->erpfi_width_bits == 0) > + if (rss_hash_field->erpfi_width_bits == 0) { > + rc = ENOTSUP; > goto fail5; > + } > } > > enp->en_rx_qcount++;