From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C43A1432F9; Sat, 11 Nov 2023 03:03:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81D46402A6; Sat, 11 Nov 2023 03:03:01 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2064.outbound.protection.outlook.com [40.107.94.64]) by mails.dpdk.org (Postfix) with ESMTP id D22194025C for ; Sat, 11 Nov 2023 03:03:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=inNOj9TWeumhVmFQlNRUhnSCEBRB+89LKGveTV4eq+Dj6yioEOn8eij5sNjsQRyrTSTz6sd+84BWi76oNq6lHX0HnlrsKbP9whSuIqJ+Zym5swzctUpduIJmjH9uIQLThPqKIJDM7U4l6K7tIbqNcDzDZs7v2b1bXjF9ot1R8fw/v9AyWwGq8CuiiiuhWMQGCwSI1/dAAlpeE1NCqJm3rJoI//XIRFItk9swQ008LydJ76Q9xTQkrWAkRg2wys5haQLljS9QT1X2eFqTmas+wIi+HZmFAK/SBW8geJJ0q/8mc+1xkPfJLU//rZ0dYVLdAYdauJFKk5z4DECXJHCDkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/5h/yT1+Sorz2RH2jf/XheSl4MKvrpc2pOMjtm8/rc8=; b=KOGu2srCd0vo4qMuo95DrwAPJTwa4CuPe4ySC5VX9csOv6+1AndChuQ1y5QVTyxllqErcYxMvfdiSv9TZaFeCOV583h5L89rH7zrE6XLu1CJm1sUc2b/IK2hSpQXdJvdCgTRGackENm55Mmss9px5W9Hbbpq/2RQtblUjeqU1Trclm3ZBncrwy/7lpUawUDBIRSasXpluLoeisKybnrrCgULzZCQe4FC+WRjrFoof8EGrGMRPe8eYBgzV10tNoJvjyEXv62W7b76+LZtUdiw0zxN1wKP5EgEflBW/sRAq7sQ9EA14lWSQs96skgNKvo+DjqNASV20bd4NVleSe8WNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5h/yT1+Sorz2RH2jf/XheSl4MKvrpc2pOMjtm8/rc8=; b=3mcrMg8XM+jzME5PwemXqUJSppHJqXLqyXpGa1Ybo53XAY0qAo+nCya7QeeAThzEnLjrqYJH2vkULI99cc5rbxgNLiHvi0VZaMXkKaOQgNhvpwWZsHvck1YyxDNQu8bvqsiXYcC2lKKo9SVqoRgUKgH7vtzJsJOj1NrnazcNMMc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV2PR12MB5917.namprd12.prod.outlook.com (2603:10b6:408:175::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Sat, 11 Nov 2023 02:02:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Sat, 11 Nov 2023 02:02:58 +0000 Message-ID: Date: Sat, 11 Nov 2023 02:02:34 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/test: fix retest link bonding fail Content-Language: en-US To: Jie Hai , dev@dpdk.org, Chas Williams , "Min Hu (Connor)" , Pablo de Lara , Declan Doherty Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20231110095302.2469090-1-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231110095302.2469090-1-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV2PR12MB5917:EE_ X-MS-Office365-Filtering-Correlation-Id: 66034ce5-0e9e-4536-c671-08dbe25a5350 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RYnmYvi7Vk41W7gQLi3m9MmgV9qCMLON5aZln0olJYwWw+asCGBQ6EP0j5C9Qla+bvEjFaeTOM5wYt6KrbxI12XXd+wjmvPXl7Bk03nzEW2ETPU5wu7ENO8B/iJqAD3E/sVM1OFF7JeOfcTm1g2/oT2n1Fuq3M9ax0kFdOi74U7HPvmJwZ0OmkDBCwWX2GQ/F0dF79AVoBbT/y+NReBsa/gJ7Ua7XqM0zq6uddsv9htqKY0P2f2HwXFX8ETxnVKuIMgUym/pxT/7ikVvyoFHrVahl/8LepmIzsHUGi14+Q18MURfUKr45bPaaUrf7RPovSvyrOzfriHZg69AniA+Rp3dOZiCiiUatPPeQ7Ad64q66Pm3NSA1xO3fKLPQs9FLK4T3sNlNCU6YTAZS6v4Ljp6v8zVWX+/193G/wfwNfRBRZKn9MFFzfAsOWadc1oBwLd1QUVNTQnMdB0I57gOGrtnNDr9LCkN1tTgInFQ9U2kv3+Lp8WIUkMkGUtxoXGkFOapfGafvLq9m7Jpf0AjDoURSyehKeTkTREOgxs7bcHI6P0e5UTPu/qsFJw1SxJ1ygQ5Kkakj4AwZ7NolMl5XeCAnahIxXGjXiBTIQWdDSAotl4Jgxgbsf3gNFOsZZlumdQtDckfeVy/nV8I5PLydWw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(136003)(366004)(396003)(346002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(8676002)(4326008)(26005)(2616005)(8936002)(66476007)(66946007)(83380400001)(110136005)(66556008)(316002)(6506007)(53546011)(5660300002)(6486002)(478600001)(86362001)(6512007)(31696002)(2906002)(6666004)(41300700001)(38100700002)(31686004)(36756003)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0FRNjMrMEt5YWJ6cEw5TkwzZEZTOWoxRDl5Q0gyODV2cE9JVWsvUGtublo3?= =?utf-8?B?YldKZG12TThFN1hXVWxGeFU3NHVQQnRpUFpQck1NN3VNdktOZmhQSU1XNXBH?= =?utf-8?B?c1pyVDJ3cktta1VwVnllOWI3cnNKUnY5VmtxYzhHdUhCYjNLM0VhUjFXSk1j?= =?utf-8?B?QzhuWktnNTZmOS8xUmxKRjg1ZnQ1Q0VNdk9KVXN4N2hCaStDRFFyN1pTQVBx?= =?utf-8?B?U2ZseDZUMHVJRURLZ1hoM2t5OGNhbzlQM0xDZEdUUk1TNGtyQXJ3NDF0V3o2?= =?utf-8?B?QUsveExVbWJZNlQzNWJEdnJmK2xzeGFLSkFUd0JqSkRXVURwTTRtanhZZFAy?= =?utf-8?B?VitqNjFSWHNlSVhrcDFGY3E0d3FMU1hwOGd4N1pmNVJxSmNaamtqQ0grWDZo?= =?utf-8?B?bVAxblpUY0cwbWtxSWNjL0VxUVplT2VzTEh1SEt0Znp5VDVJNmtwUGx6VGxz?= =?utf-8?B?NnE4SEpLMzJlV0NZS1UzYUYxWVZ5a25rbXBXS24yS2tXVG4xTXNIdk5UQ0p6?= =?utf-8?B?UWxlV0trZHB1THBRZEJaTFZWbloyWUN2Vlc2RXgrU2xROW12VG91aFE5NHJR?= =?utf-8?B?SHZORnFmMkpaU1MvazREc05SS0lZZXA0RjFvUEk5aW5zYnA5NEo5VE5zYU5s?= =?utf-8?B?U3QwSUFPU2V3dys2L3k0RlBja0tJTHVsK1hRaWhKMjFGZW13dkFhL3VUcStZ?= =?utf-8?B?V0VYWGFqQ2lLWVQxNUIxMEJiZnJkZlAxVWhDUDBrNHpsNUFiSldYVGFmb3hR?= =?utf-8?B?NGRTTkFYZHhDcmlmWDZVdDZJSHFDbVgzRHUwS2xld1pJaTZUZmdUY0w0bWdM?= =?utf-8?B?SWZEbkhFTWVtSmwyN0ZDSURqZ2ZLZVByckcrVUcrcWlZY1ZzeDBtR3BOQWRq?= =?utf-8?B?eDgxQk1DUHlWNGdrRDVOOGdycGg1L1AvNEhoeE9HbDRQNjQrYUJjOVRMN0xT?= =?utf-8?B?dXg3TklSWmI1d1NoODkycWsrblVmY0YxVHI0dk95R2dTM1VUamJPZkQvYzVM?= =?utf-8?B?SVJhYVhEQnN1VFZ6SkNUdEJBMTFWRzljMEYwRXB3M1NqV3Y4RUN2QWE4dmdV?= =?utf-8?B?YXZWazRVR1VEa3FvbEJSMVNNQm5SYi9FR1BjYWQ2bHlNRy85REkrL2NlcDNQ?= =?utf-8?B?eWRKMkR3OE5lWG41eFcvNmZrNXVoTkk2ZXFQcGQ0b2NBTEI2ZG9VOU8rZFdH?= =?utf-8?B?dkZKNDQ5bkZsS0gzZE52OWJ2bm5wOWpWRVdEZEZzTzd2U28rVkJPVy9oNGEy?= =?utf-8?B?Vi9oZytLS24xTXdzN1lvSlRYV2lyNTUzcnRzS01hR0kwMnBqMXRJU0RFMTR3?= =?utf-8?B?bGhEQm9OS3Q1NVMyS2dXWG1OMFgwTUtuVDNYc3FJWDF4VXFrNExzRXBudVdp?= =?utf-8?B?UlJxazg2WWQ0b3dab3BGOTYwMzhxVlFPSUtLYjdIWlZ1dU1KK3pWVUU5RzF2?= =?utf-8?B?NjF3aEhsNjY3T29BRFRrTmRqK3A5dUVJT0lDbTRRL3htUHZSejFuU2ZwMU5Y?= =?utf-8?B?TStWSTlhaEVTVUIzbmhrbCswREpxSU8wRFZ1WWErb0ZmeEJpNnd1VlJFMnRl?= =?utf-8?B?UHp2SzZCaTNMRzVuM093dTJSMEV0d3dXNTV3enVYZTluNEFvQk5MR1VqNWhL?= =?utf-8?B?QWoydjVpZlRFRTFzbEZyRXBKczNycGZPeWpFVTErRjNIc05YUEgxTmlDNmtI?= =?utf-8?B?Y1l2Y2diNWxJTjh4cy9oeVhSL3BhWjJCV2R5c2dNYmdJaXZVemJXbDIxTGR1?= =?utf-8?B?ZkF6Q3pmOVdIQllnZnpLWjNieDdpWkJNK1dHbmVIcGEvVGQyUEhFUWM1T2d3?= =?utf-8?B?eVpBWlQyRGdVZ2VZWFp4dk9GbDJYdVVhaXF2Nnh0TXJINTc3Z0lTUlNiSGZs?= =?utf-8?B?KzZReG9TQTVsNzN2VDFsY2JqUTdYWXBKdDZ2eHk0V2V4WG5FbXZhNTQ3Y0ky?= =?utf-8?B?bFlOQ3hSNHUvRjllclVocFZ2VktyTlpuaDFWR0lwWVZXTHNYZUhzRnRFTlla?= =?utf-8?B?Z1VYQ3R6Z3drbGdPUDhpUTZIandIRjlIcnhsOHhHY3N3K1BVdTAxMEVvUUx3?= =?utf-8?B?TXVERWx4MU5ramR1aEk4VmRpQThnWUpnbnFpZTAyczQ3Rm82bld3WWh5QzBu?= =?utf-8?Q?jMHHB5MIYhzuyHllDBJv4g3oT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66034ce5-0e9e-4536-c671-08dbe25a5350 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2023 02:02:57.8044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eVgujb3CBsKEvYZav9/AIJE7n46VPCXT4SSEgXEPPEPw2Ozca9KSVvZsYPY7dY8M X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5917 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2023 9:53 AM, Jie Hai wrote: > The testcase "test_close_bonding_device" closes the bonding > port shared by several cases. After closed, the port is in > RTE_ETH_DEV_UNUSED state, and could not be used by other cases > anymore. If retest the "link_bonding_autotest", failure occurs. > This patch creates a new bonding device for the closing testcase. > > Fixes: 92073ef961ee ("bond: unit tests") > Cc: stable@dpdk.org > This must be from times 'rte_eth_dev_close()' not release all resources, because there is already some code (in 'test_create_bonding_device()') that covers re-running unit test. So probably unit test was working when implemented but it is broken either when 'rte_eth_dev_close()' updated or its implementation changed in bonding PMD, can you please investigate it? > Signed-off-by: Jie Hai > --- > app/test/test_link_bonding.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c > index 4d54706c21d6..15fb0bc3e108 100644 > --- a/app/test/test_link_bonding.c > +++ b/app/test/test_link_bonding.c > @@ -4182,7 +4182,16 @@ test_reconfigure_bonding_device(void) > static int > test_close_bonding_device(void) > { > - rte_eth_dev_close(test_params->bonding_port_id); > + int16_t bonding_port_id; > + char pmd_name[RTE_ETH_NAME_MAX_LEN]; > + > + snprintf(pmd_name, RTE_ETH_NAME_MAX_LEN, "%s_%d", > + BONDING_DEV_NAME, ++bonding_id); > + bonding_port_id = rte_eth_bond_create(pmd_name, > + test_params->bonding_mode, rte_socket_id()); > + TEST_ASSERT(bonding_port_id >= 0, > + "Failed to create bonding ethdev %s", pmd_name); > Why not use 'rte_eth_bond_free()', it is better than creating a temporary bonding device just to close it? Adding 'rte_eth_bond_free()' also requires updating 'test_create_bonding_device()' to allow creating device on each run. And there are other bonding devices created during tests, they don't break tests because they use 'bonding_port_id' global variable that is increased in each run; should we close and remove them too here, to not leak resources, what do you think? > + rte_eth_dev_close(bonding_port_id); > Previously 'rte_eth_dev_close()' return type was void, but it is not anymore, and since test is about closing bonding device, should we test return value of the API?