From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 5EE657CFD for ; Wed, 13 Sep 2017 08:27:28 +0200 (CEST) Received: from pure.maildistiller.com (dispatch1.mdlocal [10.7.20.164]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id B2E186006C; Wed, 13 Sep 2017 06:27:27 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx3-us1.ppe-hosted.com (filterqueue.mdlocal [10.7.20.246]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 48CE2100057; Wed, 13 Sep 2017 06:27:27 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id EB2F72005D; Wed, 13 Sep 2017 06:27:26 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 13 Sep 2017 07:27:20 +0100 To: Stephen Hemminger CC: , Ivan Malov References: <1504880151-15394-1-git-send-email-arybchenko@solarflare.com> <20170912145157.0794e9f7@plumbers-lap.home.lan> From: Andrew Rybchenko Message-ID: Date: Wed, 13 Sep 2017 09:27:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170912145157.0794e9f7@plumbers-lap.home.lan> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23326.003 X-TM-AS-Result: No--4.867800-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1505284047-pvqnYxcNuTZI Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 06:27:28 -0000 On 09/13/2017 12:51 AM, Stephen Hemminger wrote: > On Fri, 8 Sep 2017 15:15:50 +0100 > Andrew Rybchenko wrote: > >> + txd->mbuf = NULL; >> + if (m == NULL) >> + continue; >> + >> + if ((nb == RTE_DIM(bulk)) || >> + ((nb != 0) && (m->pool != bulk[0]->pool))) { >> + rte_mempool_put_bulk(bulk[0]->pool, >> + (void *)bulk, nb); >> + nb = 0; >> } >> + > Why not add rte_mbuf_free_bulk (inline) to base code, rather than recoding > everywhere? I'm not 100% sure that I understand the question in a right way, but if you're talking about base driver code, it is not used in native datapath implementations at all (just header files with HW/SW interface definition). In fact patches 1 and 2 of the series are slightly different and the difference is proved by performance measurements.