From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DDD0433E3; Mon, 27 Nov 2023 11:20:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F299E4064C; Mon, 27 Nov 2023 11:20:30 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by mails.dpdk.org (Postfix) with ESMTP id 3998840150; Mon, 27 Nov 2023 11:20:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FPmxD6ocQQ3u6R1LbV4Tto6hLBHAwCnAxphSRM+j2vFJPsVmc7tEQ2UYPgZBeFYWevTkfz/vED2608HXqO9chU1aelXu/RRQJck1NYqi3Zh6tWECWNoYVA+a3STYYZb0DbuLts4xNzBOkGzGye5bK5JnOl0IgB3vNKPIhFXkJ1f44L8dBcLkpe99pufvkV3xk8fREzJKlRdbH5EsnDAti9dvpC3ls2/Azpp6FxZ9YZsy53WETdVlagxgnMLF07RNsqSa/DBRFvyDx/BOV0k7GhmuLpkOvZ/d9aSbO8H+7Tc4AB6gzz6XyYMZDCH+S9RqpYf4HMvWxrMA3c/Qt+dhbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCoiYh34cn6k+nYguF2FRdn3DiDdngDBtfuXkSGulEM=; b=HtxDvqWh2WnmtwUJODq14lMusOhC14RS3t5aC37wqudOow//qEcvHwAlkz7yCFGvAghqVVYjYvLzVn8itoKlRvwl452L2j8qmfAHGz2RDIsIYpPvm76E6FlWtXDngwU4tVgIkDcGq1VuvkLn4BxDr399hJQbB5lHGDPyqmYrX+sP89rzywF4DjcY9n+Mfx2c4fO3H65fv6r7r10gD9D7CcfTsWMvaP1XGnIJTjmjj9V+mrHfD93qC55YlCb4i9+lwY4VoF+r/yOTb7R4OkEE6wnYWyYN31l2QnXLuJJ/VXQI7v7k/LGOAzmn5ll6U0hDric3av+ORP9R9Ox+z+lubg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RCoiYh34cn6k+nYguF2FRdn3DiDdngDBtfuXkSGulEM=; b=OQrbxZgtnsPWzz7wD9teF3VZqhZAH1h1aSfkfI6Mvk5/xr83rFUBol4BaRycAVkWU8DCvmn0xIF6jRM/8j+bcZROZZeJUKCLWwSbz19LdaYvDfvzHnMZEGLQfmcUCBfmo3+pEhZem2fvAITmBaAbg80z6KnF1xPPk1RWMw099LE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5596.namprd12.prod.outlook.com (2603:10b6:510:136::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.28; Mon, 27 Nov 2023 10:20:27 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 10:20:27 +0000 Message-ID: Date: Mon, 27 Nov 2023 10:20:25 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/virtio: fix duplicated rxq xstats Content-Language: en-US To: edwin.brossette@6wind.com, dev@dpdk.org Cc: maxime.coquelin@redhat.com, olivier.matz@6wind.com, stable@dpdk.org References: <20231124135235.1831304-1-edwin.brossette@6wind.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231124135235.1831304-1-edwin.brossette@6wind.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: 177bfd29-a750-49eb-ed5f-08dbef327984 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: djt4AzW5bOQOJDJRptIFUgJi38Vw/PdXxR8jxD23wLsnTUo4TFy5rx6wiDYuOAbue/+snGckb/up/Cw5Km12K44IZuDhEl7sOf+uOwN7gQNi9CC1ik/FqRcAev7xm2SgVDdNe2WOu080s0Shvms7PMuhA5SQNoY9mzfTH1Kox00TUJFgBdRr4r3GkfWJN3ZBe9mmjWA+xG2tuB9llVZbp8SyMgLDUGJr94/U/XMVKveN7JeE6es97i5b4tyfakkXjX7luC3JDse+Np2yF28hv1I6/VSblXgyVHHgoS4/jDmF0LrlWXqgQKHe+J9snRjQ6Iq+xKBDbZOkZWt48jiH4QzN6yyqh7QtgRv7K0NDbPMksZVNiFttfar8sHwviPZSA5cve/pmp6kpqiPALMSAm39m2tGlN/Gy0Q/H3mr4O/oqV7LFSfyCZeqw5KLML7FV34Zin7GGeTUjDyrTnPf3VHcsgcGaJaJFisg2+YvOSzZVyeAYjDV40nJtPsU3a12g8BU3B1fyRYY/bswatChLURUlc43eNgKaPlQHntm9QHIpb7TklRoIskmUni2srVHvwZtTLN9jqj7PbqmxziMxhhHjeYefRKQaNxhIS7sNfPDdfKjHj3G/X5NjaunomdqMLJkGO22+GhhBxOVPDrvXIw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(39860400002)(376002)(366004)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(8936002)(4326008)(8676002)(6512007)(31696002)(53546011)(6506007)(66476007)(66556008)(66946007)(316002)(6486002)(478600001)(2906002)(4744005)(36756003)(38100700002)(41300700001)(31686004)(86362001)(26005)(44832011)(2616005)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHl3c1JwZXBJZW5jazVZQTR0WlVQWFYrWTVEanFMbStsZE9JWWpVWUxZM1Q4?= =?utf-8?B?REQvcEJzMHFlMDNQSUVGU3VUSkxIeHAvR0lpcHIzUzhSQlhBcFBkU3lpZHJu?= =?utf-8?B?c3BEbWg2a0RjUXhSNXNYNTdwakhnd3o2a1J1ZHZwbE9odXQwbEhSTDZURzZs?= =?utf-8?B?bnpXMHpSbC9BWkZ3K0FOb0xkTUhENmRaWkc5Mk8rRTEvRk9vV2dYa05CZVFz?= =?utf-8?B?TFFadDNvQzU4eFJOOWlPdVFETnZvdUZIS3pWb3E5TGd2dHdTSExMY3lic2hR?= =?utf-8?B?TVZ4VXkwVktuRUh2U0JROVlZckVMbUR4c0tsVU5YWnF0bE9VQmhHZzVya3Jr?= =?utf-8?B?bzhsbkRDaSs3YmowQVpiSTNmanhZVG1nWkRhQjlaSkhKN0hmTlJzc1R1RG5i?= =?utf-8?B?MDFVSHJiYkQzWjZDcEJrYUJDQ0RtSFZLdG5jVEcyRDY5eWkyYzAreHg4RitR?= =?utf-8?B?MnQyUmVPaW1nR0ZudFF3OEhaYXZML2o5VGoxRVFoNXA2alJrR1o1YVp3ZFVJ?= =?utf-8?B?eDZ5Y1ErdUtlSHg2TWNaaGh5TG1EZkNoaDdUa2FZRndJUlZsZ0MyckR1MUtl?= =?utf-8?B?NU5TTTY4RkJvSE5lWXhiRnViNXQzWFYrR1AvbTZ4b3lkRWhmUndXb05CeTNr?= =?utf-8?B?RUhRdENWK3R0cXNBeUVLbG9EQ0lFTmNnTXNQMlRvdHRVNCt4b2cxTjNEREk0?= =?utf-8?B?dVBtVlp3dUJiOU52ZFVCYXpjUmMvRzNRaFlOU2lhdnNIVm9GekdTd3lpdUlU?= =?utf-8?B?Z1NuZllRU1NwbXdPaER4bWtmNzRxeFZEaVI4ak1ibmZiUTNvYnF4ajBPajRJ?= =?utf-8?B?Y2VacG9DU1Q0VmNzYlNxbXJMU2p6dWhkMjUvdkNJYngrYjhQc3hoTXJOVXVL?= =?utf-8?B?U0R6TVFMZDdyZGcxdDQzYThaSWszOWd4OTZibDVZWDEzenlRem9kL29TYmRW?= =?utf-8?B?RGVqSmMxZUR3Q0M5OWJOQ0dPUitZaENRVndtdDlEaHhHUU83UTdsbk1uU0RT?= =?utf-8?B?TVo2VmJsYy9kTWdIbXYzT2Nub1BucmF6QW85Nk8xdzJBSDliZFA1Z1BtMVk4?= =?utf-8?B?VEJLai9GeWlnN29JWWQ4UVczRnhPV2xHZFB1SEJpSzRTZ3haWmJhNnlHbWs1?= =?utf-8?B?QWVSRFNKQWFMNE9lM0tvNnB6bzE5L1JtS3dURXJkdGR2aFpNMzFKd01QVE1Q?= =?utf-8?B?ajNtMU5CQ1pYcW0rRWVoMUpuekhaT3lNVXJhV3VLR3JFR3RZcGdCbFlCaEZG?= =?utf-8?B?bUE1LzV0bStjY0dyZHZvaTlwTnNxSGxrcnpkQTFiMHVIb3NGZjYxN1N0NUtD?= =?utf-8?B?b1htbjhJNUc2M0drQlZLaFI3S0x2YXNiSlNBTEJZZnVuVDFOTllxa0treVV6?= =?utf-8?B?cmNsWFpYVThUaEV2OGg1aG1Hd0tFMHhPNXBhKzFBb3RCMHNKM0x2VEhWQ0hE?= =?utf-8?B?c21oVGltMFpKRWI3Skl1SGhnUXQxUWgwY0VMYk1CYlplcnlxOVpNZXF0M2Qw?= =?utf-8?B?bWczcTdxZzUxTE9xSVB6RmwrQXRmSHBhYmdsbWFhRm4wbFBYN1JFRkpkL25G?= =?utf-8?B?ekJFTmVjSnlYME5UZkR0eXhoMFluQllIenRjMS93Yy9FWEQ0amF3TFRyV3FL?= =?utf-8?B?b0Z3U0c5STZrOTh1WWNKb29tcS9jdUM0U1JWb1N3c0pSU2t4eXQwMk51Q0xP?= =?utf-8?B?VmpNOUd0V1hkZTBJNmxKTmZyUFFsdGN5NEI2eVI0SEU3WW1WZDh4SU1CSVdj?= =?utf-8?B?Q2g0MTFSelU5QzdPV2VyQ2N4TE4wYWNNbGpBVUpnM1I5Y2tiUVNTc2ErOFNv?= =?utf-8?B?U3g1Ykk2Z3pETVRZTHhYTXJhODFVSHpjTDlILy82d2k4bmRaaExzcXk5dG5r?= =?utf-8?B?Sk1FbDducCtjWDlUcGdXclUwUDRDWU5lelNncjN1bDZrMUg3SW1lbjhtdFhI?= =?utf-8?B?SExBbFpWVE9ucU56RnJDbnFrZVpLNlZlZk5JSFBvUGF4bW9VbERXZVltMFhB?= =?utf-8?B?QUhLV2lHbGR6OEdRY2dSUlVCN1JaZTU1dWZpRHoyVVdJZmZuNlRhYnYxTmo5?= =?utf-8?B?UVhqTERSNkhBTUpUVnNpcGhlR2ZSQm12MjFDbUppbDRpcmx4WElmam5LU2VQ?= =?utf-8?Q?Rnec=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 177bfd29-a750-49eb-ed5f-08dbef327984 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 10:20:27.1157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pGUzAruM1rkF9PzpKbDq5OxfgB4L8ORukbAJLYtv0g2pzlmZqczSOBLDe9fSI6NG X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5596 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/24/2023 1:52 PM, edwin.brossette@6wind.com wrote: > From: Edwin Brossette > > The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while > moving queue stats from 'struct rte_eth_stats' to the individual pmds, > as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass > auto-filled queue xstats"). > > This flag was added so every pmd would keep its original behavior until > the change was implemented. However, this flag was not removed > afterwards in the virtio pmd and as a result, some queue stats are > displayed twice when trying to get them: once in lib_rte_ethdev, and a > second time in the virtio pmd. > > Remove this flag so stats are printed only once. > > Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") > Cc: stable@dpdk.org > > Signed-off-by: Edwin Brossette > Reviewed-by: Ferruh Yigit