From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 215B3A0032; Fri, 21 Oct 2022 15:03:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1442442B9C; Fri, 21 Oct 2022 15:03:20 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by mails.dpdk.org (Postfix) with ESMTP id 2673E41147 for ; Fri, 21 Oct 2022 15:03:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cx4fAqJkzb0VGSbZwiOJ4+CxV4CuMXMzQ10K92TANFybPRD7CkkzlDw6WiNVSr6JzY+XXRrg7rKa1JqH8pTfSzsQBPWLneMOn2rmxC7zX271m9VReZhIc9ej1/qSzmE+u0ajDfbwT6WfibOq7fv77HacKIqYUM6hqxFe/yV9C5e/3k55l01TmQhkZw4Kc6JBDeBPDov8Y1YBEDvUC0algdiTlfzWqhaTp42f5LHZ8ljWx/ESQ+9/syqpaJkLUcgh7AOb3wzovusvKSynywkzPAB6DAbqHOTKn31yymplR0CYTr78/EZK9+FrTn0PWBcQL/fLaoPmSRN/WKjBkVUlZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDdf16iVe9wa2ALZYtkGvOw31vBOH6uUOXBEkvzVLDQ=; b=SCG677A7MzxYszR61IN3iovWkUBIsExAWMKMoQiVCnr2zAoR3cqYhxdhPS2DzkFhdW0R6//oKMhz6CZ3HFlU4b7ndyjDwHkoDC8l0IfzUmjyzry5k3tnwVsEPdE5BgHFoqoBEQXrxsoyGQnBnwqUUYiDc3nqcJlBN9BOFepmn+rn4+Chgdze1YrdE/2UDmi+t5pPcFOoNFYm80vCauwchTydKs8yD8QJAcjOVjUPKLS/9N/xISGE9JMp0K98vFKqVjoX5EmndMZyaLsbaAHReLidHWxW8dkvcGPvpJnxDGVeAED6e+CPF4ySYlUvlcuL9ul24qPMHqonXSwGmTDqxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDdf16iVe9wa2ALZYtkGvOw31vBOH6uUOXBEkvzVLDQ=; b=3Iz63+h5aCEAr9lcvFBgvzFjF+ADNGVogfTYtqTW27JDkNqo268FRWhIT0S5umuGh+3G1dXiroWKkIHGvlCvhvPYJBRd7Z5w1LSwtcIBjg4GimXXYQzgalKmX4ctq47MGkusY5QERyy2J2PYO2iHQthTfUX7qpOZqI+hCHEWjxY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by MW4PR12MB7312.namprd12.prod.outlook.com (2603:10b6:303:21a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct 2022 13:03:16 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Fri, 21 Oct 2022 13:03:16 +0000 Message-ID: Date: Fri, 21 Oct 2022 14:03:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v6 02/27] net/nfp: fix the promiscuous mode control functions Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <1666232391-29152-1-git-send-email-chaoyong.he@corigine.com> <1666339323-24016-1-git-send-email-chaoyong.he@corigine.com> <1666339323-24016-3-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1666339323-24016-3-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0653.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::23) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|MW4PR12MB7312:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f054237-cbe0-409d-645c-08dab3649e36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1aFn8/5EMkb4WqzFzNY8Dew/8MTk7TfM0bimBWYpqpqLXpvEuwe0IkITPjgfhc6I1qVWD374ID+oAkVQny5/MAm3BhUfc0tEWC3OYAwPj1cV2glBpxaHTN12zcthsl868rCJqwp1cTVBhZvd36iGuQ6ugy0mAeGHxxKddRjxG6LlT+K54X7SVyaVZgGBXhrsZrOSuhKgNEmcGM+MgqkT1D5W2c7l+u/BjaZWw2j0MT7mnmfauoIaFuu9MIowiu0PTI4eoe98J6f3Ikhf8zJdp72yXz3aIUDO+tI5gB9E12kZBHzvOO92x2XAJrxvN45FgtW8u/I8GJQkcVBnYMhAOWUYCJYjLElEzqlJoGThcAQ7hRpEb7rRiz7yoCvCpicJKFn70K+ieYArKdx2J0i3+Pg4I1Bq/gAvTUvU3jANe9IKGzCGFPQlbFzUcxDb8rAcnsqAnw2Pg9YzyVp/0lVnJFYxlsDLjG9PHNPjnzs/GGmjOtG/GmZnsFAD7J5IF40oMiQvXaIZwguaiGWUrrlY4KeLWcKjtmOppFU1/UhS2um1nce4fjaa0KNtBSFPNIeWRXAYlD07yV3arNKo4QzbzNHoodq6Fk73joNi6EsyT3+4shvvFk+3tlc8vCDFa7VM9UL7pMAueQT/+wh3C94/nwyNOP58NSfkFQdm/Dv6mhEMW16TtnRNd06tpQpjrZfmNExl7uWG0a4+Dyx/Tn3RZ2ZDyazSh3oinQAMgk7fkniXQkIUmtPxhDrgyl4IYq9cJO9SIm0vJQjo6HNbZezJuQ9t9k5bYbgOzOped++Pwm0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(366004)(396003)(136003)(346002)(39860400002)(451199015)(36756003)(4326008)(316002)(6506007)(66556008)(6666004)(53546011)(41300700001)(8936002)(6512007)(44832011)(66946007)(5660300002)(38100700002)(186003)(2616005)(8676002)(2906002)(66476007)(86362001)(83380400001)(31686004)(6486002)(26005)(478600001)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2liUmZkTHZ5bGJBWGh0dktnaVFvQ2NhMmx6eDdZOWNQSzlQV0ZuanIwREpB?= =?utf-8?B?S0VhaG5jd1pLZytMOVlYVjFQWm1IOU5Od1FvZ0piV2NwcFhhNE01eUNQUU5G?= =?utf-8?B?ejVMNy9qeW5BS0czT2EwN204QWowT3NwL3drbURiZXd5eXhvK25WcUVWSjJT?= =?utf-8?B?a1F0MXBhWDVBR3pjTWlteWRhbW5qbHNaU0lyeXAxLzFabzFISWZLSURCdEZR?= =?utf-8?B?dGlOTHhKT0Ewc0Q1WTU3c1ozRVdzK0J2bGFQc25FcVdKcTNxZEtSS012L3hI?= =?utf-8?B?LzUzRnhYS28zS2FVWU5OaEdQcEl5UEhaTTduUjhobmdBZHFibzVYVVpGaTA4?= =?utf-8?B?K3A4R1Y1cDZDSDFzM1NySFE1R0U0ZU9maDUrNTZ3YVh1cVE1WXdKRTdWdVR1?= =?utf-8?B?THpYSVhPYlVPdUxIQkE5YlRKbjVEd2ZuWEpOZ21MWDhxejRPRTBDN0tlaHh4?= =?utf-8?B?RTZMZjh2MVVRbnVBN29SZVp0TXIwclhNSktiY0Q3bmhPbnZPSUxXNFladjJz?= =?utf-8?B?U0E0TmZOcTliM3F6elpLQkdxTVFBM0NsVkVNUitNaWMvN0J4VWlLajRuTkl1?= =?utf-8?B?TXJYSjVGQUU2bHExRVN1MW5GZmpTNUZISTFYNzNCOWpTdENueXQ2NHBDd1pa?= =?utf-8?B?bGxEbWZZZHoyajkrV242Qi9wWWVxSUMzZ1l4Vm5TZEJzSGlEV1JRekZ3WTNi?= =?utf-8?B?RTNzR3RxTk9TYnJZOWlvTkZOUG9BUDJGUFZ4MVBJa2g1SFpKb0tyZjZqUnEr?= =?utf-8?B?V2E0cWU0ejBSL1VWR29XNCtCQXFBem8za3owbi9uOW9zYW5HcnpSdmFFcnJ3?= =?utf-8?B?TUE4ejZxUEhDSE10R1hGbkUvcWlBSHQvRXkrSFVsL0pQR1RpN0pZWWM5akpq?= =?utf-8?B?NG0wNGwycGlPc05MTkUvdS9NUUxBSjYzT3ZMMndkdG5xbGtzUVFlcmcvSVVK?= =?utf-8?B?d1hzMUM4SUJ6b3Zzc2E0UW5GWHJMNXA2bjJIVjNveWJFQmlTOVN6Ykd4UVgx?= =?utf-8?B?cXROemx6RC9CRnlwMzNxVWJDWkNEaFdtTG9vdXBaMndSR3ZrLzFLV1R6MXJt?= =?utf-8?B?OHo2RzNUM0p1eEE0bXVzMjhKYW1PVEgvdm5rTkFZRmQxVzM5VFdjK2VmbDZZ?= =?utf-8?B?V1hHaE9iRVQxbjYydHo2cVJwblFZVWY1dXZJS2tUSFlOK01xMlhzdG9xZTVU?= =?utf-8?B?bm1lcFhVdUxybUt4T2FwR1Fhc0EvRkNXMmptRnM0ZVVEM1hHOXlmYnVFbFNB?= =?utf-8?B?UmxTdkt2ajRBZnNNNFZVbFo2N2lrMkUzWXFrdm9XQjJyOCt1NHM2N010ZmRW?= =?utf-8?B?MExtVFRXbVJaNFdCakswcGI3S0doZTR4eEl3K3ZHak9tSkFCTXl4VnNHOFcr?= =?utf-8?B?bWd2RXo5dDBPT2xJZUpYMG55eXpwQ3MxVnVSbGdXRnJiWFZIeFlsY1VDWGhs?= =?utf-8?B?SFlsS010b0crYTlsajN1Uldwd3VEL3ZicjAycEVwZ01kREdpNzFYY1ZmOTQ5?= =?utf-8?B?MXY4VEFESkNxcEkrbHZkRnlDYjd1a3NHNkF0d0lrYjIzVWoyT2R1UU94c3RH?= =?utf-8?B?Q1UvRFFWUDZGa2NOalF4bDlyNlpKRHJZaEd0TVY0R0kyVCt1QjkyTS9BK3Jr?= =?utf-8?B?L2xPc00yQndMc0ltSlB0VHhNZW5BbmEwanhHbVdiVzRwN0xNRGhKak1iLzFj?= =?utf-8?B?c0JzNDFUcjduaGRkRW9vK1E1L1hTVHJNUDJTbG1vUXk5bVpkbVZNWVVZSExY?= =?utf-8?B?bG9YSFV1dkhrODcrQXpqR28yNmdCMzYvZnJXRWNoNHhZV1lDV0xLdG9DK0Fl?= =?utf-8?B?ZGlkVVplY1pYYzErRFJxS29Lc05hVW1pZGoyMGFlY0JtYVRhSWM3QitPVito?= =?utf-8?B?WXNvSk03Vnl6MDA3b0lkYzhYTGszQVliUjJwaEQ2cmZpSFhsV0ZUV2cvOXQr?= =?utf-8?B?cEZkb28wbXdRRitTY21vVFRNWG05dWZhWDI1d2I3QWc1UmdvNmEyZXYrbmhr?= =?utf-8?B?SSs4ZDNqRUJ4QUpRMjhQUjVRMk1wUERSZ3QvZWVRVFN0MFF5VUtRT2w4Y1dU?= =?utf-8?B?MmZ5OVlTSHk4M3lsVjN1WUNUV1VFNVpjS1dFN3hwdlQ3QndTbDBoZEF0b3RC?= =?utf-8?Q?mE90L+cRHMmVyZUecGFIDuBce?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f054237-cbe0-409d-645c-08dab3649e36 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 13:03:16.1950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bOgDx/uAaduDThtq1Vw5NyHX1KS8w3JuHhgmBCo/805da7SDGED2PiDNG7RDxADR X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7312 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/21/2022 9:01 AM, Chaoyong He wrote: > The original functions of promiscuous mode can't process the > representor port rightly, revise the logic to do that. > > Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") > > Signed-off-by: Chaoyong He > --- > drivers/net/nfp/flower/nfp_flower_representor.c | 26 +++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c > index 0e60f50..cecdf46 100644 > --- a/drivers/net/nfp/flower/nfp_flower_representor.c > +++ b/drivers/net/nfp/flower/nfp_flower_representor.c > @@ -415,6 +415,9 @@ > static int > nfp_flower_repr_promiscuous_enable(struct rte_eth_dev *dev) > { > + int ret; > + uint32_t update; > + uint32_t new_ctrl; > struct nfp_net_hw *pf_hw; > struct nfp_flower_representor *repr; > > @@ -431,12 +434,23 @@ > return 0; > } > > - return nfp_net_promisc_enable(pf_hw->eth_dev); > + new_ctrl = pf_hw->ctrl | NFP_NET_CFG_CTRL_PROMISC; > + update = NFP_NET_CFG_UPDATE_GEN; > + ret = nfp_net_reconfig(pf_hw, new_ctrl, update); > + if (ret < 0) > + return ret; > + > + pf_hw->ctrl = new_ctrl; > + With this change 'nfp_net_promisc_enable()' seems not used at all in the driver. And the difference between above code and 'nfp_net_promisc_enable()' is that capability check is removed, so it looks like hack for flower, instead why not fix the issue in the 'nfp_net_promisc_enable()'? Same comment for 'nfp_net_promisc_disable()'. > + return 0; > } > > static int > nfp_flower_repr_promiscuous_disable(struct rte_eth_dev *dev) > { > + int ret; > + uint32_t update; > + uint32_t new_ctrl; > struct nfp_net_hw *pf_hw; > struct nfp_flower_representor *repr; > > @@ -448,7 +462,15 @@ > return 0; > } > > - return nfp_net_promisc_disable(pf_hw->eth_dev); > + new_ctrl = pf_hw->ctrl & ~NFP_NET_CFG_CTRL_PROMISC; > + update = NFP_NET_CFG_UPDATE_GEN; > + ret = nfp_net_reconfig(pf_hw, new_ctrl, update); > + if (ret < 0) > + return ret; > + > + pf_hw->ctrl = new_ctrl; > + > + return 0; > } > > static int