Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: enable hotplug detect in ixgbe

[Jeff Guo <jia.guo@intel.com>]

On 7/9/2018 4:13 PM, Andrew Rybchenko wrote:
> On 09.07.2018 09:56, Jeff Guo wrote:
>> This patch aim to enable hotplug detect in ixgbe pmd driver. Firstly it
>> set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug
>> ability, and then use rte_dev_event_callback_register to register
>> the hotplug event callback to eal. When eal detect the hotplug event,
>> it will call the callback to process it, if the event is hotplug remove,
>> it will trigger the RTE_ETH_EVENT_INTR_RMV event into ethdev callback
>> to let app process the hotplug for the ethdev.
>>
>> This is an example for other driver, that if any driver support hotplug
>> feature could be use this way to enable hotplug detect.
>
> I see nothing ixgbe specific in the callback. Yes, support of removal
> event should be in drv_flags, but it looks like the callback may be
> generic and located in ethdev.
>

Let it be generic and located in ethdev should be a good idea.

> Also search of the device by name could be done using querying
> mechanism to be added by Gaetan [1].
>
> [1] https://patches.dpdk.org/project/dpdk/list/?series=419

here, i just want to check if the eth port is belong to the removal device.