From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4D6381B4B0; Thu, 2 Aug 2018 15:42:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 06:42:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,436,1526367600"; d="scan'208";a="59896963" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [163.33.176.228]) ([163.33.176.228]) by fmsmga008.fm.intel.com with ESMTP; 02 Aug 2018 06:42:40 -0700 To: Radu Nicolau , dev@dpdk.org Cc: chas3@att.com, ferruh.yigit@intel.com, stable@dpdk.org References: <1525867586-23328-1-git-send-email-radu.nicolau@intel.com> <1531920077-14937-1-git-send-email-radu.nicolau@intel.com> From: "Doherty, Declan" Message-ID: Date: Thu, 2 Aug 2018 14:42:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1531920077-14937-1-git-send-email-radu.nicolau@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] net/bonding: fix slave add for mode 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 13:42:43 -0000 On 18/07/2018 2:21 PM, Radu Nicolau wrote: > Moved the link status validity check from the slave add to the slave > activation step. Otherwise slave add will fail for mode 4 if > the ports are all stopped but only one of them checked. > > Removed activate slave call from slave add function. > > Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions") > Bugzilla ID: 52 > Cc: stable@dpdk.org > > Signed-off-by: Radu Nicolau > --- > v5: removed activate_slave call from slave add > v4: reworked patch > v3: updated commit msg > v2: add fix and Bugzilla references > ... > Acked-by: Declan Doherty