From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 00/10] bnxt patches
Date: Wed, 15 Jul 2020 13:50:55 +0100 [thread overview]
Message-ID: <a38b5a38-efb2-815a-b6fa-421c1bc0c85b@intel.com> (raw)
In-Reply-To: <CACZ4nhvtej0kCJYNH=wXBJJj4mhKzW=pBfnUXQDhOS3M8gyqyQ@mail.gmail.com>
On 7/14/2020 11:36 PM, Ajit Khaparde wrote:
>
>
> On Mon, Jul 13, 2020 at 2:47 AM Somnath Kotur <somnath.kotur@broadcom.com
> <mailto:somnath.kotur@broadcom.com>> wrote:
>
> Minor enhancments added to the TF-ULP/Core layers
>
> Farah Smith (1):
> net/bnxt: add changes to support 2 table scopes
>
> Jay Ding (2):
> net/bnxt: implement TF Identifier search
> net/bnxt: check index range in bulk get
>
> Kishore Padmanabha (6):
> net/bnxt: add support to extract data from the ulp blob
> net/bnxt: ignore ipv4 TOS mask
> net/bnxt: add support for identifier search and ref count
> net/bnxt: consider VLAN fields for template match criteria
> net/bnxt: increase the number of egress flow entries
> net/bnxt: add support for decrement TTL action
>
> Peter Spreadborough (1):
> net/bnxt: add option to delay EEM sysmem mapping
>
> drivers/net/bnxt/meson.build | 3 +-
> drivers/net/bnxt/tf_core/Makefile | 1 +
> drivers/net/bnxt/tf_core/tf_core.c | 78 +++++++-
> drivers/net/bnxt/tf_core/tf_core.h | 78 +++++++-
> drivers/net/bnxt/tf_core/tf_device.h | 20 +++
> drivers/net/bnxt/tf_core/tf_device_p4.c | 2 +
> drivers/net/bnxt/tf_core/tf_em.h | 11 ++
> drivers/net/bnxt/tf_core/tf_em_common.c | 145 ++++++++++++++-
> drivers/net/bnxt/tf_core/tf_em_common.h | 27 ++-
> drivers/net/bnxt/tf_core/tf_em_host.c | 23 +--
> drivers/net/bnxt/tf_core/tf_em_internal.c | 2 +-
> drivers/net/bnxt/tf_core/tf_em_system.c | 25 +--
> drivers/net/bnxt/tf_core/tf_identifier.c | 148 +++++++++++++++
> drivers/net/bnxt/tf_core/tf_identifier.h | 47 +++++
> drivers/net/bnxt/tf_core/tf_msg.c | 3 +-
> drivers/net/bnxt/tf_core/tf_rm.c | 43 +++++
> drivers/net/bnxt/tf_core/tf_rm.h | 45 +++++
> drivers/net/bnxt/tf_core/tf_shadow_identifier.c | 190 ++++++++++++++++++++
> drivers/net/bnxt/tf_core/tf_shadow_identifier.h | 229 ++++++++++++++++++++++++
> drivers/net/bnxt/tf_core/tf_tbl.c | 40 ++---
> drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 +-
> drivers/net/bnxt/tf_ulp/ulp_mapper.c | 117 +++++++++++-
> drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 74 +++++++-
> drivers/net/bnxt/tf_ulp/ulp_rte_parser.h | 5 +
> drivers/net/bnxt/tf_ulp/ulp_template_db_tbl.c | 4 +-
> drivers/net/bnxt/tf_ulp/ulp_utils.c | 76 ++++++++
> drivers/net/bnxt/tf_ulp/ulp_utils.h | 17 ++
> 27 files changed, 1367 insertions(+), 88 deletions(-)
> create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.c
> create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.h
>
> --
> v1->v2: Corrected some typos in patch 5 and 6
> v2->v3: Modified case of some words in commit summary as per git-check-log.sh
>
> Patchset applied to dpdk-next-net-brcm. Thanks
>
Hi Ajit,
The patch "net/bnxt: add support for identifier search and ref count" is causing
build error [1], can you please check it?
[1]
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c: In function ‘ulp_mapper_ident_extract’:
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:723:8: error: implicit declaration of
function ‘tf_dir_2_str’ [-Werror=implicit-function-declaration]
723 | tf_dir_2_str(sparms.dir),
| ^~~~~~~~~~~~
.../drivers/net/bnxt/bnxt.h:867:16: note: in definition of macro ‘PMD_DRV_LOG_RAW’
867 | __func__, ## args)
| ^~~~
.../drivers/net/bnxt/tf_ulp/bnxt_tf_common.h:14:40: note: in expansion of macro
‘PMD_DRV_LOG’
14 | #define BNXT_TF_DBG(lvl, fmt, args...) PMD_DRV_LOG(lvl, fmt, ## args)
| ^~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:3: note: in expansion of macro
‘BNXT_TF_DBG’
722 | BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n",
| ^~~~~~~~~~~
.../drivers/net/bnxt/bnxt.h:866:50: error: format ‘%s’ expects argument of
type ‘char *’, but argument 5 has type ‘int’ [-Werror=format=]
866 | rte_log(RTE_LOG_ ## level, bnxt_logtype_driver, "%s(): " fmt, \
| ^~~~~~~~
.../drivers/net/bnxt/bnxt.h:870:4: note: in expansion of macro ‘PMD_DRV_LOG_RAW’
870 | PMD_DRV_LOG_RAW(level, fmt, ## args)
| ^~~~~~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/bnxt_tf_common.h:14:40: note: in expansion of macro
‘PMD_DRV_LOG’
14 | #define BNXT_TF_DBG(lvl, fmt, args...) PMD_DRV_LOG(lvl, fmt, ## args)
| ^~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:3: note: in expansion of macro
‘BNXT_TF_DBG’
722 | BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n",
| ^~~~~~~~~~~
.../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:35: note: format string is defined here
722 | BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n",
| ~^
| |
| char *
| %d
next prev parent reply other threads:[~2020-07-15 12:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 6:15 [dpdk-dev] [PATCH " Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 01/10] net/bnxt: add option to delay EEM sysmem mapping Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 02/10] net/bnxt: implement TF Identifier search Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 03/10] net/bnxt: check index range in bulk get Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 04/10] net/bnxt: add changes to support 2 table scopes Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 05/10] net/bnxt: add support to extract data from the ulp blob Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 06/10] net/bnxt: ignore ipv4 tos mask Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 07/10] net/bnxt: add support for identifier search and ref count Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 08/10] net/bnxt: consider vlan fields for the template match criteria Somnath Kotur
2020-07-13 6:15 ` [dpdk-dev] [PATCH 09/10] net/bnxt: increase the number of egress flow entries Somnath Kotur
2020-07-13 6:16 ` [dpdk-dev] [PATCH 10/10] net/bnxt: add support for decrement ttl action Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH v3 00/10] bnxt patches Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 01/10] net/bnxt: add option to delay EEM sysmem mapping Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 02/10] net/bnxt: implement TF Identifier search Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 03/10] net/bnxt: check index range in bulk get Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 04/10] net/bnxt: add changes to support 2 table scopes Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 05/10] net/bnxt: add support to extract data from the ulp blob Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 06/10] net/bnxt: ignore ipv4 TOS mask Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 07/10] net/bnxt: add support for identifier search and ref count Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 08/10] net/bnxt: consider VLAN fields for template match criteria Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 09/10] net/bnxt: increase the number of egress flow entries Somnath Kotur
2020-07-13 9:42 ` [dpdk-dev] [PATCH 10/10] net/bnxt: add support for decrement TTL action Somnath Kotur
2020-07-14 22:36 ` [dpdk-dev] [PATCH v3 00/10] bnxt patches Ajit Khaparde
2020-07-15 12:50 ` Ferruh Yigit [this message]
2020-07-15 13:50 ` [dpdk-dev] [PATCH v4 " Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 01/10] net/bnxt: add option to delay EEM sysmem mapping Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 02/10] net/bnxt: implement TF Identifier search Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 03/10] net/bnxt: check index range in bulk get Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 04/10] net/bnxt: add changes to support 2 table scopes Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 05/10] net/bnxt: add support to extract data from the ulp blob Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 06/10] net/bnxt: ignore ipv4 TOS mask Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 07/10] net/bnxt: add support for identifier search and ref count Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 08/10] net/bnxt: consider VLAN fields for template match criteria Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 09/10] net/bnxt: increase the number of egress flow entries Somnath Kotur
2020-07-15 13:50 ` [dpdk-dev] [PATCH 10/10] net/bnxt: add support for decrement TTL action Somnath Kotur
2020-07-16 23:04 ` [dpdk-dev] [PATCH v4 00/10] bnxt patches Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a38b5a38-efb2-815a-b6fa-421c1bc0c85b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).