From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3EAFA0546; Wed, 15 Jul 2020 14:50:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96BA71BEB2; Wed, 15 Jul 2020 14:50:59 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id EE64C1BE0C for ; Wed, 15 Jul 2020 14:50:57 +0200 (CEST) IronPort-SDR: fOgYeXV8MkczLufxaTS6/jZgsTcyolxPlxdZybQGbX1N7OJZXKqSubNbnNa94Uk7VX+rGhGs84 NkpDZajILHyg== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="129224350" X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="129224350" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 05:50:57 -0700 IronPort-SDR: OVUzjwQYNw4HoSxuG07kUOI/J40TsYJP2nQZP5nSph7F73h129RUm9ekS6O4/IwQcmU8P2PXOV zKvGtbc6viPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,355,1589266800"; d="scan'208";a="390771588" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.193.148]) ([10.213.193.148]) by fmsmga001.fm.intel.com with ESMTP; 15 Jul 2020 05:50:55 -0700 To: Ajit Khaparde , Somnath Kotur Cc: dpdk-dev References: <20200713061600.19456-1-somnath.kotur@broadcom.com> <20200713094213.21410-1-somnath.kotur@broadcom.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Wed, 15 Jul 2020 13:50:55 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 00/10] bnxt patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/14/2020 11:36 PM, Ajit Khaparde wrote: > > > On Mon, Jul 13, 2020 at 2:47 AM Somnath Kotur > wrote: > > Minor enhancments added to the TF-ULP/Core layers > > Farah Smith (1): >   net/bnxt: add changes to support 2 table scopes > > Jay Ding (2): >   net/bnxt: implement TF Identifier search >   net/bnxt: check index range in bulk get > > Kishore Padmanabha (6): >   net/bnxt: add support to extract data from the ulp blob >   net/bnxt: ignore ipv4 TOS mask >   net/bnxt: add support for identifier search and ref count >   net/bnxt: consider VLAN fields for template match criteria >   net/bnxt: increase the number of egress flow entries >   net/bnxt: add support for decrement TTL action > > Peter Spreadborough (1): >   net/bnxt: add option to delay EEM sysmem mapping > >  drivers/net/bnxt/meson.build                    |   3 +- >  drivers/net/bnxt/tf_core/Makefile               |   1 + >  drivers/net/bnxt/tf_core/tf_core.c              |  78 +++++++- >  drivers/net/bnxt/tf_core/tf_core.h              |  78 +++++++- >  drivers/net/bnxt/tf_core/tf_device.h            |  20 +++ >  drivers/net/bnxt/tf_core/tf_device_p4.c         |   2 + >  drivers/net/bnxt/tf_core/tf_em.h                |  11 ++ >  drivers/net/bnxt/tf_core/tf_em_common.c         | 145 ++++++++++++++- >  drivers/net/bnxt/tf_core/tf_em_common.h         |  27 ++- >  drivers/net/bnxt/tf_core/tf_em_host.c           |  23 +-- >  drivers/net/bnxt/tf_core/tf_em_internal.c       |   2 +- >  drivers/net/bnxt/tf_core/tf_em_system.c         |  25 +-- >  drivers/net/bnxt/tf_core/tf_identifier.c        | 148 +++++++++++++++ >  drivers/net/bnxt/tf_core/tf_identifier.h        |  47 +++++ >  drivers/net/bnxt/tf_core/tf_msg.c               |   3 +- >  drivers/net/bnxt/tf_core/tf_rm.c                |  43 +++++ >  drivers/net/bnxt/tf_core/tf_rm.h                |  45 +++++ >  drivers/net/bnxt/tf_core/tf_shadow_identifier.c | 190 ++++++++++++++++++++ >  drivers/net/bnxt/tf_core/tf_shadow_identifier.h | 229 ++++++++++++++++++++++++ >  drivers/net/bnxt/tf_core/tf_tbl.c               |  40 ++--- >  drivers/net/bnxt/tf_ulp/bnxt_ulp.c              |   2 +- >  drivers/net/bnxt/tf_ulp/ulp_mapper.c            | 117 +++++++++++- >  drivers/net/bnxt/tf_ulp/ulp_rte_parser.c        |  74 +++++++- >  drivers/net/bnxt/tf_ulp/ulp_rte_parser.h        |   5 + >  drivers/net/bnxt/tf_ulp/ulp_template_db_tbl.c   |   4 +- >  drivers/net/bnxt/tf_ulp/ulp_utils.c             |  76 ++++++++ >  drivers/net/bnxt/tf_ulp/ulp_utils.h             |  17 ++ >  27 files changed, 1367 insertions(+), 88 deletions(-) >  create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.c >  create mode 100644 drivers/net/bnxt/tf_core/tf_shadow_identifier.h > > -- > v1->v2: Corrected some typos in patch 5 and 6 > v2->v3: Modified case of some words in commit summary as per git-check-log.sh > > Patchset applied to dpdk-next-net-brcm. Thanks > Hi Ajit, The patch "net/bnxt: add support for identifier search and ref count" is causing build error [1], can you please check it? [1] .../drivers/net/bnxt/tf_ulp/ulp_mapper.c: In function ‘ulp_mapper_ident_extract’: .../drivers/net/bnxt/tf_ulp/ulp_mapper.c:723:8: error: implicit declaration of function ‘tf_dir_2_str’ [-Werror=implicit-function-declaration] 723 | tf_dir_2_str(sparms.dir), | ^~~~~~~~~~~~ .../drivers/net/bnxt/bnxt.h:867:16: note: in definition of macro ‘PMD_DRV_LOG_RAW’ 867 | __func__, ## args) | ^~~~ .../drivers/net/bnxt/tf_ulp/bnxt_tf_common.h:14:40: note: in expansion of macro ‘PMD_DRV_LOG’ 14 | #define BNXT_TF_DBG(lvl, fmt, args...) PMD_DRV_LOG(lvl, fmt, ## args) | ^~~~~~~~~~~ .../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:3: note: in expansion of macro ‘BNXT_TF_DBG’ 722 | BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n", | ^~~~~~~~~~~ .../drivers/net/bnxt/bnxt.h:866:50: error: format ‘%s’ expects argument of type ‘char *’, but argument 5 has type ‘int’ [-Werror=format=] 866 | rte_log(RTE_LOG_ ## level, bnxt_logtype_driver, "%s(): " fmt, \ | ^~~~~~~~ .../drivers/net/bnxt/bnxt.h:870:4: note: in expansion of macro ‘PMD_DRV_LOG_RAW’ 870 | PMD_DRV_LOG_RAW(level, fmt, ## args) | ^~~~~~~~~~~~~~~ .../drivers/net/bnxt/tf_ulp/bnxt_tf_common.h:14:40: note: in expansion of macro ‘PMD_DRV_LOG’ 14 | #define BNXT_TF_DBG(lvl, fmt, args...) PMD_DRV_LOG(lvl, fmt, ## args) | ^~~~~~~~~~~ .../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:3: note: in expansion of macro ‘BNXT_TF_DBG’ 722 | BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n", | ^~~~~~~~~~~ .../drivers/net/bnxt/tf_ulp/ulp_mapper.c:722:35: note: format string is defined here 722 | BNXT_TF_DBG(ERR, "Search ident %s:%s:%x failed.\n", | ~^ | | | char * | %d