From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01046A00BE; Wed, 29 Apr 2020 13:12:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5E5F1DA22; Wed, 29 Apr 2020 13:12:04 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id AAA0D1DA1B for ; Wed, 29 Apr 2020 13:12:03 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id d15so2030230wrx.3 for ; Wed, 29 Apr 2020 04:12:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=FhVRKR3GVnY1Q20LaJNw0x8ymMXLRJPKIo+CknrpXgU=; b=pMzAZEfCWnMgehy1GOaqOKueMslsGirZXUgwqjSnLc2DjmYcoCG35UR2p3XaYsczng yRoo+nw3CzRzCJZUWsk7huGhqwyebMNE8YYURIAxkjHQP6RP/IbgWKR6/wFzLgMRwv7y +NcEJsdHtAdRFy1bcMcwWoCIQklc7xVTXZEBKB5g4kBnTEM/yFEtS31NcdAF3kTsIm4m qSTuRvpR4bL90HxzMkF5WgoYXDx8A9gwXwoK/xy19jTFdrNJ+OwOPNUA13oxaVeSnP8I lRYkZ1e2iaxc5sK4RDV5uCmtMvJDHRLjgfQi/p7xf2Vht4MwuUlOnIYxvzRc4EHHfgKc YaDw== X-Gm-Message-State: AGi0PubdULiHpRISy0jUUjIfRduAwtYV5NSLWksy6aXOkJDkuGiX8ml0 6WNGdAlYDlEAyjf7NehkJRI= X-Google-Smtp-Source: APiQypIbtjCIuiEtcUz8AoYsaP/TSk9HxQ397VIh+HVUJp1xfs3b5b6DL1Ze0eQg7yi0Vg8ZQFYFZQ== X-Received: by 2002:adf:ab5c:: with SMTP id r28mr38243273wrc.384.1588158723447; Wed, 29 Apr 2020 04:12:03 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id e11sm28869823wrn.87.2020.04.29.04.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 04:12:02 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, ktraynor@redhat.com Date: Wed, 29 Apr 2020 12:12:02 +0100 In-Reply-To: <20200429110304.GH1907@bricha3-MOBL.ger.corp.intel.com> References: <20200429100831.398-1-bruce.richardson@intel.com> <20200429100831.398-6-bruce.richardson@intel.com> <20200429110304.GH1907@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first for static build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-04-29 at 12:03 +0100, Bruce Richardson wrote: > On Wed, Apr 29, 2020 at 11:40:33AM +0100, Luca Boccassi wrote: > > On Wed, 2020-04-29 at 11:08 +0100, Bruce Richardson wrote: > > > When calling pkg-config --static --libs, pkg-config will always outpu= t the > > > regular libs first, and then the extra libs from libraries.private fi= eld, > > > since the assumption is that those are additional dependencies for bu= ilding > > > statically that the .a files depend upon. > > >=20 > > > However, for DPDK, we only link the driver files for static builds, a= nd > > > those need to come *before* the regular libraries. To get this result= , we > > > need two pkgconfig files for DPDK, one for the shared libs, and a sec= ond > > > for the static libs and drivers, which depends upon the first. Using = a > > > dependency means that the shared libs are printed only after the > > > libraries.private field rather than before. > >=20 > > A neat trick! Can we document that the new file is an implementation > > detail for internal usage, and that it should not be referenced > > directly? > > I'm even pondering if it would be possible to install it in a private > > directory, need to check if there's a way for Requires to specify > > prefixes > >=20 > That would be great, if there was a way to hide it. I also take it from > your feedback that a package needing multiple .pc files is not an issue f= or > debian packaging? Yeah it's fine, we can ship as many as we want - just concerned about it being used by mistake, but documenting it should be enough --=20 Kind regards, Luca Boccassi